From bugzilla-daemon@bugs.koha-community.org Tue Jun 28 14:45:22 2022
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] New: encryption_key config entry not
 generated when upgrading
Date: Tue, 28 Jun 2022 12:45:21 +0000
Message-ID: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1164650297680645668=="

--===============1164650297680645668==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D31059

            Bug ID: 31059
           Summary: encryption_key config entry not generated when
                    upgrading
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs@lists.koha-community.org
          Reporter: jonathan.druart+koha@gmail.com
        QA Contact: testopia@bugs.koha-community.org

It's required for 2FA (from bug 28786) but it's not added to koha-conf.xml wh=
en
upgrading.

--=20
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============1164650297680645668==--


From bugzilla-daemon@bugs.koha-community.org Tue Jun 28 14:45:35 2022
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Tue, 28 Jun 2022 12:45:34 +0000
Message-ID: <bug-31059-70-01rHtq5LhA@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3851944609425310279=="

--===============3851944609425310279==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

Jonathan Druart <jonathan.druart+koha@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28911
         Depends on|                            |28786


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
[Bug 28786] Two-factor authentication for staff client - TOTP
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============3851944609425310279==--


From bugzilla-daemon@bugs.koha-community.org Wed Jun 29 09:42:14 2022
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Wed, 29 Jun 2022 07:42:13 +0000
Message-ID: <bug-31059-70-faYaKiMccJ@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0616038603878695228=="

--===============0616038603878695228==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0616038603878695228==--


From bugzilla-daemon@bugs.koha-community.org Mon Nov 28 22:59:53 2022
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Mon, 28 Nov 2022 21:59:52 +0000
Message-ID: <bug-31059-70-atbdveSHPT@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8232390678728125544=="

--===============8232390678728125544==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

Chris Slone <cslone@camdencountylibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cslone@camdencountylibrary.
                   |                            |org

--- Comment #1 from Chris Slone <cslone@camdencountylibrary.org> ---
Confirming that this does not get added to the koha-conf.xml. For anyone
looking for what to add it would be:

 <!-- Encryption key for crypted password or sensitive data -->
 <encryption_key>__ENCRYPTION_KEY__</encryption_key>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============8232390678728125544==--


From bugzilla-daemon@bugs.koha-community.org Tue Nov 29 00:37:07 2022
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Mon, 28 Nov 2022 23:37:06 +0000
Message-ID: <bug-31059-70-syptOV4E9I@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8720960324262680104=="

--===============8720960324262680104==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

David Cook <dcook@prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook@prosentient.com.au

--- Comment #2 from David Cook <dcook@prosentient.com.au> ---
Yeah, this is an annoyance. The same problem exists for quite a few different
koha-conf.xml options :/.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============8720960324262680104==--


From bugzilla-daemon@bugs.koha-community.org Tue Nov 29 08:59:51 2022
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Tue, 29 Nov 2022 07:59:50 +0000
Message-ID: <bug-31059-70-7AA237m5wM@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9068503715668330150=="

--===============9068503715668330150==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

--- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
We could add something to the about page and future release notes here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============9068503715668330150==--


From bugzilla-daemon@bugs.koha-community.org Tue Nov 29 10:37:11 2022
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Tue, 29 Nov 2022 09:37:10 +0000
Message-ID: <bug-31059-70-W9msIevZ3c@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2774979396673201861=="

--===============2774979396673201861==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

--- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> ---
We need to script that add missing entries. It could be a simple (perl) misc
script that is called at the end of the debian upgrade procedure.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============2774979396673201861==--


From bugzilla-daemon@bugs.koha-community.org Tue Nov 29 15:14:44 2022
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Tue, 29 Nov 2022 14:14:43 +0000
Message-ID: <bug-31059-70-X0JBXtuMAO@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7316524171445978203=="

--===============7316524171445978203==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D31059

--- Comment #5 from Chris Slone <cslone@camdencountylibrary.org> ---
I think a script like that would be great. Documentation would definitely help
too, as the tags for wrapping the entry, or even the need for changing the
config file at all, wasn't really in the release notes for the new feature (n=
ot
that I saw, anyhow).

--=20
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============7316524171445978203==--


From bugzilla-daemon@bugs.koha-community.org Tue Dec  6 04:11:20 2022
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Tue, 06 Dec 2022 03:11:18 +0000
Message-ID: <bug-31059-70-23zgszLUxZ@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3185398212039272195=="

--===============3185398212039272195==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

--- Comment #6 from David Cook <dcook@prosentient.com.au> ---
(In reply to Jonathan Druart from comment #4)
> We need to script that add missing entries. It could be a simple (perl) misc
> script that is called at the end of the debian upgrade procedure.

I added a sample one on bug 28911 that I used as a once-off but it would need
work to be used regularly like that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============3185398212039272195==--


From bugzilla-daemon@bugs.koha-community.org Tue Dec  6 04:11:53 2022
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Tue, 06 Dec 2022 03:11:42 +0000
Message-ID: <bug-31059-70-7F475umzaV@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4375251979957546300=="

--===============4375251979957546300==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

David Cook <dcook@prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22857

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============4375251979957546300==--


From bugzilla-daemon@bugs.koha-community.org Tue Jun  6 08:59:24 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Tue, 06 Jun 2023 06:59:13 +0000
Message-ID: <bug-31059-70-uYT2SUb4eK@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1106634172831231392=="

--===============1106634172831231392==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

Jonathan Druart <jonathan.druart+koha@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=30649

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============1106634172831231392==--


From bugzilla-daemon@bugs.koha-community.org Wed Jun 28 23:05:33 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Wed, 28 Jun 2023 21:05:32 +0000
Message-ID: <bug-31059-70-0z0NU8AksJ@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8323128154366089973=="

--===============8323128154366089973==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

David Nind <david@davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=33934
                 CC|                            |david@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============8323128154366089973==--


From bugzilla-daemon@bugs.koha-community.org Mon Sep 18 08:54:50 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Mon, 18 Sep 2023 06:54:49 +0000
Message-ID: <bug-31059-70-wYy3pdKlVB@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2408440852853543348=="

--===============2408440852853543348==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

David Cook <dcook@prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============2408440852853543348==--


From bugzilla-daemon@bugs.koha-community.org Wed Sep  4 09:57:47 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Wed, 04 Sep 2024 07:57:46 +0000
Message-ID: <bug-31059-70-ksPBEpZ5SP@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0940166618552597738=="

--===============0940166618552597738==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D31059

--- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> ---
And... Why not simply doing it in a db rev? Fail the upgrade until the key
exists in the config: we provide info about how to generate the key and add it
to the config. A people doing the Koha upgrade is supposed to know how to run=
 a
command and edit a file on the server.

--=20
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============0940166618552597738==--


From bugzilla-daemon@bugs.koha-community.org Wed Sep  4 14:49:48 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Wed, 04 Sep 2024 12:49:47 +0000
Message-ID: <bug-31059-70-qxNSdLRQDa@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1632530725890106776=="

--===============1632530725890106776==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

--- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
(In reply to Jonathan Druart from comment #7)
> And... Why not simply doing it in a db rev? Fail the upgrade until the key
> exists in the config: we provide info about how to generate the key and add
> it to the config. A people doing the Koha upgrade is supposed to know how to
> run a command and edit a file on the server.

Hm, I hope noone does a major update unattended, but they might get stuck on
this. Also, you'd need to restart things (Plack, Apache?) would the update
continue fine from there?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============1632530725890106776==--


From bugzilla-daemon@bugs.koha-community.org Thu Sep  5 04:39:51 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Thu, 05 Sep 2024 02:39:50 +0000
Message-ID: <bug-31059-70-xp0BqghuM8@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8936689924228030078=="

--===============8936689924228030078==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

--- Comment #9 from David Cook <dcook@prosentient.com.au> ---
(In reply to Jonathan Druart from comment #7)
> And... Why not simply doing it in a db rev? Fail the upgrade until the key
> exists in the config: we provide info about how to generate the key and add
> it to the config. A people doing the Koha upgrade is supposed to know how to
> run a command and edit a file on the server.

I think this would cause a lot of headaches, but it's an interesting point.

I still like the idea of a machine-generated config file that we can update
(for example via a db rev). 

Or... koha-conf.xml becomes a generated file. We can have a separate file for
local updates, and it can be used with program logic to generate the
koha-conf.xml

That could automatically keep koha-conf.xml up-to-date.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============8936689924228030078==--


From bugzilla-daemon@bugs.koha-community.org Thu Sep  5 04:43:46 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Thu, 05 Sep 2024 02:43:45 +0000
Message-ID: <bug-31059-70-Zllf2nVPWS@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2231682958707374555=="

--===============2231682958707374555==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

--- Comment #10 from David Cook <dcook@prosentient.com.au> ---
I have a Catalyst app that uses Catalyst::Plugin::ConfigLoader (and
Config::JFDI for non-Catalyst purposes).

It's great because I have a base config.yaml file which I manage in version
control, and then each instance has its own config_local.yaml file. These then
get merged together with the local file overwriting the base file at app
startup time.

That said, that doesn't have a mechanism either for auto-generated values. 

But if I wanted to add auto-generated values, I'd probably introduce them via
that base config.yaml file. 

--

Anyway, just my 2 cents

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============2231682958707374555==--


From bugzilla-daemon@bugs.koha-community.org Thu Sep  5 05:11:32 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Thu, 05 Sep 2024 03:11:31 +0000
Message-ID: <bug-31059-70-DgWg60hQeG@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5641790031946571736=="

--===============5641790031946571736==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

--- Comment #11 from David Cook <dcook@prosentient.com.au> ---
(One last one... I'd love to split out the Zebra config from the rest of
koha-conf.xml. The majority of koha-conf.xml is actually just Zebra config. As
we embrace Elasticsearch more and more, it's feeling sillier and sillier to
have most of koha-conf.xml be dedicated to Zebra...)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============5641790031946571736==--


From bugzilla-daemon@bugs.koha-community.org Thu Sep  5 09:05:53 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Thu, 05 Sep 2024 07:05:52 +0000
Message-ID: <bug-31059-70-xcU9Z4GkSf@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4467027313698537190=="

--===============4467027313698537190==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D31059

--- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> ---
What I suggested with the db rev was to have a quick solution for this proble=
m.
We can of course rethink the whole thing but it's 1 or 2 hours of work vs... X
days :)

(In reply to Katrin Fischer from comment #8)
> (In reply to Jonathan Druart from comment #7)
> > And... Why not simply doing it in a db rev? Fail the upgrade until the key
> > exists in the config: we provide info about how to generate the key and a=
dd
> > it to the config. A people doing the Koha upgrade is supposed to know how=
 to
> > run a command and edit a file on the server.
>=20
> Hm, I hope noone does a major update unattended, but they might get stuck on
> this. Also, you'd need to restart things (Plack, Apache?) would the update
> continue fine from there?

Yes, this would be part of the "info" we will display:
Generate the key using this command, copy the output to the koha-conf into the
correct tag, restart everything, try the update again.

--=20
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============4467027313698537190==--


From bugzilla-daemon@bugs.koha-community.org Fri Sep  6 03:04:29 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Fri, 06 Sep 2024 01:04:28 +0000
Message-ID: <bug-31059-70-QVYeS6MEWF@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4499943626400619787=="

--===============4499943626400619787==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

--- Comment #13 from David Cook <dcook@prosentient.com.au> ---
(In reply to Jonathan Druart from comment #12)
> What I suggested with the db rev was to have a quick solution for this
> problem. We can of course rethink the whole thing but it's 1 or 2 hours of
> work vs... X days :)

It's not a practical solution for many Koha implementers though.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============4499943626400619787==--


From bugzilla-daemon@bugs.koha-community.org Mon Sep  9 13:38:18 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Mon, 09 Sep 2024 11:38:17 +0000
Message-ID: <bug-31059-70-YOzrVgR9Po@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2065566323273678338=="

--===============2065566323273678338==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

--- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> ---
(In reply to David Cook from comment #13)
> (In reply to Jonathan Druart from comment #12)
> > What I suggested with the db rev was to have a quick solution for this
> > problem. We can of course rethink the whole thing but it's 1 or 2 hours of
> > work vs... X days :)
> 
> It's not a practical solution for many Koha implementers though.

Are we stuck then?

I wanted to suggest an easy to implement solution for bug 35970.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============2065566323273678338==--


From bugzilla-daemon@bugs.koha-community.org Mon Sep  9 13:46:18 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Mon, 09 Sep 2024 11:46:17 +0000
Message-ID: <bug-31059-70-ziQWcqDBe6@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9127273572504777776=="

--===============9127273572504777776==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

--- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
I feel having the database update stuck doesn't feel right. Printing and info
and adding to the about page would be preferred... in case of the JS files I
have commented there. I guess the problem is, that we might break things too
much to check the about page?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============9127273572504777776==--


From bugzilla-daemon@bugs.koha-community.org Fri Oct  4 00:24:29 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Thu, 03 Oct 2024 22:24:28 +0000
Message-ID: <bug-31059-70-MmCqmIReOr@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6430428533240015752=="

--===============6430428533240015752==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D31059

Victor Grousset/tuxayo <victor@tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor@tuxayo.net

--- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
IIRC <encryption_key> was outside of the DB so 3rd party service passwords and
sensitive data would be safe against a DB only leak (like with an SQL
injection).

But for the purpose of asset versioning without leaking the version of Koha,
would it work to have another encryption key in the DB for that use? It doesn=
't
matter much if it gets eventually stolen with the DB.

----

Something else:
I might have missed if there is this possibility: can we count for most cases
on koha-conf.xml being writable by the update process? So <encryption_key>
could be populated there and the rest of the cases without write permission
would need manual intervention for the upgrade. Assuming there are, it might
not be that bad to have a major upgrade needed a manual intervention. Since
switching the update source would already be a manual intervention.

A bonus is that every install would have an out of DB key so that opens the
possibility of using it in password storage so an SQL injection would have
absolutely no chance in being compromised. Whereas today, even with salt and
heavy hashing algorithms, It's feasible to test at least hundreds of thousands
of passwords from dictionaries of the most popular ones.

But that whole thing relies on counting for most cases on koha-conf.xml being
writable.
There are signs that it might be writable. =C2=ABOr... koha-conf.xml becomes a
generated file=C2=BB

--=20
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============6430428533240015752==--


From bugzilla-daemon@bugs.koha-community.org Wed Oct  9 05:36:27 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Wed, 09 Oct 2024 03:36:26 +0000
Message-ID: <bug-31059-70-nJqhIzB94S@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8720590227046390238=="

--===============8720590227046390238==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D31059

--- Comment #17 from David Cook <dcook@prosentient.com.au> ---
(In reply to Victor Grousset/tuxayo from comment #16)
> But that whole thing relies on counting for most cases on koha-conf.xml
> being writable.
> There are signs that it might be writable. =C2=ABOr... koha-conf.xml become=
s a
> generated file=C2=BB

In koha-testing-docker koha-conf.xml looks like it's writeable by the owner a=
nd
the owner is the Koha user.

On my servers, it looks like koha-conf.xml is owned by root.=20

According to debian/scripts/koha-create it should be owned by root...

So that's fun.

--=20
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============8720590227046390238==--


From bugzilla-daemon@bugs.koha-community.org Thu Oct 10 04:46:22 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Thu, 10 Oct 2024 02:46:21 +0000
Message-ID: <bug-31059-70-JQhQtsZ100@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7941092633785426981=="

--===============7941092633785426981==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

--- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
Thanks for checking David.

> According to debian/scripts/koha-create

So these are regular Debian or Ubuntu package installs?
These are not the RHEL/CentOS installs with homemade packaging you had at some
point?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============7941092633785426981==--


From bugzilla-daemon@bugs.koha-community.org Mon Oct 14 05:07:08 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Mon, 14 Oct 2024 03:07:07 +0000
Message-ID: <bug-31059-70-vkNwQaa0sv@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4643854538286408295=="

--===============4643854538286408295==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

--- Comment #19 from David Cook <dcook@prosentient.com.au> ---
(In reply to Victor Grousset/tuxayo from comment #18)
> Thanks for checking David.
> 
> > According to debian/scripts/koha-create
> 
> So these are regular Debian or Ubuntu package installs?
> These are not the RHEL/CentOS installs with homemade packaging you had at
> some point?

Yeah, recent Debian package installs. (That said, there could've been sysadmin
on top that changed things later. I haven't tested actually creating a new
branch on a test server.)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============4643854538286408295==--


From bugzilla-daemon@bugs.koha-community.org Thu Oct 31 00:27:02 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Wed, 30 Oct 2024 23:26:51 +0000
Message-ID: <bug-31059-70-6Ujak0JSPr@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3619629329847231837=="

--===============3619629329847231837==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

David Cook <dcook@prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31180

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============3619629329847231837==--


From bugzilla-daemon@bugs.koha-community.org Thu Oct 31 00:48:52 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Wed, 30 Oct 2024 23:48:52 +0000
Message-ID: <bug-31059-70-8hAvU0pYTZ@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3117125211873075924=="

--===============3117125211873075924==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

--- Comment #20 from David Cook <dcook@prosentient.com.au> ---
Let's follow this up on bug 31180

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============3117125211873075924==--


From bugzilla-daemon@bugs.koha-community.org Tue Jun 16 15:08:03 2026
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
Date: Tue, 16 Jun 2026 13:07:52 +0000
Message-ID: <bug-31059-70-swmPW2ROAk@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8194921412040000552=="

--===============8194921412040000552==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

Saiful Amin <saiful@semanticconsulting.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=42861

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============8194921412040000552==--


