From bugzilla-daemon@bugs.koha-community.org Fri Jan 29 18:23:56 2016
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 15564] Display "print slip" option when returning an
 item which is in a rotating collection
Date: Fri, 29 Jan 2016 17:23:53 +0000
Message-ID: <bug-15564-70-SDb0oMx7cG@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-15564-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7441464083125372908=="

--===============7441464083125372908==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D15564

--- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> ---
Comment on attachment 47274
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D47274
Bug 15564 - Display "print slip" option when returning an item which is in a
rotating collection

Review of attachment 47274:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=3Dsplinter.html&b=
ug=3D15564&attachment=3D47274)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
@@ +134,5 @@
> =20
>  [% IF ( collectionItemNeedsTransferred ) %]
> +
> +<div id=3D"rotating-collection" class=3D"dialog message">
> +<h3><a href=3D"/cgi-bin/koha/catalogue/detail.pl?type=3Dintra&amp;biblionu=
mber=3D[% itembiblionumber %]">[% title or "item" |html %]</a> is part of a r=
otating collection and needs to be transferred to [% Branches.GetName( return=
branch ) %]<br/>( <a href=3D"#" onclick=3D"Dopop('transfer-slip.pl?transferit=
em=3D[% itemnumber %]&amp;branchcode=3D[% returnbranch %]&amp;op=3Dslip'); re=
turn true;">Print slip</a> )</h3>

Why print title or "item". I don't think we do this anywhere else. Also, shou=
ld
we be using the html filter here? Hasn't Jonathan been removing these because
of XSS vulnerabilities? Is it necessary?

--=20
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============7441464083125372908==--