From bugzilla-daemon@bugs.koha-community.org Mon Jul 8 00:36:32 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] New: Deleting a report from the actions menu on a list of saved reports does not work Date: Sun, 07 Jul 2024 22:36:31 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0281004006937181133==" --===============0281004006937181133== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D37270 Bug ID: 37270 Summary: Deleting a report from the actions menu on a list of saved reports does not work Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: phil@chetcolibrary.org QA Contact: testopia@bugs.koha-community.org Depends on: 36192 You need at least one saved report to see this. Reports - Use saved - for any listed report in the Actions column click the up-arrow next to Run and choose Delete. Confirm that you want to delete, then nothing happens. Our JS thinks that the DOM is=20
Delete And attaches a click handler to .delete at https://git.koha-community.org/Koha-community/Koha/src/commit/10853d1edc9c31b= cef096ffa514bb3025e0a760e/koha-tmpl/intranet-tmpl/prog/en/modules/reports/gui= ded_reports_start.tt#L2252 which does `return $(this).siblings('form').submit()`. That fails because there's already a form open above that form, and you can't nest forms, so the form we want to submit doesn't exist because the browser h= as ignored that tag. Now that we have form-submit.js, we should just use it instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha --=20 You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============0281004006937181133==-- From bugzilla-daemon@bugs.koha-community.org Tue Jul 9 15:05:47 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Tue, 09 Jul 2024 13:05:46 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6381883945952347458==" --===============6381883945952347458== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============6381883945952347458==-- From bugzilla-daemon@bugs.koha-community.org Tue Jul 9 15:53:26 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Tue, 09 Jul 2024 13:53:25 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5032462865304145323==" --===============5032462865304145323== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. --===============5032462865304145323==-- From bugzilla-daemon@bugs.koha-community.org Tue Jul 9 15:53:36 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Tue, 09 Jul 2024 13:53:27 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6639693275242452364==" --===============6639693275242452364== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 --- Comment #1 from Owen Leonard --- Created attachment 168653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168653&action=edit Bug 37270: Fix deletion of saved reports This patch fixes deletion of saved reports in two instances which were broken by the CSRF changes: From the dropdown menu in the table of saved reports, and in the modal window which appears if you click the "Preview" dropdown menu in the table of saved reports. The patch also makes a minor change to form-submit.js so that the event handler will attach to dynamically-generated elements (as is the case with the preview modal). To test, apply the patch and go to Reports -> Use saved. - Add one or more reports if necessary. - In the table of reports, click the secondary dropdown link in the "Run" button. - Click "Delete." You should be asked to confirm, and confirming should correctly delete the report. - Now test the "Preview SQL" link in the menu. - A modal window should appear showing you the SQL of the report. - In the footer of the modal, test the "Delete" button. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes. --===============6639693275242452364==-- From bugzilla-daemon@bugs.koha-community.org Tue Jul 9 15:54:31 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Tue, 09 Jul 2024 13:54:31 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8546350010684006942==" --===============8546350010684006942== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D37270 --- Comment #2 from Owen Leonard --- "FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.= tt FAIL forbidden patterns forbidden pattern: simple-quote string (line 2461)" I think this isn't correct in this situation. --=20 You are receiving this mail because: You are watching all bug changes. --===============8546350010684006942==-- From bugzilla-daemon@bugs.koha-community.org Tue Jul 9 17:05:19 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Tue, 09 Jul 2024 15:05:18 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3747286307152786493==" --===============3747286307152786493== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D37270 --- Comment #3 from Phil Ringnalda --- That failure made me look at what that code was trying to do (since it's certainly obscure that the start of that single quote is 15 lines above), whi= ch made me discover that SQL preview actually has actions and is thus what I want to do first when I can't remember whether a forgotten report named 'tempfoo' = is actually junk, so correct or not it was certainly useful to me :) --=20 You are receiving this mail because: You are watching all bug changes. --===============3747286307152786493==-- From bugzilla-daemon@bugs.koha-community.org Tue Jul 9 17:19:48 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Tue, 09 Jul 2024 15:19:48 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8837773829964460028==" --===============8837773829964460028== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============8837773829964460028==-- From bugzilla-daemon@bugs.koha-community.org Tue Jul 9 17:19:59 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Tue, 09 Jul 2024 15:19:50 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8693517492566776178==" --===============8693517492566776178== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168653|0 |1 is obsolete| | --- Comment #4 from Phil Ringnalda --- Created attachment 168667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168667&action=edit Bug 37270: Fix deletion of saved reports This patch fixes deletion of saved reports in two instances which were broken by the CSRF changes: From the dropdown menu in the table of saved reports, and in the modal window which appears if you click the "Preview" dropdown menu in the table of saved reports. The patch also makes a minor change to form-submit.js so that the event handler will attach to dynamically-generated elements (as is the case with the preview modal). To test, apply the patch and go to Reports -> Use saved. - Add one or more reports if necessary. - In the table of reports, click the secondary dropdown link in the "Run" button. - Click "Delete." You should be asked to confirm, and confirming should correctly delete the report. - Now test the "Preview SQL" link in the menu. - A modal window should appear showing you the SQL of the report. - In the footer of the modal, test the "Delete" button. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda -- You are receiving this mail because: You are watching all bug changes. --===============8693517492566776178==-- From bugzilla-daemon@bugs.koha-community.org Wed Jul 17 17:19:36 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Wed, 17 Jul 2024 15:19:35 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8880283191018707706==" --===============8880283191018707706== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168667|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 169091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169091&action=edit Bug 37270: Fix deletion of saved reports This patch fixes deletion of saved reports in two instances which were broken by the CSRF changes: From the dropdown menu in the table of saved reports, and in the modal window which appears if you click the "Preview" dropdown menu in the table of saved reports. The patch also makes a minor change to form-submit.js so that the event handler will attach to dynamically-generated elements (as is the case with the preview modal). To test, apply the patch and go to Reports -> Use saved. - Add one or more reports if necessary. - In the table of reports, click the secondary dropdown link in the "Run" button. - Click "Delete." You should be asked to confirm, and confirming should correctly delete the report. - Now test the "Preview SQL" link in the menu. - A modal window should appear showing you the SQL of the report. - In the footer of the modal, test the "Delete" button. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. --===============8880283191018707706==-- From bugzilla-daemon@bugs.koha-community.org Wed Jul 17 17:19:58 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Wed, 17 Jul 2024 15:19:58 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2001564957241730403==" --===============2001564957241730403== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize --- Nice bit of cleanup alongside the fix here. Passing QA -- You are receiving this mail because: You are watching all bug changes. --===============2001564957241730403==-- From bugzilla-daemon@bugs.koha-community.org Wed Jul 17 17:21:03 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Wed, 17 Jul 2024 15:20:56 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5328161712595903596==" --===============5328161712595903596== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. --===============5328161712595903596==-- From bugzilla-daemon@bugs.koha-community.org Thu Jul 18 16:39:34 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Thu, 18 Jul 2024 14:39:33 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0456547264275531821==" --===============0456547264275531821== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D37270 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #7 from Katrin Fischer --- Can you please fix this QA script complaint: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.= tt FAIL forbidden patterns forbidden pattern: simple-quote string (line 2461) It's in a big block of JS so switching the quotes is quite confusing. --=20 You are receiving this mail because: You are watching all bug changes. --===============0456547264275531821==-- From bugzilla-daemon@bugs.koha-community.org Thu Jul 18 17:29:34 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Thu, 18 Jul 2024 15:29:33 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9139417080335021247==" --===============9139417080335021247== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 --- Comment #8 from Katrin Fischer --- This actually breaks the test, so waiting for the follow-up before pushing it. # Looks like you failed 1 test of 1. xt/single_quotes.t ............... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests xt/tt_valid.t ..... -- You are receiving this mail because: You are watching all bug changes. --===============9139417080335021247==-- From bugzilla-daemon@bugs.koha-community.org Thu Jul 18 17:29:44 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Thu, 18 Jul 2024 15:29:40 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8440094343181328059==" --===============8440094343181328059== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. --===============8440094343181328059==-- From bugzilla-daemon@bugs.koha-community.org Thu Jul 18 17:29:54 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Thu, 18 Jul 2024 15:29:49 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8392081375430063043==" --===============8392081375430063043== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. --===============8392081375430063043==-- From bugzilla-daemon@bugs.koha-community.org Thu Jul 18 18:55:37 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Thu, 18 Jul 2024 16:55:12 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5119459382867921701==" --===============5119459382867921701== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============5119459382867921701==-- From bugzilla-daemon@bugs.koha-community.org Thu Jul 18 18:55:47 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Thu, 18 Jul 2024 16:55:13 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2278105011053282968==" --===============2278105011053282968== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 --- Comment #9 from Owen Leonard --- Created attachment 169155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169155&action=edit Bug 37270: (follow-up) Fix mixed quotes in preview modal JS -- You are receiving this mail because: You are watching all bug changes. --===============2278105011053282968==-- From bugzilla-daemon@bugs.koha-community.org Thu Jul 18 18:56:01 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Thu, 18 Jul 2024 16:56:00 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3298285333302347570==" --===============3298285333302347570== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 --- Comment #10 from Owen Leonard --- I was not able to get the translation tool to run, so I don't know if this really works in translated templates. If you can, please try it! -- You are receiving this mail because: You are watching all bug changes. --===============3298285333302347570==-- From bugzilla-daemon@bugs.koha-community.org Mon Jul 22 08:38:55 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Mon, 22 Jul 2024 06:38:02 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8770511066262836063==" --===============8770511066262836063== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. --===============8770511066262836063==-- From bugzilla-daemon@bugs.koha-community.org Mon Jul 22 08:39:05 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Mon, 22 Jul 2024 06:38:04 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0655346169101368308==" --===============0655346169101368308== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 --- Comment #11 from Martin Renvoize --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes. --===============0655346169101368308==-- From bugzilla-daemon@bugs.koha-community.org Thu Jul 25 14:30:09 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Thu, 25 Jul 2024 11:23:37 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5159692266049801961==" --===============5159692266049801961== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes. --===============5159692266049801961==-- From bugzilla-daemon@bugs.koha-community.org Thu Oct 10 00:07:36 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Wed, 09 Oct 2024 22:07:36 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0597887311445822841==" --===============0597887311445822841== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes. --===============0597887311445822841==-- From bugzilla-daemon@bugs.koha-community.org Thu Oct 10 17:56:45 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Thu, 10 Oct 2024 15:56:44 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5928844938138620063==" --===============5928844938138620063== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes. --===============5928844938138620063==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 14 20:55:14 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Mon, 14 Oct 2024 18:55:03 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0508012708038438645==" --===============0508012708038438645== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric@bywatersolutions.com --- Comment #12 from Phil Ringnalda --- *** Bug 38160 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. --===============0508012708038438645==-- From bugzilla-daemon@bugs.koha-community.org Thu Oct 24 19:13:18 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Thu, 24 Oct 2024 17:13:17 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6174016597847972302==" --===============6174016597847972302== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 --- Comment #13 from Eric Swenson --- Would this be able to be backported? -- You are receiving this mail because: You are watching all bug changes. --===============6174016597847972302==-- From bugzilla-daemon@bugs.koha-community.org Fri Oct 25 18:41:12 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Fri, 25 Oct 2024 16:41:12 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3910316298396063814==" --===============3910316298396063814== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 Lucas Gass (lukeg) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|24.11.00 |24.11.00,24.05.05 released in| | --- Comment #14 from Lucas Gass (lukeg) --- Backported to 24.05.x for upcoming 24.05.05 -- You are receiving this mail because: You are watching all bug changes. --===============3910316298396063814==-- From bugzilla-daemon@bugs.koha-community.org Fri Oct 25 18:41:23 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Fri, 25 Oct 2024 16:41:19 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8133448596073664913==" --===============8133448596073664913== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 Lucas Gass (lukeg) changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes. --===============8133448596073664913==-- From bugzilla-daemon@bugs.koha-community.org Wed Oct 30 18:06:44 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Wed, 30 Oct 2024 17:06:43 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1662786814100668088==" --===============1662786814100668088== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 CJ Lynce changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cj.lynce@westlakelibrary.or | |g --- Comment #15 from CJ Lynce --- Lucas, it appears backporting this patch on 24.05.x caused a regression, breaking the Delete button in the toolbar drop-down menu when running or editing reports. It looks like removal of lines 2252-2258 in guided_reports_start.tt (in the first patch) broke the drop-down delete option. This only affects the 24.05.x branch, not main. -- You are receiving this mail because: You are watching all bug changes. --===============1662786814100668088==-- From bugzilla-daemon@bugs.koha-community.org Fri Nov 15 16:41:28 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Fri, 15 Nov 2024 15:41:27 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2511040982485452960==" --===============2511040982485452960== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin Somers --- Depends on Bug 36192 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes. --===============2511040982485452960==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 21 15:20:08 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Fri, 21 Feb 2025 14:19:39 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1578167252888225543==" --===============1578167252888225543== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 Bug 37270 depends on bug 36192, which changed state. Bug 36192 Summary: [OMNIBUS] CSRF Protection for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. --===============1578167252888225543==-- From bugzilla-daemon@bugs.koha-community.org Fri Apr 18 21:15:19 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 37270] Deleting a report from the actions menu on a list of saved reports does not work Date: Fri, 18 Apr 2025 19:15:18 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7103198176141014316==" --===============7103198176141014316== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D37270 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #17 from Caroline Cyr La Rose = --- Bug fix, nothing to add/edit in the manual. --=20 You are receiving this mail because: You are watching all bug changes. --===============7103198176141014316==--