From bugzilla-daemon@bugs.koha-community.org Thu Jun 28 14:34:40 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8330] New: Overdue mail link contains untranslatable strings Date: Thu, 28 Jun 2012 12:44:07 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4974542964181915899==" --===============4974542964181915899== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 Priority: P5 - low Change sponsored?: --- Bug ID: 8330 CC: frederic@tamil.fr Assignee: koha-bugs@lists.koha-community.org Summary: Overdue mail link contains untranslatable strings Severity: minor Classification: Unclassified OS: All Reporter: katrin.fischer@bsz-bw.de Hardware: All Status: NEW Version: master Component: I18N/L10N Product: Koha The overdue with fines report contains email links with a subject line: Overdue: The "Overdue" is not translatable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============4974542964181915899==-- From bugzilla-daemon@bugs.koha-community.org Thu Jul 19 09:24:44 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8330] Overdue mail link contains untranslatable strings Date: Thu, 19 Jul 2012 07:35:13 +0000 Message-ID: <bug-8330-70-CUmArMHmWW@http.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-8330-70@http.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0219924563501608842==" --===============0219924563501608842== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson@biblibre.com --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 8468 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============0219924563501608842==-- From bugzilla-daemon@bugs.koha-community.org Tue Aug 7 22:06:34 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8330] Overdue mail link contains untranslatable strings Date: Tue, 07 Aug 2012 20:18:02 +0000 Message-ID: <bug-8330-70-RaSticxZUJ@http.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-8330-70@http.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8598803361697793470==" --===============8598803361697793470== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I wonder if these links are ever used? Would be possible to instead generate a one-time notice? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============8598803361697793470==-- From bugzilla-daemon@bugs.koha-community.org Tue Aug 7 22:21:28 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8330] Overdue mail link contains untranslatable strings Date: Tue, 07 Aug 2012 20:32:56 +0000 Message-ID: <bug-8330-70-zJJiYRsylw@http.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-8330-70@http.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8940763581555667752==" --===============8940763581555667752== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, an option so send a real mail from there using a notice template would certainly be much better! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============8940763581555667752==-- From bugzilla-daemon@bugs.koha-community.org Wed Aug 8 09:05:50 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8330] Overdue mail link contains untranslatable strings Date: Wed, 08 Aug 2012 07:17:19 +0000 Message-ID: <bug-8330-70-dW7JB3hmId@http.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-8330-70@http.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4696304971949138139==" --===============4696304971949138139== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 --- Comment #4 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- They are used in at least one library i know of. I think it makes sense to have this functionnality in a report that lists overdues. Even though i agree most libraries will choose to automate sending overdue notices. Some are small enough and would rather take care of it 100% manually, other might want to be able to send another notice, manually in some cases. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============4696304971949138139==-- From bugzilla-daemon@bugs.koha-community.org Wed Aug 8 09:07:09 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8330] Overdue mail link contains untranslatable strings Date: Wed, 08 Aug 2012 07:18:39 +0000 Message-ID: <bug-8330-70-pCwtWH6hJz@http.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-8330-70@http.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5100972796645918164==" --===============5100972796645918164== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 --- Comment #5 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- Actually there used to be, i've seen it in libraries using an older version, a 'MANUAL_ODUE' notice, which would be sent from here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============5100972796645918164==-- From bugzilla-daemon@bugs.koha-community.org Wed Aug 8 09:24:41 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8330] Overdue mail link contains untranslatable strings Date: Wed, 08 Aug 2012 07:36:10 +0000 Message-ID: <bug-8330-70-Z278nEi2XU@http.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-8330-70@http.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8013759821038045960==" --===============8013759821038045960== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Gaetan, yes, and we have been trying to make it work in the past - see bug 4990. Seems it was working in 2.2, then it got reintegrated in 3.0.x, while development was already done for 3.2. There never was a working patch for 3.2 (master back then), so the the feature got lost again after updating from 3.0.x. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============8013759821038045960==-- From bugzilla-daemon@bugs.koha-community.org Sun Jun 7 00:51:24 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8330] Overdue mail link contains untranslatable strings Date: Sat, 06 Jun 2015 22:51:22 +0000 Message-ID: <bug-8330-70-zymVdy1mAC@http.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-8330-70@http.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3813086335001644103==" --===============3813086335001644103== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is still valid. I think generating manual overdue emails could maybe be dealt with on bug 4990 and only fix the wrong string here for now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============3813086335001644103==-- From bugzilla-daemon@bugs.koha-community.org Mon Jun 8 01:01:03 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8330] Overdue mail link contains untranslatable strings Date: Sun, 07 Jun 2015 23:01:00 +0000 Message-ID: <bug-8330-70-3SjwwmGtby@http.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-8330-70@http.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7395005704757959556==" --===============7395005704757959556== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============7395005704757959556==-- From bugzilla-daemon@bugs.koha-community.org Mon Jun 8 01:01:08 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8330] Overdue mail link contains untranslatable strings Date: Sun, 07 Jun 2015 23:01:03 +0000 Message-ID: <bug-8330-70-kA89lOP46O@http.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-8330-70@http.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7350676359574542562==" --===============7350676359574542562== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 39962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39962&action=edit Bug 8330: Overdue email link contains untranslatable 'Overdue:' The translation scripts don't pick up text from href attributes, which is what we want, with a small exception for this script. Patch uses a TT trick to make the Overdue: in the subject of the mailto: link translatable. Regression test: - Make sure you have an overdue item - Go to Circulation > Overdues - Verify the [email] link works and a subject with 'Overdue: <title>' is generated - Apply patch and repeat steps Bonus: Verify the branch name now shows instead of the branchcode in the table To test translatability: - cd misc/translator - perl translate update de-DE - Open file po/de-DE-staff-prog.po - Search for Overdue: - Translate string, remove 'fuzzy' marker - perl translate install de-DE - Test again, subject should now be translated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============7350676359574542562==-- From bugzilla-daemon@bugs.koha-community.org Mon Jun 8 01:01:53 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8330] Overdues email subject contains untranslatable 'Overdue:' string Date: Sun, 07 Jun 2015 23:01:50 +0000 Message-ID: <bug-8330-70-7mLhoQykCZ@http.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-8330-70@http.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4592345451558880517==" --===============4592345451558880517== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Overdue mail link contains |Overdues email subject |untranslatable strings |contains untranslatable | |'Overdue:' string Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============4592345451558880517==-- From bugzilla-daemon@bugs.koha-community.org Wed Jun 10 23:03:05 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8330] Overdues email subject contains untranslatable 'Overdue:' string Date: Wed, 10 Jun 2015 21:02:58 +0000 Message-ID: <bug-8330-70-EXUBRnCugo@http.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-8330-70@http.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0521785148013838865==" --===============0521785148013838865== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============0521785148013838865==-- From bugzilla-daemon@bugs.koha-community.org Wed Jun 10 23:03:06 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8330] Overdues email subject contains untranslatable 'Overdue:' string Date: Wed, 10 Jun 2015 21:03:01 +0000 Message-ID: <bug-8330-70-8f2bdxDkRz@http.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-8330-70@http.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3586291373033729939==" --===============3586291373033729939== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39962|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 40083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40083&action=edit Bug 8330: Overdue email link contains untranslatable 'Overdue:' The translation scripts don't pick up text from href attributes, which is what we want, with a small exception for this script. Patch uses a TT trick to make the Overdue: in the subject of the mailto: link translatable. Regression test: - Make sure you have an overdue item - Go to Circulation > Overdues - Verify the [email] link works and a subject with 'Overdue: <title>' is generated - Apply patch and repeat steps Bonus: Verify the branch name now shows instead of the branchcode in the table To test translatability: - cd misc/translator - perl translate update de-DE - Open file po/de-DE-staff-prog.po - Search for Overdue: - Translate string, remove 'fuzzy' marker - perl translate install de-DE - Test again, subject should now be translated Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes. --===============3586291373033729939==-- From bugzilla-daemon@bugs.koha-community.org Tue Jun 16 17:52:13 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8330] Overdues email subject contains untranslatable 'Overdue:' string Date: Tue, 16 Jun 2015 15:52:10 +0000 Message-ID: <bug-8330-70-loE2CC47P4@http.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-8330-70@http.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5629065788093815120==" --===============5629065788093815120== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============5629065788093815120==-- From bugzilla-daemon@bugs.koha-community.org Tue Jun 16 17:52:22 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8330] Overdues email subject contains untranslatable 'Overdue:' string Date: Tue, 16 Jun 2015 15:52:13 +0000 Message-ID: <bug-8330-70-Ste024eTRp@http.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-8330-70@http.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7012457372751196076==" --===============7012457372751196076== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40083|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40190&action=edit Bug 8330: Overdue email link contains untranslatable 'Overdue:' The translation scripts don't pick up text from href attributes, which is what we want, with a small exception for this script. Patch uses a TT trick to make the Overdue: in the subject of the mailto: link translatable. Regression test: - Make sure you have an overdue item - Go to Circulation > Overdues - Verify the [email] link works and a subject with 'Overdue: <title>' is generated - Apply patch and repeat steps Bonus: Verify the branch name now shows instead of the branchcode in the table To test translatability: - cd misc/translator - perl translate update de-DE - Open file po/de-DE-staff-prog.po - Search for Overdue: - Translate string, remove 'fuzzy' marker - perl translate install de-DE - Test again, subject should now be translated Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes. --===============7012457372751196076==-- From bugzilla-daemon@bugs.koha-community.org Mon Jun 22 16:56:39 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8330] Overdues email subject contains untranslatable 'Overdue:' string Date: Mon, 22 Jun 2015 14:56:31 +0000 Message-ID: <bug-8330-70-IXeVBDy7zN@http.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-8330-70@http.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0974883273857891315==" --===============0974883273857891315== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Nice one Katrina! -- You are receiving this mail because: You are watching all bug changes. --===============0974883273857891315==-- From bugzilla-daemon@bugs.koha-community.org Thu Jul 9 23:17:39 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 8330] Overdues email subject contains untranslatable 'Overdue:' string Date: Thu, 09 Jul 2015 21:17:35 +0000 Message-ID: <bug-8330-70-urOze4ScHJ@http.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-8330-70@http.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3099380620619978303==" --===============3099380620619978303== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. --===============3099380620619978303==--