From bugzilla-daemon@bugs.koha-community.org Sat Jun 18 03:21:25 2016
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 16767] New: OPAC suggestions, existing suggestions
don't show after placing a suggestion
Date: Sat, 18 Jun 2016 01:21:20 +0000
Message-ID:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0532431199782185968=="
--===============0532431199782185968==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D16767
Bug ID: 16767
Summary: OPAC suggestions, existing suggestions don't show
after placing a suggestion
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Acquisitions
Assignee: koha-bugs@lists.koha-community.org
Reporter: nick@bywatersolutions.com
QA Contact: testopia@bugs.koha-community.org
After placing a purchase suggestion on the opac the confirmation screen reads:
"Your suggestion has been submitted.
There are no pending purchase suggestions."
Place another, same result.
These lines in opac-suggestions.pl don't seem to be working as intended:
136 ^I^I$$suggestion{$_}=3D'' foreach qw
;
137 ^I^I$suggestions_loop =3D
138 ^I^I &SearchSuggestion( $suggestion );
--=20
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
--===============0532431199782185968==--
From bugzilla-daemon@bugs.koha-community.org Sat Jun 18 03:21:53 2016
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 16767] OPAC suggestions, existing suggestions don't
show after placing a suggestion
Date: Sat, 18 Jun 2016 01:21:50 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0255772644227384349=="
--===============0255772644227384349==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com
|ity.org |
CC| |nick@bywatersolutions.com,
| |veron@veron.ch
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
--===============0255772644227384349==--
From bugzilla-daemon@bugs.koha-community.org Sat Jun 18 04:03:36 2016
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 16767] OPAC suggestions, existing suggestions don't
show after placing a suggestion
Date: Sat, 18 Jun 2016 02:03:29 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4205838033969873199=="
--===============4205838033969873199==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767
--- Comment #1 from Nick Clemens ---
Created attachment 52503
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52503&action=edit
Bug 16767 - OPAC suggestions, existing suggestions don't show after placing a
suggestion
To test:
1 - Before applying this patch, place some suggestions
2 - Note that on success you see no suggestions
3 - Apply this patch
4 - Add a suggestion, note you see the new suggestion and all other
5 - Add a duplicate suggestion, note suggestions is rejected and you see
all existing
--
You are receiving this mail because:
You are watching all bug changes.
--===============4205838033969873199==--
From bugzilla-daemon@bugs.koha-community.org Sat Jun 18 04:04:25 2016
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 16767] OPAC suggestions, existing suggestions don't
show after placing a suggestion
Date: Sat, 18 Jun 2016 02:04:15 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5464996112571203642=="
--===============5464996112571203642==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #2 from Nick Clemens ---
Needs to be unit tested
--
You are receiving this mail because:
You are watching all bug changes.
--===============5464996112571203642==--
From bugzilla-daemon@bugs.koha-community.org Sat Jun 18 08:16:50 2016
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 16767] OPAC suggestions, existing suggestions don't
show after placing a suggestion
Date: Sat, 18 Jun 2016 06:16:47 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2060861189135072989=="
--===============2060861189135072989==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767
Marc Véron changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=15128
--
You are receiving this mail because:
You are watching all bug changes.
--===============2060861189135072989==--
From bugzilla-daemon@bugs.koha-community.org Sat Jun 18 08:17:17 2016
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 16767] OPAC suggestions, existing suggestions don't
show after placing a suggestion
Date: Sat, 18 Jun 2016 06:17:14 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3830755576856341907=="
--===============3830755576856341907==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767
--- Comment #3 from Marc Véron ---
Works fine.
QA tool complains about a forbidden pattern tab char, opac/opac-suggestions.pl
(line 136)
--
You are receiving this mail because:
You are watching all bug changes.
--===============3830755576856341907==--
From bugzilla-daemon@bugs.koha-community.org Sat Aug 6 12:04:10 2016
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 16767] OPAC suggestions, existing suggestions don'
t show after placing a suggestion
Date: Sat, 06 Aug 2016 10:04:07 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0663831370869054993=="
--===============0663831370869054993==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767
Sandre Cunha changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |cunha@monterey.org
--
You are receiving this mail because:
You are watching all bug changes.
--===============0663831370869054993==--
From bugzilla-daemon@bugs.koha-community.org Sun Jun 10 12:56:44 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 16767] OPAC suggestions, existing suggestions don't
show after placing a suggestion
Date: Sun, 10 Jun 2018 10:56:40 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8060129625520143350=="
--===============8060129625520143350==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer@bsz-bw.de
--- Comment #4 from Katrin Fischer ---
Nick, did you forget about this one? :)
--
You are receiving this mail because:
You are watching all bug changes.
--===============8060129625520143350==--
From bugzilla-daemon@bugs.koha-community.org Sat Jun 16 04:07:54 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 16767] OPAC suggestions, existing suggestions don't
show after placing a suggestion
Date: Sat, 16 Jun 2018 02:07:24 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0166712873930414852=="
--===============0166712873930414852==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |WORKSFORME
--- Comment #5 from Nick Clemens ---
Seems to be fixed
--
You are receiving this mail because:
You are watching all bug changes.
--===============0166712873930414852==--