From bugzilla-daemon@bugs.koha-community.org Sat Sep 29 18:09:41 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21454] New: Price filtered variables should not need to be html filtered Date: Sat, 29 Sep 2018 16:09:39 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8088038534419707902==" --===============8088038534419707902== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21454 Bug ID: 21454 Summary: Price filtered variables should not need to be html filtered Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 13618, 21393 The result of a variable escaped using the Price filter does not need to be html filtered, it is always a float. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21393 [Bug 21393] Make template filter checks code reusable -- You are receiving this mail because: You are watching all bug changes. --===============8088038534419707902==-- From bugzilla-daemon@bugs.koha-community.org Sat Sep 29 18:14:17 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21454] Price filtered variables should not need to be html filtered Date: Sat, 29 Sep 2018 16:14:14 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3802789400400064956==" --===============3802789400400064956== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D21454 --- Comment #1 from Jonathan Druart = --- Created attachment 79614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D79614&action=3D= edit Bug 21454: Update the tests --=20 You are receiving this mail because: You are watching all bug changes. --===============3802789400400064956==-- From bugzilla-daemon@bugs.koha-community.org Sat Sep 29 18:14:24 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21454] Price filtered variables should not need to be html filtered Date: Sat, 29 Sep 2018 16:14:19 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5208527094687838788==" --===============5208527094687838788== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D21454 --- Comment #2 from Jonathan Druart = --- Created attachment 79615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D79615&action=3D= edit Bug 21454: Do not require html filter on Price Test plan: - Apply first patch - Confirm that tests is failing (t/template_filters.t) - Apply second patch - Confirm that tests return green - Apply last patch - Confirm that prices are displayed correctly QA step: Edit a template and add the following 2 lines: [% SET p =3D '' %] [% x | $Price %] =3D> Display '0.00' --=20 You are receiving this mail because: You are watching all bug changes. --===============5208527094687838788==-- From bugzilla-daemon@bugs.koha-community.org Sat Sep 29 18:14:26 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21454] Price filtered variables should not need to be html filtered Date: Sat, 29 Sep 2018 16:14:23 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2450886489231717478==" --===============2450886489231717478== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D21454 --- Comment #3 from Jonathan Druart = --- Created attachment 79616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D79616&action=3D= edit Bug 21454: Remove html filter for Price filtered variables Generated with: perl -p -i -e 's/\|\s?\$Price\s?\|\s?html\s%]/| \$Price %]/g' **/*.tt **/*.inc --=20 You are receiving this mail because: You are watching all bug changes. --===============2450886489231717478==-- From bugzilla-daemon@bugs.koha-community.org Sat Sep 29 18:14:38 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21454] Price filtered variables should not need to be html filtered Date: Sat, 29 Sep 2018 16:14:31 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2264545714075547851==" --===============2264545714075547851== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21454 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21167 -- You are receiving this mail because: You are watching all bug changes. --===============2264545714075547851==-- From bugzilla-daemon@bugs.koha-community.org Sat Sep 29 18:14:41 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21454] Price filtered variables should not need to be html filtered Date: Sat, 29 Sep 2018 16:14:10 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6068482855919305766==" --===============6068482855919305766== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21454 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============6068482855919305766==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 1 13:20:46 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21454] Price filtered variables should not need to be html filtered Date: Mon, 01 Oct 2018 11:20:43 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1469057321718202065==" --===============1469057321718202065== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21454 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79614|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 79703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79703&action=edit Bug 21454: Update the tests Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. --===============1469057321718202065==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 1 13:21:11 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21454] Price filtered variables should not need to be html filtered Date: Mon, 01 Oct 2018 11:20:40 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2635990379307282517==" --===============2635990379307282517== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21454 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============2635990379307282517==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 1 13:21:16 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21454] Price filtered variables should not need to be html filtered Date: Mon, 01 Oct 2018 11:20:56 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2396572655948244048==" --===============2396572655948244048== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21454 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79616|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 79705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79705&action=edit Bug 21454: Remove html filter for Price filtered variables Generated with: perl -p -i -e 's/\|\s?\$Price\s?\|\s?html\s%]/| \$Price %]/g' **/*.tt **/*.inc Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. --===============2396572655948244048==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 1 13:21:22 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21454] Price filtered variables should not need to be html filtered Date: Mon, 01 Oct 2018 11:20:53 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0060393434553698826==" --===============0060393434553698826== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21454 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79615|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 79704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79704&action=edit Bug 21454: Do not require html filter on Price Test plan: - Apply first patch - Confirm that tests is failing (t/template_filters.t) - Apply second patch - Confirm that tests return green - Apply last patch - Confirm that prices are displayed correctly QA step: Edit a template and add the following 2 lines: [% SET p = '' %] [% x | $Price %] => Display '0.00' Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. --===============0060393434553698826==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 1 15:01:57 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21454] Price filtered variables should not need to be html filtered Date: Mon, 01 Oct 2018 13:01:51 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0951094655278852547==" --===============0951094655278852547== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21454 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Passed QA --- Comment #7 from Nick Clemens --- Moving to PQA - reviewed, changes all make sense -- You are receiving this mail because: You are watching all bug changes. --===============0951094655278852547==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 1 18:46:29 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21454] Price filtered variables should not need to be html filtered Date: Mon, 01 Oct 2018 16:46:26 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4634434442179288109==" --===============4634434442179288109== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21454 --- Comment #8 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. --===============4634434442179288109==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 1 18:46:39 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21454] Price filtered variables should not need to be html filtered Date: Mon, 01 Oct 2018 16:46:35 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8772888845787856383==" --===============8772888845787856383== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21454 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. --===============8772888845787856383==-- From bugzilla-daemon@bugs.koha-community.org Fri Oct 5 17:52:50 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21454] Price filtered variables should not need to be html filtered Date: Fri, 05 Oct 2018 15:52:48 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2894002919466439537==" --===============2894002919466439537== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21454 Bug 21454 depends on bug 21393, which changed state. Bug 21393 Summary: Make template filter checks code reusable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21393 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. --===============2894002919466439537==-- From bugzilla-daemon@bugs.koha-community.org Fri Oct 5 17:54:23 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21454] Price filtered variables should not need to be html filtered Date: Fri, 05 Oct 2018 15:53:54 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6128449629018309035==" --===============6128449629018309035== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21454 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #9 from Martin Renvoize --- Dependency not in 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. --===============6128449629018309035==-- From bugzilla-daemon@bugs.koha-community.org Mon Dec 3 20:43:06 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21454] Price filtered variables should not need to be html filtered Date: Mon, 03 Dec 2018 19:42:34 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3405585157760488006==" --===============3405585157760488006== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D21454 Bug 21454 depends on bug 13618, which changed state. Bug 13618 Summary: Add additional template filter methods and a filter presen= ce test to Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D13618 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --=20 You are receiving this mail because: You are watching all bug changes. --===============3405585157760488006==--