From bugzilla-daemon@bugs.koha-community.org Wed Sep  6 08:33:37 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 34724] New: Remove use of onclick for opac-imageviewer.pl
Date: Wed, 06 Sep 2023 06:33:36 +0000
Message-ID: <bug-34724-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5727311525142331406=="

--===============5727311525142331406==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34724

            Bug ID: 34724
           Summary: Remove use of onclick for opac-imageviewer.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard@myacpl.org
          Reporter: dcook@prosentient.com.au
        QA Contact: testopia@bugs.koha-community.org
        Depends on: 34723

Like bug 34570, we want to get rid of "onclick".


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34723
[Bug 34723] opac-imageviewer.pl not showing thumbnails
-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5727311525142331406==--


From bugzilla-daemon@bugs.koha-community.org Wed Sep  6 08:42:27 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34724] Remove use of onclick for opac-imageviewer.pl
Date: Wed, 06 Sep 2023 06:42:26 +0000
Message-ID: <bug-34724-70-qxnXovXFrG@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34724-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8575098487641035948=="

--===============8575098487641035948==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34724

David Cook <dcook@prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8575098487641035948==--


From bugzilla-daemon@bugs.koha-community.org Wed Sep  6 08:42:37 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34724] Remove use of onclick for opac-imageviewer.pl
Date: Wed, 06 Sep 2023 06:42:29 +0000
Message-ID: <bug-34724-70-E7FhlVJ3P7@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34724-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7550689647096195457=="

--===============7550689647096195457==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D34724

--- Comment #1 from David Cook <dcook@prosentient.com.au> ---
Created attachment 155255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D155255&action=
=3Dedit
Bug 34724: Remove inline onclick handler for opac-imageviewer.pl

This patch moves the click handler for thumbnails for opac-imageviewer.pl
out of the inline HTML and out to an existing <script> element.

Test plan:
0. Apply the patch (including dependent patches)
1. Go to
http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=3D&op=3Dsearch&se=
archfield=3Dlocalcover
2. Change both *LocalCoverImages sysprefs to "Show"
3. Go to
http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=3D&op=3Dsearch&se=
archfield=3DAllowMultipleCovers
4. Change "AllowMultipleCovers" to "Allow"
5. Click "Images (0)" tab
6. Download or make two JPEG images
7. Upload the images
8. Go to http://localhost:8080/cgi-bin/koha/opac-imageviewer.pl?biblionumber=
=3D29
9. See one large image in the centre and two smaller thumbnails on the right
side
10. Click on the thumbnail of the image that isn't displayed in the centre
11. Note that the image changes
12. Click the other thumbnail and note that the image changes back

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============7550689647096195457==--


From bugzilla-daemon@bugs.koha-community.org Wed Sep  6 08:42:48 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34724] Remove use of onclick for opac-imageviewer.pl
Date: Wed, 06 Sep 2023 06:42:44 +0000
Message-ID: <bug-34724-70-FRZPZgXAKq@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34724-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1049697809058522058=="

--===============1049697809058522058==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34724

David Cook <dcook@prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard@myacpl.org         |dcook@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1049697809058522058==--


From bugzilla-daemon@bugs.koha-community.org Wed Sep  6 08:43:20 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34724] Remove use of onclick for opac-imageviewer.pl
Date: Wed, 06 Sep 2023 06:43:08 +0000
Message-ID: <bug-34724-70-kcDR3Otio9@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34724-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4347638040736146212=="

--===============4347638040736146212==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34724

David Cook <dcook@prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |34709


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709
[Bug 34709] Eliminate event handler attributes in the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4347638040736146212==--


From bugzilla-daemon@bugs.koha-community.org Thu Sep  7 15:11:35 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34724] Remove use of onclick for opac-imageviewer.pl
Date: Thu, 07 Sep 2023 13:11:34 +0000
Message-ID: <bug-34724-70-oTbSNm6Rtd@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34724-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2535432810673915444=="

--===============2535432810673915444==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34724

Pedro Amorim <pedro.amorim@ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2535432810673915444==--


From bugzilla-daemon@bugs.koha-community.org Thu Sep  7 15:11:45 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34724] Remove use of onclick for opac-imageviewer.pl
Date: Thu, 07 Sep 2023 13:11:36 +0000
Message-ID: <bug-34724-70-55gh39AiLP@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34724-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2749603268979046343=="

--===============2749603268979046343==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D34724

Pedro Amorim <pedro.amorim@ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #155255|0                           |1
        is obsolete|                            |

--- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> ---
Created attachment 155299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D155299&action=
=3Dedit
Bug 34724: Remove inline onclick handler for opac-imageviewer.pl

This patch moves the click handler for thumbnails for opac-imageviewer.pl
out of the inline HTML and out to an existing <script> element.

Test plan:
0. Apply the patch (including dependent patches)
1. Go to
http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=3D&op=3Dsearch&se=
archfield=3Dlocalcover
2. Change both *LocalCoverImages sysprefs to "Show"
3. Go to
http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=3D&op=3Dsearch&se=
archfield=3DAllowMultipleCovers
4. Change "AllowMultipleCovers" to "Allow"
5. Go to
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=3D29
6. Click "Images (0)" tab
7. Download or make two JPEG images
8. Upload the images
9. Go to http://localhost:8080/cgi-bin/koha/opac-imageviewer.pl?biblionumber=
=3D29
10. See one large image in the centre and two smaller thumbnails on the right
side
11. Click on the thumbnail of the image that isn't displayed in the centre
12. Note that the image changes
13. Click the other thumbnail and note that the image changes back

PA amended patch: Added missing test plan step

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============2749603268979046343==--


From bugzilla-daemon@bugs.koha-community.org Thu Sep  7 15:11:55 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34724] Remove use of onclick for opac-imageviewer.pl
Date: Thu, 07 Sep 2023 13:11:38 +0000
Message-ID: <bug-34724-70-v4RXQfkh2m@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34724-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0632032319788009994=="

--===============0632032319788009994==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34724

--- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> ---
Created attachment 155300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155300&action=edit
Bug 34724: (QA follow-up):

Replace href from thumbnail link with a # to keep pointer event. The href link
gets reconstructed by showCover anyway
Remove return false from on click event, its not triggering a location change
anymore because of the above
Remove check for imagenumber, its a non-null primary key, if the image exists,
then the imagenumber must also exist
The link does not contain translatable strings, it doesnt need to be repeated
twice in if-else just for a css class change

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0632032319788009994==--


From bugzilla-daemon@bugs.koha-community.org Thu Sep  7 15:12:08 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34724] Remove use of onclick for opac-imageviewer.pl
Date: Thu, 07 Sep 2023 13:12:07 +0000
Message-ID: <bug-34724-70-Fba7yxk06V@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34724-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3968898855837732392=="

--===============3968898855837732392==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34724

Pedro Amorim <pedro.amorim@ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pedro.amorim@ptfs-europe.co
                   |                            |m

--- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> ---
Hi David, I've submitted a follow-up patch.
Please take a look and SO if you agree, or make obsolete if you don't.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3968898855837732392==--


From bugzilla-daemon@bugs.koha-community.org Fri Sep  8 04:11:45 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34724] Remove use of onclick for opac-imageviewer.pl
Date: Fri, 08 Sep 2023 02:11:44 +0000
Message-ID: <bug-34724-70-IVfAadQvsT@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34724-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2236875992468937018=="

--===============2236875992468937018==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34724

David Cook <dcook@prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #155300|0                           |1
        is obsolete|                            |

--- Comment #5 from David Cook <dcook@prosentient.com.au> ---
Comment on attachment 155300
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155300
Bug 34724: (QA follow-up):

The "src" and Javascript change looked all right, but not the change to
"loop.first".

I think the translation tools don't like Template Toolkit syntax embedded in
HTML except for things like [% image.imagenumber | html %]. 

So even though there's a lot of duplicated HTML in the current template, it's
for reasons. And I think that is the main reason.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2236875992468937018==--


From bugzilla-daemon@bugs.koha-community.org Fri Sep  8 04:12:25 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34724] Remove use of onclick for opac-imageviewer.pl
Date: Fri, 08 Sep 2023 02:12:25 +0000
Message-ID: <bug-34724-70-P8y6kRXYFM@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34724-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1045748714267088721=="

--===============1045748714267088721==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34724

--- Comment #6 from David Cook <dcook@prosentient.com.au> ---
(In reply to Pedro Amorim from comment #4)
> Hi David, I've submitted a follow-up patch.
> Please take a look and SO if you agree, or make obsolete if you don't.

If you want to redo your patch to not include that loop.first change, then I'd
SO it.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1045748714267088721==--


From bugzilla-daemon@bugs.koha-community.org Fri Sep  8 14:19:01 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34724] Remove use of onclick for opac-imageviewer.pl
Date: Fri, 08 Sep 2023 12:18:59 +0000
Message-ID: <bug-34724-70-oHkswOJBLr@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34724-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5685952751866544714=="

--===============5685952751866544714==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D34724

--- Comment #7 from Owen Leonard <oleonard@myacpl.org> ---
(In reply to David Cook from comment #5)

> I think the translation tools don't like Template Toolkit syntax embedded in
> HTML except for things like [% image.imagenumber | html %].=20

Correct:
https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML1:_Template_Toolki=
t_markup_inside_HTML

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============5685952751866544714==--


From bugzilla-daemon@bugs.koha-community.org Fri Sep  8 18:01:19 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34724] Remove use of onclick for opac-imageviewer.pl
Date: Fri, 08 Sep 2023 16:01:19 +0000
Message-ID: <bug-34724-70-fTUIjIjmSi@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34724-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1198933747190809521=="

--===============1198933747190809521==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34724

--- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> ---
Created attachment 155445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155445&action=edit
Bug 34724: (QA follow-up):

Replace href from thumbnail link with a # to keep pointer event. The href link
gets reconstructed by showCover anyway
Remove return false from on click event, its not triggering a location change
anymore because of the above
Remove check for imagenumber, its a non-null primary key, if the image exists,
then the imagenumber must also exist

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1198933747190809521==--


From bugzilla-daemon@bugs.koha-community.org Fri Sep  8 18:01:46 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34724] Remove use of onclick for opac-imageviewer.pl
Date: Fri, 08 Sep 2023 16:01:45 +0000
Message-ID: <bug-34724-70-nC13MI8vxt@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34724-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0850490648754009380=="

--===============0850490648754009380==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34724

--- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> ---
Cool! Thank you both!

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0850490648754009380==--


From bugzilla-daemon@bugs.koha-community.org Mon Sep 11 06:54:13 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34724] Remove use of onclick for opac-imageviewer.pl
Date: Mon, 11 Sep 2023 04:54:12 +0000
Message-ID: <bug-34724-70-ds3yE2RBQK@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34724-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4630940316048188972=="

--===============4630940316048188972==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34724

David Cook <dcook@prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #155445|0                           |1
        is obsolete|                            |

--- Comment #10 from David Cook <dcook@prosentient.com.au> ---
Created attachment 155472
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155472&action=edit
Bug 34724: (QA follow-up):

Replace href from thumbnail link with a # to keep pointer event. The href link
gets reconstructed by showCover anyway
Remove return false from on click event, its not triggering a location change
anymore because of the above
Remove check for imagenumber, its a non-null primary key, if the image exists,
then the imagenumber must also exist

Signed-off-by: David Cook <dcook@prosentient.com.au>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4630940316048188972==--


From bugzilla-daemon@bugs.koha-community.org Mon Sep 11 06:56:57 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34724] Remove use of onclick for opac-imageviewer.pl
Date: Mon, 11 Sep 2023 04:56:56 +0000
Message-ID: <bug-34724-70-oapYjpIDrx@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34724-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3572981556798894869=="

--===============3572981556798894869==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34724

--- Comment #11 from David Cook <dcook@prosentient.com.au> ---
(In reply to Pedro Amorim from comment #9)
> Cool! Thank you both!

Np!

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3572981556798894869==--


From bugzilla-daemon@bugs.koha-community.org Sun Sep 17 16:29:11 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34724] Remove use of onclick for opac-imageviewer.pl
Date: Sun, 17 Sep 2023 14:29:11 +0000
Message-ID: <bug-34724-70-R0tyOGRq1w@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34724-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8557248516163686018=="

--===============8557248516163686018==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34724

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8557248516163686018==--


From bugzilla-daemon@bugs.koha-community.org Sun Sep 17 16:29:22 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34724] Remove use of onclick for opac-imageviewer.pl
Date: Sun, 17 Sep 2023 14:29:13 +0000
Message-ID: <bug-34724-70-ic8sXzGScx@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34724-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4289076531284958627=="

--===============4289076531284958627==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D34724

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #155299|0                           |1
        is obsolete|                            |

--- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Created attachment 155758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D155758&action=
=3Dedit
Bug 34724: Remove inline onclick handler for opac-imageviewer.pl

This patch moves the click handler for thumbnails for opac-imageviewer.pl
out of the inline HTML and out to an existing <script> element.

Test plan:
0. Apply the patch (including dependent patches)
1. Go to
http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=3D&op=3Dsearch&se=
archfield=3Dlocalcover
2. Change both *LocalCoverImages sysprefs to "Show"
3. Go to
http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=3D&op=3Dsearch&se=
archfield=3DAllowMultipleCovers
4. Change "AllowMultipleCovers" to "Allow"
5. Go to
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=3D29
6. Click "Images (0)" tab
7. Download or make two JPEG images
8. Upload the images
9. Go to http://localhost:8080/cgi-bin/koha/opac-imageviewer.pl?biblionumber=
=3D29
10. See one large image in the centre and two smaller thumbnails on the right
side
11. Click on the thumbnail of the image that isn't displayed in the centre
12. Note that the image changes
13. Click the other thumbnail and note that the image changes back

PA amended patch: Added missing test plan step

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============4289076531284958627==--


From bugzilla-daemon@bugs.koha-community.org Sun Sep 17 16:29:32 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34724] Remove use of onclick for opac-imageviewer.pl
Date: Sun, 17 Sep 2023 14:29:16 +0000
Message-ID: <bug-34724-70-CJdI2xnDoz@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34724-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5458457115883928218=="

--===============5458457115883928218==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34724

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #155472|0                           |1
        is obsolete|                            |

--- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Created attachment 155759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155759&action=edit
Bug 34724: (QA follow-up):

Replace href from thumbnail link with a # to keep pointer event. The href link
gets reconstructed by showCover anyway
Remove return false from on click event, its not triggering a location change
anymore because of the above
Remove check for imagenumber, its a non-null primary key, if the image exists,
then the imagenumber must also exist

Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5458457115883928218==--


From bugzilla-daemon@bugs.koha-community.org Mon Sep 18 17:06:29 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34724] Remove use of onclick for opac-imageviewer.pl
Date: Mon, 18 Sep 2023 15:04:20 +0000
Message-ID: <bug-34724-70-D4PVxZELUG@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34724-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3481461881250122244=="

--===============3481461881250122244==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34724

Tomás Cohen Arazi <tomascohen@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |23.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3481461881250122244==--


From bugzilla-daemon@bugs.koha-community.org Mon Sep 18 17:06:39 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34724] Remove use of onclick for opac-imageviewer.pl
Date: Mon, 18 Sep 2023 15:04:22 +0000
Message-ID: <bug-34724-70-wuDvPs6KlN@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34724-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1316706431035564724=="

--===============1316706431035564724==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34724

--- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> ---
Pushed to master for 23.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1316706431035564724==--


From bugzilla-daemon@bugs.koha-community.org Mon Sep 18 22:44:48 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34724] Remove use of onclick for opac-imageviewer.pl
Date: Mon, 18 Sep 2023 20:44:48 +0000
Message-ID: <bug-34724-70-UXs0R5wVBI@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34724-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2116560930207103081=="

--===============2116560930207103081==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34724

Fridolin Somers <fridolin.somers@biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |fridolin.somers@biblibre.co
                   |                            |m
         Version(s)|23.11.00                    |23.11.00,23.05.04
        released in|                            |

--- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> ---
Pushed to 23.05.x for 23.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2116560930207103081==--


From bugzilla-daemon@bugs.koha-community.org Thu Oct 12 18:02:58 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34724] Remove use of onclick for opac-imageviewer.pl
Date: Thu, 12 Oct 2023 16:01:01 +0000
Message-ID: <bug-34724-70-Db89ZWzpOj@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34724-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7117116840998779103=="

--===============7117116840998779103==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34724

Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|23.11.00,23.05.04           |23.11.00,23.05.04,22.11.11
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7117116840998779103==--


From bugzilla-daemon@bugs.koha-community.org Thu Oct 12 18:03:08 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34724] Remove use of onclick for opac-imageviewer.pl
Date: Thu, 12 Oct 2023 16:01:03 +0000
Message-ID: <bug-34724-70-17qJQt1OuN@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34724-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5358584864937300795=="

--===============5358584864937300795==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34724

--- Comment #16 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> ---
Nice work everyone!

Pushed to oldstable for 22.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5358584864937300795==--