From bugzilla-daemon@bugs.koha-community.org Tue May 6 07:19:22 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 12192] New: Template toolkit code in HTML attributes is picked up into po-files Date: Tue, 06 May 2014 05:17:40 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4670969317557718402==" --===============4670969317557718402== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192 Bug ID: 12192 Summary: Template toolkit code in HTML attributes is picked up into po-files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr If TT code is used in title, alt, value, label, etc. attribute, the code is picked up into the po-files as-is, instead of replacing it with a placeholder. For example: x shows up in the po-files as: msgid "Remove facet [% facet.facet_link_value | html %]" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============4670969317557718402==-- From bugzilla-daemon@bugs.koha-community.org Tue May 6 14:24:28 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 12192] Template toolkit code in HTML attributes is picked up into po-files Date: Tue, 06 May 2014 12:22:45 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7018938000175730100==" --===============7018938000175730100== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192 Marc Véron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |veron@veron.ch Resolution|--- |INVALID --- Comment #1 from Marc Véron --- I asked about this bug on the list [koha-translate]: can we translate things like "Remove facet [% facet.facet_link_value | html %]" to something like "My translation [% facet.facet_link_value | html %]" ... and got following answer from bkriegel: "It's the way I plan to traslate myself :) I tested and it translates Ok" Thanks, Bernardo. I change status to RESOLVED INVALID. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============7018938000175730100==-- From bugzilla-daemon@bugs.koha-community.org Tue May 6 17:08:32 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 12192] Template toolkit code in HTML attributes is picked up into po-files Date: Tue, 06 May 2014 15:06:50 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4832446765072652051==" --===============4832446765072652051== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192 --- Comment #2 from paxed --- So the translators need to learn TT code? It really should be replaced with a "%s" placeholder, just like all the rest of the TT code in msgid's -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============4832446765072652051==-- From bugzilla-daemon@bugs.koha-community.org Tue May 6 17:17:07 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 12192] Template toolkit code in HTML attributes is picked up into po-files Date: Tue, 06 May 2014 15:15:25 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3040304626040619102==" --===============3040304626040619102== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192 Marc Véron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============3040304626040619102==-- From bugzilla-daemon@bugs.koha-community.org Tue May 6 17:17:18 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 12192] Template toolkit code in HTML attributes is picked up into po-files Date: Tue, 06 May 2014 15:15:36 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8999087147918829259==" --===============8999087147918829259== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192 Marc Véron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============8999087147918829259==-- From bugzilla-daemon@bugs.koha-community.org Tue May 6 18:03:39 2014 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 12192] Template toolkit code in HTML attributes is picked up into po-files Date: Tue, 06 May 2014 16:01:52 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1017011118279942192==" --===============1017011118279942192== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #3 from Bernardo Gonzalez Kriegel --- I don't tell that this is not a bug, It need to be fixed somehow, I only answered what we can do for now. Status NEW is ok in this case -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============1017011118279942192==-- From bugzilla-daemon@bugs.koha-community.org Tue Apr 28 23:44:08 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 12192] Template toolkit code in HTML attributes is picked up into po-files Date: Tue, 28 Apr 2015 21:44:05 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1508795197062919118==" --===============1508795197062919118== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192 --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 38618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38618&action=edit Bug 12192: Template toolkit code in HTML attributes is picked up into po-files This patch gives a partial solution for this problem. It ignores strings like "[% something %]", but not "[% IF ( value ) %][% value %][% END %]" We get 100+ strings less to translate To test: 1) Update translation files for your preferred language 2) Apply the patch 3) Update again 4) Compare, you must find 100+ strings removed from translation files eg. -msgid "[% SEARCH_RESULT.biblionumber |url %]" -msgid "[% accepteddate | $KohaDates %]" -msgid "[% amountoutstanding | format('%.2f') %]" -msgid "[% authtypetext |html %]" -msgid "[% barcode_llx |html %]" -msgid "[% barcode_lly |html %]" -msgid "[% biblio.quantity.length ? biblio.quantity : 1 %]" -msgid "[% billingdate | $KohaDates %]" -msgid "[% borname |html %]" ... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============1508795197062919118==-- From bugzilla-daemon@bugs.koha-community.org Tue Apr 28 23:45:45 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 12192] Template toolkit code in HTML attributes is picked up into po-files Date: Tue, 28 Apr 2015 21:45:42 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3421877534634824665==" --===============3421877534634824665== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Severity|enhancement |minor Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============3421877534634824665==-- From bugzilla-daemon@bugs.koha-community.org Wed Apr 29 10:53:28 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 12192] Template toolkit code in HTML attributes is picked up into po-files Date: Wed, 29 Apr 2015 08:53:26 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6807342344406020135==" --===============6807342344406020135== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============6807342344406020135==-- From bugzilla-daemon@bugs.koha-community.org Wed Apr 29 10:53:32 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 12192] Template toolkit code in HTML attributes is picked up into po-files Date: Wed, 29 Apr 2015 08:53:28 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6954500745384502792==" --===============6954500745384502792== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38618|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 38646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38646&action=edit Bug 12192: Template toolkit code in HTML attributes is picked up into po-files This patch gives a partial solution for this problem. It ignores strings like "[% something %]", but not "[% IF ( value ) %][% value %][% END %]" We get 100+ strings less to translate To test: 1) Update translation files for your preferred language 2) Apply the patch 3) Update again 4) Compare, you must find 100+ strings removed from translation files eg. -msgid "[% SEARCH_RESULT.biblionumber |url %]" -msgid "[% accepteddate | $KohaDates %]" -msgid "[% amountoutstanding | format('%.2f') %]" -msgid "[% authtypetext |html %]" -msgid "[% barcode_llx |html %]" -msgid "[% barcode_lly |html %]" -msgid "[% biblio.quantity.length ? biblio.quantity : 1 %]" -msgid "[% billingdate | $KohaDates %]" -msgid "[% borname |html %]" ... Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. --===============6954500745384502792==-- From bugzilla-daemon@bugs.koha-community.org Thu Apr 30 08:09:50 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 12192] Template toolkit code in HTML attributes is picked up into po-files Date: Thu, 30 Apr 2015 06:09:47 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7285609166112334461==" --===============7285609166112334461== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============7285609166112334461==-- From bugzilla-daemon@bugs.koha-community.org Thu Apr 30 08:09:53 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 12192] Template toolkit code in HTML attributes is picked up into po-files Date: Thu, 30 Apr 2015 06:09:49 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0473580844831385546==" --===============0473580844831385546== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38646|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 38713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38713&action=edit Bug 12192: Template toolkit code in HTML attributes is picked up into po-files This patch gives a partial solution for this problem. It ignores strings like "[% something %]", but not "[% IF ( value ) %][% value %][% END %]" We get 100+ strings less to translate To test: 1) Update translation files for your preferred language 2) Apply the patch 3) Update again 4) Compare, you must find 100+ strings removed from translation files eg. -msgid "[% SEARCH_RESULT.biblionumber |url %]" -msgid "[% accepteddate | $KohaDates %]" -msgid "[% amountoutstanding | format('%.2f') %]" -msgid "[% authtypetext |html %]" -msgid "[% barcode_llx |html %]" -msgid "[% barcode_lly |html %]" -msgid "[% biblio.quantity.length ? biblio.quantity : 1 %]" -msgid "[% billingdate | $KohaDates %]" -msgid "[% borname |html %]" ... Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Verified all strings removed from the po files were pure TT. -- You are receiving this mail because: You are watching all bug changes. --===============0473580844831385546==-- From bugzilla-daemon@bugs.koha-community.org Wed May 6 15:45:57 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 12192] Template toolkit code in HTML attributes is picked up into po-files Date: Wed, 06 May 2015 13:45:55 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0955555170812686802==" --===============0955555170812686802== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tomás Cohen Arazi --- Great improvement Bernardo. Thanks! Pushed to master. -- You are receiving this mail because: You are watching all bug changes. --===============0955555170812686802==-- From bugzilla-daemon@bugs.koha-community.org Sun May 17 07:53:52 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 12192] Template toolkit code in HTML attributes is picked up into po-files Date: Sun, 17 May 2015 05:53:49 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7186004261113058289==" --===============7186004261113058289== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. --===============7186004261113058289==--