From bugzilla-daemon@bugs.koha-community.org Fri Mar 21 14:52:54 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] New: Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Fri, 21 Mar 2025 13:52:53 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3014693971359086214==" --===============3014693971359086214== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D39408 Bug ID: 39408 Summary: Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Some libraries use Template Toolkit logic to avoid sending emails. In the case of the welcome notice they may only want to send for patrons fully added, not self registered. In the case of Aspen, we currently use the patrons API for self registration = as there is not a self registration API. If you add logic like: [% USE Koha %] [% IF borrower.categorycode !=3D 'SELFREG' %] Hello [% borrower.title %] [% borrower.firstname %] [% borrower.surname %].
Thank you for joining [% IF Koha.Preference('LibraryName') %][% Koha.Preference('LibraryName') %][% ELSE %]the library[% END %]

You can search for all our materials in our catalog.

Your library card number is [% borrower.cardnumber %]

If you have any problems or questions regarding your account, please contact the library. [% END %] Then add a patron via the API in the self reg class: {"surname":"PATRON","firstname":"PROBLEM","library_id":"CPL","category_id":"S= ELFREG","email":"eample@example.org"} You get an error response: "Given does not exist" --=20 You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============3014693971359086214==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 21 15:00:25 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Fri, 21 Mar 2025 14:00:16 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3453467974291986261==" --===============3453467974291986261== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39408 Nick Clemens (kidclamp) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============3453467974291986261==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 21 15:00:35 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Fri, 21 Mar 2025 14:00:18 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0890018568370094525==" --===============0890018568370094525== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D39408 --- Comment #1 from Nick Clemens (kidclamp) --- Created attachment 179613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D179613&action= =3Dedit Bug 39408: Handle BadParameter exception better Currently we assume BadParameter has been thrown with a parameter that is a valid patron field. It may only include a message, or it may have come from outside the patron object, we should handle all cases. To test: 1 - Wrap "WELCOME" notice content in conditional: [% IF borrower.categorycode !=3D 'SELFREG' %] ... [% END %] 2 - Enable preference AutoEmailNewUser 3 - Attempt to self register a patron via API with body: =20 {"surname":"PATRON","firstname":"PROBLEM","library_id":"CPL","category_id":"S= ELFREG","email":"eample@example.org"} 4 - Response error: "Given does not exist" 5 - Apply this patch, restart all 6 - Repeat 3 7 - Response error: "Exception 'Koha::Exceptions::BadParameter' thrown 'Parameter message_id cannot be empty if passed.'\n" 8 - It's uglier, but actually helpful --=20 You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============0890018568370094525==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 21 15:00:45 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Fri, 21 Mar 2025 14:00:20 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4246970346038815219==" --===============4246970346038815219== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39408 --- Comment #2 from Nick Clemens (kidclamp) --- Created attachment 179614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179614&action=edit Bug 39408: Don't attempt to send a message if one is not generated The routine to create the message can return nothing if there is no content, we should handle this case and not attempt to send. To test: 1 - Test plan from last patch 2 - Apply this patch 3 - POST to patron API again 4 - Success! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============4246970346038815219==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 21 15:00:55 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Fri, 21 Mar 2025 14:00:30 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3859620268456305579==" --===============3859620268456305579== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39408 Nick Clemens (kidclamp) changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============3859620268456305579==-- From bugzilla-daemon@bugs.koha-community.org Tue Apr 1 14:28:22 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Tue, 01 Apr 2025 12:28:21 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8072971916633447557==" --===============8072971916633447557== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39408 claire.hernandez@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. --===============8072971916633447557==-- From bugzilla-daemon@bugs.koha-community.org Wed Apr 2 10:37:18 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Wed, 02 Apr 2025 08:37:09 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6120332953734160563==" --===============6120332953734160563== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D39408 claire.hernandez@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179613|0 |1 is obsolete| | --- Comment #3 from claire.hernandez@biblibre.com --- Created attachment 180255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D180255&action= =3Dedit Bug 39408: Handle BadParameter exception better Currently we assume BadParameter has been thrown with a parameter that is a valid patron field. It may only include a message, or it may have come from outside the patron object, we should handle all cases. To test: 1 - Wrap "WELCOME" notice content in conditional: [% IF borrower.categorycode !=3D 'SELFREG' %] ... [% END %] 2 - Enable preference AutoEmailNewUser 3 - Attempt to self register a patron via API with body: =20 {"surname":"PATRON","firstname":"PROBLEM","library_id":"CPL","category_id":"S= ELFREG","email":"eample@example.org"} 4 - Response error: "Given does not exist" 5 - Apply this patch, restart all 6 - Repeat 3 7 - Response error: "Exception 'Koha::Exceptions::BadParameter' thrown 'Parameter message_id cannot be empty if passed.'\n" 8 - It's uglier, but actually helpful Signed-off-by: Claire Hernandez --=20 You are receiving this mail because: You are watching all bug changes. --===============6120332953734160563==-- From bugzilla-daemon@bugs.koha-community.org Wed Apr 2 10:37:28 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Wed, 02 Apr 2025 08:37:12 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4386434728524383542==" --===============4386434728524383542== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D39408 claire.hernandez@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179614|0 |1 is obsolete| | --- Comment #4 from claire.hernandez@biblibre.com --- Created attachment 180256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D180256&action= =3Dedit Bug 39408: Don't attempt to send a message if one is not generated The routine to create the message can return nothing if there is no content, we should handle this case and not attempt to send. To test: 1 - Test plan from last patch 2 - Apply this patch 3 - POST to patron API again 4 - Success! Signed-off-by: Claire Hernandez --=20 You are receiving this mail because: You are watching all bug changes. --===============4386434728524383542==-- From bugzilla-daemon@bugs.koha-community.org Wed Apr 2 10:37:48 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Wed, 02 Apr 2025 08:37:32 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0180931883958397335==" --===============0180931883958397335== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39408 claire.hernandez@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============0180931883958397335==-- From bugzilla-daemon@bugs.koha-community.org Fri May 9 14:27:24 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Fri, 09 May 2025 12:27:22 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1832411537751406005==" --===============1832411537751406005== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D39408 Martin Renvoize (ashimema) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180255|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize (ashimema) --- Created attachment 182165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D182165&action= =3Dedit Bug 39408: Handle BadParameter exception better Currently we assume BadParameter has been thrown with a parameter that is a valid patron field. It may only include a message, or it may have come from outside the patron object, we should handle all cases. To test: 1 - Wrap "WELCOME" notice content in conditional: [% IF borrower.categorycode !=3D 'SELFREG' %] ... [% END %] 2 - Enable preference AutoEmailNewUser 3 - Attempt to self register a patron via API with body: =20 {"surname":"PATRON","firstname":"PROBLEM","library_id":"CPL","category_id":"S= ELFREG","email":"eample@example.org"} 4 - Response error: "Given does not exist" 5 - Apply this patch, restart all 6 - Repeat 3 7 - Response error: "Exception 'Koha::Exceptions::BadParameter' thrown 'Parameter message_id cannot be empty if passed.'\n" 8 - It's uglier, but actually helpful Signed-off-by: Claire Hernandez Signed-off-by: Martin Renvoize --=20 You are receiving this mail because: You are watching all bug changes. --===============1832411537751406005==-- From bugzilla-daemon@bugs.koha-community.org Fri May 9 14:27:34 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Fri, 09 May 2025 12:27:25 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3917970164401279474==" --===============3917970164401279474== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D39408 Martin Renvoize (ashimema) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180256|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize (ashimema) --- Created attachment 182166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D182166&action= =3Dedit Bug 39408: Don't attempt to send a message if one is not generated The routine to create the message can return nothing if there is no content, we should handle this case and not attempt to send. To test: 1 - Test plan from last patch 2 - Apply this patch 3 - POST to patron API again 4 - Success! Signed-off-by: Claire Hernandez Signed-off-by: Martin Renvoize --=20 You are receiving this mail because: You are watching all bug changes. --===============3917970164401279474==-- From bugzilla-daemon@bugs.koha-community.org Fri May 9 14:27:44 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Fri, 09 May 2025 12:27:27 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5993761697525285727==" --===============5993761697525285727== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D39408 --- Comment #7 from Martin Renvoize (ashimema) --- Created attachment 182167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D182167&action= =3Dedit Bug 39408: (QA follow-up) Add unit tests Signed-off-by: Martin Renvoize --=20 You are receiving this mail because: You are watching all bug changes. --===============5993761697525285727==-- From bugzilla-daemon@bugs.koha-community.org Fri May 9 14:27:54 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Fri, 09 May 2025 12:27:42 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7394114873567297643==" --===============7394114873567297643== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39408 Martin Renvoize (ashimema) changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk CC| |martin.renvoize@openfifth.c | |o.uk Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============7394114873567297643==-- From bugzilla-daemon@bugs.koha-community.org Mon May 12 18:16:02 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Mon, 12 May 2025 16:16:01 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3407441162560705248==" --===============3407441162560705248== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D39408 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #8 from Katrin Fischer --- I applied the patches and ran yarn build. But: FAIL Koha/REST/V1/Patrons.pm FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl Koha/REST/V1/Patrons.pm` FAIL t/db_dependent/api/v1/patrons.t FAIL critic # Subroutines::ProhibitExplicitReturnUndef: Got 1 violation(s= ).=20 Please also double check the tests, I had some trouble there that only went away after a reset_all. --=20 You are receiving this mail because: You are watching all bug changes. --===============3407441162560705248==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 13 10:39:03 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Mon, 13 Oct 2025 08:39:02 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8327913641582214834==" --===============8327913641582214834== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D39408 Martin Renvoize (ashimema) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182165|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize (ashimema) --- Created attachment 187798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D187798&action= =3Dedit Bug 39408: Handle BadParameter exception better Currently we assume BadParameter has been thrown with a parameter that is a valid patron field. It may only include a message, or it may have come from outside the patron object, we should handle all cases. To test: 1 - Wrap "WELCOME" notice content in conditional: [% IF borrower.categorycode !=3D 'SELFREG' %] ... [% END %] 2 - Enable preference AutoEmailNewUser 3 - Attempt to self register a patron via API with body: =20 {"surname":"PATRON","firstname":"PROBLEM","library_id":"CPL","category_id":"S= ELFREG","email":"eample@example.org"} 4 - Response error: "Given does not exist" 5 - Apply this patch, restart all 6 - Repeat 3 7 - Response error: "Exception 'Koha::Exceptions::BadParameter' thrown 'Parameter message_id cannot be empty if passed.'\n" 8 - It's uglier, but actually helpful Signed-off-by: Claire Hernandez Signed-off-by: Martin Renvoize --=20 You are receiving this mail because: You are watching all bug changes. --===============8327913641582214834==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 13 10:39:13 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Mon, 13 Oct 2025 08:39:04 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4915262826802380859==" --===============4915262826802380859== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D39408 Martin Renvoize (ashimema) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182166|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize (ashimema) --- Created attachment 187799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D187799&action= =3Dedit Bug 39408: Don't attempt to send a message if one is not generated The routine to create the message can return nothing if there is no content, we should handle this case and not attempt to send. To test: 1 - Test plan from last patch 2 - Apply this patch 3 - POST to patron API again 4 - Success! Signed-off-by: Claire Hernandez Signed-off-by: Martin Renvoize --=20 You are receiving this mail because: You are watching all bug changes. --===============4915262826802380859==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 13 10:39:24 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Mon, 13 Oct 2025 08:39:07 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6579323741154853510==" --===============6579323741154853510== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D39408 Martin Renvoize (ashimema) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182167|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize (ashimema) --- Created attachment 187800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D187800&action= =3Dedit Bug 39408: (QA follow-up) Add unit tests Signed-off-by: Martin Renvoize --=20 You are receiving this mail because: You are watching all bug changes. --===============6579323741154853510==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 13 10:44:05 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Mon, 13 Oct 2025 08:43:55 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3685328450487874885==" --===============3685328450487874885== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39408 Martin Renvoize (ashimema) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============3685328450487874885==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 13 10:46:19 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Mon, 13 Oct 2025 08:45:00 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2243496320400012801==" --===============2243496320400012801== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39408 Martin Renvoize (ashimema) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. --===============2243496320400012801==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 13 12:36:18 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Mon, 13 Oct 2025 10:36:17 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3401586663203447991==" --===============3401586663203447991== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D39408 Martin Renvoize (ashimema) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187798|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize (ashimema) --- Created attachment 187827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D187827&action= =3Dedit Bug 39408: Handle BadParameter exception better Currently we assume BadParameter has been thrown with a parameter that is a valid patron field. It may only include a message, or it may have come from outside the patron object, we should handle all cases. To test: 1 - Wrap "WELCOME" notice content in conditional: [% IF borrower.categorycode !=3D 'SELFREG' %] ... [% END %] 2 - Enable preference AutoEmailNewUser 3 - Attempt to self register a patron via API with body: =20 {"surname":"PATRON","firstname":"PROBLEM","library_id":"CPL","category_id":"S= ELFREG","email":"eample@example.org"} 4 - Response error: "Given does not exist" 5 - Apply this patch, restart all 6 - Repeat 3 7 - Response error: "Exception 'Koha::Exceptions::BadParameter' thrown 'Parameter message_id cannot be empty if passed.'\n" 8 - It's uglier, but actually helpful Signed-off-by: Claire Hernandez Signed-off-by: Martin Renvoize --=20 You are receiving this mail because: You are watching all bug changes. --===============3401586663203447991==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 13 12:36:28 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Mon, 13 Oct 2025 10:36:19 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8519268194581567373==" --===============8519268194581567373== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D39408 Martin Renvoize (ashimema) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187799|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize (ashimema) --- Created attachment 187828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D187828&action= =3Dedit Bug 39408: Don't attempt to send a message if one is not generated The routine to create the message can return nothing if there is no content, we should handle this case and not attempt to send. To test: 1 - Test plan from last patch 2 - Apply this patch 3 - POST to patron API again 4 - Success! Signed-off-by: Claire Hernandez Signed-off-by: Martin Renvoize --=20 You are receiving this mail because: You are watching all bug changes. --===============8519268194581567373==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 13 12:36:38 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Mon, 13 Oct 2025 10:36:21 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8966495066367634137==" --===============8966495066367634137== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D39408 Martin Renvoize (ashimema) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187800|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize (ashimema) --- Created attachment 187829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D187829&action= =3Dedit Bug 39408: (QA follow-up) Add unit tests Signed-off-by: Martin Renvoize --=20 You are receiving this mail because: You are watching all bug changes. --===============8966495066367634137==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 13 12:36:49 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Mon, 13 Oct 2025 10:36:34 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2757592595376198834==" --===============2757592595376198834== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39408 Martin Renvoize (ashimema) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============2757592595376198834==-- From bugzilla-daemon@bugs.koha-community.org Tue Oct 14 22:30:38 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Tue, 14 Oct 2025 20:30:37 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5921567474268859468==" --===============5921567474268859468== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39408 Lucas Gass (lukeg) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. --===============5921567474268859468==-- From bugzilla-daemon@bugs.koha-community.org Tue Oct 14 22:56:58 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Tue, 14 Oct 2025 20:56:30 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6377639832224564842==" --===============6377639832224564842== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39408 Lucas Gass (lukeg) changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. --===============6377639832224564842==-- From bugzilla-daemon@bugs.koha-community.org Tue Oct 14 22:57:08 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Tue, 14 Oct 2025 20:56:37 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2138323434859476345==" --===============2138323434859476345== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39408 --- Comment #15 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. --===============2138323434859476345==-- From bugzilla-daemon@bugs.koha-community.org Wed Oct 29 10:10:17 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Wed, 29 Oct 2025 09:09:41 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6368452314344246100==" --===============6368452314344246100== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39408 Paul Derscheid changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. --===============6368452314344246100==-- From bugzilla-daemon@bugs.koha-community.org Wed Oct 29 10:10:27 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Wed, 29 Oct 2025 09:09:42 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2399487970025364161==" --===============2399487970025364161== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39408 --- Comment #16 from Paul Derscheid --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes. --===============2399487970025364161==-- From bugzilla-daemon@bugs.koha-community.org Mon Nov 10 15:30:48 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Mon, 10 Nov 2025 14:30:47 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8862391889568375722==" --===============8862391889568375722== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39408 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00,25.05.05 |25.11.00,25.05.05,24.1.11 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #17 from Fridolin Somers --- Pushed to 24.11.x for 24.11.11 -- You are receiving this mail because: You are watching all bug changes. --===============8862391889568375722==-- From bugzilla-daemon@bugs.koha-community.org Wed Nov 26 11:03:36 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Wed, 26 Nov 2025 10:03:35 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5928536832898714032==" --===============5928536832898714032== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39408 Marion Durand changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marion.durand@biblibre.com Version(s)|25.11.00,25.05.05,24.1.11 |25.11.00,25.05.05,24.11.11 released in| | -- You are receiving this mail because: You are watching all bug changes. --===============5928536832898714032==-- From bugzilla-daemon@bugs.koha-community.org Fri Feb 27 01:42:01 2026 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 39408] Cannot add patron via API if AutoEmailNewUser and WELCOME content blank Date: Fri, 27 Feb 2026 00:11:05 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8385697000464369626==" --===============8385697000464369626== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39408 Wainui Witika-Park changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #18 from Wainui Witika-Park --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes. --===============8385697000464369626==--