From bugzilla-daemon@bugs.koha-community.org Mon Mar 1 17:12:17 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 27824] New: Report batch operations break with space in placeholder Date: Mon, 01 Mar 2021 16:12:16 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4048068252844824396==" --===============4048068252844824396== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D27824 Bug ID: 27824 Summary: Report batch operations break with space in placeholder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 23390 I found this bug while testing Bug 5697: Using the system for defining a column name placeholder (Bug 23390), if there is a space inside the column name placeholder it won't work. The SQL example = in Bug 5697: SELECT=20 i.itemnumber, i.itemnumber as Exemplarnummber, [[i.itemnumber| itemnumber for batch]], CONCAT('', i.itemnum= ber, '' ) AS "itemnumber as edit link" FROM items i "[[i.itemnumber| itemnumber for batch]]" has a space before "itemnumber for batch." With that space removed it works as expected. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D23390 [Bug 23390] Add placeholder syntax for column names --=20 You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============4048068252844824396==-- From bugzilla-daemon@bugs.koha-community.org Tue Mar 2 15:09:03 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 27824] Report batch operations break with space in placeholder Date: Tue, 02 Mar 2021 14:09:02 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2648339846673414927==" --===============2648339846673414927== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D27824 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart = --- What does not work exactly? I copy/pasted the query to create a new SQL report, I run it and see the table result with the 4 headers: itemnumber, Exemplarnummber, itemnumber for batch, itemnumber as edit link --=20 You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============2648339846673414927==-- From bugzilla-daemon@bugs.koha-community.org Sat Jul 1 19:34:25 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 27824] Report batch operations break with space in placeholder Date: Sat, 01 Jul 2023 17:34:24 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4251955431615360250==" --===============4251955431615360250== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D27824 --- Comment #2 from Katrin Fischer --- (In reply to Jonathan Druart from comment #1) > What does not work exactly? > I copy/pasted the query to create a new SQL report, I run it and see the > table result with the 4 headers: itemnumber, Exemplarnummber, itemnumber for > batch, itemnumber as edit link The third column should look like the first - linked to actions. But it doesn= 't work. --=20 You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============4251955431615360250==-- From bugzilla-daemon@bugs.koha-community.org Wed Jul 5 15:45:35 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 27824] Report batch operations break with space in placeholder Date: Wed, 05 Jul 2023 13:45:34 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6833289428184780878==" --===============6833289428184780878== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27824 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============6833289428184780878==-- From bugzilla-daemon@bugs.koha-community.org Wed Jul 5 15:45:45 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 27824] Report batch operations break with space in placeholder Date: Wed, 05 Jul 2023 13:45:36 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8950417103566458941==" --===============8950417103566458941== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27824 --- Comment #3 from Jonathan Druart --- Created attachment 153059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153059&action=edit Bug 27824: Add a test -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============8950417103566458941==-- From bugzilla-daemon@bugs.koha-community.org Wed Jul 5 15:45:55 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 27824] Report batch operations break with space in placeholder Date: Wed, 05 Jul 2023 13:45:39 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3861940617562127060==" --===============3861940617562127060== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D27824 --- Comment #4 from Jonathan Druart --- Created attachment 153060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D153060&action= =3Dedit Bug 27824: Trim column headers To support additional spaces. Using the system for defining a column name placeholder (Bug 23390), if there is a space inside the column name placeholder it won't work. The SQL example = in Bug 5697: SELECT i.itemnumber, i.itemnumber as Exemplarnummber, [[i.itemnumber| itemnumber for batch]], CONCAT('', i.itemnum= ber, '' ) AS "itemnumber as edit link" FROM items i "[[i.itemnumber| itemnumber for batch]]" has a space before "itemnumber for batch." With that space removed it works as expected. --=20 You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============3861940617562127060==-- From bugzilla-daemon@bugs.koha-community.org Wed Jul 5 17:49:26 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 27824] Report batch operations break with space in placeholder Date: Wed, 05 Jul 2023 15:49:25 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8309091092925066565==" --===============8309091092925066565== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27824 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============8309091092925066565==-- From bugzilla-daemon@bugs.koha-community.org Wed Jul 5 17:49:36 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 27824] Report batch operations break with space in placeholder Date: Wed, 05 Jul 2023 15:49:27 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1131001399955830068==" --===============1131001399955830068== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27824 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153059|0 |1 is obsolete| | Attachment #153060|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 153064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153064&action=edit Bug 27824: Add a test Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============1131001399955830068==-- From bugzilla-daemon@bugs.koha-community.org Wed Jul 5 17:49:46 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 27824] Report batch operations break with space in placeholder Date: Wed, 05 Jul 2023 15:49:29 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0991581603304299141==" --===============0991581603304299141== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27824 --- Comment #6 from Owen Leonard --- Created attachment 153065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153065&action=edit Bug 27824: Trim column headers To support additional spaces. Using the system for defining a column name placeholder (Bug 23390), if there is a space inside the column name placeholder it won't work. The SQL example in Bug 5697: SELECT i.itemnumber, i.itemnumber as Exemplarnummber, [[i.itemnumber| itemnumber for batch]], CONCAT('', i.itemnumber, '' ) AS "itemnumber as edit link" FROM items i "[[i.itemnumber| itemnumber for batch]]" has a space before "itemnumber for batch." With that space removed it works as expected. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============0991581603304299141==-- From bugzilla-daemon@bugs.koha-community.org Wed Jul 5 17:55:53 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 27824] Report batch operations break with space in placeholder Date: Wed, 05 Jul 2023 15:55:52 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6905183206059752192==" --===============6905183206059752192== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27824 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============6905183206059752192==-- From bugzilla-daemon@bugs.koha-community.org Sun Jul 9 16:13:40 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 27824] Report batch operations break with space in placeholder Date: Sun, 09 Jul 2023 14:13:39 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8489824628017094242==" --===============8489824628017094242== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27824 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. --===============8489824628017094242==-- From bugzilla-daemon@bugs.koha-community.org Sun Jul 9 16:15:09 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 27824] Report batch operations break with space in placeholder Date: Sun, 09 Jul 2023 14:15:09 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1797365360120098624==" --===============1797365360120098624== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27824 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============1797365360120098624==-- From bugzilla-daemon@bugs.koha-community.org Sun Jul 9 16:15:20 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 27824] Report batch operations break with space in placeholder Date: Sun, 09 Jul 2023 14:15:11 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8335597827746683188==" --===============8335597827746683188== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27824 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153064|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 153220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153220&action=edit Bug 27824: Add a test Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. --===============8335597827746683188==-- From bugzilla-daemon@bugs.koha-community.org Sun Jul 9 16:15:31 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 27824] Report batch operations break with space in placeholder Date: Sun, 09 Jul 2023 14:15:14 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1029437122271977860==" --===============1029437122271977860== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27824 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153065|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 153221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153221&action=edit Bug 27824: Trim column headers To support additional spaces. Using the system for defining a column name placeholder (Bug 23390), if there is a space inside the column name placeholder it won't work. The SQL example in Bug 5697: SELECT i.itemnumber, i.itemnumber as Exemplarnummber, [[i.itemnumber| itemnumber for batch]], CONCAT('', i.itemnumber, '' ) AS "itemnumber as edit link" FROM items i "[[i.itemnumber| itemnumber for batch]]" has a space before "itemnumber for batch." With that space removed it works as expected. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. --===============1029437122271977860==-- From bugzilla-daemon@bugs.koha-community.org Thu Jul 13 20:21:15 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 27824] Report batch operations break with space in placeholder Date: Thu, 13 Jul 2023 18:21:14 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4343122112258290932==" --===============4343122112258290932== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27824 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. --===============4343122112258290932==-- From bugzilla-daemon@bugs.koha-community.org Thu Jul 13 20:21:25 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 27824] Report batch operations break with space in placeholder Date: Thu, 13 Jul 2023 18:21:17 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3824396876095412377==" --===============3824396876095412377== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27824 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. --===============3824396876095412377==-- From bugzilla-daemon@bugs.koha-community.org Tue Jul 18 13:51:53 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 27824] Report batch operations break with space in placeholder Date: Tue, 18 Jul 2023 11:51:52 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2345337635770523167==" --===============2345337635770523167== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27824 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.02 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. --===============2345337635770523167==-- From bugzilla-daemon@bugs.koha-community.org Tue Jul 18 13:52:03 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 27824] Report batch operations break with space in placeholder Date: Tue, 18 Jul 2023 11:51:53 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3182610545211371204==" --===============3182610545211371204== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27824 --- Comment #10 from Martin Renvoize --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes. --===============3182610545211371204==-- From bugzilla-daemon@bugs.koha-community.org Tue Jul 18 16:23:37 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 27824] Report batch operations break with space in placeholder Date: Tue, 18 Jul 2023 14:23:36 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4144935420622119452==" --===============4144935420622119452== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27824 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | -- You are receiving this mail because: You are watching all bug changes. --===============4144935420622119452==-- From bugzilla-daemon@bugs.koha-community.org Tue Jul 18 16:23:47 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 27824] Report batch operations break with space in placeholder Date: Tue, 18 Jul 2023 14:23:38 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1276363942846708606==" --===============1276363942846708606== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27824 --- Comment #11 from Matt Blenkinsop --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. --===============1276363942846708606==--