From bugzilla-daemon@bugs.koha-community.org Fri Apr 2 20:20:41 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28080] New: Add system preference that allows users to insert HTML in the on all OPAC pages Date: Fri, 02 Apr 2021 18:20:41 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0222983540099837432==" --===============0222983540099837432== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D28080 Bug ID: 28080 Summary: Add system preference that allows users to insert HTML in the on all OPAC pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org It would be nice if there was a system preference to allow librarinans to insert HTML into the document . Currently there is no way to add custom scripts or meta content, links to Google fonts, etc.=20 Many already insert this in the OPACHeader but since that has moved to the Ne= ws Tool it is less than ideal to do it this way. ( see bug 26942 ) --=20 You are receiving this mail because: You are watching all bug changes. --===============0222983540099837432==-- From bugzilla-daemon@bugs.koha-community.org Fri Apr 2 20:26:04 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28080] Add system preference that allows users to insert HTML in the on all OPAC pages Date: Fri, 02 Apr 2021 18:26:04 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3889038528259630176==" --===============3889038528259630176== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============3889038528259630176==-- From bugzilla-daemon@bugs.koha-community.org Fri Apr 2 20:26:14 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28080] Add system preference that allows users to insert HTML in the on all OPAC pages Date: Fri, 02 Apr 2021 18:26:06 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7767532635085535374==" --===============7767532635085535374== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 --- Comment #1 from Lucas Gass --- Created attachment 119142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119142&action=edit Bug 28080: Add OPACHTMLHead system preference To test: -Apply patch -Look for the syspref OPACHTMLHead -If you insert HTML it should be present inside the on all pages in the OPAC -An easy way to test is to add something like this: -All OPAC pages should then have a red background -- You are receiving this mail because: You are watching all bug changes. --===============7767532635085535374==-- From bugzilla-daemon@bugs.koha-community.org Fri Apr 2 20:26:38 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28080] Add system preference that allows users to insert HTML in the on all OPAC pages Date: Fri, 02 Apr 2021 18:26:37 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6900431386984097232==" --===============6900431386984097232== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. --===============6900431386984097232==-- From bugzilla-daemon@bugs.koha-community.org Mon Apr 5 00:12:00 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28080] Add system preference that allows users to insert HTML in the on all OPAC pages Date: Sun, 04 Apr 2021 22:11:58 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0614811020271940478==" --===============0614811020271940478== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============0614811020271940478==-- From bugzilla-daemon@bugs.koha-community.org Mon Apr 5 00:12:10 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28080] Add system preference that allows users to insert HTML in the on all OPAC pages Date: Sun, 04 Apr 2021 22:12:02 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5579817042739163522==" --===============5579817042739163522== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119142|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 119171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119171&action=edit Bug 28080: Add OPACHTMLHead system preference To test: -Apply patch -Look for the syspref OPACHTMLHead -If you insert HTML it should be present inside the on all pages in the OPAC -An easy way to test is to add something like this: -All OPAC pages should then have a red background Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. --===============5579817042739163522==-- From bugzilla-daemon@bugs.koha-community.org Tue Apr 6 03:05:10 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28080] Add system preference that allows users to insert HTML in the on all OPAC pages Date: Tue, 06 Apr 2021 01:05:09 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0525018796861771691==" --===============0525018796861771691== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. --===============0525018796861771691==-- From bugzilla-daemon@bugs.koha-community.org Wed May 5 05:53:56 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28080] Add system preference that allows users to insert HTML in the on all OPAC pages Date: Wed, 05 May 2021 03:53:54 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0991060725848928468==" --===============0991060725848928468== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 --- Comment #3 from David Cook --- Commenting in an attempt to remind myself to QA this as it would be very useful. -- You are receiving this mail because: You are watching all bug changes. --===============0991060725848928468==-- From bugzilla-daemon@bugs.koha-community.org Mon May 10 16:47:30 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28080] Add system preference that allows users to insert HTML in the on all OPAC pages Date: Mon, 10 May 2021 14:47:29 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6300133348575885882==" --===============6300133348575885882== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. --===============6300133348575885882==-- From bugzilla-daemon@bugs.koha-community.org Fri Jul 9 11:08:41 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28080] Add system preference that allows users to insert HTML in the on all OPAC pages Date: Fri, 09 Jul 2021 09:08:40 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1972464788398487868==" --===============1972464788398487868== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |In Discussion --- Comment #4 from Marcel de Rooy --- (In reply to Lucas Gass from comment #0) > It would be nice if there was a system preference to allow librarinans to > insert HTML into the document . Currently there is no way to add > custom scripts or meta content, links to Google fonts, etc. > > Many already insert this in the OPACHeader but since that has moved to the > News Tool it is less than ideal to do it this way. ( see bug 26942 ) We now have this already: KohaPlugins.get_plugins_opac_head And: [% KohaPlugins.get_plugins_opac_js %] And: [% KohaPlugins.get_plugins_intranet_head %] So it is a discussion item whether we really should have this too. We miss an intranet counterpart here, that the plugins offer. And maybe the location of adding the pref content in doc-head-close is questionable? Should we add it at the end, if we would decide so? Could you raise this on koha-devel ? -- You are receiving this mail because: You are watching all bug changes. --===============1972464788398487868==-- From bugzilla-daemon@bugs.koha-community.org Fri Jul 9 16:14:19 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28080] Add system preference that allows users to insert HTML in the on all OPAC pages Date: Fri, 09 Jul 2021 14:14:18 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7964492693164527169==" --===============7964492693164527169== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D28080 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall --- > We now have this already: > KohaPlugins.get_plugins_opac_head > And: [% KohaPlugins.get_plugins_opac_js %] > And: [% KohaPlugins.get_plugins_intranet_head %] >=20 > So it is a discussion item whether we really should have this too. > We miss an intranet counterpart here, that the plugins offer. > And maybe the location of adding the pref content in doc-head-close is > questionable? Should we add it at the end, if we would decide so? >=20 > Could you raise this on koha-devel ? I think you are misunderstanding the purpose of this patch. Clearly, we should not have to build a plugin just to import a google font into Koha for some CSS style. That appears to be the purpose of this ehancement; to allow importing = js and css into the correct part of Koha's html, the head block. Does that make sense? --=20 You are receiving this mail because: You are watching all bug changes. --===============7964492693164527169==-- From bugzilla-daemon@bugs.koha-community.org Fri Jul 9 22:46:44 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28080] Add system preference that allows users to insert HTML in the on all OPAC pages Date: Fri, 09 Jul 2021 20:46:43 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0758681910201869174==" --===============0758681910201869174== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. --===============0758681910201869174==-- From bugzilla-daemon@bugs.koha-community.org Mon Jul 12 10:53:03 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28080] Add system preference that allows users to insert HTML in the on all OPAC pages Date: Mon, 12 Jul 2021 08:53:02 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0797085646725750728==" --===============0797085646725750728== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 --- Comment #6 from Marcel de Rooy --- (In reply to Kyle M Hall from comment #5) > > We now have this already: > > KohaPlugins.get_plugins_opac_head > > And: [% KohaPlugins.get_plugins_opac_js %] > > And: [% KohaPlugins.get_plugins_intranet_head %] > > > > So it is a discussion item whether we really should have this too. > > We miss an intranet counterpart here, that the plugins offer. > > And maybe the location of adding the pref content in doc-head-close is > > questionable? Should we add it at the end, if we would decide so? > > > > Could you raise this on koha-devel ? > > I think you are misunderstanding the purpose of this patch. Clearly, we > should not have to build a plugin just to import a google font into Koha for > some CSS style. That appears to be the purpose of this ehancement; to allow > importing js and css into the correct part of Koha's html, the head block. > > Does that make sense? Surely, this explanation is helpful :) In this case I would ask: Couldnt you do the same with OPACUserCSS and @import url() or @font-face and src: url()? -- You are receiving this mail because: You are watching all bug changes. --===============0797085646725750728==-- From bugzilla-daemon@bugs.koha-community.org Tue Jul 13 16:32:55 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28080] Add system preference that allows users to insert HTML in the on all OPAC pages Date: Tue, 13 Jul 2021 14:32:54 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8352282340181382691==" --===============8352282340181382691== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|In Discussion |RESOLVED --- Comment #7 from Lucas Gass --- > Surely, this explanation is helpful :) > In this case I would ask: Couldnt you do the same with OPACUserCSS and > @import url() or @font-face and src: url()? Marcel, we can do that for CSS, yes. I thought maybe it would be beneficial to be able to add other things that belong in the HTML head, link/meta/style/script etc. But perhaps the use case is so small that is not worth adding a whole new system preference to Koha. I will go ahead and mark this one as invalid as there are workarounds to my problem. -- You are receiving this mail because: You are watching all bug changes. --===============8352282340181382691==-- From bugzilla-daemon@bugs.koha-community.org Tue Jul 13 16:42:21 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 28080] Add system preference that allows users to insert HTML in the on all OPAC pages Date: Tue, 13 Jul 2021 14:42:20 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7375291233871406849==" --===============7375291233871406849== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 --- Comment #8 from Marcel de Rooy --- (In reply to Lucas Gass from comment #7) > Marcel, we can do that for CSS, yes. I thought maybe it would be beneficial > to be able to add other things that belong in the HTML head, > link/meta/style/script etc. > > But perhaps the use case is so small that is not worth adding a whole new > system preference to Koha. I will go ahead and mark this one as invalid as > there are workarounds to my problem. Fair enough. But no one told you so yet. Stand with the first QA wave, cope with the second :) -- You are receiving this mail because: You are watching all bug changes. --===============7375291233871406849==--