From bugzilla-daemon@bugs.koha-community.org Mon Apr 20 00:29:15 2015
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 1917] Add RSS Feeds for Lists
Date: Sun, 19 Apr 2015 22:29:11 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4676900546964383757=="
--===============4676900546964383757==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D1917
--- Comment #6 from Katrin Fischer ---
Comment on attachment 38117
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D38117
[Signed-off] Bug 1917 - Add RSS Feeds for Lists
Review of attachment 38117:
--> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=3Dsplinter.html&bu=
g=3D1917&attachment=3D38117)
-----------------------------------------------------------------
Hi,
I love to see work on the low bug numbers! :)
The biggest issue here is that the strings from opac-shelves-rss.tt don't
appear to be translatable. I updated my po files, but the strings or file name
won't show up there.
I also found some smaller issues, please see comments below:
::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves-rss.tt
@@ +2,5 @@
> +
> +
> +
> +
> + [% shelfname %]
Why no |html here, but below?
@@ +8,5 @@
> + RSS feed for public list [% shelfname | html %]
> +
> +[% FOREACH i IN itemsloop %]
> + -
> + [% i.title %] by [% i.author %]
The by is always shown, even if there is no author. Also because of the
included ISBD punctuation in MARC21 this would only be needed/useful for
UNIMARC.
::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
@@ +153,5 @@
> [% IF ( viewshelf ) %]
> +
> + [% shelfname |html %]
> +