From bugzilla-daemon@bugs.koha-community.org Tue Sep 21 00:33:36 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 29067] New: Remove duplicate conditional statement from OPAC messaging settings title Date: Mon, 20 Sep 2021 22:33:36 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0026552590852429762==" --===============0026552590852429762== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 Bug ID: 29067 Summary: Remove duplicate conditional statement from OPAC messaging settings title Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lari.taskula@hypernova.fi QA Contact: testopia@bugs.koha-community.org There is a duplicate conditional statement in OPAC messaging settings . We need to check LibraryNameTitle just once. -- You are receiving this mail because: You are watching all bug changes. --===============0026552590852429762==-- From bugzilla-daemon@bugs.koha-community.org Tue Sep 21 00:42:18 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 29067] Remove duplicate conditional statement from OPAC messaging settings title Date: Mon, 20 Sep 2021 22:42:08 +0000 Message-ID: <bug-29067-70-1WHjxovLAF@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7320221962897979747==" --===============7320221962897979747== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============7320221962897979747==-- From bugzilla-daemon@bugs.koha-community.org Tue Sep 21 00:42:28 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 29067] Remove duplicate conditional statement from OPAC messaging settings title Date: Mon, 20 Sep 2021 22:42:20 +0000 Message-ID: <bug-29067-70-8dadr1bJjX@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3386070192166747592==" --===============3386070192166747592== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 --- Comment #1 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 125083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125083&action=edit Bug 29067: Remove duplicate conditional statement from OPAC messaging settings title We can never reach the first [% ELSE %]Koha online[% END %] block in OPAC messaging preferences title, so it's dead code. This patch removes the useless duplicate if-statement. To test: 1. Enable EnhancedMessagingPreferencesOPAC system preference 2. Go to /cgi-bin/koha/opac-messaging.pl 3. Observe title Your messaging settings > Koha online catalog 4. Apply patch 5. Refresh page /cgi-bin/koha/opac-messaging.pl 6. Observe same title Your messaging settings > Koha online catalog 7. See patch content 8. Confirm there are no functional changes in the new logic -- You are receiving this mail because: You are watching all bug changes. --===============3386070192166747592==-- From bugzilla-daemon@bugs.koha-community.org Tue Sep 21 00:43:20 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 29067] Remove duplicate conditional statement from OPAC messaging settings title Date: Mon, 20 Sep 2021 22:43:19 +0000 Message-ID: <bug-29067-70-dMqTR8j4fr@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8863895876123839185==" --===============8863895876123839185== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lari.taskula@hypernova.fi -- You are receiving this mail because: You are watching all bug changes. --===============8863895876123839185==-- From bugzilla-daemon@bugs.koha-community.org Wed Sep 22 17:04:27 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 29067] Remove duplicate conditional statement from OPAC messaging settings title Date: Wed, 22 Sep 2021 15:04:26 +0000 Message-ID: <bug-29067-70-llRPWRGXCG@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4271292561081181376==" --===============4271292561081181376== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============4271292561081181376==-- From bugzilla-daemon@bugs.koha-community.org Wed Sep 22 17:04:37 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 29067] Remove duplicate conditional statement from OPAC messaging settings title Date: Wed, 22 Sep 2021 15:04:29 +0000 Message-ID: <bug-29067-70-dgOf66c5VE@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6217404770608704947==" --===============6217404770608704947== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125083|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125139&action=edit Bug 29067: Remove duplicate conditional statement from OPAC messaging settings title We can never reach the first [% ELSE %]Koha online[% END %] block in OPAC messaging preferences title, so it's dead code. This patch removes the useless duplicate if-statement. To test: 1. Enable EnhancedMessagingPreferencesOPAC system preference 2. Go to /cgi-bin/koha/opac-messaging.pl 3. Observe title Your messaging settings > Koha online catalog 4. Apply patch 5. Refresh page /cgi-bin/koha/opac-messaging.pl 6. Observe same title Your messaging settings > Koha online catalog 7. See patch content 8. Confirm there are no functional changes in the new logic Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes. --===============6217404770608704947==-- From bugzilla-daemon@bugs.koha-community.org Sun Sep 26 12:49:28 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 29067] Remove duplicate conditional statement from OPAC messaging settings title Date: Sun, 26 Sep 2021 10:49:27 +0000 Message-ID: <bug-29067-70-ec01wshOzm@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0126622618651946052==" --===============0126622618651946052== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. --===============0126622618651946052==-- From bugzilla-daemon@bugs.koha-community.org Sun Sep 26 12:53:10 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 29067] Remove duplicate conditional statement from OPAC messaging settings title Date: Sun, 26 Sep 2021 10:53:10 +0000 Message-ID: <bug-29067-70-9i1saV43mk@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8986126171180732741==" --===============8986126171180732741== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============8986126171180732741==-- From bugzilla-daemon@bugs.koha-community.org Sun Sep 26 12:53:21 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 29067] Remove duplicate conditional statement from OPAC messaging settings title Date: Sun, 26 Sep 2021 10:53:13 +0000 Message-ID: <bug-29067-70-uJjzCpqQPn@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5008290935147102587==" --===============5008290935147102587== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125139|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 125315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125315&action=edit Bug 29067: Remove duplicate conditional statement from OPAC messaging settings title We can never reach the first [% ELSE %]Koha online[% END %] block in OPAC messaging preferences title, so it's dead code. This patch removes the useless duplicate if-statement. To test: 1. Enable EnhancedMessagingPreferencesOPAC system preference 2. Go to /cgi-bin/koha/opac-messaging.pl 3. Observe title Your messaging settings > Koha online catalog 4. Apply patch 5. Refresh page /cgi-bin/koha/opac-messaging.pl 6. Observe same title Your messaging settings > Koha online catalog 7. See patch content 8. Confirm there are no functional changes in the new logic Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. --===============5008290935147102587==-- From bugzilla-daemon@bugs.koha-community.org Tue Sep 28 15:45:06 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 29067] Remove duplicate conditional statement from OPAC messaging settings title Date: Tue, 28 Sep 2021 13:39:48 +0000 Message-ID: <bug-29067-70-rGPFR1zl5D@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6551000828120838198==" --===============6551000828120838198== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. --===============6551000828120838198==-- From bugzilla-daemon@bugs.koha-community.org Tue Sep 28 15:45:16 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 29067] Remove duplicate conditional statement from OPAC messaging settings title Date: Tue, 28 Sep 2021 13:39:51 +0000 Message-ID: <bug-29067-70-QPGWeVJ3tc@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6283194790969358479==" --===============6283194790969358479== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. --===============6283194790969358479==-- From bugzilla-daemon@bugs.koha-community.org Fri Oct 8 14:26:53 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 29067] Remove duplicate conditional statement from OPAC messaging settings title Date: Fri, 08 Oct 2021 12:26:52 +0000 Message-ID: <bug-29067-70-nztV453YxA@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0650796501571559414==" --===============0650796501571559414== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. --===============0650796501571559414==-- From bugzilla-daemon@bugs.koha-community.org Thu Oct 21 05:16:41 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 29067] Remove duplicate conditional statement from OPAC messaging settings title Date: Thu, 21 Oct 2021 03:16:40 +0000 Message-ID: <bug-29067-70-aO9fBfHskZ@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1749541063506541194==" --===============1749541063506541194== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |27742 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 27742 not in 20.11.x Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27742 [Bug 27742] Accessibility: OPAC - Page titles should have unique information first -- You are receiving this mail because: You are watching all bug changes. --===============1749541063506541194==-- From bugzilla-daemon@bugs.koha-community.org Thu Oct 21 05:18:35 2021 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 29067] Remove duplicate conditional statement from OPAC messaging settings title Date: Thu, 21 Oct 2021 03:18:35 +0000 Message-ID: <bug-29067-70-Q9m3dyVZIK@https.bugs.koha-community.org/bugzilla3/> In-Reply-To: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3420892459905268145==" --===============3420892459905268145== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. --===============3420892459905268145==--