From bugzilla-daemon@bugs.koha-community.org Tue Jan 22 18:33:03 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9445] New: Use DataTables in local use system preferences editor Date: Tue, 22 Jan 2013 17:32:58 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1321817188386564635==" --===============1321817188386564635== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Bug ID: 9445 Summary: Use DataTables in local use system preferences editor Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/systempreferences.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The "old" system preferences editor, used now only for local use preferences, uses the old tablesorter plugin. It should use DataTables instead. -- You are receiving this mail because: You are watching all bug changes. --===============1321817188386564635==-- From bugzilla-daemon@bugs.koha-community.org Tue Jan 22 18:47:02 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor Date: Tue, 22 Jan 2013 17:46:58 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6393582671323424391==" --===============6393582671323424391== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 --- Comment #1 from Owen Leonard --- Created attachment 14755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14755&action=edit Bug 9445 - Use DataTables in local use system preferences editor Replace the tablesorter plugin with the DataTables plugin in the local use system preferences editor. This patch moves embedding of the toolbar and table-sorting JS from within the body of the page to the for sake of consistency. To test, open the system preferences editor to the Local Use tab. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. -- You are receiving this mail because: You are watching all bug changes. --===============6393582671323424391==-- From bugzilla-daemon@bugs.koha-community.org Tue Jan 22 18:47:11 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor Date: Tue, 22 Jan 2013 17:46:57 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6831089864620639840==" --===============6831089864620639840== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============6831089864620639840==-- From bugzilla-daemon@bugs.koha-community.org Wed Jan 23 09:40:54 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor Date: Wed, 23 Jan 2013 08:40:48 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0001963766958497718==" --===============0001963766958497718== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============0001963766958497718==-- From bugzilla-daemon@bugs.koha-community.org Wed Jan 23 09:41:01 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor Date: Wed, 23 Jan 2013 08:40:50 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3851894622613666812==" --===============3851894622613666812== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14755|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 14771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14771&action=edit Bug 9445 - Use DataTables in local use system preferences editor Replace the tablesorter plugin with the DataTables plugin in the local use system preferences editor. This patch moves embedding of the toolbar and table-sorting JS from within the body of the page to the for sake of consistency. To test, open the system preferences editor to the Local Use tab. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. --===============3851894622613666812==-- From bugzilla-daemon@bugs.koha-community.org Tue Feb 26 16:09:18 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor Date: Tue, 26 Feb 2013 15:08:51 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0489783323264499263==" --===============0489783323264499263== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. --===============0489783323264499263==-- From bugzilla-daemon@bugs.koha-community.org Tue Feb 26 17:26:52 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor Date: Tue, 26 Feb 2013 16:26:33 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9192376725207726025==" --===============9192376725207726025== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============9192376725207726025==-- From bugzilla-daemon@bugs.koha-community.org Tue Feb 26 17:26:53 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor Date: Tue, 26 Feb 2013 16:26:34 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2693506418679152638==" --===============2693506418679152638== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14771|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 15700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15700&action=edit Bug 9445 [Revised] Use DataTables in local use system preferences editor Replace the tablesorter plugin with the DataTables plugin in the local use system preferences editor. This patch moves embedding of the toolbar and table-sorting JS from within the body of the page to the for sake of consistency. To test, open the system preferences editor to the Local Use tab. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. -- You are receiving this mail because: You are watching all bug changes. --===============2693506418679152638==-- From bugzilla-daemon@bugs.koha-community.org Thu Feb 28 00:42:24 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor Date: Wed, 27 Feb 2013 23:42:08 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4075844772036038295==" --===============4075844772036038295== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15700|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 15744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15744&action=edit [SIGNED-OFF] Bug 9445 [Revised] Use DataTables in local use system preferences editor Replace the tablesorter plugin with the DataTables plugin in the local use system preferences editor. This patch moves embedding of the toolbar and table-sorting JS from within the body of the page to the for sake of consistency. To test, open the system preferences editor to the Local Use tab. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Tab sorting works. No errors. -- You are receiving this mail because: You are watching all bug changes. --===============4075844772036038295==-- From bugzilla-daemon@bugs.koha-community.org Thu Feb 28 00:42:41 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor Date: Wed, 27 Feb 2013 23:42:26 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0201888841107375535==" --===============0201888841107375535== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes. --===============0201888841107375535==-- From bugzilla-daemon@bugs.koha-community.org Thu Feb 28 16:49:55 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor Date: Thu, 28 Feb 2013 15:49:34 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0669226070322137715==" --===============0669226070322137715== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart --- QA comment: Add datatable on the systempreferences.pl page (local use only). Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. --===============0669226070322137715==-- From bugzilla-daemon@bugs.koha-community.org Thu Feb 28 16:50:04 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor Date: Thu, 28 Feb 2013 15:49:48 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2292792532507108150==" --===============2292792532507108150== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15744|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 15775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15775&action=edit Bug 9445 [Revised] Use DataTables in local use system preferences editor Replace the tablesorter plugin with the DataTables plugin in the local use system preferences editor. This patch moves embedding of the toolbar and table-sorting JS from within the body of the page to the for sake of consistency. To test, open the system preferences editor to the Local Use tab. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Tab sorting works. No errors. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. --===============2292792532507108150==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 1 01:19:55 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor Date: Fri, 01 Mar 2013 00:19:39 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2034653218437279854==" --===============2034653218437279854== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #7 from Jared Camins-Esakov --- This patch adds Datatables, but it does not remove tablesorter from the page. It probably should. -- You are receiving this mail because: You are watching all bug changes. --===============2034653218437279854==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 1 09:44:19 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor Date: Fri, 01 Mar 2013 08:44:02 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6092728032855712813==" --===============6092728032855712813== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 --- Comment #8 from Jonathan Druart --- (In reply to comment #7) > This patch adds Datatables, but it does not remove tablesorter from the > page. It probably should. Ho yes, good catch. I don't understand when this code is used but it should be deleted. -- You are receiving this mail because: You are watching all bug changes. --===============6092728032855712813==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 1 15:56:43 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor Date: Fri, 01 Mar 2013 14:56:19 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2118388592578256846==" --===============2118388592578256846== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. --===============2118388592578256846==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 1 20:46:41 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor Date: Fri, 01 Mar 2013 19:46:22 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1026935027973529765==" --===============1026935027973529765== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============1026935027973529765==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 1 20:46:43 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor Date: Fri, 01 Mar 2013 19:46:23 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8567437545474606008==" --===============8567437545474606008== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15775|0 |1 is obsolete| | --- Comment #9 from Owen Leonard --- Created attachment 15810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15810&action=edit Bug 9445 [Revised] Use DataTables in local use system preferences editor Replace the tablesorter plugin with the DataTables plugin in the local use system preferences editor. This patch moves embedding of the toolbar and table-sorting JS from within the body of the page to the for sake of consistency. To test, open the system preferences editor to the Local Use tab. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Tab sorting works. No errors. Signed-off-by: Jonathan Druart Further revision removes old tablesorter code -- You are receiving this mail because: You are watching all bug changes. --===============8567437545474606008==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 1 20:46:59 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor Date: Fri, 01 Mar 2013 19:46:43 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8914397016098453695==" --===============8914397016098453695== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============8914397016098453695==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 1 20:47:27 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor Date: Fri, 01 Mar 2013 19:47:10 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4792577226095665584==" --===============4792577226095665584== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Owen Leonard --- Returning to "Passed QA" as per jcamins' instructions. -- You are receiving this mail because: You are watching all bug changes. --===============4792577226095665584==-- From bugzilla-daemon@bugs.koha-community.org Sat Mar 2 18:26:04 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor Date: Sat, 02 Mar 2013 17:25:43 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7687728623144514763==" --===============7687728623144514763== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. --===============7687728623144514763==--