From bugzilla-daemon@bugs.koha-community.org Sun May  3 03:11:38 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 25354] New: Clean up JavaScript markup in cataloging
 plugin scripts
Date: Sun, 03 May 2020 01:11:27 +0000
Message-ID: <bug-25354-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7250255216899043504=="

--===============7250255216899043504==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D25354

            Bug ID: 25354
           Summary: Clean up JavaScript markup in cataloging plugin
                    scripts
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard@myacpl.org
          Reporter: oleonard@myacpl.org
        QA Contact: testopia@bugs.koha-community.org

I have an idea for how to move JavaScript in additem.tt and addbiblio.tt to t=
he
footer, but the JavaScript generated by the plugin scripts needs some cleanup
before that can happen.

Specifically, single line JS comments (// ... ) will break the script if
whitespace in the script is collapsed. These will be changed to multi-line
comments (/* ... */).

While I'm making changes I'll be removing the <script> tag's "type" attribute
and obsolete "//<![CDATA[" markers.

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============7250255216899043504==--


From bugzilla-daemon@bugs.koha-community.org Mon May  4 00:17:01 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 25354] Clean up JavaScript markup in cataloging
 plugin scripts
Date: Sun, 03 May 2020 22:17:00 +0000
Message-ID: <bug-25354-70-cynSN1H664@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25354-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5322995346237294836=="

--===============5322995346237294836==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25354

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5322995346237294836==--


From bugzilla-daemon@bugs.koha-community.org Mon May  4 00:17:11 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 25354] Clean up JavaScript markup in cataloging
 plugin scripts
Date: Sun, 03 May 2020 22:17:03 +0000
Message-ID: <bug-25354-70-NrUHv0E1Ce@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25354-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6063982166420980187=="

--===============6063982166420980187==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25354

--- Comment #1 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 104239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104239&action=edit
Bug 25354: Clean up JavaScript markup in cataloging plugin scripts

This patch makes some minor changes to the JavaScript generated by the
cataloging plugins: <script> "type" attribute removed; single-line
comments converted to multi-line style; obsolete //<![CDATA[ marks
removed.

These changes help the JavaScript conform to current coding guidelines.
The comment style change allows for whitespace in the scripts to be
collapsed by the Template::Toolkit "collapse" filter.

Since the patch makes small cosmetic changes to many files it may be
easiest to test this patch by visually inspecting the changes.

It's also simple to test some plugins which are enabled by default (at
least in MARC21): In the basic MARC editor, the leader, 007, and 008. In
the item editor, subfield d - Date acquired.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6063982166420980187==--


From bugzilla-daemon@bugs.koha-community.org Mon May  4 07:59:08 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 25354] Clean up JavaScript markup in cataloging
 plugin scripts
Date: Mon, 04 May 2020 05:59:06 +0000
Message-ID: <bug-25354-70-Oy4vERPHcl@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25354-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3466898372199517525=="

--===============3466898372199517525==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25354

Josef Moravec <josef.moravec@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3466898372199517525==--


From bugzilla-daemon@bugs.koha-community.org Thu Sep 10 20:11:08 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 25354] Clean up JavaScript markup in cataloging
 plugin scripts
Date: Thu, 10 Sep 2020 18:11:06 +0000
Message-ID: <bug-25354-70-GBwhGowYyW@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25354-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0840295014450989325=="

--===============0840295014450989325==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25354

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104239|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 109857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109857&action=edit
Bug 25354: Clean up JavaScript markup in cataloging plugin scripts

This patch makes some minor changes to the JavaScript generated by the
cataloging plugins: <script> "type" attribute removed; single-line
comments converted to multi-line style; obsolete //<![CDATA[ marks
removed.

These changes help the JavaScript conform to current coding guidelines.
The comment style change allows for whitespace in the scripts to be
collapsed by the Template::Toolkit "collapse" filter.

Since the patch makes small cosmetic changes to many files it may be
easiest to test this patch by visually inspecting the changes.

It's also simple to test some plugins which are enabled by default (at
least in MARC21): In the basic MARC editor, the leader, 007, and 008. In
the item editor, subfield d - Date acquired.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0840295014450989325==--


From bugzilla-daemon@bugs.koha-community.org Thu Oct  1 15:58:45 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 25354] Clean up JavaScript markup in cataloging
 plugin scripts
Date: Thu, 01 Oct 2020 13:58:44 +0000
Message-ID: <bug-25354-70-lWGR8RJWsX@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25354-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6859663656536418286=="

--===============6859663656536418286==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25354

David Nind <david@davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6859663656536418286==--


From bugzilla-daemon@bugs.koha-community.org Thu Oct  1 15:58:55 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 25354] Clean up JavaScript markup in cataloging
 plugin scripts
Date: Thu, 01 Oct 2020 13:58:51 +0000
Message-ID: <bug-25354-70-LqXbFgXjvn@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25354-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0030344966029742954=="

--===============0030344966029742954==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25354

David Nind <david@davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #109857|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david@davidnind.com> ---
Created attachment 111047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111047&action=edit
Bug 25354: Clean up JavaScript markup in cataloging plugin scripts

This patch makes some minor changes to the JavaScript generated by the
cataloging plugins: <script> "type" attribute removed; single-line
comments converted to multi-line style; obsolete //<![CDATA[ marks
removed.

These changes help the JavaScript conform to current coding guidelines.
The comment style change allows for whitespace in the scripts to be
collapsed by the Template::Toolkit "collapse" filter.

Since the patch makes small cosmetic changes to many files it may be
easiest to test this patch by visually inspecting the changes.

It's also simple to test some plugins which are enabled by default (at
least in MARC21): In the basic MARC editor, the leader, 007, and 008. In
the item editor, subfield d - Date acquired.

Signed-off-by: David Nind <david@davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0030344966029742954==--


From bugzilla-daemon@bugs.koha-community.org Tue Oct 13 13:41:03 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 25354] Clean up JavaScript markup in cataloging
 plugin scripts
Date: Tue, 13 Oct 2020 11:41:02 +0000
Message-ID: <bug-25354-70-oieMPD3hcH@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25354-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5830719139405436488=="

--===============5830719139405436488==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25354

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5830719139405436488==--


From bugzilla-daemon@bugs.koha-community.org Tue Oct 13 13:41:13 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 25354] Clean up JavaScript markup in cataloging
 plugin scripts
Date: Tue, 13 Oct 2020 11:41:10 +0000
Message-ID: <bug-25354-70-uo5YX6evyD@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25354-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1954267691406450450=="

--===============1954267691406450450==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25354

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #111047|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Created attachment 111537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111537&action=edit
Bug 25354: Clean up JavaScript markup in cataloging plugin scripts

This patch makes some minor changes to the JavaScript generated by the
cataloging plugins: <script> "type" attribute removed; single-line
comments converted to multi-line style; obsolete //<![CDATA[ marks
removed.

These changes help the JavaScript conform to current coding guidelines.
The comment style change allows for whitespace in the scripts to be
collapsed by the Template::Toolkit "collapse" filter.

Since the patch makes small cosmetic changes to many files it may be
easiest to test this patch by visually inspecting the changes.

It's also simple to test some plugins which are enabled by default (at
least in MARC21): In the basic MARC editor, the leader, 007, and 008. In
the item editor, subfield d - Date acquired.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1954267691406450450==--


From bugzilla-daemon@bugs.koha-community.org Wed Oct 14 14:56:04 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 25354] Clean up JavaScript markup in cataloging
 plugin scripts
Date: Wed, 14 Oct 2020 12:54:19 +0000
Message-ID: <bug-25354-70-lBoRMOHrpg@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25354-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8487234879392371751=="

--===============8487234879392371751==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25354

Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8487234879392371751==--


From bugzilla-daemon@bugs.koha-community.org Wed Oct 14 14:56:14 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 25354] Clean up JavaScript markup in cataloging
 plugin scripts
Date: Wed, 14 Oct 2020 12:54:22 +0000
Message-ID: <bug-25354-70-ZiUh3s12za@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25354-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0659843370460372883=="

--===============0659843370460372883==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D25354

--- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org>=
 ---
Pushed to master for 20.11, thanks to everybody involved!

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============0659843370460372883==--


From bugzilla-daemon@bugs.koha-community.org Fri Nov 13 15:44:12 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 25354] Clean up JavaScript markup in cataloging
 plugin scripts
Date: Fri, 13 Nov 2020 14:44:11 +0000
Message-ID: <bug-25354-70-SWDfoYa1tI@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-25354-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1980057796183002005=="

--===============1980057796183002005==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25354

Lucas Gass <lucas@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas@bywatersolutions.com

--- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> ---
enhancement will not be backported to 20.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1980057796183002005==--