From bugzilla-daemon@bugs.koha-community.org Wed Apr 22 07:58:07 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25237] New: Accessibility: The 'Author details' in the full record display contains semantically incorrect headings Date: Wed, 22 Apr 2020 05:58:06 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1164157691304064897==" --===============1164157691304064897== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D25237 Bug ID: 25237 Summary: Accessibility: The 'Author details' in the full record display contains semantically incorrect headings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: oleonard@myacpl.org, testopia@bugs.koha-community.org Depends on: 25236 Blocks: 25150 Library Catalogue - OPAC The =E2=80=98Author=E2=80=99 heading is not logical because it increases by m= ore than one heading level. This means that screen reader users may not be able to determi= ne the structure of content on the page. 1/ Search for an item 2/ Click through to a records full details disaply 3/ Note that the author details are semantically marked as a heading of the wrong level. Current Code:
By: Barty, James | Morgan Grenfell.
Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D25150 [Bug 25150] Accessibility: 2.4.10 Section Headings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D25236 [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings --=20 You are receiving this mail because: You are watching all bug changes. --===============1164157691304064897==-- From bugzilla-daemon@bugs.koha-community.org Wed Apr 22 07:58:37 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings Date: Wed, 22 Apr 2020 05:58:16 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7864301703544904990==" --===============7864301703544904990== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|25236 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings -- You are receiving this mail because: You are watching all bug changes. --===============7864301703544904990==-- From bugzilla-daemon@bugs.koha-community.org Wed Apr 22 08:03:15 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings Date: Wed, 22 Apr 2020 06:03:04 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0921093545535258914==" --===============0921093545535258914== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25238 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 [Bug 25238] Accessibility: Multiple 'H1' headings exist in the full record display -- You are receiving this mail because: You are watching all bug changes. --===============0921093545535258914==-- From bugzilla-daemon@bugs.koha-community.org Wed Apr 22 08:03:45 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings Date: Wed, 22 Apr 2020 06:03:14 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2827951892896461149==" --===============2827951892896461149== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25238 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 [Bug 25238] Accessibility: Multiple 'H1' headings exist in the full record display -- You are receiving this mail because: You are watching all bug changes. --===============2827951892896461149==-- From bugzilla-daemon@bugs.koha-community.org Thu Jun 11 13:20:30 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings Date: Thu, 11 Jun 2020 11:20:21 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6225514278874520943==" --===============6225514278874520943== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25238 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 [Bug 25238] Accessibility: Multiple 'H1' headings exist in the full record display -- You are receiving this mail because: You are watching all bug changes. --===============6225514278874520943==-- From bugzilla-daemon@bugs.koha-community.org Thu Jun 11 13:27:03 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings Date: Thu, 11 Jun 2020 11:27:02 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8539328812421597477==" --===============8539328812421597477== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh@parliament.uk -- You are receiving this mail because: You are watching all bug changes. --===============8539328812421597477==-- From bugzilla-daemon@bugs.koha-community.org Thu Jun 11 13:49:48 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings Date: Thu, 11 Jun 2020 11:49:47 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8363180750960194934==" --===============8363180750960194934== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 --- Comment #1 from Martin Renvoize --- Created attachment 105737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105737&action=edit Bug 25237: Fix semantic heading for opac-details Prior to this patch the opac-details view contained semantically incorrect h3 headings for the author information. Test plan 1/ Perform a search in the OPAC that will yield results 2/ Navigate to any results detailed view 3/ Inspect the page and note that there are semantically incorrect headings H1 (Page title) > H2 (Item title) > H5 (Author) 4/ Apply the patch 5/ Reload the page 6/ Inspect the page and note that the semantically incorrect author block has been converted to a span with an 'h3' class for styling 7/ Note the page still appears nicely 8/ Signoff Bonus points: Check with XSLT views enabled and disabled. -- You are receiving this mail because: You are watching all bug changes. --===============8363180750960194934==-- From bugzilla-daemon@bugs.koha-community.org Thu Jun 11 13:50:02 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings Date: Thu, 11 Jun 2020 11:50:02 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2595798986703080486==" --===============2595798986703080486== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. --===============2595798986703080486==-- From bugzilla-daemon@bugs.koha-community.org Thu Jun 11 13:50:19 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings Date: Thu, 11 Jun 2020 11:50:18 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7813130792992857644==" --===============7813130792992857644== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. --===============7813130792992857644==-- From bugzilla-daemon@bugs.koha-community.org Tue Jun 23 10:47:33 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings Date: Tue, 23 Jun 2020 08:47:32 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7380292591578238531==" --===============7380292591578238531== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105737|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 106182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106182&action=edit Bug 25237: Fix semantic heading for opac-details Prior to this patch the opac-details view contained semantically incorrect h3 headings for the author information. Test plan 1/ Perform a search in the OPAC that will yield results 2/ Navigate to any results detailed view 3/ Inspect the page and note that there are semantically incorrect headings H1 (Page title) > H2 (Item title) > H5 (Author) 4/ Apply the patch 5/ Reload the page 6/ Inspect the page and note that the semantically incorrect author block has been converted to a span with an 'h3' class for styling 7/ Note the page still appears nicely 8/ Signoff Bonus points: Check with XSLT views enabled and disabled. Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. --===============7380292591578238531==-- From bugzilla-daemon@bugs.koha-community.org Tue Jun 23 10:48:12 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings Date: Tue, 23 Jun 2020 08:48:12 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7270604976911730013==" --===============7270604976911730013== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============7270604976911730013==-- From bugzilla-daemon@bugs.koha-community.org Tue Jul 7 00:35:44 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings Date: Mon, 06 Jul 2020 22:35:43 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4396927381766953398==" --===============4396927381766953398== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============4396927381766953398==-- From bugzilla-daemon@bugs.koha-community.org Tue Jul 7 00:35:54 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings Date: Mon, 06 Jul 2020 22:35:47 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8964126301080890562==" --===============8964126301080890562== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106182|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 106619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106619&action=edit Bug 25237: Fix semantic heading for opac-details Prior to this patch the opac-details view contained semantically incorrect h3 headings for the author information. Test plan 1/ Perform a search in the OPAC that will yield results 2/ Navigate to any results detailed view 3/ Inspect the page and note that there are semantically incorrect headings H1 (Page title) > H2 (Item title) > H5 (Author) 4/ Apply the patch 5/ Reload the page 6/ Inspect the page and note that the semantically incorrect author block has been converted to a span with an 'h3' class for styling 7/ Note the page still appears nicely 8/ Signoff Bonus points: Check with XSLT views enabled and disabled. Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. --===============8964126301080890562==-- From bugzilla-daemon@bugs.koha-community.org Mon Jul 20 17:51:52 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings Date: Mon, 20 Jul 2020 15:48:38 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0242109158003506040==" --===============0242109158003506040== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. --===============0242109158003506040==-- From bugzilla-daemon@bugs.koha-community.org Mon Jul 20 17:52:02 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings Date: Mon, 20 Jul 2020 15:48:40 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4642033661174773775==" --===============4642033661174773775== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D25237 --- Comment #4 from Jonathan Druart = --- Pushed to master for 20.11, thanks to everybody involved! --=20 You are receiving this mail because: You are watching all bug changes. --===============4642033661174773775==-- From bugzilla-daemon@bugs.koha-community.org Mon Jul 27 19:13:34 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings Date: Mon, 27 Jul 2020 17:13:33 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7233052407416614663==" --===============7233052407416614663== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.03 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #5 from Lucas Gass --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. --===============7233052407416614663==-- From bugzilla-daemon@bugs.koha-community.org Tue Aug 4 01:07:52 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings Date: Mon, 03 Aug 2020 23:07:51 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5914870787515932838==" --===============5914870787515932838== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.03 |20.11.00, 20.05.03, released in| |19.11.09 CC| |aleisha@catalyst.net.nz Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Aleisha Amohia --- backported to 19.11.x for 19.11.09 -- You are receiving this mail because: You are watching all bug changes. --===============5914870787515932838==-- From bugzilla-daemon@bugs.koha-community.org Fri Sep 18 22:11:22 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings Date: Fri, 18 Sep 2020 20:11:21 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4445612833636820469==" --===============4445612833636820469== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #7 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. --===============4445612833636820469==--