From bugzilla-daemon@bugs.koha-community.org Fri Apr  6 18:59:47 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] New: Remove the need of writing [%
 KOHA_VERSION %] everywhere
Date: Fri, 06 Apr 2018 16:59:44 +0000
Message-ID: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7053768894300034704=="

--===============7053768894300034704==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

            Bug ID: 20538
           Summary: Remove the need of writing [% KOHA_VERSION %]
                    everywhere
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: julian.maurice@biblibre.com
          Reporter: julian.maurice@biblibre.com
        QA Contact: testopia@bugs.koha-community.org

Having to write [% KOHA_VERSION %] for each url is bad because:
- It's easily forgettable when adding new <script> or <link>
- It prevents grep'ing for the full filename
- It violates the DRY principle
- If at some point we want to change the "force js and css reload" mechanism,
it will be tedious

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7053768894300034704==--


From bugzilla-daemon@bugs.koha-community.org Fri Apr  6 19:00:57 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Fri, 06 Apr 2018 17:00:49 +0000
Message-ID: <bug-20538-70-cNnLcwZx4s@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1228058769314580043=="

--===============1228058769314580043==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

Julian Maurice <julian.maurice@biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1228058769314580043==--


From bugzilla-daemon@bugs.koha-community.org Fri Apr  6 19:01:00 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Fri, 06 Apr 2018 17:00:30 +0000
Message-ID: <bug-20538-70-81o5qGaame@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4158882057095671226=="

--===============4158882057095671226==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

--- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> ---
Created attachment 73791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73791&action=edit
Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere

Having to write [% KOHA_VERSION %] for each url is bad because:
- It's easily forgettable when adding new <script> or <link>
- It prevents grep'ing for the full filename
- It violates the DRY principle
- If at some point we want to change the "force js and css reload"
  mechanism, it will be tedious

This patch:
- adds a Template::Toolkit plugin that generates <script> and
  <link> tags for JS and CSS files, and inserts automatically the Koha
  version in the filename
- use the new plugin to remove all occurences of [% KOHA_VERSION %]
- remove the code that was adding KOHA_VERSION as a template variable

Test plan:
1. Apply patch
2. Go to several different pages in Koha (opac and intranet) while
   checking your browser's dev tools (there should be no 404 for JS and
   CSS files, and the Koha version should appear in filenames) and the
   server logs (there should be no "File not found")
3. `git grep KOHA_VERSION` should return nothing
4. prove t/db_dependent/Koha/Template/Plugin/Asset.t

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4158882057095671226==--


From bugzilla-daemon@bugs.koha-community.org Fri Apr  6 19:41:27 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Fri, 06 Apr 2018 17:41:25 +0000
Message-ID: <bug-20538-70-cN3F68Mp7U@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3535303513156888993=="

--===============3535303513156888993==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart@bugs.koha-c
                   |                            |ommunity.org
           Keywords|                            |rel_18_05_candidate,
                   |                            |RM_priority

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3535303513156888993==--


From bugzilla-daemon@bugs.koha-community.org Fri Apr  6 20:56:35 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Fri, 06 Apr 2018 18:56:30 +0000
Message-ID: <bug-20538-70-NL984Tsbz6@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0194055214525619981=="

--===============0194055214525619981==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

Roch D'Amour <roch.damour@inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |roch.damour@inlibro.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #2 from Roch D'Amour <roch.damour@inlibro.com> ---
Patch doesn't apply for me on master, sorry

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0194055214525619981==--


From bugzilla-daemon@bugs.koha-community.org Sun Apr  8 12:52:44 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Sun, 08 Apr 2018 10:52:41 +0000
Message-ID: <bug-20538-70-KEx2zK9ZoR@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1995324425243053229=="

--===============1995324425243053229==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

Julian Maurice <julian.maurice@biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> ---
Patch rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1995324425243053229==--


From bugzilla-daemon@bugs.koha-community.org Sun Apr  8 12:52:52 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Sun, 08 Apr 2018 10:52:20 +0000
Message-ID: <bug-20538-70-AVIxLDk1Q0@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7117071925486596376=="

--===============7117071925486596376==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

Julian Maurice <julian.maurice@biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73791|0                           |1
        is obsolete|                            |

--- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> ---
Created attachment 73836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73836&action=edit
Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere

Having to write [% KOHA_VERSION %] for each url is bad because:
- It's easily forgettable when adding new <script> or <link>
- It prevents grep'ing for the full filename
- It violates the DRY principle
- If at some point we want to change the "force js and css reload"
  mechanism, it will be tedious

This patch:
- adds a Template::Toolkit plugin that generates <script> and
  <link> tags for JS and CSS files, and inserts automatically the Koha
  version in the filename
- use the new plugin to remove all occurences of [% KOHA_VERSION %]
- remove the code that was adding KOHA_VERSION as a template variable

Test plan:
1. Apply patch
2. Go to several different pages in Koha (opac and intranet) while
   checking your browser's dev tools (there should be no 404 for JS and
   CSS files, and the Koha version should appear in filenames) and the
   server logs (there should be no "File not found")
3. `git grep KOHA_VERSION` should return nothing
4. prove t/db_dependent/Koha/Template/Plugin/Asset.t

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7117071925486596376==--


From bugzilla-daemon@bugs.koha-community.org Sun Apr  8 12:57:19 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Sun, 08 Apr 2018 10:57:16 +0000
Message-ID: <bug-20538-70-Qn5RgmZL1k@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0528163122393838799=="

--===============0528163122393838799==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

--- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> ---
Just in case, the sed commands I used to modify (almost) all templates:

sed -i -E 's/<(script|link) .*(href|src)=["'"'"']((\[%.*?%\])\/)*([^%]*)_\[%
KOHA_VERSION %\]\.(js|css)["'"'"'].*(\/?>|<\/\1>)/[% Asset.\6("\5\.\6") %]/'
**/*.inc **/*.tt

git status --porcelain | grep '^ M' | awk '{print $2}' | xargs -- sed -i '1i[%
USE Asset %]'

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0528163122393838799==--


From bugzilla-daemon@bugs.koha-community.org Thu Apr 12 09:16:21 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Thu, 12 Apr 2018 07:16:17 +0000
Message-ID: <bug-20538-70-F923hKadu6@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7346501791682469971=="

--===============7346501791682469971==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

Josef Moravec <josef.moravec@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7346501791682469971==--


From bugzilla-daemon@bugs.koha-community.org Thu Apr 12 09:16:41 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Thu, 12 Apr 2018 07:16:36 +0000
Message-ID: <bug-20538-70-P2yjobbXbz@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7428089391333290220=="

--===============7428089391333290220==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

Josef Moravec <josef.moravec@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|josef.moravec@gmail.com     |testopia@bugs.koha-communit
                   |                            |y.org

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7428089391333290220==--


From bugzilla-daemon@bugs.koha-community.org Thu Apr 12 09:17:44 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Thu, 12 Apr 2018 07:17:37 +0000
Message-ID: <bug-20538-70-bslAMSUfb7@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1323035603884893937=="

--===============1323035603884893937==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

Josef Moravec <josef.moravec@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1323035603884893937==--


From bugzilla-daemon@bugs.koha-community.org Thu Apr 12 09:17:47 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Thu, 12 Apr 2018 07:17:44 +0000
Message-ID: <bug-20538-70-HcsRnovQb1@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7329988599023110921=="

--===============7329988599023110921==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

Josef Moravec <josef.moravec@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73836|0                           |1
        is obsolete|                            |

--- Comment #6 from Josef Moravec <josef.moravec@gmail.com> ---
Created attachment 74048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74048&action=edit
Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere

Having to write [% KOHA_VERSION %] for each url is bad because:
- It's easily forgettable when adding new <script> or <link>
- It prevents grep'ing for the full filename
- It violates the DRY principle
- If at some point we want to change the "force js and css reload"
  mechanism, it will be tedious

This patch:
- adds a Template::Toolkit plugin that generates <script> and
  <link> tags for JS and CSS files, and inserts automatically the Koha
  version in the filename
- use the new plugin to remove all occurences of [% KOHA_VERSION %]
- remove the code that was adding KOHA_VERSION as a template variable

Test plan:
1. Apply patch
2. Go to several different pages in Koha (opac and intranet) while
   checking your browser's dev tools (there should be no 404 for JS and
   CSS files, and the Koha version should appear in filenames) and the
   server logs (there should be no "File not found")
3. `git grep KOHA_VERSION` should return nothing
4. prove t/db_dependent/Koha/Template/Plugin/Asset.t

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7329988599023110921==--


From bugzilla-daemon@bugs.koha-community.org Thu Apr 12 09:17:56 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Thu, 12 Apr 2018 07:17:47 +0000
Message-ID: <bug-20538-70-uGHbVBxePw@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2263159148201631883=="

--===============2263159148201631883==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

--- Comment #7 from Josef Moravec <josef.moravec@gmail.com> ---
Created attachment 74049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74049&action=edit
Bug 20538: (follow-up) Update discharges request page with Asset plugin

This is follow-up of bug 20524

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2263159148201631883==--


From bugzilla-daemon@bugs.koha-community.org Thu Apr 12 09:20:23 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Thu, 12 Apr 2018 07:20:18 +0000
Message-ID: <bug-20538-70-hEuoQcETnf@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1367241964119957936=="

--===============1367241964119957936==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20538

--- Comment #8 from Josef Moravec <josef.moravec@gmail.com> ---
I started to write a rule for coding guidelines here:
https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML8:_use_Asset_TT_pl=
ugin_for_linking_javascript_and_css_files

feel free to update it and we can discuss it on the next meeting

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============1367241964119957936==--


From bugzilla-daemon@bugs.koha-community.org Thu Apr 12 10:20:34 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Thu, 12 Apr 2018 08:20:31 +0000
Message-ID: <bug-20538-70-5nYDFLxoQR@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2168554538548148278=="

--===============2168554538548148278==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer@bsz-bw.de
         QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de
                   |y.org                       |

--- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
There are some FAILs in the QA script, but I assume they are just side
effects/false positives for this patch. Maybe something to look into later:

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-MARCdetail.tt
   FAIL   forbidden patterns
                forbidden pattern: opac-tmpl should certainly replaced with [%
interface %] (line 67)
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   OK     valid_template

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt
   FAIL   forbidden patterns
                forbidden pattern: opac-tmpl should certainly replaced with [%
interface %] (line 132)
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   OK     valid_template
...

1) Is the copyright statement correct?
+package Koha::Template::Plugin::Asset;
+
+# Copyright Marc Véron / marc veron ag, Switzerland

2) Not blocker, but a note: Need to update qa tools!

Can you quickly check 1) please?

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2168554538548148278==--


From bugzilla-daemon@bugs.koha-community.org Thu Apr 12 10:31:40 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Thu, 12 Apr 2018 08:31:37 +0000
Message-ID: <bug-20538-70-WYJSV4J5bF@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1255177610366734135=="

--===============1255177610366734135==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

--- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> ---
Created attachment 74053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74053&action=edit
Bug 20538: Fix copyright notice in Asset.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1255177610366734135==--


From bugzilla-daemon@bugs.koha-community.org Thu Apr 12 10:31:51 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Thu, 12 Apr 2018 08:31:41 +0000
Message-ID: <bug-20538-70-NcJdwDDA8Q@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9075648656481088145=="

--===============9075648656481088145==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

--- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> ---
Created attachment 74054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74054&action=edit
Bug 20538: Fix 2 JS paths

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============9075648656481088145==--


From bugzilla-daemon@bugs.koha-community.org Thu Apr 12 10:33:29 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Thu, 12 Apr 2018 08:33:26 +0000
Message-ID: <bug-20538-70-F3xkv0Gq3t@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8260473946487687328=="

--===============8260473946487687328==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

Julian Maurice <julian.maurice@biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> ---
(In reply to Katrin Fischer from comment #9)
> There are some FAILs in the QA script, but I assume they are just side
> effects/false positives for this patch. Maybe something to look into later:
> 
>  FAIL	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-MARCdetail.tt
>    FAIL	  forbidden patterns
> 		forbidden pattern: opac-tmpl should certainly replaced with [% interface
> %] (line 67)
>    OK	  git manipulation
>    OK	  spelling
>    OK	  tt_valid
>    OK	  valid_template
> 
>  FAIL	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt
>    FAIL	  forbidden patterns
> 		forbidden pattern: opac-tmpl should certainly replaced with [% interface
> %] (line 132)
>    OK	  git manipulation
>    OK	  spelling
>    OK	  tt_valid
>    OK	  valid_template
> ...
These ones are true positives. Fixed in the last patch

> 
> 1) Is the copyright statement correct?
> +package Koha::Template::Plugin::Asset;
> +
> +# Copyright Marc Véron / marc veron ag, Switzerland
> 
> 2) Not blocker, but a note: Need to update qa tools!
> 
> Can you quickly check 1) please?
Done. Thanks for catching that.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8260473946487687328==--


From bugzilla-daemon@bugs.koha-community.org Thu Apr 12 11:37:47 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Thu, 12 Apr 2018 09:37:42 +0000
Message-ID: <bug-20538-70-AYrsYlgkjM@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2156789668578593345=="

--===============2156789668578593345==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

--- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> ---
Created attachment 74056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74056&action=edit
Bug 20538: Move categories.js out of language directory

This was the last js/css file inside a language directory

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2156789668578593345==--


From bugzilla-daemon@bugs.koha-community.org Thu Apr 12 11:37:49 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Thu, 12 Apr 2018 09:37:46 +0000
Message-ID: <bug-20538-70-a2lbQyS2DJ@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7814873804527965051=="

--===============7814873804527965051==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

--- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> ---
Created attachment 74057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74057&action=edit
Bug 20538: Add POD for Asset.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7814873804527965051==--


From bugzilla-daemon@bugs.koha-community.org Thu Apr 12 11:40:29 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Thu, 12 Apr 2018 09:39:59 +0000
Message-ID: <bug-20538-70-DuU43JzOLI@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1691481180346468001=="

--===============1691481180346468001==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

--- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> ---
I wrote a little patch for qa-test-tools to avoid all the 'File not found'
warnings. You can found it here :
https://github.com/jajm/koha-qa-test-tools/tree/bug_20538

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1691481180346468001==--


From bugzilla-daemon@bugs.koha-community.org Thu Apr 12 11:51:13 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Thu, 12 Apr 2018 09:51:06 +0000
Message-ID: <bug-20538-70-554hwExciC@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4061758321342825426=="

--===============4061758321342825426==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74048|0                           |1
        is obsolete|                            |

--- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Created attachment 74058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74058&action=edit
Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere

Having to write [% KOHA_VERSION %] for each url is bad because:
- It's easily forgettable when adding new <script> or <link>
- It prevents grep'ing for the full filename
- It violates the DRY principle
- If at some point we want to change the "force js and css reload"
  mechanism, it will be tedious

This patch:
- adds a Template::Toolkit plugin that generates <script> and
  <link> tags for JS and CSS files, and inserts automatically the Koha
  version in the filename
- use the new plugin to remove all occurences of [% KOHA_VERSION %]
- remove the code that was adding KOHA_VERSION as a template variable

Test plan:
1. Apply patch
2. Go to several different pages in Koha (opac and intranet) while
   checking your browser's dev tools (there should be no 404 for JS and
   CSS files, and the Koha version should appear in filenames) and the
   server logs (there should be no "File not found")
3. `git grep KOHA_VERSION` should return nothing
4. prove t/db_dependent/Koha/Template/Plugin/Asset.t

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4061758321342825426==--


From bugzilla-daemon@bugs.koha-community.org Thu Apr 12 11:51:17 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Thu, 12 Apr 2018 09:51:10 +0000
Message-ID: <bug-20538-70-ZBATBuagCk@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0607318089668159888=="

--===============0607318089668159888==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74049|0                           |1
        is obsolete|                            |

--- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Created attachment 74059
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74059&action=edit
Bug 20538: (follow-up) Update discharges request page with Asset plugin

This is follow-up of bug 20524

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0607318089668159888==--


From bugzilla-daemon@bugs.koha-community.org Thu Apr 12 11:51:27 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Thu, 12 Apr 2018 09:51:13 +0000
Message-ID: <bug-20538-70-HkAm7UdWMG@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6877778147685523717=="

--===============6877778147685523717==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74053|0                           |1
        is obsolete|                            |

--- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Created attachment 74060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74060&action=edit
Bug 20538: Fix copyright notice in Asset.pm

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6877778147685523717==--


From bugzilla-daemon@bugs.koha-community.org Thu Apr 12 11:51:36 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Thu, 12 Apr 2018 09:51:17 +0000
Message-ID: <bug-20538-70-7jWnK6RuYW@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1552687799258053879=="

--===============1552687799258053879==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74054|0                           |1
        is obsolete|                            |

--- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Created attachment 74061
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74061&action=edit
Bug 20538: Fix 2 JS paths

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1552687799258053879==--


From bugzilla-daemon@bugs.koha-community.org Thu Apr 12 11:51:45 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Thu, 12 Apr 2018 09:51:21 +0000
Message-ID: <bug-20538-70-Shuocbyxio@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4078343761695663845=="

--===============4078343761695663845==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74056|0                           |1
        is obsolete|                            |

--- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Created attachment 74062
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74062&action=edit
Bug 20538: Move categories.js out of language directory

This was the last js/css file inside a language directory

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4078343761695663845==--


From bugzilla-daemon@bugs.koha-community.org Thu Apr 12 11:51:48 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Thu, 12 Apr 2018 09:51:24 +0000
Message-ID: <bug-20538-70-ftC8nkOVOL@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0328780542026813052=="

--===============0328780542026813052==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74057|0                           |1
        is obsolete|                            |

--- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Created attachment 74063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74063&action=edit
Bug 20538: Add POD for Asset.pm

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0328780542026813052==--


From bugzilla-daemon@bugs.koha-community.org Thu Apr 12 12:29:27 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Thu, 12 Apr 2018 10:29:23 +0000
Message-ID: <bug-20538-70-KBHT305vRh@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7126729416134603679=="

--===============7126729416134603679==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7126729416134603679==--


From bugzilla-daemon@bugs.koha-community.org Fri Apr 13 17:08:52 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Fri, 13 Apr 2018 15:08:23 +0000
Message-ID: <bug-20538-70-oHL9PUENX2@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4437980914470198974=="

--===============4437980914470198974==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20538

--- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org=
> ---
Created attachment 74171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D74171&action=3D=
edit
Bug 20538: ->tag is private - tell it explicitly

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============4437980914470198974==--


From bugzilla-daemon@bugs.koha-community.org Fri Apr 13 18:42:06 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Fri, 13 Apr 2018 16:42:01 +0000
Message-ID: <bug-20538-70-NssVVU4OEn@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3460734501124380838=="

--===============3460734501124380838==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20538

Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org=
> ---
Pushed to master for 18.05, thanks to everybody involved!

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============3460734501124380838==--


From bugzilla-daemon@bugs.koha-community.org Tue Apr 24 18:12:07 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Tue, 24 Apr 2018 16:12:00 +0000
Message-ID: <bug-20538-70-nvoOeSrAgB@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6472050487019129500=="

--===============6472050487019129500==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20538

Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_18_05_candidate,        |additional_work_needed
                   |RM_priority                 |

--- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org=
> ---
Could you take a look at xt/author/valid-templates.t ?
There are too many errors:

File not found : lib/emoji-picker/js/emoji-picker.js at
/home/vagrant/kohaclone/Koha/Template/Plugin/Asset.pm line 83.
File not found : js/basket.js at
/home/vagrant/kohaclone/Koha/Template/Plugin/Asset.pm line 83.
File not found : js/tags.js at
/home/vagrant/kohaclone/Koha/Template/Plugin/Asset.pm line 83.
File not found : js/datatables.js at
/home/vagrant/kohaclone/Koha/Template/Plugin/Asset.pm line 83.

[...]

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============6472050487019129500==--


From bugzilla-daemon@bugs.koha-community.org Wed Apr 25 09:22:31 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Wed, 25 Apr 2018 07:22:28 +0000
Message-ID: <bug-20538-70-ae3tyIXQRo@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8520816204371605753=="

--===============8520816204371605753==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

--- Comment #25 from Julian Maurice <julian.maurice@biblibre.com> ---
Created attachment 74835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74835&action=edit
Bug 20538: Prevent warnings in xt/author/valid-templates.t

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8520816204371605753==--


From bugzilla-daemon@bugs.koha-community.org Wed Apr 25 16:51:16 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Wed, 25 Apr 2018 14:51:08 +0000
Message-ID: <bug-20538-70-QYfGSURCmg@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6415428651389337759=="

--===============6415428651389337759==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20538

--- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org=
> ---
(In reply to Julian Maurice from comment #25)
> Created attachment 74835 [details] [review]
> Bug 20538: Prevent warnings in xt/author/valid-templates.t

Pushed to master, thanks Julian!

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============6415428651389337759==--


From bugzilla-daemon@bugs.koha-community.org Fri May 18 18:16:50 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Fri, 18 May 2018 16:16:44 +0000
Message-ID: <bug-20538-70-7wP1EeQmON@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7106005654263677105=="

--===============7106005654263677105==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed      |

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7106005654263677105==--


From bugzilla-daemon@bugs.koha-community.org Mon May 21 19:36:38 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Mon, 21 May 2018 17:36:35 +0000
Message-ID: <bug-20538-70-mUnZZ6NXuC@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7023759149186316909=="

--===============7023759149186316909==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

Nick Clemens <nick@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick@bywatersolutions.com
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #27 from Nick Clemens <nick@bywatersolutions.com> ---
Enhancement, not backported for 17.11

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7023759149186316909==--


From bugzilla-daemon@bugs.koha-community.org Mon May 28 23:57:07 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Mon, 28 May 2018 21:57:02 +0000
Message-ID: <bug-20538-70-pT0MMzoErC@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5221077039482684384=="

--===============5221077039482684384==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20538

Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20761


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D20761
[Bug 20761] Advanced Cataloging Editor - Rancor - Some js files are not fetch=
ed
using Asset
--=20
You are receiving this mail because:
You are watching all bug changes.

--===============5221077039482684384==--


From bugzilla-daemon@bugs.koha-community.org Thu Sep  6 20:23:28 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Thu, 06 Sep 2018 18:23:18 +0000
Message-ID: <bug-20538-70-KFvws73YBz@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3016984043710331315=="

--===============3016984043710331315==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

M. Tompsett <mtompset@hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |indradg@l2c2.co.in

--- Comment #28 from M. Tompsett <mtompset@hotmail.com> ---
*** Bug 20066 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3016984043710331315==--


From bugzilla-daemon@bugs.koha-community.org Wed Oct 17 14:37:41 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION	%]
 everywhere
Date: Wed, 17 Oct 2018 12:37:37 +0000
Message-ID: <bug-20538-70-baOM66RfYx@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-20538-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6767921177387666762=="

--===============6767921177387666762==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

Nick Clemens <nick@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21583


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21583
[Bug 21583] Novelist Select staff client not working in staff client -
ns2init.js not loading
-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6767921177387666762==--