From bugzilla-daemon@bugs.koha-community.org Thu Jun 27 15:24:17 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 23226] New: Remove type attribute from script	tags:
 Cataloging
Date: Thu, 27 Jun 2019 13:23:46 +0000
Message-ID: <bug-23226-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6590513113186738384=="

--===============6590513113186738384==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23226

            Bug ID: 23226
           Summary: Remove type attribute from script tags: Cataloging
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Keywords: Academy
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard@myacpl.org
          Reporter: oleonard@myacpl.org
        QA Contact: testopia@bugs.koha-community.org
                CC: testopia@bugs.koha-community.org
            Blocks: 22956

This patch will remove the obsolete "type" attribute from <script> tags in the
following cataloging templates:

 - intranet-tmpl\prog\en\modules\cataloguing\addbooks.tt
 - intranet-tmpl\prog\en\modules\cataloguing\z3950_auth_search.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22956
[Bug 22956] Omnibus: Remove type attribute from script tags
-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6590513113186738384==--


From bugzilla-daemon@bugs.koha-community.org Thu Jun 27 15:32:50 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 23226] Remove type attribute from script tags:	Cataloging
Date: Thu, 27 Jun 2019 13:32:47 +0000
Message-ID: <bug-23226-70-qhUADCVwMn@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23226-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3165900909112078200=="

--===============3165900909112078200==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23226

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3165900909112078200==--


From bugzilla-daemon@bugs.koha-community.org Thu Jun 27 15:33:22 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 23226] Remove type attribute from script tags:	Cataloging
Date: Thu, 27 Jun 2019 13:32:50 +0000
Message-ID: <bug-23226-70-oWSsGhiRP4@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23226-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2383561925384263022=="

--===============2383561925384263022==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23226

--- Comment #1 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 91053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91053&action=edit
Bug 23226: Remove type attribute from script tags: Cataloging

This patch removes the "type" attribute from <script> tags one
cataloging and one authorities template.

To test, apply the patch and confirm that examples of affected pages
work properly without any JavaScript errors in the browser console:

 - Cataloging -> Cataloging home page
 - Cataloging -> Cataloging home page -> Search results
 - Authorities -> New authority -> New from Z39.50/SRU

Validating the HTML source of any of these pages should return no errors
related to the "type" attribute.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2383561925384263022==--


From bugzilla-daemon@bugs.koha-community.org Fri Jul 19 21:30:32 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 23226] Remove type attribute from script tags:	Cataloging
Date: Fri, 19 Jul 2019 19:30:29 +0000
Message-ID: <bug-23226-70-ztDhpDr4Sj@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23226-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8353762720547585003=="

--===============8353762720547585003==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23226

Frédérik Chénier <frederik.chenier@inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8353762720547585003==--


From bugzilla-daemon@bugs.koha-community.org Fri Jul 19 21:30:38 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 23226] Remove type attribute from script tags:	Cataloging
Date: Fri, 19 Jul 2019 19:30:35 +0000
Message-ID: <bug-23226-70-kc2EjSKVpS@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23226-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2029431686944992950=="

--===============2029431686944992950==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23226

Frédérik Chénier <frederik.chenier@inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91053|0                           |1
        is obsolete|                            |

--- Comment #2 from Frédérik Chénier <frederik.chenier@inlibro.com> ---
Created attachment 91667
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91667&action=edit
Bug 23226: Remove type attribute from script tags: Cataloging

This patch removes the "type" attribute from <script> tags one
cataloging and one authorities template.

To test, apply the patch and confirm that examples of affected pages
work properly without any JavaScript errors in the browser console:

 - Cataloging -> Cataloging home page
 - Cataloging -> Cataloging home page -> Search results
 - Authorities -> New authority -> New from Z39.50/SRU

Validating the HTML source of any of these pages should return no errors
related to the "type" attribute.

Signed-off-by: frederik chenier <frederik.chenier@inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2029431686944992950==--


From bugzilla-daemon@bugs.koha-community.org Fri Jul 26 14:59:05 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 23226] Remove type attribute from script tags:	Cataloging
Date: Fri, 26 Jul 2019 12:59:02 +0000
Message-ID: <bug-23226-70-JLAln1i0fS@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23226-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7508879453405539890=="

--===============7508879453405539890==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23226

Nick Clemens <nick@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7508879453405539890==--


From bugzilla-daemon@bugs.koha-community.org Fri Jul 26 14:59:14 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 23226] Remove type attribute from script tags:	Cataloging
Date: Fri, 26 Jul 2019 12:59:05 +0000
Message-ID: <bug-23226-70-wAxFY6dx2j@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23226-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5294346242447571750=="

--===============5294346242447571750==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23226

Nick Clemens <nick@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91667|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick@bywatersolutions.com> ---
Created attachment 91809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91809&action=edit
Bug 23226: Remove type attribute from script tags: Cataloging

This patch removes the "type" attribute from <script> tags one
cataloging and one authorities template.

To test, apply the patch and confirm that examples of affected pages
work properly without any JavaScript errors in the browser console:

 - Cataloging -> Cataloging home page
 - Cataloging -> Cataloging home page -> Search results
 - Authorities -> New authority -> New from Z39.50/SRU

Validating the HTML source of any of these pages should return no errors
related to the "type" attribute.

Signed-off-by: frederik chenier <frederik.chenier@inlibro.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5294346242447571750==--


From bugzilla-daemon@bugs.koha-community.org Fri Jul 26 17:19:33 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 23226] Remove type attribute from script tags:	Cataloging
Date: Fri, 26 Jul 2019 15:19:23 +0000
Message-ID: <bug-23226-70-zLIP4xEAZl@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23226-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0369066355769252036=="

--===============0369066355769252036==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23226

Martin Renvoize <martin.renvoize@ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |19.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0369066355769252036==--


From bugzilla-daemon@bugs.koha-community.org Fri Jul 26 17:19:35 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 23226] Remove type attribute from script tags:	Cataloging
Date: Fri, 26 Jul 2019 15:19:25 +0000
Message-ID: <bug-23226-70-Z9k3YHRE8S@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23226-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6135890437076018768=="

--===============6135890437076018768==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23226

--- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6135890437076018768==--


From bugzilla-daemon@bugs.koha-community.org Fri Aug  9 14:52:02 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 23226] Remove type attribute from script tags: Cataloging
Date: Fri, 09 Aug 2019 12:52:01 +0000
Message-ID: <bug-23226-70-7IG3eRVyfX@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23226-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4092050991193757840=="

--===============4092050991193757840==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23226

Fridolin SOMERS <fridolin.somers@biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|19.11.00                    |19.11.00,19.05.03
        released in|                            |
                 CC|                            |fridolin.somers@biblibre.co
                   |                            |m
             Status|Pushed to master            |Pushed to stable

--- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> ---
Pushed to 19.05.x for 19.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4092050991193757840==--


From bugzilla-daemon@bugs.koha-community.org Tue Sep  3 23:19:30 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 23226] Remove type attribute from script tags: Cataloging
Date: Tue, 03 Sep 2019 21:19:30 +0000
Message-ID: <bug-23226-70-UBjqQBHEZp@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23226-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8924248320128555309=="

--===============8924248320128555309==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23226

Lucas Gass <lucas@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas@bywatersolutions.com

--- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> ---
backported to 18.11.x for 18.11.10

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8924248320128555309==--