From bugzilla-daemon@bugs.koha-community.org Tue Jun 6 00:49:46 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33902] New: On opac-detail.tt the libraryInfoModal is outside of HTML tags Date: Mon, 05 Jun 2023 22:49:45 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8358342379163079732==" --===============8358342379163079732== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D33902 Bug ID: 33902 Summary: On opac-detail.tt the libraryInfoModal is outside of HTML tags Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org If you go to OPAC detail and look for the #libraryInfoModal you'll notice it = is outside of the tag. Run the HTML through a validator and it will come back with an error. --=20 You are receiving this mail because: You are watching all bug changes. --===============8358342379163079732==-- From bugzilla-daemon@bugs.koha-community.org Tue Jun 6 00:53:11 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags Date: Mon, 05 Jun 2023 22:53:10 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5991557533967128856==" --===============5991557533967128856== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. --===============5991557533967128856==-- From bugzilla-daemon@bugs.koha-community.org Tue Jun 6 01:04:46 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags Date: Mon, 05 Jun 2023 23:04:45 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5533971579952660581==" --===============5533971579952660581== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============5533971579952660581==-- From bugzilla-daemon@bugs.koha-community.org Tue Jun 6 01:04:56 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags Date: Mon, 05 Jun 2023 23:04:47 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4531972628899273586==" --===============4531972628899273586== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 --- Comment #1 from Lucas Gass --- Created attachment 152017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152017&action=edit Bug 33902: Move modal inside HTML body To test: -Go Administration > Libraries and add a URL for a branch. -Also add some OPAC info: ( via HTML Customizations ) -Now find a record belonging to that branch and bring up the OPAC detail page. -In the holdings table there should be a link under the 'Current library' column. -Clicking it should bring up a modal. -Make sure the modal pops up correctly, can be dismissed, and the 'Visit web site' link works. Nothing about the appearance or behavior of the page should change. -- You are receiving this mail because: You are watching all bug changes. --===============4531972628899273586==-- From bugzilla-daemon@bugs.koha-community.org Tue Jun 6 01:05:07 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags Date: Mon, 05 Jun 2023 23:05:07 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3243661256310657925==" --===============3243661256310657925== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. --===============3243661256310657925==-- From bugzilla-daemon@bugs.koha-community.org Tue Jun 6 01:06:12 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags Date: Mon, 05 Jun 2023 23:06:11 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7606522355385083561==" --===============7606522355385083561== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33897 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 [Bug 33897] Use template wrapper for tabs: OPAC bibliographic detail page -- You are receiving this mail because: You are watching all bug changes. --===============7606522355385083561==-- From bugzilla-daemon@bugs.koha-community.org Tue Jun 6 03:28:26 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags Date: Tue, 06 Jun 2023 01:28:25 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2973659280430786175==" --===============2973659280430786175== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============2973659280430786175==-- From bugzilla-daemon@bugs.koha-community.org Tue Jun 6 03:28:36 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags Date: Tue, 06 Jun 2023 01:28:28 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3406049918070657953==" --===============3406049918070657953== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152017|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 152022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152022&action=edit Bug 33902: Move modal inside HTML body To test: -Go Administration > Libraries and add a URL for a branch. -Also add some OPAC info: ( via HTML Customizations ) -Now find a record belonging to that branch and bring up the OPAC detail page. -In the holdings table there should be a link under the 'Current library' column. -Clicking it should bring up a modal. -Make sure the modal pops up correctly, can be dismissed, and the 'Visit web site' link works. Nothing about the appearance or behavior of the page should change. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. --===============3406049918070657953==-- From bugzilla-daemon@bugs.koha-community.org Tue Jun 6 03:38:42 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags Date: Tue, 06 Jun 2023 01:38:41 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1285009969751982607==" --===============1285009969751982607== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This moves the HTML for the release notes| |pop-up window with the | |information for a library | |(where it exists) on the | |OPAC detail page inside the | | tag so that it | |validates correctly. There | |is no change to the | |appearance or behavior of | |the page. -- You are receiving this mail because: You are watching all bug changes. --===============1285009969751982607==-- From bugzilla-daemon@bugs.koha-community.org Tue Jun 6 07:57:35 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags Date: Tue, 06 Jun 2023 05:57:35 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6790217811964930496==" --===============6790217811964930496== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============6790217811964930496==-- From bugzilla-daemon@bugs.koha-community.org Tue Jun 6 07:57:46 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags Date: Tue, 06 Jun 2023 05:57:37 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0457896223776202120==" --===============0457896223776202120== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152022|0 |1 is obsolete| | --- Comment #3 from David Cook --- Created attachment 152031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152031&action=edit Bug 33902: Move modal inside HTML body To test: -Go Administration > Libraries and add a URL for a branch. -Also add some OPAC info: ( via HTML Customizations ) -Now find a record belonging to that branch and bring up the OPAC detail page. -In the holdings table there should be a link under the 'Current library' column. -Clicking it should bring up a modal. -Make sure the modal pops up correctly, can be dismissed, and the 'Visit web site' link works. Nothing about the appearance or behavior of the page should change. Signed-off-by: David Nind Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. --===============0457896223776202120==-- From bugzilla-daemon@bugs.koha-community.org Tue Jun 6 08:08:34 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags Date: Tue, 06 Jun 2023 06:08:28 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1300782299845031557==" --===============1300782299845031557== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | -- You are receiving this mail because: You are watching all bug changes. --===============1300782299845031557==-- From bugzilla-daemon@bugs.koha-community.org Wed Jun 7 20:29:41 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags Date: Wed, 07 Jun 2023 18:29:24 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2935148205213326223==" --===============2935148205213326223== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |BLOCKED --- Comment #4 from Tomás Cohen Arazi --- The dependency is not PQA. Can someone check? -- You are receiving this mail because: You are watching all bug changes. --===============2935148205213326223==-- From bugzilla-daemon@bugs.koha-community.org Wed Jun 7 20:48:17 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags Date: Wed, 07 Jun 2023 18:48:16 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4631960326207326590==" --===============4631960326207326590== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Depends on|33897 | --- Comment #5 from Lucas Gass --- (In reply to Tomás Cohen Arazi from comment #4) > The dependency is not PQA. Can someone check? I am removing the dependency. Neither of these patch sets conflict with one another. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 [Bug 33897] Use template wrapper for tabs: OPAC bibliographic detail page -- You are receiving this mail because: You are watching all bug changes. --===============4631960326207326590==-- From bugzilla-daemon@bugs.koha-community.org Wed Jun 7 21:50:12 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags Date: Wed, 07 Jun 2023 19:49:38 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8738468984814345920==" --===============8738468984814345920== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. --===============8738468984814345920==-- From bugzilla-daemon@bugs.koha-community.org Wed Jun 7 21:50:22 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags Date: Wed, 07 Jun 2023 19:49:39 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4154250300926733174==" --===============4154250300926733174== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. --===============4154250300926733174==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 9 21:07:01 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags Date: Fri, 09 Jun 2023 19:06:13 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1431469532176765648==" --===============1431469532176765648== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes. --===============1431469532176765648==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 9 21:07:11 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags Date: Fri, 09 Jun 2023 19:06:15 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2407696422817690570==" --===============2407696422817690570== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. --===============2407696422817690570==-- From bugzilla-daemon@bugs.koha-community.org Mon Jun 12 13:56:01 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags Date: Mon, 12 Jun 2023 11:55:44 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3017569828666808086==" --===============3017569828666808086== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.01 |23.11.00,23.05.01,22.11.07 released in| | -- You are receiving this mail because: You are watching all bug changes. --===============3017569828666808086==-- From bugzilla-daemon@bugs.koha-community.org Mon Jun 12 13:56:11 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags Date: Mon, 12 Jun 2023 11:55:46 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2656353493519758216==" --===============2656353493519758216== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 --- Comment #8 from Matt Blenkinsop --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. --===============2656353493519758216==--