From bugzilla-daemon@bugs.koha-community.org Fri Aug 31 18:19:06 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] New: Update two-column templates with
 Bootstrap grid: Catalog
Date: Fri, 31 Aug 2018 16:19:02 +0000
Message-ID: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4089893372584208155=="

--===============4089893372584208155==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

            Bug ID: 21304
           Summary: Update two-column templates with Bootstrap grid:
                    Catalog
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard@myacpl.org
          Reporter: oleonard@myacpl.org
        QA Contact: testopia@bugs.koha-community.org
                CC: testopia@bugs.koha-community.org
            Blocks: 20654

This patch will convert even more acquisitions templates to use the Bootstrap
grid:

 - ISBDdetail.tt
 - MARCdetail.tt
 - detail.tt
 - imageviewer.tt
 - issuehistory.tt
 - labeledMARCdetail.tt
 - moredetail.tt
 - results.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654
[Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid
-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4089893372584208155==--


From bugzilla-daemon@bugs.koha-community.org Fri Aug 31 19:07:04 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Fri, 31 Aug 2018 17:07:01 +0000
Message-ID: <bug-21304-70-cJarMdbMKH@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4520087989637038918=="

--===============4520087989637038918==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

--- Comment #1 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 78343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78343&action=edit
Bug 21304: Update two-column templates with Bootstrap grid: Catalog

This patch modifies several catalog templates to use the Bootstrap grid
instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Catalog -> Search
   - Search results
     - Bibliographic details
     - MARC details (viewMARC preference enabled)
     - Labeled MARC details (viewLabeledMARC preference enabled)
     - ISBD (viewISBD preference enabled)
     - Items
     - Checkout history

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4520087989637038918==--


From bugzilla-daemon@bugs.koha-community.org Fri Aug 31 19:07:28 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Fri, 31 Aug 2018 17:06:58 +0000
Message-ID: <bug-21304-70-gl4VmlSLN0@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7716777471358634542=="

--===============7716777471358634542==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7716777471358634542==--


From bugzilla-daemon@bugs.koha-community.org Mon Sep  3 15:04:30 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Mon, 03 Sep 2018 13:04:23 +0000
Message-ID: <bug-21304-70-HOjFPjMHyt@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9215582927634371540=="

--===============9215582927634371540==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Cab Vinton <bibliwho@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bibliwho@gmail.com

--- Comment #2 from Cab Vinton <bibliwho@gmail.com> ---
Created attachment 78375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78375&action=edit
Next record glitch

All looks good except for the Return to Results display. For all examples Next
Record is offset on the next line rather than on the same line as Previous
Record.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============9215582927634371540==--


From bugzilla-daemon@bugs.koha-community.org Wed Sep  5 16:36:12 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Wed, 05 Sep 2018 14:36:09 +0000
Message-ID: <bug-21304-70-OU3296ppYp@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7045711968604292695=="

--===============7045711968604292695==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

--- Comment #3 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 78437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78437&action=edit
Bug 21304: (follow-up) Fix style of search results browser

This follow-up revises the style of the search result browser in the
staff client, making it behave better at smaller browser widths.

The patch also makes a couple of ESLint-prompted changes to browser.js

To test, apply the patch and regenerate CSS.

 - Perform a catalog search in the staff client.
 - Click on one of the search results.
 - On the bibliographic detail page there should be results browsing
   controls in the left-hand sidebar.
   - Resize the browser window and confirm that the controls work well
     at various sizes.
   - Test with both the first and last search result.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7045711968604292695==--


From bugzilla-daemon@bugs.koha-community.org Thu Sep  6 16:50:33 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Thu, 06 Sep 2018 14:50:00 +0000
Message-ID: <bug-21304-70-BzTz76QNP7@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7199278243119656777=="

--===============7199278243119656777==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

pierre-marc.thibault@inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pierre-marc.thibault@inlibr
                   |                            |o.com

--- Comment #4 from pierre-marc.thibault@inlibro.com ---
Created attachment 78491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78491&action=edit
Next button of the controls in an awkward position.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7199278243119656777==--


From bugzilla-daemon@bugs.koha-community.org Thu Sep  6 16:57:26 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Thu, 06 Sep 2018 14:56:56 +0000
Message-ID: <bug-21304-70-2R3iOYnw6y@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7120541233056703661=="

--===============7120541233056703661==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

pierre-marc.thibault@inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #5 from pierre-marc.thibault@inlibro.com ---
Controls have been tested with the first and last result. The next button is
still in an awkward position when the size is small. 

When the Next button is inactive and its area become bigger, not all the area
is colored in grey because the grey area width is fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7120541233056703661==--


From bugzilla-daemon@bugs.koha-community.org Thu Sep  6 18:06:32 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Thu, 06 Sep 2018 16:06:27 +0000
Message-ID: <bug-21304-70-n7oTdvUBnh@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7193654130356919543=="

--===============7193654130356919543==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

pierre-marc.thibault@inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #6 from pierre-marc.thibault@inlibro.com ---
Sorry. I assumed CSS files has been changed while SCSS has been and oversee
your mention to regenerate CSS. Tests will be redo to validate the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7193654130356919543==--


From bugzilla-daemon@bugs.koha-community.org Thu Sep  6 20:08:55 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Thu, 06 Sep 2018 18:08:30 +0000
Message-ID: <bug-21304-70-ZxLqAxd2fK@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9116692667596080028=="

--===============9116692667596080028==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

--- Comment #7 from pierre-marc.thibault@inlibro.com ---
Created attachment 78494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78494&action=edit
Previous and Next buttons a little hidden at a certain size.

There is no longer a problem with the Next button at an awkward position.
However, when the browser reach a certain size, the buttons text Previous and
Next can be partially covered.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============9116692667596080028==--


From bugzilla-daemon@bugs.koha-community.org Thu Sep  6 20:09:45 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Thu, 06 Sep 2018 18:09:42 +0000
Message-ID: <bug-21304-70-cCIapBnS1g@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7101528905170720594=="

--===============7101528905170720594==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

pierre-marc.thibault@inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7101528905170720594==--


From bugzilla-daemon@bugs.koha-community.org Thu Sep 20 20:35:03 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Thu, 20 Sep 2018 18:35:00 +0000
Message-ID: <bug-21304-70-CluwEpeP8x@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3080047335178283076=="

--===============3080047335178283076==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3080047335178283076==--


From bugzilla-daemon@bugs.koha-community.org Thu Sep 20 20:35:08 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Thu, 20 Sep 2018 18:35:03 +0000
Message-ID: <bug-21304-70-sMCArKd3v3@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6523308521696302906=="

--===============6523308521696302906==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78343|0                           |1
        is obsolete|                            |
  Attachment #78437|0                           |1
        is obsolete|                            |

--- Comment #8 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 79184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79184&action=edit
Bug 21304: (follow-up) Fix style of search results browser

This follow-up revises the style of the search result browser in the
staff client, making it behave better at smaller browser widths.

The patch also makes a couple of ESLint-prompted changes to browser.js

To test, apply the patch and regenerate CSS.

 - Perform a catalog search in the staff client.
 - Click on one of the search results.
 - On the bibliographic detail page there should be results browsing
   controls in the left-hand sidebar.
   - Resize the browser window and confirm that the controls work well
     at various sizes.
   - Test with both the first and last search result.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6523308521696302906==--


From bugzilla-daemon@bugs.koha-community.org Thu Sep 20 20:36:03 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Thu, 20 Sep 2018 18:35:33 +0000
Message-ID: <bug-21304-70-5od4SB0zxx@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4541332593444307774=="

--===============4541332593444307774==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78343|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4541332593444307774==--


From bugzilla-daemon@bugs.koha-community.org Thu Oct 11 14:50:13 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Thu, 11 Oct 2018 12:49:42 +0000
Message-ID: <bug-21304-70-FPZeVbrlTG@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4800471405264691676=="

--===============4800471405264691676==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78343|0                           |1
        is obsolete|                            |
  Attachment #79184|0                           |1
        is obsolete|                            |

--- Comment #9 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 80405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80405&action=edit
Bug 21304: Update two-column templates with Bootstrap grid: Catalog

This patch modifies several catalog templates to use the Bootstrap grid
instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Catalog -> Search
   - Search results
     - Bibliographic details
     - MARC details (viewMARC preference enabled)
     - Labeled MARC details (viewLabeledMARC preference enabled)
     - ISBD (viewISBD preference enabled)
     - Items
     - Checkout history

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4800471405264691676==--


From bugzilla-daemon@bugs.koha-community.org Thu Oct 11 14:50:18 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Thu, 11 Oct 2018 12:49:46 +0000
Message-ID: <bug-21304-70-v20GI4DooL@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0950337134847889387=="

--===============0950337134847889387==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

--- Comment #10 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 80406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80406&action=edit
Bug 21304: (follow-up) Fix style of search results browser

This follow-up revises the style of the search result browser in the
staff client, making it behave better at smaller browser widths.

The patch also makes a couple of ESLint-prompted changes to browser.js

To test, apply the patch and regenerate CSS.

 - Perform a catalog search in the staff client.
 - Click on one of the search results.
 - On the bibliographic detail page there should be results browsing
   controls in the left-hand sidebar.
   - Resize the browser window and confirm that the controls work well
     at various sizes.
   - Test with both the first and last search result.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0950337134847889387==--


From bugzilla-daemon@bugs.koha-community.org Thu Oct 25 20:27:31 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Thu, 25 Oct 2018 18:27:27 +0000
Message-ID: <bug-21304-70-RyaUFfcIwv@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1276729925144992470=="

--===============1276729925144992470==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80405|0                           |1
        is obsolete|                            |
  Attachment #80406|0                           |1
        is obsolete|                            |

--- Comment #11 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 81192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81192&action=edit
Bug 21304: Update two-column templates with Bootstrap grid: Catalog

This patch modifies several catalog templates to use the Bootstrap grid
instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Catalog -> Search
   - Search results
     - Bibliographic details
     - MARC details (viewMARC preference enabled)
     - Labeled MARC details (viewLabeledMARC preference enabled)
     - ISBD (viewISBD preference enabled)
     - Items
     - Checkout history
     - Rota (stock rotation)

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1276729925144992470==--


From bugzilla-daemon@bugs.koha-community.org Thu Oct 25 20:27:34 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Thu, 25 Oct 2018 18:27:30 +0000
Message-ID: <bug-21304-70-89WXcrWnIK@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2030077903080275443=="

--===============2030077903080275443==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

--- Comment #12 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 81193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81193&action=edit
Bug 21304: (follow-up) Fix style of search results browser

This follow-up revises the style of the search result browser in the
staff client, making it behave better at smaller browser widths.

The patch also makes a couple of ESLint-prompted changes to browser.js

To test, apply the patch and regenerate CSS.

 - Perform a catalog search in the staff client.
 - Click on one of the search results.
 - On the bibliographic detail page there should be results browsing
   controls in the left-hand sidebar.
   - Resize the browser window and confirm that the controls work well
     at various sizes.
   - Test with both the first and last search result.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2030077903080275443==--


From bugzilla-daemon@bugs.koha-community.org Fri Nov  9 17:19:27 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Fri, 09 Nov 2018 16:19:24 +0000
Message-ID: <bug-21304-70-TrEiOlpPDt@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7295259735986824249=="

--===============7295259735986824249==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D21304

--- Comment #13 from Josef Moravec <josef.moravec@gmail.com> ---
Comment on attachment 81192
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D81192
Bug 21304: Update two-column templates with Bootstrap grid: Catalog

Review of attachment 81192:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=3Dsplinter.html&b=
ug=3D21304&attachment=3D81192)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
@@ +620,5 @@
> +        </div> <!-- /.col-sm-10.col-sm-push-2 -->
> +
> +        <div class=3D"col-sm-2 col-sm-pull-10">
> +            <aside>
> +                [% INCLUDE 'admin-menu.inc' %]

This should be facets.inc

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============7295259735986824249==--


From bugzilla-daemon@bugs.koha-community.org Fri Nov  9 17:21:07 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Fri, 09 Nov 2018 16:20:37 +0000
Message-ID: <bug-21304-70-m1QJcJs2ls@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8506084184956101095=="

--===============8506084184956101095==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Josef Moravec <josef.moravec@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec@gmail.com

--- Comment #14 from Josef Moravec <josef.moravec@gmail.com> ---
Created attachment 82179
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82179&action=edit
Search results

There is a glitch in search results, see screenshot

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8506084184956101095==--


From bugzilla-daemon@bugs.koha-community.org Fri Nov  9 17:21:21 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Fri, 09 Nov 2018 16:21:19 +0000
Message-ID: <bug-21304-70-yuGTsbUdLV@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6511957436023490429=="

--===============6511957436023490429==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Josef Moravec <josef.moravec@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6511957436023490429==--


From bugzilla-daemon@bugs.koha-community.org Fri Nov  9 18:06:44 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Fri, 09 Nov 2018 17:06:42 +0000
Message-ID: <bug-21304-70-o1OtlHRlre@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6696654211868235475=="

--===============6696654211868235475==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6696654211868235475==--


From bugzilla-daemon@bugs.koha-community.org Fri Nov  9 18:06:55 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Fri, 09 Nov 2018 17:06:46 +0000
Message-ID: <bug-21304-70-g95Oqbizj4@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3816543948711175555=="

--===============3816543948711175555==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81192|0                           |1
        is obsolete|                            |
  Attachment #81193|0                           |1
        is obsolete|                            |

--- Comment #15 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 82186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82186&action=edit
Bug 21304: Update two-column templates with Bootstrap grid: Catalog

This patch modifies several catalog templates to use the Bootstrap grid
instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Catalog -> Search
   - Search results
     - Bibliographic details
     - MARC details (viewMARC preference enabled)
     - Labeled MARC details (viewLabeledMARC preference enabled)
     - ISBD (viewISBD preference enabled)
     - Items
     - Checkout history
     - Rota (stock rotation)

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3816543948711175555==--


From bugzilla-daemon@bugs.koha-community.org Fri Nov  9 18:07:03 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Fri, 09 Nov 2018 17:06:50 +0000
Message-ID: <bug-21304-70-hmtpmClqqD@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2690910437287752186=="

--===============2690910437287752186==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

--- Comment #16 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 82187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82187&action=edit
Bug 21304: (follow-up) Fix style of search results browser

This follow-up revises the style of the search result browser in the
staff client, making it behave better at smaller browser widths.

The patch also makes a couple of ESLint-prompted changes to browser.js

To test, apply the patch and regenerate CSS.

 - Perform a catalog search in the staff client.
 - Click on one of the search results.
 - On the bibliographic detail page there should be results browsing
   controls in the left-hand sidebar.
   - Resize the browser window and confirm that the controls work well
     at various sizes.
   - Test with both the first and last search result.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2690910437287752186==--


From bugzilla-daemon@bugs.koha-community.org Fri Nov  9 18:17:48 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Fri, 09 Nov 2018 17:17:17 +0000
Message-ID: <bug-21304-70-yfJMTCeEKO@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2267389959143372720=="

--===============2267389959143372720==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D21304

--- Comment #17 from Owen Leonard <oleonard@myacpl.org> ---
(In reply to Josef Moravec from comment #14)

> There is a glitch in search results, see screenshot

I've fixed the facet.inc error in the newly-added patches, but I haven't
addressed this issue.

I think this problem only happens after you've changed the width of the brows=
er
and buttons in the toolbar have wrapped to a new line. I think this is a
relatively uncommon sequence of events, and a page refresh fixes it.

This problem needs to be fixed globally for every page which has a floating
toolbar (see also Bug 21751).

I'm leaning towards suggesting we accept this glitch and work on a follow-up,
but I understand if y'all disagree.

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============2267389959143372720==--


From bugzilla-daemon@bugs.koha-community.org Tue Dec  4 20:52:48 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Tue, 04 Dec 2018 19:52:43 +0000
Message-ID: <bug-21304-70-nawOu9TrF3@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5773890320541700051=="

--===============5773890320541700051==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21948


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948
[Bug 21948] Clean up style of item detail page
-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5773890320541700051==--


From bugzilla-daemon@bugs.koha-community.org Thu Dec 20 17:36:28 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Thu, 20 Dec 2018 16:36:25 +0000
Message-ID: <bug-21304-70-hImrRGO28Z@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7560237434906431141=="

--===============7560237434906431141==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22032


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22032
[Bug 22032] Improve local cover image tab on detail page
-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7560237434906431141==--


From bugzilla-daemon@bugs.koha-community.org Mon Feb  4 15:18:50 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Mon, 04 Feb 2019 14:18:47 +0000
Message-ID: <bug-21304-70-ya541VnGU1@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0144181072044986863=="

--===============0144181072044986863==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82186|0                           |1
        is obsolete|                            |
  Attachment #82187|0                           |1
        is obsolete|                            |

--- Comment #18 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 84704
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84704&action=edit
Bug 21304: Update two-column templates with Bootstrap grid: Catalog

This patch modifies several catalog templates to use the Bootstrap grid
instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Catalog -> Search
   - Search results
     - Bibliographic details
     - MARC details (viewMARC preference enabled)
     - Labeled MARC details (viewLabeledMARC preference enabled)
     - ISBD (viewISBD preference enabled)
     - Items
     - Checkout history
     - Rota (stock rotation)

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0144181072044986863==--


From bugzilla-daemon@bugs.koha-community.org Mon Feb  4 15:18:53 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Mon, 04 Feb 2019 14:18:50 +0000
Message-ID: <bug-21304-70-kzLgukTOko@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3525138614099173079=="

--===============3525138614099173079==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

--- Comment #19 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 84705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84705&action=edit
Bug 21304: (follow-up) Fix style of search results browser

This follow-up revises the style of the search result browser in the
staff client, making it behave better at smaller browser widths.

The patch also makes a couple of ESLint-prompted changes to browser.js

To test, apply the patch and regenerate CSS.

 - Perform a catalog search in the staff client.
 - Click on one of the search results.
 - On the bibliographic detail page there should be results browsing
   controls in the left-hand sidebar.
   - Resize the browser window and confirm that the controls work well
     at various sizes.
   - Test with both the first and last search result.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3525138614099173079==--


From bugzilla-daemon@bugs.koha-community.org Mon Mar  4 13:49:03 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Mon, 04 Mar 2019 12:48:33 +0000
Message-ID: <bug-21304-70-UGIo2ygtrj@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4214172980163600962=="

--===============4214172980163600962==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84704|0                           |1
        is obsolete|                            |
  Attachment #84705|0                           |1
        is obsolete|                            |

--- Comment #20 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 85980
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85980&action=edit
Bug 21304: (follow-up) Fix style of search results browser

This follow-up revises the style of the search result browser in the
staff client, making it behave better at smaller browser widths.

The patch also makes a couple of ESLint-prompted changes to browser.js

To test, apply the patch and regenerate CSS.

 - Perform a catalog search in the staff client.
 - Click on one of the search results.
 - On the bibliographic detail page there should be results browsing
   controls in the left-hand sidebar.
   - Resize the browser window and confirm that the controls work well
     at various sizes.
   - Test with both the first and last search result.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4214172980163600962==--


From bugzilla-daemon@bugs.koha-community.org Mon Mar  4 17:43:56 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Mon, 04 Mar 2019 16:43:53 +0000
Message-ID: <bug-21304-70-bgRULpocSe@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7877176067585309349=="

--===============7877176067585309349==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85980|0                           |1
        is obsolete|                            |

--- Comment #21 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 86015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86015&action=edit
Bug 21304: Update two-column templates with Bootstrap grid: Catalog

This patch modifies several catalog templates to use the Bootstrap grid
instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Catalog -> Search
   - Search results
     - Bibliographic details
     - MARC details (viewMARC preference enabled)
     - Labeled MARC details (viewLabeledMARC preference enabled)
     - ISBD (viewISBD preference enabled)
     - Items
     - Checkout history
     - Rota (stock rotation)

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7877176067585309349==--


From bugzilla-daemon@bugs.koha-community.org Mon Mar  4 17:44:01 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Mon, 04 Mar 2019 16:43:56 +0000
Message-ID: <bug-21304-70-TOL0ZzGwD6@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5076428223607048428=="

--===============5076428223607048428==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

--- Comment #22 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 86016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86016&action=edit
Bug 21304: (follow-up) Fix style of search results browser

This follow-up revises the style of the search result browser in the
staff client, making it behave better at smaller browser widths.

The patch also makes a couple of ESLint-prompted changes to browser.js

To test, apply the patch and regenerate CSS.

 - Perform a catalog search in the staff client.
 - Click on one of the search results.
 - On the bibliographic detail page there should be results browsing
   controls in the left-hand sidebar.
   - Resize the browser window and confirm that the controls work well
     at various sizes.
   - Test with both the first and last search result.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5076428223607048428==--


From bugzilla-daemon@bugs.koha-community.org Mon Mar  4 19:34:01 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Mon, 04 Mar 2019 18:33:58 +0000
Message-ID: <bug-21304-70-u5VyHElrYM@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4556628813923748304=="

--===============4556628813923748304==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Liz Rea <wizzyrea@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4556628813923748304==--


From bugzilla-daemon@bugs.koha-community.org Mon Mar  4 19:34:04 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Mon, 04 Mar 2019 18:34:01 +0000
Message-ID: <bug-21304-70-QAsk6cj1ux@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2940668503198782237=="

--===============2940668503198782237==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Liz Rea <wizzyrea@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86015|0                           |1
        is obsolete|                            |
  Attachment #86016|0                           |1
        is obsolete|                            |

--- Comment #23 from Liz Rea <wizzyrea@gmail.com> ---
Created attachment 86022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86022&action=edit
Bug 21304: Update two-column templates with Bootstrap grid: Catalog

This patch modifies several catalog templates to use the Bootstrap grid
instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Catalog -> Search
   - Search results
     - Bibliographic details
     - MARC details (viewMARC preference enabled)
     - Labeled MARC details (viewLabeledMARC preference enabled)
     - ISBD (viewISBD preference enabled)
     - Items
     - Checkout history
     - Rota (stock rotation)

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2940668503198782237==--


From bugzilla-daemon@bugs.koha-community.org Mon Mar  4 19:34:08 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Mon, 04 Mar 2019 18:34:04 +0000
Message-ID: <bug-21304-70-ncc20xTXxg@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0523859466844658806=="

--===============0523859466844658806==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

--- Comment #24 from Liz Rea <wizzyrea@gmail.com> ---
Created attachment 86023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86023&action=edit
Bug 21304: (follow-up) Fix style of search results browser

This follow-up revises the style of the search result browser in the
staff client, making it behave better at smaller browser widths.

The patch also makes a couple of ESLint-prompted changes to browser.js

To test, apply the patch and regenerate CSS.

 - Perform a catalog search in the staff client.
 - Click on one of the search results.
 - On the bibliographic detail page there should be results browsing
   controls in the left-hand sidebar.
   - Resize the browser window and confirm that the controls work well
     at various sizes.
   - Test with both the first and last search result.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0523859466844658806==--


From bugzilla-daemon@bugs.koha-community.org Wed Mar  6 08:03:45 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Wed, 06 Mar 2019 07:03:15 +0000
Message-ID: <bug-21304-70-K5lZfSCiDJ@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9108427979919616322=="

--===============9108427979919616322==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============9108427979919616322==--


From bugzilla-daemon@bugs.koha-community.org Wed Mar  6 08:03:48 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Wed, 06 Mar 2019 07:03:22 +0000
Message-ID: <bug-21304-70-blfBTKXQ9I@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2387029238282059003=="

--===============2387029238282059003==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86023|0                           |1
        is obsolete|                            |

--- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Created attachment 86127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86127&action=edit
Bug 21304: (follow-up) Fix style of search results browser

This follow-up revises the style of the search result browser in the
staff client, making it behave better at smaller browser widths.

The patch also makes a couple of ESLint-prompted changes to browser.js

To test, apply the patch and regenerate CSS.

 - Perform a catalog search in the staff client.
 - Click on one of the search results.
 - On the bibliographic detail page there should be results browsing
   controls in the left-hand sidebar.
   - Resize the browser window and confirm that the controls work well
     at various sizes.
   - Test with both the first and last search result.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2387029238282059003==--


From bugzilla-daemon@bugs.koha-community.org Wed Mar  6 08:03:49 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Wed, 06 Mar 2019 07:03:19 +0000
Message-ID: <bug-21304-70-oSqXUBQrVY@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3948654396691515135=="

--===============3948654396691515135==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86022|0                           |1
        is obsolete|                            |

--- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Created attachment 86126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86126&action=edit
Bug 21304: Update two-column templates with Bootstrap grid: Catalog

This patch modifies several catalog templates to use the Bootstrap grid
instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Catalog -> Search
   - Search results
     - Bibliographic details
     - MARC details (viewMARC preference enabled)
     - Labeled MARC details (viewLabeledMARC preference enabled)
     - ISBD (viewISBD preference enabled)
     - Items
     - Checkout history
     - Rota (stock rotation)

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3948654396691515135==--


From bugzilla-daemon@bugs.koha-community.org Sat Mar 16 01:20:05 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Sat, 16 Mar 2019 00:20:02 +0000
Message-ID: <bug-21304-70-jz21cyieli@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8954454608694276527=="

--===============8954454608694276527==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Nick Clemens <nick@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick@bywatersolutions.com
             Status|Passed QA                   |Failed QA

--- Comment #27 from Nick Clemens <nick@bywatersolutions.com> ---
After applying I get a JS error on search results:
TypeError: c is null[Learn More] hc-sticky_18.1200027.js:11:4777

And I have no button to select records in the search results

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8954454608694276527==--


From bugzilla-daemon@bugs.koha-community.org Tue Mar 19 16:52:09 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Tue, 19 Mar 2019 15:52:06 +0000
Message-ID: <bug-21304-70-XZNIbXALJa@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8255845946042959806=="

--===============8255845946042959806==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

--- Comment #28 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 86753
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86753&action=edit
Bug 21304: (follow-up) Correct hc-sticky configuration

This patch corrects the element passed to the hc-sticky plugin to define
which element the floating toolbar sticks to.

To test, apply the patch and perform a search in the staff client which
will return multiple results. Confirm that scrolling down the page
triggers the floating toolbar.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8255845946042959806==--


From bugzilla-daemon@bugs.koha-community.org Tue Mar 19 16:52:33 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Tue, 19 Mar 2019 15:52:02 +0000
Message-ID: <bug-21304-70-Khk77AkuxU@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3670644076921184371=="

--===============3670644076921184371==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3670644076921184371==--


From bugzilla-daemon@bugs.koha-community.org Fri Mar 22 21:35:51 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Fri, 22 Mar 2019 20:35:48 +0000
Message-ID: <bug-21304-70-hs1AcHlveJ@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5534396272751117844=="

--===============5534396272751117844==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Nick Clemens <nick@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #29 from Nick Clemens <nick@bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5534396272751117844==--


From bugzilla-daemon@bugs.koha-community.org Mon Apr  1 12:24:54 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap
	grid: Catalog
Date: Mon, 01 Apr 2019 10:24:51 +0000
Message-ID: <bug-21304-70-0oQU6elKkW@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1470390651380806011=="

--===============1470390651380806011==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304

Martin Renvoize <martin.renvoize@ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize@ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> ---
Enhancement, will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1470390651380806011==--