From bugzilla-daemon@bugs.koha-community.org Tue Apr 12 13:54:02 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30512] New: Staff interface search results template error Date: Tue, 12 Apr 2022 11:54:01 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5677198872305274731==" --===============5677198872305274731== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 Bug ID: 30512 Summary: Staff interface search results template error Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 29609 Bug 29609 made a change to results.tt which result in broken markup: 'p1'> biblio_a_href doesn't accept a "class" property. The problem will only appear if you have IntranetCoce, AmazonCoverImages, or LocalCoverImages enabled. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29609 [Bug 29609] Links to guess the biblio default view need to be centralized -- You are receiving this mail because: You are watching all bug changes. --===============5677198872305274731==-- From bugzilla-daemon@bugs.koha-community.org Tue Apr 12 13:54:22 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30512] Staff interface search results template error Date: Tue, 12 Apr 2022 11:54:09 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2942001659708109272==" --===============2942001659708109272== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. --===============2942001659708109272==-- From bugzilla-daemon@bugs.koha-community.org Tue Apr 12 14:06:45 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30512] Staff interface search results template error Date: Tue, 12 Apr 2022 12:06:44 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2808401621945051771==" --===============2808401621945051771== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 --- Comment #1 from Owen Leonard --- Created attachment 133210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133210&action=edit Screenshot showing the problem -- You are receiving this mail because: You are watching all bug changes. --===============2808401621945051771==-- From bugzilla-daemon@bugs.koha-community.org Tue Apr 12 14:07:15 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30512] Staff interface search results template error Date: Tue, 12 Apr 2022 12:07:14 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7879340801785318898==" --===============7879340801785318898== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============7879340801785318898==-- From bugzilla-daemon@bugs.koha-community.org Tue Apr 12 14:07:25 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30512] Staff interface search results template error Date: Tue, 12 Apr 2022 12:07:17 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9097018038523168167==" --===============9097018038523168167== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 --- Comment #2 from Owen Leonard --- Created attachment 133211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133211&action=edit Bug 30512: Staff interface search results template error This patch removes some markup from the search results template which was causing markup to be output on the screen. Rather than correct the markup so that the "p1" class is correctly added to the relevant links I'm removing it. The "p1" class isn't used anywhere. The patch also corrects two incorrect template filters on one of the page's links. To test, apply the patch and enable the following system preferences: - AmazonCoverImages - IntranetCoce (if available) - LocalCoverImages - Perform a catalog search in the staff interface which will return results with cover images from each of the enabled services. - The covers should show correctly in the search results with no markup being output on screen. -- You are receiving this mail because: You are watching all bug changes. --===============9097018038523168167==-- From bugzilla-daemon@bugs.koha-community.org Fri Apr 15 13:06:43 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30512] Staff interface search results template error Date: Fri, 15 Apr 2022 11:06:33 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7704619647907446455==" --===============7704619647907446455== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D30512 Bug 30512 depends on bug 29609, which changed state. Bug 29609 Summary: Links to guess the biblio default view need to be centrali= zed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D29609 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED --=20 You are receiving this mail because: You are watching all bug changes. --===============7704619647907446455==-- From bugzilla-daemon@bugs.koha-community.org Thu Apr 21 16:56:34 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30512] Staff interface search results template error Date: Thu, 21 Apr 2022 14:56:33 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8807689179511484017==" --===============8807689179511484017== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============8807689179511484017==-- From bugzilla-daemon@bugs.koha-community.org Thu Apr 21 16:56:44 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30512] Staff interface search results template error Date: Thu, 21 Apr 2022 14:56:39 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7095077113571497293==" --===============7095077113571497293== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133211|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 133571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133571&action=edit Bug 30512: Staff interface search results template error This patch removes some markup from the search results template which was causing markup to be output on the screen. Rather than correct the markup so that the "p1" class is correctly added to the relevant links I'm removing it. The "p1" class isn't used anywhere. The patch also corrects two incorrect template filters on one of the page's links. To test, apply the patch and enable the following system preferences: - AmazonCoverImages - IntranetCoce (if available) - LocalCoverImages - Perform a catalog search in the staff interface which will return results with cover images from each of the enabled services. - The covers should show correctly in the search results with no markup being output on screen. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. --===============7095077113571497293==-- From bugzilla-daemon@bugs.koha-community.org Thu Apr 21 16:56:56 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30512] Staff interface search results template error Date: Thu, 21 Apr 2022 14:56:55 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6618064824473021838==" --===============6618064824473021838== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart+koha@gmail. | |com --- Comment #4 from Jonathan Druart --- Oops, thanks Owen! -- You are receiving this mail because: You are watching all bug changes. --===============6618064824473021838==-- From bugzilla-daemon@bugs.koha-community.org Fri Apr 22 20:53:24 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30512] Staff interface search results template error Date: Fri, 22 Apr 2022 18:52:53 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5045730516480591285==" --===============5045730516480591285== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. --===============5045730516480591285==-- From bugzilla-daemon@bugs.koha-community.org Fri Apr 22 20:53:34 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30512] Staff interface search results template error Date: Fri, 22 Apr 2022 18:52:55 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5858371436231949126==" --===============5858371436231949126== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. --===============5858371436231949126==-- From bugzilla-daemon@bugs.koha-community.org Fri Apr 29 19:27:28 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30512] Staff interface search results template error Date: Fri, 29 Apr 2022 17:25:26 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3346120363245859223==" --===============3346120363245859223== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall --- Not applying to 21.11.x, please rebase if you think this should be backported! -- You are receiving this mail because: You are watching all bug changes. --===============3346120363245859223==-- From bugzilla-daemon@bugs.koha-community.org Wed Aug 3 19:36:12 2022 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 30512] Staff interface search results template error Date: Wed, 03 Aug 2022 17:36:11 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3196438479051183153==" --===============3196438479051183153== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. --===============3196438479051183153==--