From bugzilla-daemon@pippin.metavore.com Tue Sep  9 18:42:22 2008
From: bugzilla-daemon@pippin.metavore.com
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 2596] New: restore ability to hyperlink URL fields
	in MARC detail dispaly
Date: Tue, 09 Sep 2008 09:33:01 -0700
Message-ID: <20080909163301.E622A12D78026@pippin.metavore.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7472295828296880287=="

--===============7472295828296880287==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2596

           Summary: restore ability to hyperlink URL fields in MARC detail
                    dispaly
           Product: Koha
           Version: HEAD
          Platform: PC
               URL: catalogue/MARCdetail.pl
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Cataloging
        AssignedTo: oleonard@myacpl.org
        ReportedBy: galen.charlton@liblime.com
         QAContact: koha-bugs@lists.koha.org


A recent patch added HTML escaping to the display of MARC subfield contents in
catalogue/MARCdetail.pl.  This is a necessary fix, but it does break the
behavior of making known URL subfields (e.g., the 856$u in MARC21) clickable.

This was done via the following code:

                if ( $tagslib->{ $fields[$x_i]->tag() }->{ $subf[$i][0] }
                    ->{isurl} )
                {
                    $subfield_data{marc_value} =
                      "<a href=\"$subf[$i][1]\">$subf[$i][1]</a>";
                }

To fix this, I suggest not trying to embed HTML tags like this, and instead
pass a "isurl" variable to the template, which can then decide to make a
clickable link.




------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

--===============7472295828296880287==--