From bugzilla-daemon@bugs.koha-community.org Sun Nov 28 23:41:03 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 29588] New: Yesterday and tomorrow in datepicker
 don't translate
Date: Sun, 28 Nov 2021 22:41:02 +0000
Message-ID: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4170921412570626356=="

--===============4170921412570626356==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588

            Bug ID: 29588
           Summary: Yesterday and tomorrow in datepicker don't translate
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs@lists.koha-community.org
          Reporter: katrin.fischer@bsz-bw.de
        QA Contact: testopia@bugs.koha-community.org
                CC: frederic@tamil.fr
        Depends on: 29478

Tomorrow, Yesterday and or in the new Flatpickr datepicker don't translate.

Today does, I am not sure why. I think it should be either only one underscore
in an .inc file or it's something else. I tried updating the po files locally,
but the strings didn't show up.

++ b/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc
@@ -34,6 +34,7 @@
 <!-- / calendar.inc -->
 [% Asset.js("js/calendar.js") | $raw %]
 [% Asset.js("lib/flatpickr/flatpickr.min.js") | $raw %]
+[% Asset.js("lib/flatpickr/shortcut-buttons-flatpickr.min.js") | $raw %]
 <script>
     flatpickr.l10ns.default.weekdays = flatpickr_weekdays;
     flatpickr.l10ns.default.months   = flatpickr_months;
@@ -84,6 +85,38 @@
                 $(on_close_focus).focus();
             }
         },
+        plugins: [
+          ShortcutButtonsPlugin({
+            button: [
+              {
+                label: __("Yesterday")
+              },
+              {
+                label: __("Today")
+              },
+              {
+                label: __("Tomorrow")
+              }
+            ],
+            label: "or",


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478
[Bug 29478] flatpickr misses quick shortcut to "Today" date
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============4170921412570626356==--


From bugzilla-daemon@bugs.koha-community.org Mon Nov 29 21:14:48 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate
Date: Mon, 29 Nov 2021 20:14:47 +0000
Message-ID: <bug-29588-70-JLSoV8gDNR@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0253967068514723456=="

--===============0253967068514723456==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588

Andrew Nugged <nugged@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nugged@gmail.com

--- Comment #1 from Andrew Nugged <nugged@gmail.com> ---
> I tried updating the po files locally, but the strings didn't show up.

It's JS runtime translations, so it goes from ln-LN-messages-js.po to
locale_data.js, but it's not detected by the parser (or we should do some
magic?)... Let's call for JD for help :), we bumped a lot before release.

I did the update for .po manually and it worked (in ITEM EDIT page for
example):


*** fi-FI-messages-js.po.orig
--- fi-FI-messages-js.po
***************
*** 1305,1314 ****
--- 1305,1323 ----
  msgid "Thursday"
  msgstr "Torstai"

+ #: koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc:92
+ msgid "Yesterday"
+ msgstr "Eilen"
+
+ #: koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc:95
  #: koha-tmpl/intranet-tmpl/prog/js/calendar.js:111
  msgid "Today"
  msgstr "Tänään"

+ #: koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc:98
+ msgid "Tomorrow"
+ msgstr "Huomenna"
+
  #: koha-tmpl/intranet-tmpl/prog/js/checkouts.js:291
  #: koha-tmpl/intranet-tmpl/prog/js/checkouts.js:658
  msgid "Today's checkouts"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============0253967068514723456==--


From bugzilla-daemon@bugs.koha-community.org Mon Nov 29 21:16:32 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate
Date: Mon, 29 Nov 2021 20:16:32 +0000
Message-ID: <bug-29588-70-nWvNO1mxoc@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0442973483178476685=="

--===============0442973483178476685==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D29588

--- Comment #2 from Andrew Nugged <nugged@gmail.com> ---
the parallel issue I found: these translations make flatpickr translated on t=
he
ITEM EDIT page, but not translate all three words at all on the USER EDIT pag=
e.
(/me  researching)

--=20
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============0442973483178476685==--


From bugzilla-daemon@bugs.koha-community.org Mon Nov 29 21:21:08 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate
Date: Mon, 29 Nov 2021 20:21:07 +0000
Message-ID: <bug-29588-70-7b1OnKPxHr@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8831246878288139577=="

--===============8831246878288139577==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588

--- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
(In reply to Andrew Nugged from comment #1)
> > I tried updating the po files locally, but the strings didn't show up.
> 
> It's JS runtime translations, so it goes from ln-LN-messages-js.po to
> locale_data.js, but it's not detected by the parser (or we should do some
> magic?)... Let's call for JD for help :), we bumped a lot before release.

Yes, but a git grep didn't bring the string up in any of the .po files.

The issue might be the file ending. This is an .inc, so it's not parsed as a
.js but like a .tt file. This is .js code, but the translation tool doesn't
know or expect it (is my guess)

> I did the update for .po manually and it worked (in ITEM EDIT page for
> example):
> 
> 
> *** fi-FI-messages-js.po.orig
> --- fi-FI-messages-js.po
> ***************
> *** 1305,1314 ****
> --- 1305,1323 ----
>   msgid "Thursday"
>   msgstr "Torstai"
> 
> + #: koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc:92
> + msgid "Yesterday"
> + msgstr "Eilen"
> +
> + #: koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc:95
>   #: koha-tmpl/intranet-tmpl/prog/js/calendar.js:111
>   msgid "Today"
>   msgstr "Tänään"
> 
> + #: koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc:98
> + msgid "Tomorrow"
> + msgstr "Huomenna"
> +
>   #: koha-tmpl/intranet-tmpl/prog/js/checkouts.js:291
>   #: koha-tmpl/intranet-tmpl/prog/js/checkouts.js:658
>   msgid "Today's checkouts"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============8831246878288139577==--


From bugzilla-daemon@bugs.koha-community.org Mon Nov 29 21:22:06 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate
Date: Mon, 29 Nov 2021 20:22:05 +0000
Message-ID: <bug-29588-70-rU5tWijDkC@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2894160571887319894=="

--===============2894160571887319894==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588

--- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Try changing __ to _ maybe?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============2894160571887319894==--


From bugzilla-daemon@bugs.koha-community.org Mon Nov 29 21:25:11 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate
Date: Mon, 29 Nov 2021 20:25:10 +0000
Message-ID: <bug-29588-70-Y4pU61cWw8@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5757728571302333304=="

--===============5757728571302333304==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D29588

--- Comment #5 from Andrew Nugged <nugged@gmail.com> ---
the parallel issue I found: these translations make flatpickr translated on t=
he
ITEM EDIT page accordingly to the current language,

but I found strange behavior on the USER EDIT page: it sticks to some language
from available (randomly? I am researching) and is ignorant to the current
chosen language (wth?)

--=20
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============5757728571302333304==--


From bugzilla-daemon@bugs.koha-community.org Mon Nov 29 21:28:34 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate
Date: Mon, 29 Nov 2021 20:28:33 +0000
Message-ID: <bug-29588-70-12B4PMeapa@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7342430262745685619=="

--===============7342430262745685619==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D29588

--- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
That does sound odd, good luck for the bug hunting! It's a prominent spot, so=
 I
hope we can figure it out for .1

--=20
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============7342430262745685619==--


From bugzilla-daemon@bugs.koha-community.org Tue Nov 30 12:10:43 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate
Date: Tue, 30 Nov 2021 11:10:42 +0000
Message-ID: <bug-29588-70-7pbU2eu5DA@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7776115688561034193=="

--===============7776115688561034193==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588

Jonathan Druart <jonathan.druart+koha@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============7776115688561034193==--


From bugzilla-daemon@bugs.koha-community.org Tue Nov 30 12:10:53 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate
Date: Tue, 30 Nov 2021 11:10:45 +0000
Message-ID: <bug-29588-70-ds5MGlpfJ6@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5442935661193883665=="

--===============5442935661193883665==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588

--- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> ---
Created attachment 128102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128102&action=edit
Bug 29588: (bug 29478 follow-up) Make strings translatable

"or", "Yesterday", "Today" and "Tomorrow" are not translatable, we are
using __ when _ should be used (__ is for .js files only).

Test plan:
0. Apply the patch
1. cd misc/translator && perl translate update fr-FR
2. Edit misc/translator/po/fr-FR-staff-prog.po
Search for "or", "Yesterday", "Today" and "Tomorrow" and translate them
3. cd misc/translator && perl translate install fr-FR
4. Enable fr-FR (syspref 'language')
5. Edit a patron and an item and confirm that the flatpickr widget has
the strings correctly translated

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

--===============5442935661193883665==--


From bugzilla-daemon@bugs.koha-community.org Tue Nov 30 12:11:10 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate
Date: Tue, 30 Nov 2021 11:11:09 +0000
Message-ID: <bug-29588-70-GUOTLhkQqY@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2562220300492651607=="

--===============2562220300492651607==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588

Jonathan Druart <jonathan.druart+koha@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_21_11_candidate
           Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail.
                   |ity.org                     |com
                 CC|                            |jonathan.druart+koha@gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

--===============2562220300492651607==--


From bugzilla-daemon@bugs.koha-community.org Wed Dec  1 11:09:44 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate
Date: Wed, 01 Dec 2021 10:09:43 +0000
Message-ID: <bug-29588-70-xaUdNgFoJI@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4921852907719720201=="

--===============4921852907719720201==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588

David Nind <david@davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david@davidnind.com

--- Comment #8 from David Nind <david@davidnind.com> ---
For whatever reason I couldn't get "Tomorrow" to translate. I tried it with
fr-FR and de-DE - there was a translation for that already available, but it
didn't change anything in the staff interface. (All the other ones worked as
expected.)

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4921852907719720201==--


From bugzilla-daemon@bugs.koha-community.org Wed Dec  1 11:20:31 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate
Date: Wed, 01 Dec 2021 10:20:30 +0000
Message-ID: <bug-29588-70-e0vJdL1KoT@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5514982247381676785=="

--===============5514982247381676785==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588

--- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> ---
(In reply to David Nind from comment #8)
> For whatever reason I couldn't get "Tomorrow" to translate. I tried it with
> fr-FR and de-DE - there was a translation for that already available, but it
> didn't change anything in the staff interface. (All the other ones worked as
> expected.)

Did you remove the fuzzy line?
It should look like that (fr-FR):

62284 #: koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc:38
62285 msgid "Tomorrow"
62286 msgstr "Demain"

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5514982247381676785==--


From bugzilla-daemon@bugs.koha-community.org Wed Dec  1 11:46:14 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate
Date: Wed, 01 Dec 2021 10:46:13 +0000
Message-ID: <bug-29588-70-H4FH77Sm3y@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4056746233963041546=="

--===============4056746233963041546==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588

--- Comment #10 from David Nind <david@davidnind.com> ---
(In reply to Jonathan Druart from comment #9)

> Did you remove the fuzzy line?
> It should look like that (fr-FR):

I didn't - this now works as expected now.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4056746233963041546==--


From bugzilla-daemon@bugs.koha-community.org Wed Dec  1 11:48:43 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate
Date: Wed, 01 Dec 2021 10:48:42 +0000
Message-ID: <bug-29588-70-IpJCuxtIxg@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4007762569029905340=="

--===============4007762569029905340==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588

David Nind <david@davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4007762569029905340==--


From bugzilla-daemon@bugs.koha-community.org Wed Dec  1 11:48:54 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate
Date: Wed, 01 Dec 2021 10:48:46 +0000
Message-ID: <bug-29588-70-oaVOaUKZHK@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0780723962058730189=="

--===============0780723962058730189==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588

David Nind <david@davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #128102|0                           |1
        is obsolete|                            |

--- Comment #11 from David Nind <david@davidnind.com> ---
Created attachment 128121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128121&action=edit
Bug 29588: (bug 29478 follow-up) Make strings translatable

"or", "Yesterday", "Today" and "Tomorrow" are not translatable, we are
using __ when _ should be used (__ is for .js files only).

Test plan:
0. Apply the patch
1. cd misc/translator && perl translate update fr-FR
2. Edit misc/translator/po/fr-FR-staff-prog.po
Search for "or", "Yesterday", "Today" and "Tomorrow" and translate them
3. cd misc/translator && perl translate install fr-FR
4. Enable fr-FR (syspref 'language')
5. Edit a patron and an item and confirm that the flatpickr widget has
the strings correctly translated

Signed-off-by: David Nind <david@davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0780723962058730189==--


From bugzilla-daemon@bugs.koha-community.org Wed Dec  1 14:16:49 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate
Date: Wed, 01 Dec 2021 13:16:48 +0000
Message-ID: <bug-29588-70-B5RZgMz0BW@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5508652801065006804=="

--===============5508652801065006804==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588

Thibaud Guillot <thibaud.guillot@biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #128121|0                           |1
        is obsolete|                            |

--- Comment #12 from Thibaud Guillot <thibaud.guillot@biblibre.com> ---
Created attachment 128126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128126&action=edit
Bug 29588: (bug 29478 follow-up) Make strings translatable

"or", "Yesterday", "Today" and "Tomorrow" are not translatable, we are
using __ when _ should be used (__ is for .js files only).

Test plan:
0. Apply the patch
1. cd misc/translator && perl translate update fr-FR
2. Edit misc/translator/po/fr-FR-staff-prog.po
Search for "or", "Yesterday", "Today" and "Tomorrow" and translate them
3. cd misc/translator && perl translate install fr-FR
4. Enable fr-FR (syspref 'language')
5. Edit a patron and an item and confirm that the flatpickr widget has
the strings correctly translated

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: ThibaudGLT <thibaud.guillot@biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5508652801065006804==--


From bugzilla-daemon@bugs.koha-community.org Tue Dec 14 15:36:44 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate
Date: Tue, 14 Dec 2021 14:36:43 +0000
Message-ID: <bug-29588-70-oYYd1pcztB@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4271266370389817218=="

--===============4271266370389817218==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588

Martin Renvoize <martin.renvoize@ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #128126|0                           |1
        is obsolete|                            |

--- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> ---
Created attachment 128509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128509&action=edit
Bug 29588: (bug 29478 follow-up) Make strings translatable

"or", "Yesterday", "Today" and "Tomorrow" are not translatable, we are
using __ when _ should be used (__ is for .js files only).

Test plan:
0. Apply the patch
1. cd misc/translator && perl translate update fr-FR
2. Edit misc/translator/po/fr-FR-staff-prog.po
Search for "or", "Yesterday", "Today" and "Tomorrow" and translate them
3. cd misc/translator && perl translate install fr-FR
4. Enable fr-FR (syspref 'language')
5. Edit a patron and an item and confirm that the flatpickr widget has
the strings correctly translated

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: ThibaudGLT <thibaud.guillot@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4271266370389817218==--


From bugzilla-daemon@bugs.koha-community.org Tue Dec 14 15:37:19 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate
Date: Tue, 14 Dec 2021 14:37:18 +0000
Message-ID: <bug-29588-70-ITXQanK31u@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4993010403306236380=="

--===============4993010403306236380==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588

Martin Renvoize <martin.renvoize@ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize@ptfs-europe
                   |                            |.com

--- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> ---
Man.. that's an easy hole to fall into!

Works as expected now, Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4993010403306236380==--


From bugzilla-daemon@bugs.koha-community.org Tue Dec 14 15:37:54 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate
Date: Tue, 14 Dec 2021 14:37:53 +0000
Message-ID: <bug-29588-70-QAoQtu6emJ@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0515979382885157629=="

--===============0515979382885157629==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588

Martin Renvoize <martin.renvoize@ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0515979382885157629==--


From bugzilla-daemon@bugs.koha-community.org Wed Dec 22 08:09:36 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate
Date: Wed, 22 Dec 2021 07:09:35 +0000
Message-ID: <bug-29588-70-dtxZOk3iSU@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6139629568584936852=="

--===============6139629568584936852==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588

Fridolin Somers <fridolin.somers@biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
                 CC|                            |fridolin.somers@biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6139629568584936852==--


From bugzilla-daemon@bugs.koha-community.org Wed Dec 22 08:11:48 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate
Date: Wed, 22 Dec 2021 07:11:32 +0000
Message-ID: <bug-29588-70-X7uAN8BXhY@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5061737679367994653=="

--===============5061737679367994653==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588

Fridolin Somers <fridolin.somers@biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5061737679367994653==--


From bugzilla-daemon@bugs.koha-community.org Wed Dec 22 08:11:58 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate
Date: Wed, 22 Dec 2021 07:11:34 +0000
Message-ID: <bug-29588-70-8Th2zuBi6M@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6850894020561793227=="

--===============6850894020561793227==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588

--- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> ---
Pushed to master for 22.05, thanks to everybody involved 🦄

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6850894020561793227==--


From bugzilla-daemon@bugs.koha-community.org Wed Dec 22 09:49:19 2021
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate
Date: Wed, 22 Dec 2021 08:49:18 +0000
Message-ID: <bug-29588-70-QNtOTRukKv@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2374408906326829928=="

--===============2374408906326829928==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588

David Nind <david@davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This fixes "or",
      release notes|                            |"Yesterday", "Today" and
                   |                            |"Tomorrow" in the flatpickr
                   |                            |date selector so they can
                   |                            |be translated. (This was
                   |                            |because __ was used when _
                   |                            |should have been used (__
                   |                            |is for .js files only)).

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2374408906326829928==--


From bugzilla-daemon@bugs.koha-community.org Fri Jan  7 12:14:05 2022
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate
Date: Fri, 07 Jan 2022 11:14:05 +0000
Message-ID: <bug-29588-70-RyoK6beEae@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3345011463902119960=="

--===============3345011463902119960==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588

Kyle M Hall <kyle@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.05.00                    |22.05.00,21.11.02
        released in|                            |
                 CC|                            |kyle@bywatersolutions.com

--- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> ---
Pushed to 21.11.x for 21.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3345011463902119960==--


From bugzilla-daemon@bugs.koha-community.org Mon Jan 10 16:39:00 2022
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate
Date: Mon, 10 Jan 2022 15:38:59 +0000
Message-ID: <bug-29588-70-bHKQA6vwb2@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8775558768785726676=="

--===============8775558768785726676==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588

Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |andrew@bywatersolutions.com
             Status|Pushed to stable            |RESOLVED

--- Comment #17 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> ---
Missing dependency, not backported to 21.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8775558768785726676==--