From bugzilla-daemon@bugs.koha-community.org Fri Jun 16 13:19:14 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 34031] New: Move various translatable strings out of opac-bottom.inc Date: Fri, 16 Jun 2023 11:19:13 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5957838988671728194==" --===============5957838988671728194== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34031 Bug ID: 34031 Summary: Move various translatable strings out of opac-bottom.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 34026, 21156 opac-bottom.inc defines several template variables for translation which are either unused or which can be moved into the corresponding JavaScript. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34026 [Bug 34026] Move translatable cover-handling strings out of opac-bottom.inc -- You are receiving this mail because: You are watching all bug changes. --===============5957838988671728194==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 16 13:39:53 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 34031] Move various translatable strings out of opac-bottom.inc Date: Fri, 16 Jun 2023 11:39:52 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1813497580234453228==" --===============1813497580234453228== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34031 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. --===============1813497580234453228==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 16 13:40:03 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 34031] Move various translatable strings out of opac-bottom.inc Date: Fri, 16 Jun 2023 11:39:54 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7604808652639455844==" --===============7604808652639455844== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34031 --- Comment #1 from Owen Leonard --- Created attachment 152402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152402&action=edit Bug 34031: Move various translatable strings out of opac-bottom.inc This patch moves some JS variable definitions out of opac-bottom.inc. These variables where defined so that they could be picked up for translation, but they can now be moved to the corresponding