From bugzilla-daemon@bugs.koha-community.org Mon Jul 24 16:31:57 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 34359] New: Can we get rid of Koha/BiblioUtils ? Date: Mon, 24 Jul 2023 14:31:56 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4331492076410948590==" --===============4331492076410948590== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D34359 Bug ID: 34359 Summary: Can we get rid of Koha/BiblioUtils ? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org This is not used (only by itself): git grep BiblioUtils::Iterator Koha/BiblioUtils/Iterator.pm:package Koha::BiblioUtils::Iterator; Koha/BiblioUtils/Iterator.pm:Koha::BiblioUtils::Iterator - iterates over biblios provided by a DBIx::Class::ResultSet Koha/BiblioUtils/Iterator.pm: use Koha::BiblioUtils::Iterator; Koha/BiblioUtils/Iterator.pm: my $iterator =3D Koha::BiblioUtils::Iterator->new($rs); t/db_dependent/Koha/BiblioUtils/Iterator.t:use_ok('Koha::BiblioUtils::Iterato= r'); t/db_dependent/Koha/BiblioUtils/Iterator.t:my $iterator =3D Koha::BiblioUtils::Iterator->new($rs, items =3D> 1 ); I know that someone kind of hates Util modules :) Unfortunately we cannot (yet) remove Koha::BiblioUtils module: Koha/BiblioUtils.pm:package Koha::BiblioUtils; Koha/BiblioUtils.pm:Koha::BiblioUtils - contains fundamental biblio-related functions Koha/BiblioUtils.pm: my $biblio =3D Koha::BiblioUtils->new($marc_record, [$biblionumber]); Koha/BiblioUtils.pm:Creates an instance of C based on the marc record. If known, Koha/BiblioUtils.pm: my $biblio =3D Koha::BiblioUtils->get_from_biblionumber($biblionumber, %options); Koha/BiblioUtils.pm:This will give you an instance of L th= at is the biblio that Koha/BiblioUtils.pm: my $it =3D Koha::BiblioUtils->get_all_biblios_iterator(%options); Koha/BiblioUtils.pm:Koha::BiblioUtils of each biblio. This will include the item data. Koha/BiblioUtils.pm: my $marc =3D Koha::BiblioUtils->get_marc_biblio($bibn= um, %options); misc/release_notes/release_notes_22_05_00.html:
  • [29= 625] Wrong var name in Koha::BiblioUtils get_all_biblios_iterator
    • misc/release_notes/release_notes_22_05_00.md:- [[29625]](http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D29625) W= rong var name in Koha::BiblioUtils get_all_biblios_iterator misc/search_tools/rebuild_elasticsearch.pl:use Koha::BiblioUtils; misc/search_tools/rebuild_elasticsearch.pl: return ($r, Koha::BiblioUtils->get_from_biblionumber($r, item_data =3D> 1 )); misc/search_tools/rebuild_elasticsearch.pl: my $records =3D Koha::BiblioUtils->get_all_biblios_iterator(%iterator_options); --=20 You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============4331492076410948590==-- From bugzilla-daemon@bugs.koha-community.org Mon Jul 24 16:32:28 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 34359] Can we get rid of Koha/BiblioUtils ? Date: Mon, 24 Jul 2023 14:32:06 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6992530326345937482==" --===============6992530326345937482== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============6992530326345937482==-- From bugzilla-daemon@bugs.koha-community.org Mon Jul 24 16:33:16 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 34359] Can we get rid of Koha/BiblioUtils ? Date: Mon, 24 Jul 2023 14:33:15 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3673568109785157596==" --===============3673568109785157596== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. --===============3673568109785157596==-- From bugzilla-daemon@bugs.koha-community.org Mon Jul 24 16:33:26 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 34359] Can we get rid of Koha/BiblioUtils ? Date: Mon, 24 Jul 2023 14:33:18 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6998381928939962202==" --===============6998381928939962202== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 --- Comment #1 from Marcel de Rooy --- Created attachment 153839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153839&action=edit Bug 34359: Remove unneeded module Koha/BiblioUtils/Iterator.pm with test Test plan: git grep BiblioUtils::Iterator Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. --===============6998381928939962202==-- From bugzilla-daemon@bugs.koha-community.org Mon Jul 24 16:33:36 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 34359] Can we get rid of Koha/BiblioUtils ? Date: Mon, 24 Jul 2023 14:33:33 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5386946885478051545==" --===============5386946885478051545== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes. --===============5386946885478051545==-- From bugzilla-daemon@bugs.koha-community.org Mon Jul 24 16:33:55 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 34359] Can we get rid of Koha/BiblioUtils/Iterator ? Date: Mon, 24 Jul 2023 14:33:55 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8670749695792700622==" --===============8670749695792700622== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can we get rid of |Can we get rid of |Koha/BiblioUtils ? |Koha/BiblioUtils/Iterator ? -- You are receiving this mail because: You are watching all bug changes. --===============8670749695792700622==-- From bugzilla-daemon@bugs.koha-community.org Mon Jul 24 19:50:03 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 34359] Can we get rid of Koha/BiblioUtils/Iterator ? Date: Mon, 24 Jul 2023 17:50:02 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0820787801697705426==" --===============0820787801697705426== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12478 --- Comment #2 from Jonathan Druart --- This has actually been replaced with Koha::BiblioUtils::get_all_biblios_iterator, since the very beginning (12478). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 [Bug 12478] Elasticsearch support for Koha -- You are receiving this mail because: You are watching all bug changes. --===============0820787801697705426==-- From bugzilla-daemon@bugs.koha-community.org Mon Jul 24 19:52:03 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 34359] Can we get rid of Koha/BiblioUtils/Iterator ? Date: Mon, 24 Jul 2023 17:52:02 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7402082307479484846==" --===============7402082307479484846== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============7402082307479484846==-- From bugzilla-daemon@bugs.koha-community.org Mon Jul 24 19:52:13 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 34359] Can we get rid of Koha/BiblioUtils/Iterator ? Date: Mon, 24 Jul 2023 17:52:05 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2883916470592055908==" --===============2883916470592055908== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153839|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 153854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153854&action=edit Bug 34359: Remove unneeded module Koha/BiblioUtils/Iterator.pm with test Test plan: git grep BiblioUtils::Iterator Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. --===============2883916470592055908==-- From bugzilla-daemon@bugs.koha-community.org Sun Jul 30 23:18:10 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 34359] Can we get rid of Koha/BiblioUtils/Iterator ? Date: Sun, 30 Jul 2023 21:18:09 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8199667306195082113==" --===============8199667306195082113== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============8199667306195082113==-- From bugzilla-daemon@bugs.koha-community.org Sun Jul 30 23:18:20 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 34359] Can we get rid of Koha/BiblioUtils/Iterator ? Date: Sun, 30 Jul 2023 21:18:11 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6526952658035482376==" --===============6526952658035482376== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153854|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 154079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154079&action=edit Bug 34359: Remove unneeded module Koha/BiblioUtils/Iterator.pm with test Test plan: git grep BiblioUtils::Iterator Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. --===============6526952658035482376==-- From bugzilla-daemon@bugs.koha-community.org Sun Jul 30 23:18:30 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 34359] Get rid of Koha/BiblioUtils/Iterator Date: Sun, 30 Jul 2023 21:18:22 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5859599849995060215==" --===============5859599849995060215== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Summary|Can we get rid of |Get rid of |Koha/BiblioUtils/Iterator ? |Koha/BiblioUtils/Iterator -- You are receiving this mail because: You are watching all bug changes. --===============5859599849995060215==-- From bugzilla-daemon@bugs.koha-community.org Tue Aug 15 11:17:03 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 34359] Get rid of Koha/BiblioUtils/Iterator Date: Tue, 15 Aug 2023 09:14:20 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0937332936832208213==" --===============0937332936832208213== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. --===============0937332936832208213==-- From bugzilla-daemon@bugs.koha-community.org Tue Aug 15 11:17:13 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 34359] Get rid of Koha/BiblioUtils/Iterator Date: Tue, 15 Aug 2023 09:14:23 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8121857304789960048==" --===============8121857304789960048== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. --===============8121857304789960048==-- From bugzilla-daemon@bugs.koha-community.org Thu Aug 17 21:31:59 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 34359] Get rid of Koha/BiblioUtils/Iterator Date: Thu, 17 Aug 2023 19:31:59 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8589391156370696372==" --===============8589391156370696372== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers --- I propose not to backport to stable -- You are receiving this mail because: You are watching all bug changes. --===============8589391156370696372==-- From bugzilla-daemon@bugs.koha-community.org Wed Aug 30 11:01:37 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 34359] Get rid of Koha/BiblioUtils/Iterator Date: Wed, 30 Aug 2023 09:01:36 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4095533513905692715==" --===============4095533513905692715== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. --===============4095533513905692715==--