From bugzilla-daemon@bugs.koha-community.org Thu Jul 19 23:00:27 2018
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
Date: Thu, 19 Jul 2018 21:00:19 +0000
Message-ID: <bug-13618-70-vuM9oJTTbG@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6602168474532443602=="

--===============6602168474532443602==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D13618

--- Comment #219 from Jonathan Druart <jonathan.druart@bugs.koha-community.or=
g> ---
I am back!

Next version has been pushed to the remote branch -
https://gitlab.com/joubu/Koha/commits/bug_13618

Here is commit message of the main patch:

    As we did not fix the performance issue when autofiltering
    the variables (see bug 20975), the only solution we have is to add the
    filters explicitely.

    This patch has been autogenerated (using add_html_filters.pl, see next
    pathces) and add the html filter to all the variables displayed in the
    template.
    Exceptions are made (using the new 'raw' TT filter) to the variable we
    already listed in the previous versions of this patch.

    To test:
    - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated
    data which contain <script> tags

    - Remove them from borrower_debarments.comments (there are allowed here)
    update  borrower_debarments set comment=3D"html tags possible here";

    - From the interface hit page and try to catch alert box.
    If you find one it means you find a possible XSS.
    To know where it comes from:
    * note the exact URL where you found it
    * note the alert box content
    * Dump your DB and search for the string in the dump to identify its
    location (for instance table.field)

    Next:
    * Ideally we would like to use the raw filter when it is not necessary
    to HTML escape the variables (in big loop for instance)
    * Provide a QA script to catch missing filters (we want html, uri, url
    or raw, certainly others that I am forgetting now)
    * Replace the html filters with uri when needed (!)


Please test!

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============6602168474532443602==--