From bugzilla-daemon@bugs.koha-community.org Thu Jul 18 16:53:58 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 23339] New: Reindent addbooks.tt
Date: Thu, 18 Jul 2019 14:53:55 +0000
Message-ID: <bug-23339-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7253578692429278324=="

--===============7253578692429278324==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339

            Bug ID: 23339
           Summary: Reindent addbooks.tt
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard@myacpl.org
          Reporter: oleonard@myacpl.org
        QA Contact: testopia@bugs.koha-community.org

I would like to reindent cataloging/addbooks.tt: Remove tabs, correct
indentation, add some comments to clarify the structure.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7253578692429278324==--


From bugzilla-daemon@bugs.koha-community.org Thu Jul 18 17:52:13 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 23339] Reindent addbooks.tt
Date: Thu, 18 Jul 2019 15:51:43 +0000
Message-ID: <bug-23339-70-f6lbUy0ZIQ@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23339-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5229217398812199576=="

--===============5229217398812199576==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5229217398812199576==--


From bugzilla-daemon@bugs.koha-community.org Thu Jul 18 17:52:15 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 23339] Reindent addbooks.tt
Date: Thu, 18 Jul 2019 15:51:49 +0000
Message-ID: <bug-23339-70-WRUuYyjulH@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23339-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7625112296426497417=="

--===============7625112296426497417==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339

--- Comment #2 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 91595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91595&action=edit
Bug 23339: (follow-up) Markup comments and corrections

This patch adds comments to the template to highlight the markup
structure. It also removes the obsolete "type" attribute from the
<script> tag.

This patch should have no effect on the interface or functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7625112296426497417==--


From bugzilla-daemon@bugs.koha-community.org Thu Jul 18 17:52:16 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 23339] Reindent addbooks.tt
Date: Thu, 18 Jul 2019 15:51:46 +0000
Message-ID: <bug-23339-70-MO4CIjy9dF@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23339-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3104089893410670605=="

--===============3104089893410670605==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339

--- Comment #1 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 91594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91594&action=edit
Bug 23339: Reindent addbooks.tt

This patch reindents cataloguing/addbooks.tt to use four spaces,
following coding guidelines.

To test, apply the patch and use your preferred method for checking the
differences between files while ignoring whitespace. I use diff with the
"-w" flag, but you should look into your own heart for the
right solution.

Go to Cataloging. Test that the initial page and search results view
look correct and work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3104089893410670605==--


From bugzilla-daemon@bugs.koha-community.org Fri Jul 19 21:44:15 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 23339] Reindent addbooks.tt
Date: Fri, 19 Jul 2019 19:44:12 +0000
Message-ID: <bug-23339-70-m69InbIe21@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23339-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7189648535877838028=="

--===============7189648535877838028==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339

Maryse Simard <maryse.simard@inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91594|0                           |1
        is obsolete|                            |

--- Comment #3 from Maryse Simard <maryse.simard@inlibro.com> ---
Created attachment 91669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91669&action=edit
Bug 23339: Reindent addbooks.tt

This patch reindents cataloguing/addbooks.tt to use four spaces,
following coding guidelines.

To test, apply the patch and use your preferred method for checking the
differences between files while ignoring whitespace. I use diff with the
"-w" flag, but you should look into your own heart for the
right solution.

Go to Cataloging. Test that the initial page and search results view
look correct and work correctly.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7189648535877838028==--


From bugzilla-daemon@bugs.koha-community.org Fri Jul 19 21:44:21 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 23339] Reindent addbooks.tt
Date: Fri, 19 Jul 2019 19:44:16 +0000
Message-ID: <bug-23339-70-Cg3fRR4RTb@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23339-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6026808176383495316=="

--===============6026808176383495316==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339

Maryse Simard <maryse.simard@inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91595|0                           |1
        is obsolete|                            |

--- Comment #4 from Maryse Simard <maryse.simard@inlibro.com> ---
Created attachment 91670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91670&action=edit
Bug 23339: (follow-up) Markup comments and corrections

This patch adds comments to the template to highlight the markup
structure. It also removes the obsolete "type" attribute from the
<script> tag.

This patch should have no effect on the interface or functionality.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6026808176383495316==--


From bugzilla-daemon@bugs.koha-community.org Fri Jul 19 21:44:28 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 23339] Reindent addbooks.tt
Date: Fri, 19 Jul 2019 19:44:25 +0000
Message-ID: <bug-23339-70-pqQhcmJOMs@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23339-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1779045269206119666=="

--===============1779045269206119666==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339

Maryse Simard <maryse.simard@inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |maryse.simard@inlibro.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1779045269206119666==--


From bugzilla-daemon@bugs.koha-community.org Tue Jul 30 14:32:20 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 23339] Reindent addbooks.tt
Date: Tue, 30 Jul 2019 12:32:18 +0000
Message-ID: <bug-23339-70-fxBnfbbWlo@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23339-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5187506820889008318=="

--===============5187506820889008318==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339

Nick Clemens <nick@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5187506820889008318==--


From bugzilla-daemon@bugs.koha-community.org Tue Jul 30 14:32:31 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 23339] Reindent addbooks.tt
Date: Tue, 30 Jul 2019 12:32:24 +0000
Message-ID: <bug-23339-70-Sc0f2TKkeK@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23339-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2439977897782241356=="

--===============2439977897782241356==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339

Nick Clemens <nick@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91670|0                           |1
        is obsolete|                            |

--- Comment #6 from Nick Clemens <nick@bywatersolutions.com> ---
Created attachment 91868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91868&action=edit
Bug 23339: (follow-up) Markup comments and corrections

This patch adds comments to the template to highlight the markup
structure. It also removes the obsolete "type" attribute from the
<script> tag.

This patch should have no effect on the interface or functionality.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2439977897782241356==--


From bugzilla-daemon@bugs.koha-community.org Tue Jul 30 14:32:31 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 23339] Reindent addbooks.tt
Date: Tue, 30 Jul 2019 12:32:21 +0000
Message-ID: <bug-23339-70-CpaRxva8ic@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23339-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1830042613754551738=="

--===============1830042613754551738==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339

Nick Clemens <nick@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91669|0                           |1
        is obsolete|                            |

--- Comment #5 from Nick Clemens <nick@bywatersolutions.com> ---
Created attachment 91867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91867&action=edit
Bug 23339: Reindent addbooks.tt

This patch reindents cataloguing/addbooks.tt to use four spaces,
following coding guidelines.

To test, apply the patch and use your preferred method for checking the
differences between files while ignoring whitespace. I use diff with the
"-w" flag, but you should look into your own heart for the
right solution.

Go to Cataloging. Test that the initial page and search results view
look correct and work correctly.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1830042613754551738==--


From bugzilla-daemon@bugs.koha-community.org Tue Jul 30 14:32:42 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 23339] Reindent addbooks.tt
Date: Tue, 30 Jul 2019 12:32:36 +0000
Message-ID: <bug-23339-70-sYO8klpma5@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23339-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1279653733040677615=="

--===============1279653733040677615==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339

Nick Clemens <nick@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com
                   |y.org                       |
                 CC|                            |nick@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1279653733040677615==--


From bugzilla-daemon@bugs.koha-community.org Mon Aug  5 17:22:42 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 23339] Reindent addbooks.tt
Date: Mon, 05 Aug 2019 15:22:41 +0000
Message-ID: <bug-23339-70-I8JYdIOoc1@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23339-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1980953051004529569=="

--===============1980953051004529569==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91867|0                           |1
        is obsolete|                            |
  Attachment #91868|0                           |1
        is obsolete|                            |

--- Comment #7 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 92013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92013&action=edit
Bug 23339: Reindent addbooks.tt

This patch reindents cataloguing/addbooks.tt to use four spaces,
following coding guidelines.

To test, apply the patch and use your preferred method for checking the
differences between files while ignoring whitespace. I use diff with the
"-w" flag, but you should look into your own heart for the
right solution.

Go to Cataloging. Test that the initial page and search results view
look correct and work correctly.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1980953051004529569==--


From bugzilla-daemon@bugs.koha-community.org Mon Aug  5 17:22:52 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 23339] Reindent addbooks.tt
Date: Mon, 05 Aug 2019 15:22:44 +0000
Message-ID: <bug-23339-70-1v7wcKmQ4Q@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23339-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6188606972772489327=="

--===============6188606972772489327==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339

--- Comment #8 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 92014
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92014&action=edit
Bug 23339: (follow-up) Markup comments and corrections

This patch adds comments to the template to highlight the markup
structure. It also removes the obsolete "type" attribute from the
<script> tag.

This patch should have no effect on the interface or functionality.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6188606972772489327==--


From bugzilla-daemon@bugs.koha-community.org Mon Aug  5 17:27:15 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 23339] Reindent addbooks.tt
Date: Mon, 05 Aug 2019 15:27:14 +0000
Message-ID: <bug-23339-70-ry56wbhw4F@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23339-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6975728072832293717=="

--===============6975728072832293717==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339

Martin Renvoize <martin.renvoize@ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |19.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6975728072832293717==--


From bugzilla-daemon@bugs.koha-community.org Mon Aug  5 17:27:25 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 23339] Reindent addbooks.tt
Date: Mon, 05 Aug 2019 15:27:15 +0000
Message-ID: <bug-23339-70-dNlS0w6efm@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23339-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8866063439498678194=="

--===============8866063439498678194==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339

--- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8866063439498678194==--


From bugzilla-daemon@bugs.koha-community.org Fri Aug  9 15:51:01 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 23339] Reindent addbooks.tt
Date: Fri, 09 Aug 2019 13:51:00 +0000
Message-ID: <bug-23339-70-UmAn5U30oV@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-23339-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8275346976345681366=="

--===============8275346976345681366==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339

Fridolin SOMERS <fridolin.somers@biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers@biblibre.co
                   |                            |m
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED

--- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> ---
Enhancement not pushed to 19.05.x

(Does not apply on 19.05.x)

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8275346976345681366==--