From bugzilla-daemon@bugs.koha-community.org Thu May 23 15:46:34 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 22975] New: Remove type attribute from script tags:
 Acquisitions
Date: Thu, 23 May 2019 13:46:30 +0000
Message-ID: <bug-22975-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8195521766786089481=="

--===============8195521766786089481==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22975

            Bug ID: 22975
           Summary: Remove type attribute from script tags: Acquisitions
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard@myacpl.org
          Reporter: oleonard@myacpl.org
        QA Contact: testopia@bugs.koha-community.org
                CC: testopia@bugs.koha-community.org
            Blocks: 22956
  Target Milestone: ---

This patch will remove the obsolete "type" attribute from <script> tags in the
following acquisitions templates:

 - intranet-tmpl\prog\en\modules\acqui\basketgroup.tt
 - intranet-tmpl\prog\en\modules\acqui\parcels.tt
 - intranet-tmpl\prog\en\modules\acqui\transferorder.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22956
[Bug 22956] Omnibus: Remove type attribute from script tags
-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8195521766786089481==--


From bugzilla-daemon@bugs.koha-community.org Thu May 23 15:46:46 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22975] Remove type attribute from script tags:	Acquisitions
Date: Thu, 23 May 2019 13:46:40 +0000
Message-ID: <bug-22975-70-9HPWXtn0o6@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22975-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8674767252802917042=="

--===============8674767252802917042==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22975

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8674767252802917042==--


From bugzilla-daemon@bugs.koha-community.org Thu May 23 17:39:09 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22975] Remove type attribute from script tags:	Acquisitions
Date: Thu, 23 May 2019 15:38:39 +0000
Message-ID: <bug-22975-70-26NAJDZr8Z@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22975-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8416942513304973483=="

--===============8416942513304973483==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22975

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8416942513304973483==--


From bugzilla-daemon@bugs.koha-community.org Thu May 23 17:39:12 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22975] Remove type attribute from script tags:	Acquisitions
Date: Thu, 23 May 2019 15:38:41 +0000
Message-ID: <bug-22975-70-NV3Ul37uyM@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22975-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2350104880541431690=="

--===============2350104880541431690==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22975

--- Comment #1 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 90039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90039&action=edit
Bug 22975: Remove type attribute from script tags: Acquisitions

This patch removes the "type" attribute from <script> tags in several
acquisitions templates. Also removed: Obsolete "//<![CDATA[ //]]>"
markers.

This patch also makes minor indentation changes, so diff using the "-w"
flag.

To test, apply the patch and confirm that examples of affected pages
work properly without any JavaScript errors in the browser console:

 - Acquisitions -> Vendors -> Vendor -> Basket groups
 - Acquisitions -> Vendors -> Vendor -> Receive shipments
 - Acquisitions -> Vendors -> Vendor -> Basket:
   In the table of orders, click "Transfer." Transfer an order

Validating the HTML source of any of these pages should return no errors
related to the "type" attribute.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2350104880541431690==--


From bugzilla-daemon@bugs.koha-community.org Thu May 23 20:51:25 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22975] Remove type attribute from script tags:	Acquisitions
Date: Thu, 23 May 2019 18:51:20 +0000
Message-ID: <bug-22975-70-2gxYzgNiIe@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22975-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1862378379369905400=="

--===============1862378379369905400==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22975

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1862378379369905400==--


From bugzilla-daemon@bugs.koha-community.org Fri May 24 01:08:30 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22975] Remove type attribute from script tags:	Acquisitions
Date: Thu, 23 May 2019 23:08:27 +0000
Message-ID: <bug-22975-70-wVsKXcxN9D@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22975-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4148413827934822155=="

--===============4148413827934822155==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22975

Hayley Mapley <hayleymapley@catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4148413827934822155==--


From bugzilla-daemon@bugs.koha-community.org Fri May 24 01:08:37 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22975] Remove type attribute from script tags:	Acquisitions
Date: Thu, 23 May 2019 23:08:32 +0000
Message-ID: <bug-22975-70-PQKF4rApCr@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22975-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4222793527828580880=="

--===============4222793527828580880==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22975

Hayley Mapley <hayleymapley@catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90039|0                           |1
        is obsolete|                            |

--- Comment #2 from Hayley Mapley <hayleymapley@catalyst.net.nz> ---
Created attachment 90056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90056&action=edit
Bug 22975: Remove type attribute from script tags: Acquisitions

This patch removes the "type" attribute from <script> tags in several
acquisitions templates. Also removed: Obsolete "//<![CDATA[ //]]>"
markers.

This patch also makes minor indentation changes, so diff using the "-w"
flag.

To test, apply the patch and confirm that examples of affected pages
work properly without any JavaScript errors in the browser console:

 - Acquisitions -> Vendors -> Vendor -> Basket groups
 - Acquisitions -> Vendors -> Vendor -> Receive shipments
 - Acquisitions -> Vendors -> Vendor -> Basket:
   In the table of orders, click "Transfer." Transfer an order

Validating the HTML source of any of these pages should return no errors
related to the "type" attribute.

Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4222793527828580880==--


From bugzilla-daemon@bugs.koha-community.org Mon May 27 22:49:53 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22975] Remove type attribute from script tags:	Acquisitions
Date: Mon, 27 May 2019 20:49:50 +0000
Message-ID: <bug-22975-70-jc1ziZgTas@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22975-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5481094067589321926=="

--===============5481094067589321926==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22975

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5481094067589321926==--


From bugzilla-daemon@bugs.koha-community.org Mon May 27 22:49:59 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22975] Remove type attribute from script tags:	Acquisitions
Date: Mon, 27 May 2019 20:49:54 +0000
Message-ID: <bug-22975-70-NwrQQXvGpW@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22975-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1608137098332316712=="

--===============1608137098332316712==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22975

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90056|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Created attachment 90125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90125&action=edit
Bug 22975: Remove type attribute from script tags: Acquisitions

This patch removes the "type" attribute from <script> tags in several
acquisitions templates. Also removed: Obsolete "//<![CDATA[ //]]>"
markers.

This patch also makes minor indentation changes, so diff using the "-w"
flag.

To test, apply the patch and confirm that examples of affected pages
work properly without any JavaScript errors in the browser console:

 - Acquisitions -> Vendors -> Vendor -> Basket groups
 - Acquisitions -> Vendors -> Vendor -> Receive shipments
 - Acquisitions -> Vendors -> Vendor -> Basket:
   In the table of orders, click "Transfer." Transfer an order

Validating the HTML source of any of these pages should return no errors
related to the "type" attribute.

Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1608137098332316712==--


From bugzilla-daemon@bugs.koha-community.org Thu May 30 12:39:59 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22975] Remove type attribute from script tags:	Acquisitions
Date: Thu, 30 May 2019 10:39:56 +0000
Message-ID: <bug-22975-70-wrXOa8VbEl@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22975-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4539212408310815441=="

--===============4539212408310815441==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22975

Nick Clemens <nick@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick@bywatersolutions.com

--- Comment #4 from Nick Clemens <nick@bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4539212408310815441==--