From bugzilla-daemon@bugs.koha-community.org Mon Jan 27 16:28:58 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 24520] New: Share via Twitter option on OPAC is out
 of line with rest of Share options
Date: Mon, 27 Jan 2020 15:28:57 +0000
Message-ID: <bug-24520-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3294059495556874418=="

--===============3294059495556874418==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24520

            Bug ID: 24520
           Summary: Share via Twitter option on OPAC is out of line with
                    rest of Share options
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: lucas@bywatersolutions.com
          Reporter: kelly@bywatersolutions.com
        QA Contact: testopia@bugs.koha-community.org

It would appear as most Share options, email, facebook, linkedin are Font
Awesome - however, the Tweet option is not.  Therefore when the Tweet Options
appears next to the other share options, it is out of line with them.

It would be nice to make the Tweet option also Font Awesome to keep them
consistent and look nice.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3294059495556874418==--


From bugzilla-daemon@bugs.koha-community.org Mon Jan 27 16:45:54 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 24520] Share via Twitter option on OPAC is out of
 line with rest of Share options
Date: Mon, 27 Jan 2020 15:45:53 +0000
Message-ID: <bug-24520-70-JfOgwNGIv7@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-24520-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8243994779537919615=="

--===============8243994779537919615==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D24520

--- Comment #1 from Owen Leonard <oleonard@myacpl.org> ---
The tweet link is a Font Awesome icon, but there is also some JavaScript which
loads Twitter's version of the button in its place. I must have it blocked in
my browser because I didn't see it until I switched to another one.

The solution is to remove the Twitter-specific JS:

Line 1410:

[% IF ( SocialNetworks ) %]
    <script>!function(d,s,id){var
js,fjs=3Dd.getElementsByTagName(s)[0];if(!d.getElementById(id)){js=3Dd.create=
Element(s);js.id=3Did;js.src=3D"//platform.twitter.com/widgets.js";fjs.parent=
Node.insertBefore(js,fjs);}}(document,"script","twitter-wjs");</script>
[% END %]

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============8243994779537919615==--


From bugzilla-daemon@bugs.koha-community.org Fri Sep  4 23:05:25 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 24520] Share via Twitter option on OPAC is out of
 line with rest of Share options
Date: Fri, 04 Sep 2020 21:05:24 +0000
Message-ID: <bug-24520-70-MchkBofYkW@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-24520-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8472000700380441770=="

--===============8472000700380441770==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24520

Lucas Gass <lucas@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> ---
This problem is fixed by Bug 26069.

Making this resolved

*** This bug has been marked as a duplicate of bug 26069 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8472000700380441770==--