From bugzilla-daemon@bugs.koha-community.org Tue Jan 22 18:56:53 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9446] New: Use DataTables on Z39.50 servers administration page Date: Tue, 22 Jan 2013 17:56:48 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5121510744120413627==" --===============5121510744120413627== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 Bug ID: 9446 Summary: Use DataTables on Z39.50 servers administration page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The Z39.50 servers administration page uses the old tablesorter plugin. It should use the DataTables plugin instead. -- You are receiving this mail because: You are watching all bug changes. --===============5121510744120413627==-- From bugzilla-daemon@bugs.koha-community.org Tue Jan 22 19:03:57 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page Date: Tue, 22 Jan 2013 18:03:54 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3141955153540865025==" --===============3141955153540865025== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 --- Comment #1 from Owen Leonard --- Created attachment 14756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14756&action=edit Bug 9446 - Use DataTables on Z39.50 servers administration page Replace the tablesorter plugin with the DataTables plugin on the Z39.50 servers administration page. Structural changes were made to deal with a DataTables bug which prevents it from properly parsing a with a colspan. This patch also moves embedding of the toolbar and table-sorting JS from within the body of the page to the for sake of consistency. To test, open the Z39.50 servers administration page (Administration -> Z39.50 client targets). Confirm that table sorting works correctly. -- You are receiving this mail because: You are watching all bug changes. --===============3141955153540865025==-- From bugzilla-daemon@bugs.koha-community.org Tue Jan 22 19:04:00 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page Date: Tue, 22 Jan 2013 18:03:52 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1372954796172788828==" --===============1372954796172788828== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============1372954796172788828==-- From bugzilla-daemon@bugs.koha-community.org Wed Jan 23 09:45:20 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page Date: Wed, 23 Jan 2013 08:45:16 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7142665985695497066==" --===============7142665985695497066== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============7142665985695497066==-- From bugzilla-daemon@bugs.koha-community.org Wed Jan 23 09:45:28 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page Date: Wed, 23 Jan 2013 08:45:18 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3445739022885741613==" --===============3445739022885741613== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14756|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 14772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14772&action=edit Bug 9446 - Use DataTables on Z39.50 servers administration page Replace the tablesorter plugin with the DataTables plugin on the Z39.50 servers administration page. Structural changes were made to deal with a DataTables bug which prevents it from properly parsing a with a colspan. This patch also moves embedding of the toolbar and table-sorting JS from within the body of the page to the for sake of consistency. To test, open the Z39.50 servers administration page (Administration -> Z39.50 client targets). Confirm that table sorting works correctly. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. --===============3445739022885741613==-- From bugzilla-daemon@bugs.koha-community.org Tue Feb 26 16:09:07 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page Date: Tue, 26 Feb 2013 15:08:49 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2047426279762967145==" --===============2047426279762967145== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. --===============2047426279762967145==-- From bugzilla-daemon@bugs.koha-community.org Tue Feb 26 17:29:55 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page Date: Tue, 26 Feb 2013 16:29:40 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6703224038779946934==" --===============6703224038779946934== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============6703224038779946934==-- From bugzilla-daemon@bugs.koha-community.org Tue Feb 26 17:29:57 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page Date: Tue, 26 Feb 2013 16:29:41 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5340969907854198206==" --===============5340969907854198206== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14772|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 15701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15701&action=edit Bug 9446 [Revised] Use DataTables on Z39.50 servers administration page Replace the tablesorter plugin with the DataTables plugin on the Z39.50 servers administration page. Structural changes were made to deal with a DataTables bug which prevents it from properly parsing a with a colspan. This patch also moves embedding of the toolbar and table-sorting JS from within the body of the page to the for sake of consistency. To test, open the Z39.50 servers administration page (Administration -> Z39.50 client targets). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. -- You are receiving this mail because: You are watching all bug changes. --===============5340969907854198206==-- From bugzilla-daemon@bugs.koha-community.org Thu Feb 28 00:45:01 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page Date: Wed, 27 Feb 2013 23:44:44 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8402690862037174824==" --===============8402690862037174824== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D9446 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15701|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 15745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D15745&action=3De= dit [SIGNED-OFF] Bug 9446 [Revised] Use DataTables on Z39.50 servers administrati= on page Replace the tablesorter plugin with the DataTables plugin on the Z39.50 servers administration page. Structural changes were made to deal with a DataTables bug which prevents it from properly parsing a with a colspan. This patch also moves embedding of the toolbar and table-sorting JS from within the body of the page to the for sake of consistency. To test, open the Z39.50 servers administration page (Administration -> Z39.50 client targets). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Table sorting works. No errors. --=20 You are receiving this mail because: You are watching all bug changes. --===============8402690862037174824==-- From bugzilla-daemon@bugs.koha-community.org Thu Feb 28 00:45:14 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page Date: Wed, 27 Feb 2013 23:44:58 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1049081475147944566==" --===============1049081475147944566== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes. --===============1049081475147944566==-- From bugzilla-daemon@bugs.koha-community.org Tue Mar 5 10:59:46 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page Date: Tue, 05 Mar 2013 09:59:26 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0772823377480606478==" --===============0772823377480606478== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D9446 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart --- QA comment: This patch replaces tablesorter with datatable on the z3950 servers admin pag= e. Marked as Passed QA. --=20 You are receiving this mail because: You are watching all bug changes. --===============0772823377480606478==-- From bugzilla-daemon@bugs.koha-community.org Tue Mar 5 10:59:59 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page Date: Tue, 05 Mar 2013 09:59:41 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4365072708117748061==" --===============4365072708117748061== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15745|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 15884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15884&action=edit Bug 9446 [Revised] Use DataTables on Z39.50 servers administration page Replace the tablesorter plugin with the DataTables plugin on the Z39.50 servers administration page. Structural changes were made to deal with a DataTables bug which prevents it from properly parsing a with a colspan. This patch also moves embedding of the toolbar and table-sorting JS from within the body of the page to the for sake of consistency. To test, open the Z39.50 servers administration page (Administration -> Z39.50 client targets). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Table sorting works. No errors. Signed-off-by: Jonathan Druart Amended patch: Add the aLengthMenu key for DataTables -- You are receiving this mail because: You are watching all bug changes. --===============4365072708117748061==-- From bugzilla-daemon@bugs.koha-community.org Thu Mar 7 16:42:30 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page Date: Thu, 07 Mar 2013 15:41:55 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7904176527517212844==" --===============7904176527517212844== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. --===============7904176527517212844==-- From bugzilla-daemon@bugs.koha-community.org Mon Mar 11 13:53:41 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page Date: Mon, 11 Mar 2013 12:53:34 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0158639613647610286==" --===============0158639613647610286== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #8 from Jared Camins-Esakov --- This patch has been reverted from master at the request of the author. -- You are receiving this mail because: You are watching all bug changes. --===============0158639613647610286==-- From bugzilla-daemon@bugs.koha-community.org Wed Mar 13 13:16:28 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page Date: Wed, 13 Mar 2013 12:16:20 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5699323963121900581==" --===============5699323963121900581== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion -- You are receiving this mail because: You are watching all bug changes. --===============5699323963121900581==-- From bugzilla-daemon@bugs.koha-community.org Wed Mar 13 13:17:05 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page Date: Wed, 13 Mar 2013 12:16:44 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1002582806022894905==" --===============1002582806022894905== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #9 from Jared Camins-Esakov --- Per discussion with Owen, I am going to re-merge this patch. -- You are receiving this mail because: You are watching all bug changes. --===============1002582806022894905==-- From bugzilla-daemon@bugs.koha-community.org Wed Mar 13 14:03:51 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page Date: Wed, 13 Mar 2013 13:03:38 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4092911644251426251==" --===============4092911644251426251== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #10 from Jared Camins-Esakov --- Actually, disregard my last comment. This patch re-adds the YUI toolbar. -- You are receiving this mail because: You are watching all bug changes. --===============4092911644251426251==-- From bugzilla-daemon@bugs.koha-community.org Wed Mar 13 17:49:16 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page Date: Wed, 13 Mar 2013 16:49:10 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5879298126296432536==" --===============5879298126296432536== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============5879298126296432536==-- From bugzilla-daemon@bugs.koha-community.org Wed Mar 13 17:49:23 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page Date: Wed, 13 Mar 2013 16:49:11 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1195500540662359014==" --===============1195500540662359014== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15884|0 |1 is obsolete| | --- Comment #11 from Owen Leonard --- Created attachment 16097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16097&action=edit Bug 9446 [Revised] Use DataTables on Z39.50 servers administration page Replace the tablesorter plugin with the DataTables plugin on the Z39.50 servers administration page. Structural changes were made to deal with a DataTables bug which prevents it from properly parsing a with a colspan. This patch also moves embedding of the toolbar and table-sorting JS from within the body of the page to the for sake of consistency. To test, open the Z39.50 servers administration page (Administration -> Z39.50 client targets). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Further revision fixes conflict with Bug 9647. -- You are receiving this mail because: You are watching all bug changes. --===============1195500540662359014==-- From bugzilla-daemon@bugs.koha-community.org Wed Mar 20 12:45:08 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page Date: Wed, 20 Mar 2013 11:44:58 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5812976801357938602==" --===============5812976801357938602== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #12 from Paul Poulain --- Patch tested with a sandbox, by Frederic Durand -- You are receiving this mail because: You are watching all bug changes. --===============5812976801357938602==-- From bugzilla-daemon@bugs.koha-community.org Wed Mar 20 12:45:19 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page Date: Wed, 20 Mar 2013 11:45:11 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1941789272693597493==" --===============1941789272693597493== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16097|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. --===============1941789272693597493==-- From bugzilla-daemon@bugs.koha-community.org Wed Mar 20 12:45:27 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page Date: Wed, 20 Mar 2013 11:45:16 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6023558139932156330==" --===============6023558139932156330== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 --- Comment #13 from Paul Poulain --- Created attachment 16506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16506&action=edit Bug 9446 [Revised] Use DataTables on Z39.50 servers administration page Replace the tablesorter plugin with the DataTables plugin on the Z39.50 servers administration page. Structural changes were made to deal with a DataTables bug which prevents it from properly parsing a with a colspan. This patch also moves embedding of the toolbar and table-sorting JS from within the body of the page to the for sake of consistency. To test, open the Z39.50 servers administration page (Administration -> Z39.50 client targets). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Further revision fixes conflict with Bug 9647. Signed-off-by: Frederic Durand -- You are receiving this mail because: You are watching all bug changes. --===============6023558139932156330==-- From bugzilla-daemon@bugs.koha-community.org Wed Mar 20 15:11:19 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page Date: Wed, 20 Mar 2013 14:11:02 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6688011068521529250==" --===============6688011068521529250== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D9446 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Jonathan Druart --- QA comment: This patch replaces tablesorter with datatable on the z3950 servers admin pag= e. Marked as Passed QA. --=20 You are receiving this mail because: You are watching all bug changes. --===============6688011068521529250==-- From bugzilla-daemon@bugs.koha-community.org Wed Mar 20 15:11:29 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page Date: Wed, 20 Mar 2013 14:11:19 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2315989346504558591==" --===============2315989346504558591== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16506|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 16523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16523&action=edit Bug 9446 [Revised] Use DataTables on Z39.50 servers administration page Replace the tablesorter plugin with the DataTables plugin on the Z39.50 servers administration page. Structural changes were made to deal with a DataTables bug which prevents it from properly parsing a with a colspan. This patch also moves embedding of the toolbar and table-sorting JS from within the body of the page to the for sake of consistency. To test, open the Z39.50 servers administration page (Administration -> Z39.50 client targets). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Further revision fixes conflict with Bug 9647. Signed-off-by: Frederic Durand Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. --===============2315989346504558591==-- From bugzilla-daemon@bugs.koha-community.org Wed Mar 20 20:28:18 2013 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 9446] Use DataTables on Z39.50 servers administration page Date: Wed, 20 Mar 2013 19:28:06 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5001104501949030305==" --===============5001104501949030305== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9446 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. --===============5001104501949030305==--