From bugzilla-daemon@bugs.koha-community.org Thu Aug 15 23:19:19 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 37655] New: Basic editor needs to HTML-escape the
bib record title used as a heading
Date: Thu, 15 Aug 2024 21:19:18 +0000
Message-ID:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9173897168672006271=="
--===============9173897168672006271==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D37655
Bug ID: 37655
Summary: Basic editor needs to HTML-escape the bib record title
used as a heading
Change sponsored?: ---
Product: Koha
Version: Main
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P3
Component: Cataloging
Assignee: koha-bugs@lists.koha-community.org
Reporter: phil@chetcolibrary.org
QA Contact: testopia@bugs.koha-community.org
CC: m.de.rooy@rijksmuseum.nl
When you edit an existing record, the basic editor has an at the top of
the page saying "Editing {bib title} (Record nnn)", which fails to HTML-escape
the title. That gives you unpleasant results if the title is something like
" is a second-level heading" making the entire editor an , or it gives
you alarming results if someone has stuck a at =
the end of
the title in field 245 subfield a
2. Save, then edit the bib record again.
3. Oops, that alert() could have been more serious.
--=20
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
--===============9173897168672006271==--
From bugzilla-daemon@bugs.koha-community.org Fri Aug 16 00:50:33 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 37655] Basic editor needs to HTML-escape the bib
record title used as a heading
Date: Thu, 15 Aug 2024 22:50:32 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5474753699982435072=="
--===============5474753699982435072==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37655
Phil Ringnalda changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
--===============5474753699982435072==--
From bugzilla-daemon@bugs.koha-community.org Fri Aug 16 00:50:43 2024
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 37655] Basic editor needs to HTML-escape the bib
record title used as a heading
Date: Thu, 15 Aug 2024 22:50:34 +0000
Message-ID:
In-Reply-To:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6330295636075156381=="
--===============6330295636075156381==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37655
--- Comment #1 from Phil Ringnalda ---
Created attachment 170414
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170414&action=edit
Bug 37655: Basic editor needs to HTML-escape the bib record title used as a
heading
We stick the title of a bib record you are editing in the basic editor into
an without escaping any HTML it might contain. We should instead escape
it.
Test plan:
1. Without the patch, search for any record in the catalog and click Edit
record (if you are in the advanced editor, switch to the basic one)
2. Tab 2, Field 245, Subfield a, paste
at the end of the subfield
3. Save, then from the record detail page select Edit - Edit record
4. You will have gotten an alert(), and the entire form will be the size
of an . That's ugly, so go back to the detail page.
5. Apply patch, restart_all
6. Edit - Edit record
7. Now you should not get an alert, the whole title inluding the