From bugzilla-daemon@bugs.koha-community.org Sat Feb 25 22:50:00 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7601] New: Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") Date: Sat, 25 Feb 2012 21:53:16 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1395664271865101521==" --===============1395664271865101521== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D7601 Bug #: 7601 Summary: Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: veron@veron.ch QAContact: koha.sekjal@gmail.com Problem: -------- When a new marc record is added, the language code in field 008 Range 35-37 defaults to Englih ("eng"). This makes cataloguing inefficient and error-prone for librarians if most of the bibliographic data is e.g. in German or in French. Background: ----------- The language code for English (eng) is hard coded in the files ...koha\intranet\cgi-bin\cataloguing\value_builder\marc21_field_008.pl (~Lines 61, 100) and=20 ...koha\intranet\cgi-bin\cataloguing\value_builder\normarc_field_008.pl (~Lines 58, 98) Proposition: ------------ --Step 1 -------------------------- Add somewhere to cataloguing.pref,=20 section "Record Structure" : ----------------------------------- - - Fill in the default language for field 008 Range 35-37 (e.g. en= g, nor, ger, see MARC Code List = for Languages) - pref: DefaultLanguageField008 - " Empty defaults to eng." --Step 2 -------------------------- Change marc21_field_008.pl and=20 normarc_field_008.pl as follows: ----------------------------------- --2a--- Add 3 lines of code at the top of the functions sub plugin_javascript and sub plugin: my $lang =3D C4::Context->preference('DefaultLanguageField008' ); $lang =3D "eng" unless $lang; $lang =3D pack("A3", $lang); The code defaults an empty value to "eng" makes sure that the code has a leng= ht of 3 letters. --2b--- In both functions, replace hard coded eng with $lang: document.getElementById(\"$field_number\").value=3D'$dateentered' + 't = xxu||||| |||| 00| 0 $lang d'; $result =3D "$dateentered" . "t xxu||||| |||| 00| 0 $lang d" unless $result; =20 --Step 3---------------------------------------------------------------------- Login to Koha, go to Home =E2=80=BA Administration =E2=80=BA System Preferenc= es (Cataloging)=20 and test with empty value and different language codes (ger, ita etc.) ------------------------------------------------------------------------------ I implemented and tested this locally with marc21_field_008.pl (Koha 3.06.02.003) --=20 Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab= =3Demail ------- You are receiving this mail because: ------- You are watching all bug changes. --===============1395664271865101521==-- From bugzilla-daemon@bugs.koha-community.org Sat Feb 25 22:51:31 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7601] Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") Date: Sat, 25 Feb 2012 21:54:43 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9010131214725117296==" --===============9010131214725117296== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D7601 --- Comment #1 from Marc V=C3=A9ron 2012-02-25 21:54:43 UTC = --- Created attachment 7881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D7881 Changed marc21_field_008.pl --=20 Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab= =3Demail ------- You are receiving this mail because: ------- You are watching all bug changes. --===============9010131214725117296==-- From bugzilla-daemon@bugs.koha-community.org Sat Feb 25 22:53:48 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7601] Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") Date: Sat, 25 Feb 2012 21:57:03 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4497124848711423723==" --===============4497124848711423723== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D7601 --- Comment #2 from Marc V=C3=A9ron 2012-02-25 21:57:03 UTC = --- Created attachment 7882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D7882 cataloguing.pref with preference for 008 default language added --=20 Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab= =3Demail ------- You are receiving this mail because: ------- You are watching all bug changes. --===============4497124848711423723==-- From bugzilla-daemon@bugs.koha-community.org Sat Feb 25 22:59:38 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7601] Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") Date: Sat, 25 Feb 2012 22:02:51 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6172408983136154764==" --===============6172408983136154764== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D7601 Marc V=C3=A9ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marc@msys.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=3D7586 --=20 Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab= =3Demail ------- You are receiving this mail because: ------- You are watching all bug changes. --===============6172408983136154764==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 8 17:38:32 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7601] Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") Date: Fri, 08 Jun 2012 15:47:00 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8941057286677988114==" --===============8941057286677988114== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7601 --- Comment #3 from Marc Véron --- Created attachment 9987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9987&action=edit Bug 7601 - Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") When a new marc record is added, the language code in field 008 Range 35-37 defaults to Englih ("eng"). This makes cataloguing inefficient and error-prone for librarians if most of the bibliographic data is e.g. in German or in French. Test: - Apply patch - Edit preference DefaultLanguageField008, fill in e.g. 'ger' - Go to Cataloguing, Add marc Record - Click in field 008. Language code should read 'ger' (instead of 'eng') -- You are receiving this mail because: You are watching all bug changes. --===============8941057286677988114==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 8 17:38:56 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7601] Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") Date: Fri, 08 Jun 2012 15:47:24 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8871381859038909527==" --===============8871381859038909527== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7601 Marc Véron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7882|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. --===============8871381859038909527==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 8 17:39:11 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7601] Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") Date: Fri, 08 Jun 2012 15:47:40 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5062167349437972396==" --===============5062167349437972396== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7601 Marc Véron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7881|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. --===============5062167349437972396==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 8 17:40:16 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7601] Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") Date: Fri, 08 Jun 2012 15:48:44 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8831529893705961371==" --===============8831529893705961371== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7601 Marc Véron changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes. --===============8831529893705961371==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 8 17:40:49 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7601] Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") Date: Fri, 08 Jun 2012 15:49:18 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3535463807015921415==" --===============3535463807015921415== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7601 Marc Véron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============3535463807015921415==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 8 17:48:17 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7601] Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") Date: Fri, 08 Jun 2012 15:56:45 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8294412643846297847==" --===============8294412643846297847== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7601 Marc Véron changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. --===============8294412643846297847==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 8 21:41:33 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7601] Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") Date: Fri, 08 Jun 2012 19:50:01 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8911991647962045099==" --===============8911991647962045099== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7601 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9987|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 9988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9988&action=edit Bug 7601 - Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") When a new marc record is added, the language code in field 008 Range 35-37 defaults to Englih ("eng"). This makes cataloguing inefficient and error-prone for librarians if most of the bibliographic data is e.g. in German or in French. Test: - Apply patch - Edit preference DefaultLanguageField008, fill in e.g. 'ger' - Go to Cataloguing, Add marc Record - Click in field 008. Language code should read 'ger' (instead of 'eng') Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. --===============8911991647962045099==-- From bugzilla-daemon@bugs.koha-community.org Fri Jun 8 21:42:11 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7601] Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") Date: Fri, 08 Jun 2012 19:50:39 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4813340086036882525==" --===============4813340086036882525== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7601 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. --===============4813340086036882525==-- From bugzilla-daemon@bugs.koha-community.org Sun Jun 10 10:49:14 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7601] Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") Date: Sun, 10 Jun 2012 08:57:46 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6072988728184708225==" --===============6072988728184708225== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7601 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #5 from Paul Poulain --- QA comment: * small patch that replaces a hardcoded value by a syspref * Despite his size, the content of the patch is tiny, loading the syspref, filling it to 3 chars, and using it instead of the default passed QA -- You are receiving this mail because: You are watching all bug changes. --===============6072988728184708225==-- From bugzilla-daemon@bugs.koha-community.org Sun Jun 10 10:49:23 2012 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7601] Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") Date: Sun, 10 Jun 2012 08:57:57 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4170833397812592474==" --===============4170833397812592474== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7601 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes. --===============4170833397812592474==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 20 16:55:30 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 7601] Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") Date: Fri, 20 Mar 2015 15:55:22 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6737325699649841740==" --===============6737325699649841740== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7601 Marc Véron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9269 -- You are receiving this mail because: You are watching all bug changes. --===============6737325699649841740==--