From bugzilla-daemon@bugs.koha-community.org Thu Apr 11 01:58:40 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on	source
 of import
Date: Wed, 10 Apr 2019 23:58:34 +0000
Message-ID: <bug-14957-70-RoDrHSlpSy@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8630284729452148634=="

--===============8630284729452148634==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D14957

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #145 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Taking a first view here, starting with the QA script:


1) QA script failures:
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-merge-rules.tt
   FAIL   filters
                missing_filter at line 376 (                    <input
type=3D"checkbox" name=3D"batchremove" value=3D"[% rule.id %]"[% IF rule.remo=
vemarked
%] checked=3D"checked"[% END %]/>)
                missing_filter at line 364 (                <td>[% rule.filter
%]</td>)
                missing_filter at line 372 (                    <a
href=3D"?op=3Dremove&id=3D[% rule.id %]" title=3D"Delete" class=3D"btn btn-mi=
ni"><i
class=3D"fa fa-trash"></i> Delete</a>)
                missing_filter at line 317 (                              =20
<option value=3D"[% module.id %]">[% module.name %]</option>)
                missing_filter at line 373 (                    <a
href=3D"?op=3Dedit&id=3D[% rule.id %]" title=3D"Edit" class=3D"btn btn-mini">=
<i class=3D"fa
fa-pencil"></i> Edit</a>)
                missing_filter at line 363 (                <td>[% rule.module
%]</td>)
                missing_filter at line 308 (            <tr id=3D"[% rule.id =
%]"
class=3D"rule[% IF rule.edit %]-edit[% END %]">)
                missing_filter at line 315 (                              =20
<option value=3D"[% module.id %]" selected=3D"selected">[% module.name %]</op=
tion>)
                missing_filter at line 234 (<form action=3D"[% script_name %]"
method=3D"GET">)
                missing_filter at line 328 (                            <opti=
on
value=3D"[% preset %]">[% preset %]</option>)
                missing_filter at line 357 (                    <button
class=3D"btn btn-mini" title=3D"Save" id=3D"doedit" value=3D"[% rule.id %]"><i
class=3D"fa fa-check"></i> Save</button>)
                missing_filter at line 323 (                <td><input
type=3D"text" size=3D"3" name=3D"tag" value=3D"[% rule.tag %]"/></td>)
                wrong_html_filter at line 373 (                    <a
href=3D"?op=3Dedit&id=3D[% rule.id %]" title=3D"Edit" class=3D"btn btn-mini">=
<i class=3D"fa
fa-pencil"></i> Edit</a>)
                missing_filter at line 5 (<link rel=3D"stylesheet"
type=3D"text/css" href=3D"[% interface %]/[% theme %]/css/datatables.css" />)
                missing_filter at line 310 (                <td>[% rule.id
%]</td>)
                missing_filter at line 385 (<form action=3D"[% script_name %]"
method=3D"post">)
                missing_filter at line 365 (                <td>[% rule.tag
%]</td>)
                missing_filter at line 241 (<form action=3D"[% script_name %]"
method=3D"POST" id=3D"marc-merge-rules-form">)
                wrong_html_filter at line 372 (                    <a
href=3D"?op=3Dremove&id=3D[% rule.id %]" title=3D"Delete" class=3D"btn btn-mi=
ni"><i
class=3D"fa fa-trash"></i> Delete</a>)
                missing_filter at line 362 (                <td>[% rule.id
%]</td>)
                missing_filter at line 263 (                        <option
value=3D"[% module.id %]">[% module.name %]</option>)
                missing_filter at line 273 (                        <option
value=3D"[% preset %]">[% preset %]</option>)
                missing_filter at line 322 (                <td><input
type=3D"text" size=3D"5" name=3D"filter" value=3D"[% rule.filter %]"/></td>)
   FAIL   forbidden patterns
                forbidden pattern: Do *not* include full path to css files, u=
se
the Asset TT plugin (bug 20538) (line 5)
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 372)
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 373)
                forbidden pattern: Attribute type should not be used for scri=
pt
tags (bug 20053) (line 14)
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 357)
                forbidden pattern: Attribute type should not be used for style
tags (bug 20054) (line 8)
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 302)
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 358)
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 301)
   OK     git manipulation
   FAIL   js_in_body
                A <script> tag found inside head, must be moved to the body
(see bug 17858)
   OK     spelling
   FAIL   tt_valid
                lines 334, 335, 340, 341, 346, 347, 352, 353, 376
   OK     valid_template

 FAIL   Koha/MarcMergeRule.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
                POD is missing for 'store'
   OK     spelling
   OK     valid

 FAIL   Koha/MarcMergeRules.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
                POD is missing for delete
                POD is missing for find_or_create
                POD is missing for object_class
                POD is missing for operations
                POD is missing for update
                POD is missing for validate
   OK     spelling
   OK     valid

 FAIL   Koha/MarcMergeRule.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
                POD is missing for 'store'
   OK     spelling
   OK     valid

 FAIL   Koha/MarcMergeRules.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
                POD is missing for delete
                POD is missing for find_or_create
                POD is missing for object_class
                POD is missing for operations
                POD is missing for update
                POD is missing for validate
   OK     spelling
   OK     valid


2) Please merge your 3 atomic update SQL files into one .perl file. That will
make the RM happy.

3) There is no sign-off line on the patch?

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============8630284729452148634==--