From bugzilla-daemon@bugs.koha-community.org Thu May 23 19:53:32 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22981] New: Remove type attribute from script	tags: Catalog
Date: Thu, 23 May 2019 17:53:28 +0000
Message-ID: <bug-22981-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0943850716924200679=="

--===============0943850716924200679==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22981

            Bug ID: 22981
           Summary: Remove type attribute from script tags: Catalog
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard@myacpl.org
          Reporter: oleonard@myacpl.org
        QA Contact: testopia@bugs.koha-community.org
            Blocks: 22956
  Target Milestone: ---

This patch will remove the obsolete "type" attribute from <script> tags in the
following catalog templates:

 - intranet-tmpl\prog\en\modules\catalogue\advsearch.tt
 - intranet-tmpl\prog\en\modules\catalogue\itemsearch.tt
 - intranet-tmpl\prog\en\modules\catalogue\search-history.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22956
[Bug 22956] Omnibus: Remove type attribute from script tags
-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0943850716924200679==--


From bugzilla-daemon@bugs.koha-community.org Thu May 23 19:53:38 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22981] Remove type attribute from script tags:	Catalog
Date: Thu, 23 May 2019 17:53:35 +0000
Message-ID: <bug-22981-70-X76w0TGpes@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22981-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2854232051503289340=="

--===============2854232051503289340==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22981

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2854232051503289340==--


From bugzilla-daemon@bugs.koha-community.org Thu May 23 20:39:05 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22981] Remove type attribute from script tags:	Catalog
Date: Thu, 23 May 2019 18:39:03 +0000
Message-ID: <bug-22981-70-5mhaKVQPWj@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22981-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3389185372895446321=="

--===============3389185372895446321==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22981

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3389185372895446321==--


From bugzilla-daemon@bugs.koha-community.org Thu May 23 20:39:08 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22981] Remove type attribute from script tags:	Catalog
Date: Thu, 23 May 2019 18:39:05 +0000
Message-ID: <bug-22981-70-lwwBiv4dig@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22981-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5710192673205760174=="

--===============5710192673205760174==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22981

--- Comment #1 from Owen Leonard <oleonard@myacpl.org> ---
Created attachment 90049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90049&action=edit
Bug 22981: Remove type attribute from script tags: Catalog

This patch removes the "type" attribute from <script> tags in several
catalog-related templates.

To test, apply the patch and confirm that the following work properly
without any JavaScript errors in the browser console:

 - Catalog -> Advanced search
 - Catalog -> Item search
 - Search history

Validating the HTML source of these pages should return no errors
related to the "type" attribute.

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============5710192673205760174==--


From bugzilla-daemon@bugs.koha-community.org Thu May 23 20:51:26 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22981] Remove type attribute from script tags:	Catalog
Date: Thu, 23 May 2019 18:51:19 +0000
Message-ID: <bug-22981-70-fLi7Qnibyp@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22981-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7803015876951359578=="

--===============7803015876951359578==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22981

Owen Leonard <oleonard@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7803015876951359578==--


From bugzilla-daemon@bugs.koha-community.org Fri May 24 03:42:03 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22981] Remove type attribute from script tags:	Catalog
Date: Fri, 24 May 2019 01:42:00 +0000
Message-ID: <bug-22981-70-8LA1zbqEEs@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22981-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7238938758077498054=="

--===============7238938758077498054==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22981

Hayley Mapley <hayleymapley@catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7238938758077498054==--


From bugzilla-daemon@bugs.koha-community.org Fri May 24 03:42:33 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22981] Remove type attribute from script tags:	Catalog
Date: Fri, 24 May 2019 01:42:03 +0000
Message-ID: <bug-22981-70-MBLqr8g9Zx@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22981-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3039511099641808633=="

--===============3039511099641808633==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22981

Hayley Mapley <hayleymapley@catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90049|0                           |1
        is obsolete|                            |

--- Comment #2 from Hayley Mapley <hayleymapley@catalyst.net.nz> ---
Created attachment 90058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90058&action=edit
Bug 22981: Remove type attribute from script tags: Catalog

This patch removes the "type" attribute from <script> tags in several
catalog-related templates.

To test, apply the patch and confirm that the following work properly
without any JavaScript errors in the browser console:

 - Catalog -> Advanced search
 - Catalog -> Item search
 - Search history

Validating the HTML source of these pages should return no errors
related to the "type" attribute.

Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3039511099641808633==--


From bugzilla-daemon@bugs.koha-community.org Mon May 27 22:57:25 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22981] Remove type attribute from script tags:	Catalog
Date: Mon, 27 May 2019 20:57:23 +0000
Message-ID: <bug-22981-70-C8NUyNzdbY@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22981-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8017156128593256001=="

--===============8017156128593256001==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22981

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8017156128593256001==--


From bugzilla-daemon@bugs.koha-community.org Mon May 27 22:57:37 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22981] Remove type attribute from script tags:	Catalog
Date: Mon, 27 May 2019 20:57:26 +0000
Message-ID: <bug-22981-70-6v7pNW9Xaz@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22981-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2173491434746275939=="

--===============2173491434746275939==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22981

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90058|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Created attachment 90127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90127&action=edit
Bug 22981: Remove type attribute from script tags: Catalog

This patch removes the "type" attribute from <script> tags in several
catalog-related templates.

To test, apply the patch and confirm that the following work properly
without any JavaScript errors in the browser console:

 - Catalog -> Advanced search
 - Catalog -> Item search
 - Search history

Validating the HTML source of these pages should return no errors
related to the "type" attribute.

Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2173491434746275939==--


From bugzilla-daemon@bugs.koha-community.org Thu May 30 12:40:24 2019
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject:
 [Koha-bugs] [Bug 22981] Remove type attribute from script tags:	Catalog
Date: Thu, 30 May 2019 10:40:18 +0000
Message-ID: <bug-22981-70-TajQrYX1hO@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-22981-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7281096432569680877=="

--===============7281096432569680877==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22981

Nick Clemens <nick@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick@bywatersolutions.com

--- Comment #4 from Nick Clemens <nick@bywatersolutions.com> ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============7281096432569680877==--