From bugzilla-daemon@bugs.koha-community.org Thu Oct 23 20:59:48 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41092] New: Some system preferences have target='blank' instead of target='_blank' Date: Thu, 23 Oct 2025 18:59:47 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3828300017472962956==" --===============3828300017472962956== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D41092 Bug ID: 41092 Summary: Some system preferences have target=3D'blank' instead of target=3D'_blank' Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com I found this while translating and I've never seen target=3D'blank' before, I= 've only ever seen target=3D'_blank' (with the underscore). koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref: = =20 - "The following database columns should be unique in an item:" koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref: = =20 - "The following database columns must be filled in on the patron modification screen:" koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref: = =20 - "The following database columns must be filled in on the patron entry screen:" koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref: = =20 - "The following database columns will not appear on the patron self-registration screen:" koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref: = =20 - "The following database columns will not appear on the patron self-modification screen:" koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref: = =20 - "Valid options are the database columns of the borrowers table, separated by | (pipe)." koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref: = =20 - "The following database columns must be filled in on the patron entry screen:" koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref: = =20 - "The following database columns will not appear on the patron entry screen:" koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref: = =20 - "The following database columns:" koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref: = =20 - "The following database columns:" --=20 You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============3828300017472962956==-- From bugzilla-daemon@bugs.koha-community.org Thu Oct 23 21:43:15 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41092] Some system preferences have target='blank' instead of target='_blank' Date: Thu, 23 Oct 2025 19:43:15 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0079315813803515298==" --===============0079315813803515298== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============0079315813803515298==-- From bugzilla-daemon@bugs.koha-community.org Thu Oct 23 21:43:27 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41092] Some system preferences have target='blank' instead of target='_blank' Date: Thu, 23 Oct 2025 19:43:17 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3501822891967488418==" --===============3501822891967488418== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D41092 --- Comment #1 from Caroline Cyr La Rose -= -- Created attachment 188393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D188393&action= =3Dedit Bug 41092: Some system preferences have target=3D'blank' instead of target=3D'_blank' This patch changes target=3D'blank' to target=3D'_blank' in system preferences. To test: 1. Apply the patch 2. Check the following system preferences, click on the links, make sure every click opens in a new tab - UniqueItemFields - PatronSelfModificationMandatoryField - PatronSelfRegistrationBorrowerMandatoryField - PatronSelfRegistrationBorrowerUnwantedField - PatronSelfModificationBorrowerUnwantedField - EmailFieldPrecedence - BorrowerMandatoryField - BorrowerUnwantedField - PatronQuickAddFields - PatronDuplicateMatchingAddFields --=20 You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============3501822891967488418==-- From bugzilla-daemon@bugs.koha-community.org Thu Oct 23 21:49:38 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41092] Some system preferences have target='blank' instead of target='_blank' Date: Thu, 23 Oct 2025 19:49:38 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0650634764616393100==" --===============0650634764616393100== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D41092 --- Comment #2 from Caroline Cyr La Rose -= -- For reference, Paul D. sent me this stack overflow answer regarding the difference between blank and _blank. One will open all the clicks in the same tab (it will open a new tab the first time, but then identify that tab as "blank" and open all further clicks in that same one), whereas _blank will op= en always in a new tab. (... Is how I understand it!) https://stackoverflow.com/questions/36769460/is-the-underscore-in-target-blan= k-no-longer-needed --=20 You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============0650634764616393100==-- From bugzilla-daemon@bugs.koha-community.org Fri Oct 24 01:01:53 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41092] Some system preferences have target='blank' instead of target='_blank' Date: Thu, 23 Oct 2025 23:01:52 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6510509190830003556==" --===============6510509190830003556== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. --===============6510509190830003556==-- From bugzilla-daemon@bugs.koha-community.org Fri Oct 24 01:02:11 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41092] Some system preferences have target='blank' instead of target='_blank' Date: Thu, 23 Oct 2025 23:02:10 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1671280018519432808==" --===============1671280018519432808== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 --- Comment #3 from David Cook --- Good catch. I recently noticed this somewhere in Koha as well I think... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============1671280018519432808==-- From bugzilla-daemon@bugs.koha-community.org Fri Oct 24 17:44:23 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41092] Some system preferences have target='blank' instead of target='_blank' Date: Fri, 24 Oct 2025 15:44:23 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7112653430687609220==" --===============7112653430687609220== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|String patch |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============7112653430687609220==-- From bugzilla-daemon@bugs.koha-community.org Fri Oct 24 17:44:34 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41092] Some system preferences have target='blank' instead of target='_blank' Date: Fri, 24 Oct 2025 15:44:25 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4175940686630528531==" --===============4175940686630528531== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188393|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 188413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188413&action=edit Bug 41092: Some system preferences have target='blank' instead of target='_blank' This patch changes target='blank' to target='_blank' in system preferences. To test: 1. Apply the patch 2. Check the following system preferences, click on the links, make sure every click opens in a new tab - UniqueItemFields - PatronSelfModificationMandatoryField - PatronSelfRegistrationBorrowerMandatoryField - PatronSelfRegistrationBorrowerUnwantedField - PatronSelfModificationBorrowerUnwantedField - EmailFieldPrecedence - BorrowerMandatoryField - BorrowerUnwantedField - PatronQuickAddFields - PatronDuplicateMatchingAddFields Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============4175940686630528531==-- From bugzilla-daemon@bugs.koha-community.org Sat Oct 25 01:26:48 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41092] Some system preferences have target='blank' instead of target='_blank' Date: Fri, 24 Oct 2025 23:26:47 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2375229196869941910==" --===============2375229196869941910== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============2375229196869941910==-- From bugzilla-daemon@bugs.koha-community.org Sat Oct 25 01:26:58 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41092] Some system preferences have target='blank' instead of target='_blank' Date: Fri, 24 Oct 2025 23:26:51 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0844556253005360645==" --===============0844556253005360645== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188413|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 188436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188436&action=edit Bug 41092: Some system preferences have target='blank' instead of target='_blank' This patch changes target='blank' to target='_blank' in system preferences. To test: 1. Apply the patch 2. Check the following system preferences, click on the links, make sure every click opens in a new tab - UniqueItemFields - PatronSelfModificationMandatoryField - PatronSelfRegistrationBorrowerMandatoryField - PatronSelfRegistrationBorrowerUnwantedField - PatronSelfModificationBorrowerUnwantedField - EmailFieldPrecedence - BorrowerMandatoryField - BorrowerUnwantedField - PatronQuickAddFields - PatronDuplicateMatchingAddFields Signed-off-by: Owen Leonard Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============0844556253005360645==-- From bugzilla-daemon@bugs.koha-community.org Sat Oct 25 01:36:52 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41092] Some system preferences have target='blank' instead of target='_blank' Date: Fri, 24 Oct 2025 23:36:52 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2273620818736618395==" --===============2273620818736618395== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D41092 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Text to go in the| |This fixes the HTML target release notes| |attribute for some system | |preference links that open | |a pop-up window or external | |link. The link attribute | |now uses "_blank" instead | |of "blank", and opens in a | |new tab for external links, | |and the same browser window | |for pop-up windows | |(modals). CC| |david@davidnind.com --- Comment #6 from David Nind --- Have changed to a minor bug, instead of an enhancement. QA script is happy. One thing I noticed, is that when you press "Save" for any changes in the pop-up windows, you get the notification "Saved preference XXXXX", but the "Save all XXX preferences" button in orange is still highlighted. Clicking th= at says "nothing to save". Outside the scope of this bug to fix that. --=20 You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============2273620818736618395==-- From bugzilla-daemon@bugs.koha-community.org Wed Oct 29 13:43:40 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41092] Some system preferences have target='blank' instead of target='_blank' Date: Wed, 29 Oct 2025 12:43:40 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4942049054926673971==" --===============4942049054926673971== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 Lucas Gass (lukeg) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass (lukeg) --- According to Bugzilla no one wrote this patch and no one QA'd it? Fill out the Assignee and QA Contact fields please. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============4942049054926673971==-- From bugzilla-daemon@bugs.koha-community.org Wed Oct 29 13:57:15 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41092] Some system preferences have target='blank' instead of target='_blank' Date: Wed, 29 Oct 2025 12:57:14 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4999345425707549240==" --===============4999345425707549240== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com QA Contact|testopia@bugs.koha-communit |david@davidnind.com |y.org | --- Comment #8 from David Nind --- (In reply to Lucas Gass (lukeg) from comment #7) > According to Bugzilla no one wrote this patch and no one QA'd it? > > Fill out the Assignee and QA Contact fields please. Fields updated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============4999345425707549240==-- From bugzilla-daemon@bugs.koha-community.org Fri Oct 31 22:34:00 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41092] Some system preferences have target='blank' instead of target='_blank' Date: Fri, 31 Oct 2025 21:32:07 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0550750788272763786==" --===============0550750788272763786== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 Lucas Gass (lukeg) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. --===============0550750788272763786==-- From bugzilla-daemon@bugs.koha-community.org Fri Oct 31 22:34:10 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41092] Some system preferences have target='blank' instead of target='_blank' Date: Fri, 31 Oct 2025 21:32:14 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1212577699689614655==" --===============1212577699689614655== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 --- Comment #9 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. --===============1212577699689614655==-- From bugzilla-daemon@bugs.koha-community.org Tue Nov 25 17:39:01 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41092] Some system preferences have target='blank' instead of target='_blank' Date: Tue, 25 Nov 2025 16:31:21 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9209432944580263930==" --===============9209432944580263930== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 Paul Derscheid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. --===============9209432944580263930==-- From bugzilla-daemon@bugs.koha-community.org Tue Nov 25 17:39:11 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41092] Some system preferences have target='blank' instead of target='_blank' Date: Tue, 25 Nov 2025 16:31:22 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9130861795430145902==" --===============9130861795430145902== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 --- Comment #10 from Paul Derscheid --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes. --===============9130861795430145902==-- From bugzilla-daemon@bugs.koha-community.org Tue Dec 2 10:33:29 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41092] Some system preferences have target='blank' instead of target='_blank' Date: Tue, 02 Dec 2025 09:33:28 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5941045079349349669==" --===============5941045079349349669== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable Version(s)|25.11.00,25.05.06 |25.11.00,25.05.06,24.11.11 released in| | --- Comment #11 from Fridolin Somers --- Pushed to 24.11.x for 24.11.11 -- You are receiving this mail because: You are watching all bug changes. --===============5941045079349349669==-- From bugzilla-daemon@bugs.koha-community.org Thu May 21 02:32:07 2026 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41092] Some system preferences have target='blank' instead of target='_blank' Date: Thu, 21 May 2026 00:32:07 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7021812656643011587==" --===============7021812656643011587== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 Wainui Witika-Park changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |Needs documenting --- Comment #12 from Wainui Witika-Park --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes. --===============7021812656643011587==-- From bugzilla-daemon@bugs.koha-community.org Thu May 21 09:25:07 2026 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 41092] Some system preferences have target='blank' instead of target='_blank' Date: Thu, 21 May 2026 07:25:07 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1898771301684612450==" --===============1898771301684612450== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #13 from David Nind --- Bug fix, no changes required to the manual. -- You are receiving this mail because: You are watching all bug changes. --===============1898771301684612450==--