From bugzilla-daemon@bugs.koha-community.org Fri Mar 3 14:32:40 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33126] New: Markup error in staff interface tab wrapper Date: Fri, 03 Mar 2023 13:32:40 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1635316105624175806==" --===============1635316105624175806== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 Bug ID: 33126 Summary: Markup error in staff interface tab wrapper Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 32571 There is a closing which lacks the slash. The example code also has an error. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes. --===============1635316105624175806==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 3 14:51:48 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33126] Markup error in staff interface tab wrapper Date: Fri, 03 Mar 2023 13:51:47 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3100829091324711402==" --===============3100829091324711402== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============3100829091324711402==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 3 14:51:59 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33126] Markup error in staff interface tab wrapper Date: Fri, 03 Mar 2023 13:51:49 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7849150039943528829==" --===============7849150039943528829== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 --- Comment #1 from Owen Leonard --- Created attachment 147697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147697&action=edit Bug 33126: Markup error in staff interface tab wrapper This patch makes a minor correction to the tab WRAPPER directives: a
  • which should be
  • . The patch also modifies the example WRAPPER markup to correct an error and clarify usage. To test, apply the patch and test a page which has been updated to use tab wrappers: The about page, basket groups, library transfer limits. Tabs should continue to work as expected. Before the patch, the about page source will include this:
  • After the patch the closing
  • will be correct. -- You are receiving this mail because: You are watching all bug changes. --===============7849150039943528829==-- From bugzilla-daemon@bugs.koha-community.org Tue Mar 7 12:49:41 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33126] Markup error in staff interface tab wrapper Date: Tue, 07 Mar 2023 11:49:40 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5004834453252464955==" --===============5004834453252464955== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147697|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 147826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147826&action=edit Bug 33126: Markup error in staff interface tab wrapper This patch makes a minor correction to the tab WRAPPER directives: a
  • which should be
  • . The patch also modifies the example WRAPPER markup to correct an error and clarify usage. To test, apply the patch and test a page which has been updated to use tab wrappers: The about page, basket groups, library transfer limits. Tabs should continue to work as expected. Before the patch, the about page source will include this:
  • After the patch the closing
  • will be correct. Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. --===============5004834453252464955==-- From bugzilla-daemon@bugs.koha-community.org Tue Mar 7 12:49:59 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33126] Markup error in staff interface tab wrapper Date: Tue, 07 Mar 2023 11:49:59 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8610290188958542012==" --===============8610290188958542012== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off --- Comment #3 from Sally --- Works as described, thanks for the patch. -- You are receiving this mail because: You are watching all bug changes. --===============8610290188958542012==-- From bugzilla-daemon@bugs.koha-community.org Wed Mar 15 18:44:14 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33126] Markup error in staff interface tab wrapper Date: Wed, 15 Mar 2023 17:44:13 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0523424994803797077==" --===============0523424994803797077== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147826|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 148231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148231&action=edit Bug 33126: Markup error in staff interface tab wrapper This patch makes a minor correction to the tab WRAPPER directives: a
  • which should be
  • . The patch also modifies the example WRAPPER markup to correct an error and clarify usage. To test, apply the patch and test a page which has been updated to use tab wrappers: The about page, basket groups, library transfer limits. Tabs should continue to work as expected. Before the patch, the about page source will include this:
  • After the patch the closing
  • will be correct. Signed-off-by: Sally Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. --===============0523424994803797077==-- From bugzilla-daemon@bugs.koha-community.org Wed Mar 15 18:46:06 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33126] Markup error in staff interface tab wrapper Date: Wed, 15 Mar 2023 17:46:05 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6549716414587390234==" --===============6549716414587390234== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Clear correction, passing QA -- You are receiving this mail because: You are watching all bug changes. --===============6549716414587390234==-- From bugzilla-daemon@bugs.koha-community.org Thu Mar 16 20:33:07 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33126] Markup error in staff interface tab wrapper Date: Thu, 16 Mar 2023 19:31:42 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2027075014340647020==" --===============2027075014340647020== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. --===============2027075014340647020==-- From bugzilla-daemon@bugs.koha-community.org Thu Mar 16 20:33:18 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33126] Markup error in staff interface tab wrapper Date: Thu, 16 Mar 2023 19:31:44 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1572196157371222793==" --===============1572196157371222793== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. --===============1572196157371222793==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 17 18:04:07 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33126] Markup error in staff interface tab wrapper Date: Fri, 17 Mar 2023 17:02:58 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3302605526630648646==" --===============3302605526630648646== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. --===============3302605526630648646==-- From bugzilla-daemon@bugs.koha-community.org Fri Mar 17 18:04:17 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33126] Markup error in staff interface tab wrapper Date: Fri, 17 Mar 2023 17:02:59 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4123901970285678503==" --===============4123901970285678503== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 --- Comment #7 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. --===============4123901970285678503==-- From bugzilla-daemon@bugs.koha-community.org Mon Jun 5 14:58:15 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33126] Markup error in staff interface tab wrapper Date: Mon, 05 Jun 2023 12:57:55 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3567494426204495610==" --===============3567494426204495610== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 Bug 33126 depends on bug 32571, which changed state. Bug 32571 Summary: Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. --===============3567494426204495610==-- From bugzilla-daemon@bugs.koha-community.org Mon Aug 25 19:07:27 2025 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 33126] Markup error in staff interface tab wrapper Date: Mon, 25 Aug 2025 17:05:48 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8759250480701227291==" --===============8759250480701227291== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33126 Bug 33126 depends on bug 32571, which changed state. Bug 32571 Summary: Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. --===============8759250480701227291==--