From bugzilla-daemon@bugs.koha-community.org Mon Aug 24 22:27:26 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] New: opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Mon, 24 Aug 2015 20:27:22 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1476843589793809978==" --===============1476843589793809978== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D14716 Bug ID: 14716 Summary: opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Created attachment 41870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D41870&action=3De= dit marc record with test data To reproduce Add a bib with the following data in biblioitems.marcxml: Magic tree house ; #6 39181 [the attached bib-14675.utf8 contains just such a record] Make sure that the fast indexer picks up the record. In the opac a title search for the bib; this should bring up opac-detail.pl Using view source The 'Series' link looks like this: Magic tree house ; #6 When url-decoded, the href looks like /cgi-bin/koha/opac-search.pl?q=3Dse,phr:"Magic tree house ;" ... this will not return any search results When the trailing space and semicolon is removed: /cgi-bin/koha/opac-search.pl?q=3Dse,phr:"Magic tree house" The resulting string can be url-encoded and appended to the opac base url -- this will return search results. --=20 You are receiving this mail because: You are watching all bug changes. --===============1476843589793809978==-- From bugzilla-daemon@bugs.koha-community.org Tue Oct 13 16:30:01 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Tue, 13 Oct 2015 14:29:54 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2653045588832470571==" --===============2653045588832470571== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D14716 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com --- Comment #1 from Kyle M Hall --- This is happening because the query is malformed. Take for example the query se,phr:"Frank%20Einstein%20;" which is=20 se,phr:"Frank Einstein" but the semicolon is truncating the query so it looks to Koha=20 se,phr:"Frank Einstein which is not a problem on the staff side. Zebra seems to deal with this ok. On the opac side though, we are adding on supression, so the query ends up li= ke this: (se,phr:"Frank Einstein ) not Suppress=3D1 which zebra chokes on. Removing the semicolon from the subject heading would fix this, but I imagine that's a band-aid as the semi is part of the standard. The semi is being treated as an ampersand. This is deep in the machinery ( http://www.w3.org/TR/1999/REC-html401-19991224/appendix/notes.html#h-B.2.2 ) Basically, the semi needs to be url encoded as %3B --=20 You are receiving this mail because: You are watching all bug changes. --===============2653045588832470571==-- From bugzilla-daemon@bugs.koha-community.org Tue Oct 13 17:31:34 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Tue, 13 Oct 2015 15:31:26 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0291009021887368471==" --===============0291009021887368471== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle.m.hall@gmail.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. --===============0291009021887368471==-- From bugzilla-daemon@bugs.koha-community.org Tue Oct 13 17:33:49 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Tue, 13 Oct 2015 15:33:45 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6078179525314014518==" --===============6078179525314014518== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #2 from Kyle M Hall --- Created attachment 43385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43385&action=edit MARC21 File for testing -- You are receiving this mail because: You are watching all bug changes. --===============6078179525314014518==-- From bugzilla-daemon@bugs.koha-community.org Tue Oct 13 17:36:33 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Tue, 13 Oct 2015 15:36:30 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1348758179244281395==" --===============1348758179244281395== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #3 from Kyle M Hall --- Created attachment 43386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43386&action=edit Bug 14716 - opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. This is happening because the query is malformed. Take for example the query se,phr:"Frank%20Einstein%20;" which is se,phr:"Frank Einstein" but the semicolon is truncating the query so it looks to Koha se,phr:"Frank Einstein which is not a problem on the staff side. Zebra seems to deal with this ok. On the opac side though, we are adding on supression, so the query ends up like this: (se,phr:"Frank Einstein ) not Suppress=1 which zebra chokes on. Removing the semicolon from the subject heading would fix this, but I imagine that's a band-aid as the semi is part of the standard. The semi is being treated as an ampersand. This is deep in the machinery ( http://www.w3.org/TR/1999/REC-html401-19991224/appendix/notes.html#h-B.2.2 ) Basically, the semi needs to be url encoded as %3B Test Plan: 1) Import the records in the attached MARC21 file, re-index 2) From the OPAC search for "Frank Einstein and the antimatter motor" 3) Click the series link, note you get no results 4) Apply this patch 5) Refresh the record details page 6) Click the series link 7) Results! NOTE: This bug does not occurr with all Koha server configurations. I have yet to determine the specific variable that creates this truncation behavior. -- You are receiving this mail because: You are watching all bug changes. --===============1348758179244281395==-- From bugzilla-daemon@bugs.koha-community.org Tue Oct 13 17:36:34 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Tue, 13 Oct 2015 15:36:28 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2506637081857650984==" --===============2506637081857650984== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============2506637081857650984==-- From bugzilla-daemon@bugs.koha-community.org Thu Oct 15 02:09:53 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Thu, 15 Oct 2015 00:09:44 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5984282314713370095==" --===============5984282314713370095== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. --===============5984282314713370095==-- From bugzilla-daemon@bugs.koha-community.org Thu Oct 15 02:28:37 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Thu, 15 Oct 2015 00:28:33 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9105251569396605559==" --===============9105251569396605559== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============9105251569396605559==-- From bugzilla-daemon@bugs.koha-community.org Thu Oct 15 02:28:39 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Thu, 15 Oct 2015 00:28:36 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5103879236283878043==" --===============5103879236283878043== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43386|0 |1 is obsolete| | --- Comment #4 from Mason James --- Created attachment 43412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43412&action=edit Bug 14716 - opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. This is happening because the query is malformed. Take for example the query se,phr:"Frank%20Einstein%20;" which is se,phr:"Frank Einstein" but the semicolon is truncating the query so it looks to Koha se,phr:"Frank Einstein which is not a problem on the staff side. Zebra seems to deal with this ok. On the opac side though, we are adding on supression, so the query ends up like this: (se,phr:"Frank Einstein ) not Suppress=1 which zebra chokes on. Removing the semicolon from the subject heading would fix this, but I imagine that's a band-aid as the semi is part of the standard. The semi is being treated as an ampersand. This is deep in the machinery ( http://www.w3.org/TR/1999/REC-html401-19991224/appendix/notes.html#h-B.2.2 ) Basically, the semi needs to be url encoded as %3B Test Plan: 1) Import the records in the attached MARC21 file, re-index 2) From the OPAC search for "Frank Einstein and the antimatter motor" 3) Click the series link, note you get no results 4) Apply this patch 5) Refresh the record details page 6) Click the series link 7) Results! NOTE: This bug does not occurr with all Koha server configurations. I have yet to determine the specific variable that creates this truncation behavior. Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. --===============5103879236283878043==-- From bugzilla-daemon@bugs.koha-community.org Thu Oct 15 02:30:09 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Thu, 15 Oct 2015 00:30:04 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0911851230770293138==" --===============0911851230770293138== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #5 from Mason James --- > Signed-off-by: Mason James thanks Barton - patch works perfectly for me -- You are receiving this mail because: You are watching all bug changes. --===============0911851230770293138==-- From bugzilla-daemon@bugs.koha-community.org Thu Oct 15 03:21:22 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Thu, 15 Oct 2015 01:21:19 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3015573512031106153==" --===============3015573512031106153== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #6 from Mason James --- Created attachment 43413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43413&action=edit Bug 14716 - opac-detail.pl -- Series link fails when series - [FOLLOWUP] correct 2 other problematic series links -- You are receiving this mail because: You are watching all bug changes. --===============3015573512031106153==-- From bugzilla-daemon@bugs.koha-community.org Thu Oct 15 03:22:48 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Thu, 15 Oct 2015 01:22:45 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4628150275820411041==" --===============4628150275820411041== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============4628150275820411041==-- From bugzilla-daemon@bugs.koha-community.org Thu Oct 15 03:23:28 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Thu, 15 Oct 2015 01:23:24 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4732799727555823193==" --===============4732799727555823193== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #7 from Mason James --- (In reply to Mason James from comment #6) > Created attachment 43413 [details] [review] > Bug 14716 - opac-detail.pl -- Series link fails when series - [FOLLOWUP] switching back to 'needs signoff' for followup patch -- You are receiving this mail because: You are watching all bug changes. --===============4732799727555823193==-- From bugzilla-daemon@bugs.koha-community.org Thu Oct 15 03:33:45 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Thu, 15 Oct 2015 01:33:41 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5304618214806709001==" --===============5304618214806709001== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13316 -- You are receiving this mail because: You are watching all bug changes. --===============5304618214806709001==-- From bugzilla-daemon@bugs.koha-community.org Thu Oct 29 18:14:57 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Thu, 29 Oct 2015 17:14:54 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7385116428535140612==" --===============7385116428535140612== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============7385116428535140612==-- From bugzilla-daemon@bugs.koha-community.org Thu Oct 29 18:15:01 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Thu, 29 Oct 2015 17:14:57 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7485005737366598634==" --===============7485005737366598634== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43412|0 |1 is obsolete| | Attachment #43413|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 44174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44174&action=edit Bug 14716 - opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. This is happening because the query is malformed. Take for example the query se,phr:"Frank%20Einstein%20;" which is se,phr:"Frank Einstein" but the semicolon is truncating the query so it looks to Koha se,phr:"Frank Einstein which is not a problem on the staff side. Zebra seems to deal with this ok. On the opac side though, we are adding on supression, so the query ends up like this: (se,phr:"Frank Einstein ) not Suppress=1 which zebra chokes on. Removing the semicolon from the subject heading would fix this, but I imagine that's a band-aid as the semi is part of the standard. The semi is being treated as an ampersand. This is deep in the machinery ( http://www.w3.org/TR/1999/REC-html401-19991224/appendix/notes.html#h-B.2.2 ) Basically, the semi needs to be url encoded as %3B Test Plan: 1) Import the records in the attached MARC21 file, re-index 2) From the OPAC search for "Frank Einstein and the antimatter motor" 3) Click the series link, note you get no results 4) Apply this patch 5) Refresh the record details page 6) Click the series link 7) Results! NOTE: This bug does not occurr with all Koha server configurations. I have yet to determine the specific variable that creates this truncation behavior. Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. --===============7485005737366598634==-- From bugzilla-daemon@bugs.koha-community.org Thu Oct 29 18:15:13 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Thu, 29 Oct 2015 17:15:07 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0707735937590541146==" --===============0707735937590541146== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #9 from Kyle M Hall --- Created attachment 44175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44175&action=edit Bug 14716 - opac-detail.pl -- Series link fails when series - [FOLLOWUP] correct 2 other problematic series links Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. --===============0707735937590541146==-- From bugzilla-daemon@bugs.koha-community.org Thu Nov 5 08:12:55 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Thu, 05 Nov 2015 07:12:52 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1728539758421452707==" --===============1728539758421452707== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #10 from Katrin Fischer --- Hm, wondering - why not remove the semicolon from the search term as we do in other places? -- You are receiving this mail because: You are watching all bug changes. --===============1728539758421452707==-- From bugzilla-daemon@bugs.koha-community.org Fri Dec 11 11:24:43 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Fri, 11 Dec 2015 10:24:38 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8103763922247642584==" --===============8103763922247642584== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. --===============8103763922247642584==-- From bugzilla-daemon@bugs.koha-community.org Sat Dec 12 07:12:05 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Sat, 12 Dec 2015 06:12:02 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0330978169390667365==" --===============0330978169390667365== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #11 from Mason James --- (In reply to Katrin Fischer from comment #10) > Hm, wondering - why not remove the semicolon from the search term as we do > in other places? Hmmm... why remove characters from a search term, when you have a working solution that allows those characters to be used? I think this solution is better -- You are receiving this mail because: You are watching all bug changes. --===============0330978169390667365==-- From bugzilla-daemon@bugs.koha-community.org Sat Dec 12 07:59:01 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Sat, 12 Dec 2015 06:58:56 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6495821634074908927==" --===============6495821634074908927== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |murphy.daniel.j@edumail.vic | |.gov.au --- Comment #12 from Mason James --- (In reply to Katrin Fischer from comment #10) > Hm, wondering - why not remove the semicolon from the search term as we do > in other places? also, its not just the semicolon that is a problem character, its any character *other* than these... !'()*-.0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ_abcdefghijklmnopqrstuvwxyz~ so, we would have to remove all other characters from all search terms, using that method its patch provides a general xslt solution to correctly encode problem characters within a url -- You are receiving this mail because: You are watching all bug changes. --===============6495821634074908927==-- From bugzilla-daemon@bugs.koha-community.org Sat Dec 12 08:18:04 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Sat, 12 Dec 2015 07:18:00 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4402589659392521485==" --===============4402589659392521485== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #13 from Mason James --- (In reply to Mason James from comment #11) > (In reply to Katrin Fischer from comment #10) > > Hm, wondering - why not remove the semicolon from the search term as we do > > in other places? > > Hmmm... why remove characters from a search term, when you have a working > solution that allows those characters to be used? > > I think this solution is better Cait, its not just the semicolon character that is causing a problem, here afaict, its any char thats *not* the following... !'()*-.0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ_abcdefghijklmnopqrstuvwxyz- so, your solution would require us to remove all those problem chars from a 'search term', rather than using a technique that correctly url-encodes them all If you are happy with my explaination, please change the status back to signed-off -- You are receiving this mail because: You are watching all bug changes. --===============4402589659392521485==-- From bugzilla-daemon@bugs.koha-community.org Sat Dec 12 08:21:12 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Sat, 12 Dec 2015 07:21:09 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4884774625080071722==" --===============4884774625080071722== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #14 from Mason James --- oops, double post (In reply to Mason James from comment #12) > (In reply to Katrin Fischer from comment #10) > > Hm, wondering - why not remove the semicolon from the search term as we do > > in other places? > > also, its not just the semicolon that is a problem character, > > Cait, its not just the semicolon character that is causing a problem, here > oups, doubled posted :) -- You are receiving this mail because: You are watching all bug changes. --===============4884774625080071722==-- From bugzilla-daemon@bugs.koha-community.org Thu Dec 17 01:38:46 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Thu, 17 Dec 2015 00:38:41 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4667775772333476163==" --===============4667775772333476163== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44175|0 |1 is obsolete| | --- Comment #15 from Mason James --- Created attachment 45743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45743&action=edit Bug 14716 - opac-detail.pl -- Series link fails when series - [FOLLOWUP] correct 2 other problematic series links Signed-off-by: Kyle M Hall Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. --===============4667775772333476163==-- From bugzilla-daemon@bugs.koha-community.org Thu Dec 17 01:42:41 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Thu, 17 Dec 2015 00:42:38 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1424346071076654812==" --===============1424346071076654812== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #16 from Mason James --- (In reply to Mason James from comment #7) > (In reply to Mason James from comment #6) > > Created attachment 43413 [details] [review] [review] > > Bug 14716 - opac-detail.pl -- Series link fails when series - [FOLLOWUP] > > switching back to 'needs signoff' for followup patch follow-up patch is now 'signed-off' -- You are receiving this mail because: You are watching all bug changes. --===============1424346071076654812==-- From bugzilla-daemon@bugs.koha-community.org Thu Dec 17 01:51:54 2015 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Date: Thu, 17 Dec 2015 00:51:50 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3906367560005197691==" --===============3906367560005197691== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D14716 --- Comment #17 from Mason James --- (In reply to Mason James from comment #13) > (In reply to Mason James from comment #11) > > (In reply to Katrin Fischer from comment #10) > > > Hm, wondering - why not remove the semicolon from the search term as we= do > > > in other places? >=20 > If you are happy with my explanation, please change the status back to > signed-off waiting for a response from Cait here --=20 You are receiving this mail because: You are watching all bug changes. --===============3906367560005197691==--