From bugzilla-daemon@bugs.koha-community.org Thu Jul 19 16:21:41 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21091] New: Move add item template JavaScript to a separate file Date: Thu, 19 Jul 2018 14:21:38 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5038812438467750746==" --===============5038812438467750746== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21091 Bug ID: 21091 Summary: Move add item template JavaScript to a separate file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org I would like to modify the add item template (additem.tt) to move JavaScript from the to separate files: cataloging_additem.js and cataloging_additem.inc (for defining translatable strings used in the js). -- You are receiving this mail because: You are watching all bug changes. --===============5038812438467750746==-- From bugzilla-daemon@bugs.koha-community.org Thu Jul 19 16:49:42 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21091] Move add item template JavaScript to a separate file Date: Thu, 19 Jul 2018 14:49:39 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6310727340300718103==" --===============6310727340300718103== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21091 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. --===============6310727340300718103==-- From bugzilla-daemon@bugs.koha-community.org Thu Jul 19 16:49:45 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21091] Move add item template JavaScript to a separate file Date: Thu, 19 Jul 2018 14:49:42 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5391563318612489983==" --===============5391563318612489983== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21091 --- Comment #1 from Owen Leonard --- Created attachment 77135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77135&action=edit Bug 21091: Move add item template JavaScript to a separate file This patch moves the JavaScript in the add item template to separate files: 1 JS file and 1 include file containing translatable strings. While moving the JS to cataloging_additem.js I have made some changes to quiet ESLint warnings (spacing, variable definition). To test, apply the patch and open the add item page for an existing record. Test the various JS-driven functionalities: - Table sorting - Table column configuration - Table searching - Table inline edit/delete links (click anywhere in the table row) - Add multiple item form show/hide - Add multiple item warning when adding 100+ items -- You are receiving this mail because: You are watching all bug changes. --===============5391563318612489983==-- From bugzilla-daemon@bugs.koha-community.org Thu Aug 16 09:55:16 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21091] Move add item template JavaScript to a separate file Date: Thu, 16 Aug 2018 07:55:13 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1611391580692193755==" --===============1611391580692193755== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21091 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============1611391580692193755==-- From bugzilla-daemon@bugs.koha-community.org Thu Aug 16 09:55:19 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21091] Move add item template JavaScript to a separate file Date: Thu, 16 Aug 2018 07:55:16 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4093244950976468926==" --===============4093244950976468926== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21091 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77135|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 77876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77876&action=edit Bug 21091: Move add item template JavaScript to a separate file This patch moves the JavaScript in the add item template to separate files: 1 JS file and 1 include file containing translatable strings. While moving the JS to cataloging_additem.js I have made some changes to quiet ESLint warnings (spacing, variable definition). To test, apply the patch and open the add item page for an existing record. Test the various JS-driven functionalities: - Table sorting - Table column configuration - Table searching - Table inline edit/delete links (click anywhere in the table row) - Add multiple item form show/hide - Add multiple item warning when adding 100+ items Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. --===============4093244950976468926==-- From bugzilla-daemon@bugs.koha-community.org Fri Aug 17 18:02:46 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21091] Move add item template JavaScript to a separate file Date: Fri, 17 Aug 2018 16:02:43 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7798203913342147822==" --===============7798203913342147822== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D21091 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart = --- Please rebase on top of bug 13618. I do not think we should move the declaration of columns_settings in the .inc, it should be stay close to the datatables init. --=20 You are receiving this mail because: You are watching all bug changes. --===============7798203913342147822==-- From bugzilla-daemon@bugs.koha-community.org Sun Aug 26 18:40:48 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21091] Move add item template JavaScript to a separate file Date: Sun, 26 Aug 2018 16:40:45 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4614331024447271037==" --===============4614331024447271037== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21091 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer --- Owen, can you please rebase and take a look at Jonathan's comment#3? Thx! -- You are receiving this mail because: You are watching all bug changes. --===============4614331024447271037==-- From bugzilla-daemon@bugs.koha-community.org Wed Nov 28 19:24:47 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21091] Move add item template JavaScript to a separate file Date: Wed, 28 Nov 2018 18:24:44 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2085199283514639136==" --===============2085199283514639136== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21091 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============2085199283514639136==-- From bugzilla-daemon@bugs.koha-community.org Wed Nov 28 19:24:51 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21091] Move add item template JavaScript to a separate file Date: Wed, 28 Nov 2018 18:24:47 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1883585051416737703==" --===============1883585051416737703== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21091 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77876|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 82707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82707&action=edit Bug 21091: Move add item template JavaScript to a separate file This patch moves the JavaScript in the add item template to separate files: 1 JS file and 1 include file containing translatable strings. While moving the JS to cataloging_additem.js I have made some changes to quiet ESLint warnings (spacing, variable definition). To test, apply the patch and open the add item page for an existing record. Test the various JS-driven functionalities: - Table sorting - Table column configuration - Table searching - Table inline edit/delete links (click anywhere in the table row) - Add multiple item form show/hide - Add multiple item warning when adding 100+ items -- You are receiving this mail because: You are watching all bug changes. --===============1883585051416737703==-- From bugzilla-daemon@bugs.koha-community.org Wed Nov 28 19:26:16 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21091] Move add item template JavaScript to a separate file Date: Wed, 28 Nov 2018 18:26:13 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7360170893363125933==" --===============7360170893363125933== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21091 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. --===============7360170893363125933==-- From bugzilla-daemon@bugs.koha-community.org Wed Nov 28 19:26:36 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21091] Move add item template JavaScript to a separate file Date: Wed, 28 Nov 2018 18:26:06 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3741066932975490557==" --===============3741066932975490557== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21091 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82707|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. --===============3741066932975490557==-- From bugzilla-daemon@bugs.koha-community.org Wed Nov 28 19:34:07 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21091] Move add item template JavaScript to a separate file Date: Wed, 28 Nov 2018 18:34:04 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1927733394226708048==" --===============1927733394226708048== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21091 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============1927733394226708048==-- From bugzilla-daemon@bugs.koha-community.org Wed Nov 28 19:34:10 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21091] Move add item template JavaScript to a separate file Date: Wed, 28 Nov 2018 18:34:07 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8772676178173679077==" --===============8772676178173679077== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21091 --- Comment #6 from Owen Leonard --- Created attachment 82708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82708&action=edit Bug 21091: Move add item template JavaScript to a separate file This patch moves the JavaScript in the add item template to separate files: 1 JS file and 1 include file containing translatable strings. While moving the JS to cataloging_additem.js I have made some changes to quiet ESLint warnings (spacing, variable definition). To test, apply the patch and open the add item page for an existing record. Test the various JS-driven functionalities: - Table sorting - Table column configuration - Table searching - Table inline edit/delete links (click anywhere in the table row) - Add multiple item form show/hide - Add multiple item warning when adding 100+ items -- You are receiving this mail because: You are watching all bug changes. --===============8772676178173679077==-- From bugzilla-daemon@bugs.koha-community.org Wed Nov 28 19:35:11 2018 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 21091] Move add item template JavaScript to a separate file Date: Wed, 28 Nov 2018 18:35:08 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8222071150512126020==" --===============8222071150512126020== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21091 --- Comment #7 from Owen Leonard --- (In reply to Jonathan Druart from comment #3) > I do not think we should move the declaration of columns_settings in the > .inc, it should be stay close to the datatables init. I don't think it makes sense to create a whole new