From bugzilla-daemon@bugs.koha-community.org Tue Feb 23 21:14:39 2016 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 15888] New: Syndetics Reviews preference should not enable LibraryThing reviews Date: Tue, 23 Feb 2016 20:14:34 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4196062248178097862==" --===============4196062248178097862== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D15888 Bug ID: 15888 Summary: Syndetics Reviews preference should not enable LibraryThing reviews Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org On opac-detail.pl the code below attempts to retrieve LibraryThing content wh= en SyndeticsReviews are enabled even if the librarything prefs are not turned on 564 [% IF ( SyndeticsReviews && SYNDETICS_REVIEWS ) %] 565
  • Reviews
    • 566
  • 567 [% IF ( using_https ) %] 568 569 570 [% ELSE %] 571 572 573 [% END %] 57
    • 575 [% END %] --=20 You are receiving this mail because: You are watching all bug changes. --===============4196062248178097862==-- From bugzilla-daemon@bugs.koha-community.org Tue Feb 23 21:42:34 2016 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 15888] Syndetics Reviews preference should not enable LibraryThing reviews Date: Tue, 23 Feb 2016 20:42:30 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7649655214846416292==" --===============7649655214846416292== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15888 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|oleonard@myacpl.org |nick@bywatersolutions.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. --===============7649655214846416292==-- From bugzilla-daemon@bugs.koha-community.org Tue Feb 23 21:55:54 2016 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 15888] Syndetics Reviews preference should not enable LibraryThing reviews Date: Tue, 23 Feb 2016 20:55:52 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1688692079940968155==" --===============1688692079940968155== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15888 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============1688692079940968155==-- From bugzilla-daemon@bugs.koha-community.org Tue Feb 23 21:55:56 2016 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 15888] Syndetics Reviews preference should not enable LibraryThing reviews Date: Tue, 23 Feb 2016 20:55:53 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8116020029899749056==" --===============8116020029899749056== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D15888 --- Comment #1 from Nick Clemens --- Created attachment 48320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D48320&action=3D= edit Bug 15888 - Syndetics Reviews preference should not enable LibraryThing revie= ws To test: 1 - Enable Syndetics Reviews without a LibraryThing ID 2 - Check page source and note you have a stanza for LTFL tabbed reveiws 3 - Apply patch 4 - Reload page and note LTFL tabbed reviews are not present 5 - Enter a LibraryThing ID and not the tab is restored. --=20 You are receiving this mail because: You are watching all bug changes. --===============8116020029899749056==-- From bugzilla-daemon@bugs.koha-community.org Wed Mar 2 09:29:18 2016 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 15888] Syndetics Reviews preference should not enable LibraryThing reviews Date: Wed, 02 Mar 2016 08:29:12 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6065454845981389754==" --===============6065454845981389754== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15888 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============6065454845981389754==-- From bugzilla-daemon@bugs.koha-community.org Wed Mar 2 09:29:18 2016 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 15888] Syndetics Reviews preference should not enable LibraryThing reviews Date: Wed, 02 Mar 2016 08:29:15 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0533767936159233361==" --===============0533767936159233361== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D15888 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48320|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 48540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D48540&action=3D= edit Bug 15888 - Syndetics Reviews preference should not enable LibraryThing revie= ws To test: 1 - Enable Syndetics Reviews without a LibraryThing ID 2 - Check page source and note you have a stanza for LTFL tabbed reveiws 3 - Apply patch 4 - Reload page and note LTFL tabbed reviews are not present 5 - Enter a LibraryThing ID and not the tab is restored. Signed-off-by: Chris Cormack --=20 You are receiving this mail because: You are watching all bug changes. --===============0533767936159233361==-- From bugzilla-daemon@bugs.koha-community.org Thu Mar 24 08:04:55 2016 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 15888] Syndetics Reviews preference should not enable LibraryThing reviews Date: Thu, 24 Mar 2016 07:04:53 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6687725502572346669==" --===============6687725502572346669== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15888 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============6687725502572346669==-- From bugzilla-daemon@bugs.koha-community.org Thu Mar 24 08:04:58 2016 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 15888] Syndetics Reviews preference should not enable LibraryThing reviews Date: Thu, 24 Mar 2016 07:04:56 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2451506666993188500==" --===============2451506666993188500== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15888 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48540|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 49519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49519&action=edit [PASSED QA] Bug 15888 - Syndetics Reviews preference should not enable LibraryThing reviews To test: 1 - Enable Syndetics Reviews without a LibraryThing ID 2 - Check page source and note you have a stanza for LTFL tabbed reveiws 3 - Apply patch 4 - Reload page and note LTFL tabbed reviews are not present 5 - Enter a LibraryThing ID and not the tab is restored. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. --===============2451506666993188500==-- From bugzilla-daemon@bugs.koha-community.org Thu Mar 24 17:08:10 2016 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 15888] Syndetics Reviews preference should not enable LibraryThing reviews Date: Thu, 24 Mar 2016 16:08:04 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7279079348864035094==" --===============7279079348864035094== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15888 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. --===============7279079348864035094==-- From bugzilla-daemon@bugs.koha-community.org Thu Apr 7 07:48:51 2016 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 15888] Syndetics Reviews preference should not enable LibraryThing reviews Date: Thu, 07 Apr 2016 05:48:48 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0575307480622644488==" --===============0575307480622644488== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15888 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes. --===============0575307480622644488==-- From bugzilla-daemon@bugs.koha-community.org Wed Apr 27 17:37:36 2016 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 15888] Syndetics Reviews preference should not enable LibraryThing reviews Date: Wed, 27 Apr 2016 15:37:26 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7402363516167892080==" --===============7402363516167892080== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15888 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #6 from Frédéric Demians --- Pushed to 3.20.x, will be in 3.20.11. -- You are receiving this mail because: You are watching all bug changes. --===============7402363516167892080==--