From bugzilla-daemon@bugs.koha-community.org Fri Feb  3 15:56:38 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC
Date: Fri, 03 Feb 2023 14:56:30 +0000
Message-ID: <bug-8628-70-TxjNsLy95U@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-8628-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1075765462371303727=="

--===============1075765462371303727==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D8628

--- Comment #128 from Magnus Enger <magnus@libriotech.no> ---
Great to see this is being kept alive after so many years! :-)=20

I had the same initial error as David and Solene. I was able to make it go aw=
ay
by doing this:=20

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt
b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt
index 931079996c..f8b57c0db7 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt
@@ -373,7 +373,7 @@
             </tr>
             </thead>
             <tbody>
-                [% FOREACH s IN signs %]
+                [% FOREACH s IN signs.next %]
                 <tr>
                     <td><a
href=3D"/cgi-bin/koha/tools/signs.pl?op=3Dview_sign&amp;sign_id=3D[% s.sign_i=
d | uri
%]">[% s.name | html %]</a></td>
                     <td>[% IF ( s.webapp ) %]Yes[% ELSE %]No[% END %]</td>
@@ -413,7 +413,7 @@
             </tr>
             </thead>
             <tbody>
-                [% FOREACH s IN streams %]
+                [% FOREACH s IN streams.next %]
                 <tr>
                     <td><a
href=3D"/cgi-bin/koha/tools/signs.pl?op=3Dview_stream&amp;sign_stream_id=3D[%
s.sign_stream_id | uri %]">[% s.name | html %]</a></td>
                     <td title=3D"ID: [% s.saved_sql_id | html %]">[%
s.saved_sql.report_name | html %]</td>

But I have problems getting the one sign I added to display, so that change
might be just nonsense.=20

I was also getting a JS error when viewing the table of signs. It seems to be
am invalid value for sPaginationType, so this made the error go away:=20

@@ -451,13 +451,13 @@
             "aoColumnDefs": [
                 { "aTargets": [ -1 ], "bSearchable": false, "bSortable": fal=
se
},
             ],
-            "sPaginationType": "four_button"
+            "sPaginationType": "full"
         }));
         $("#table_streams").dataTable($.extend(true, {}, dataTablesDefaults,=
 {
             "aoColumnDefs": [
                 { "aTargets": [ -1 ], "bSearchable": false, "bSortable": fal=
se
},
             ],
-            "sPaginationType": "four_button"
+            "sPaginationType": "full"
         }));

Not sure if "full" is the pagination we want, though.

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============1075765462371303727==--