[Bug 14928] New: Remove C4::Dates from files acqui/pdfformat/layout*.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 Bug ID: 14928 Summary: Remove C4::Dates from files acqui/pdfformat/layout*.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org This patch removes C4::Dates from: - acqui/pdfformat/layout2pages.pm - acqui/pdfformat/layout2pagesde.pm - acqui/pdfformat/layout3pages.pm - acqui/pdfformat/layout3pagesfr.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 42975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42975&action=edit Bug 14928 - Remove C4::Dates from files acqui/pdfformat/layout*.pm This patch removes C4::Dates from: - acqui/pdfformat/layout2pages.pm - acqui/pdfformat/layout2pagesde.pm - acqui/pdfformat/layout3pages.pm - acqui/pdfformat/layout3pagesfr.pm To test: - Apply patch - Go to Home > Acquisitions > [Vendor] > Basket groups - Print a basket (order) - Verify that the current date is formatted respects syspref 'dateformat' - Do the same with syspref 'OrderPdfFormat' set to the four different choices -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |veron@veron.ch Blocks| |14870 Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42975|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42991&action=edit [COUNTER-PATCH] Bug 14928: Remove C4::Dates from circ/pendingreserves.pl This patch uses Koha::DateUtils instead of C4::Dates and Date::Calc. It also sent DateTime objects to the template, which use the TT plugin to display them. If an invalid dates is entered, the default date is picked. Test plan: 1/ Go to Home > Circulation > Holds to pull 2/ Verify that the the filter and the list behave as before 3/ Enter invalid dates and confirm that you do not get a software error -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Attachment #42975|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42991|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Wrong bug report, sorry about that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42975|0 |1 is obsolete| | --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 43286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43286&action=edit [SIGNED-OFF]Bug 14928 - Remove C4::Dates from files acqui/pdfformat/layout*.pm This patch removes C4::Dates from: - acqui/pdfformat/layout2pages.pm - acqui/pdfformat/layout2pagesde.pm - acqui/pdfformat/layout3pages.pm - acqui/pdfformat/layout3pagesfr.pm To test: - Apply patch - Go to Home > Acquisitions > [Vendor] > Basket groups - Print a basket (order) - Verify that the current date is formatted respects syspref 'dateformat' - Do the same with syspref 'OrderPdfFormat' set to the four different choices Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Date printed in PDF Ok -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43286|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43291&action=edit Bug 14928 - Remove C4::Dates from files acqui/pdfformat/layout*.pm This patch removes C4::Dates from: - acqui/pdfformat/layout2pages.pm - acqui/pdfformat/layout2pagesde.pm - acqui/pdfformat/layout3pages.pm - acqui/pdfformat/layout3pagesfr.pm To test: - Apply patch - Go to Home > Acquisitions > [Vendor] > Basket groups - Print a basket (order) - Verify that the current date is formatted respects syspref 'dateformat' - Do the same with syspref 'OrderPdfFormat' set to the four different choices Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Date printed in PDF Ok Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org