[Bug 12302] New: OPAC course details not displaying item status correctly for itemtypes that are not for loan
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Bug ID: 12302 Summary: OPAC course details not displaying item status correctly for itemtypes that are not for loan Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org If an item is not for loan based on it's itemtype, opac-detail.pl will show the item as "Not for loan" but opac-course-details.pl will show the item as "Available". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28402&action=edit Bug 12302 - OPAC course details not displaying item status correctly for itemtypes that are not for loan If an item is not for loan based on it's itemtype, opac-detail.pl will show the item as "Not for loan" but opac-course-details.pl will show the item as "Available". Test Plan: 1) Enable course reserves 2) Create a course, add an item to it 3) Edit that item's itemtype, set it to not for loan 4) View the item from opac-detail.pl, note the status is "Not for loan" 5) View the item from opac-course-details.pl, note the status is "Available" 6) Apply this patch 7) Reload opac-course-details.pl, not the status is now "Not for loan" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28402|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28403&action=edit Bug 12302 - OPAC course details not displaying item status correctly for itemtypes that are not for loan If an item is not for loan based on it's itemtype, opac-detail.pl will show the item as "Not for loan" but opac-course-details.pl will show the item as "Available". Test Plan: 1) Enable course reserves 2) Create a course, add an item to it 3) Edit that item's itemtype, set it to not for loan 4) View the item from opac-detail.pl, note the status is "Not for loan" 5) View the item from opac-course-details.pl, note the status is "Available" 6) Apply this patch 7) Reload opac-course-details.pl, not the status is now "Not for loan" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org --- Comment #3 from Nick Clemens <nick@quecheelibrary.org> --- Hi Kyle, I tried testing, but after applying the patch I lose all info except availability and notes on opac-course-details.pl Item still shows as available as well -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13155 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13155 Depends on|13155 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #4 from Frédéric Demians <frederic@tamil.fr> --- *** Bug 13155 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28403|0 |1 is obsolete| | --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 32851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32851&action=edit Bug 12302 - OPAC course details not displaying item status correctly for itemtypes that are not for loan If an item is not for loan based on it's itemtype, opac-detail.pl will show the item as "Not for loan" but opac-course-details.pl will show the item as "Available". Test Plan: 1) Enable course reserves 2) Create a course, add an item to it 3) Edit that item's itemtype, set it to not for loan 4) View the item from opac-detail.pl, note the status is "Not for loan" 5) View the item from opac-course-details.pl, note the status is "Available" 6) Apply this patch 7) Reload opac-course-details.pl, not the status is now "Not for loan" Signed-off-by: Frederic Demians <f.demians@tamil.fr> This is a revised version of the patch, introducing a invalid display on item table (see obsolete bug 13155). It works, and correct the bug described by Kyle. A 2nd sign-off may be necessrary. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Nick Clemens from comment #3)
Hi Kyle,
I tried testing, but after applying the patch I lose all info except availability and notes on opac-course-details.pl
Item still shows as available as well
Test the revised patch to confirm it works for you. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32851|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 32852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32852&action=edit [SIGNED OFF] Bug 12302 - OPAC course details not displaying item status correctly for itemtypes that are not for loan If an item is not for loan based on it's itemtype, opac-detail.pl will show the item as "Not for loan" but opac-course-details.pl will show the item as "Available". Test Plan: 1) Enable course reserves 2) Create a course, add an item to it 3) Edit that item's itemtype, set it to not for loan 4) View the item from opac-detail.pl, note the status is "Not for loan" 5) View the item from opac-course-details.pl, note the status is "Available" 6) Apply this patch 7) Reload opac-course-details.pl, not the status is now "Not for loan" Signed-off-by: Frederic Demians <f.demians@tamil.fr> This is a revised version of the patch, introducing a invalid display on item table (see obsolete bug 13155). It works, and correct the bug described by Kyle. A 2nd sign-off may be necessrary. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch works, but I see 2 problems: - It only checks for the notforloan on the itemtype, but not for the notforloan in the item record itself. We should check both to match the behaviour on the result list and in other places. - The change in GetBiblioFromItemnumber should be backed up by unit tests. Failing for the second, but the first should be fixed here or separately to have a more complete fix. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=3333 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org