[Bug 20480] New: Fix styling issues on bad SCI/SCO module logins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20480 Bug ID: 20480 Summary: Fix styling issues on bad SCI/SCO module logins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org When one of this modules is tried, with either wrong credentials or a user without access, the Auth.pm code short-circuits to the login page, but the KOHA_VERSION template param is never set. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20480 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20480 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12904, 15492 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 [Bug 12904] Force browser to load new JavaScript and CSS files after upgrade https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 [Bug 15492] Stand alone self check-in tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20480 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20480 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 73319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73319&action=edit Bug 20480: Make KOHA_VERSION available to all templates in all circumstances This patch makes C4::Templates::gettemplate set the KOHA_VERSION param for the template. This way this template parameter, which is required by (probably) all pages that include CSS/JS content is available in all circumstances. A noticeable problem with the current approach is when using the SCO and SCI modules with wrong/forbidden users: C4::Auth short-circuits and redirects to the login page, without setting the KOHA_VERSION param. This patch solves it for good. To test: - Enable the SCI module - Open the browser at http://localhost:8080/cgi-bin/koha/sci/sci-main.pl - Login with the db user (koha_kohadev / password) => FAIL: Login failure, but styling is broken - Apply this patch - Retry => SUCCESS: Everything looks as it should! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20480 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73330&action=edit Bug 20480: send KOHA_VERSION even if only one language is enabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20480 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73330|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 73332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73332&action=edit Bug 20480: send KOHA_VERSION even if only one language is enabled Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20480 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20480 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73319|0 |1 is obsolete| | Attachment #73332|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 73333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73333&action=edit Bug 20480: Make KOHA_VERSION available to all templates in all circumstances This patch makes C4::Templates::gettemplate set the KOHA_VERSION param for the template. This way this template parameter, which is required by (probably) all pages that include CSS/JS content is available in all circumstances. A noticeable problem with the current approach is when using the SCO and SCI modules with wrong/forbidden users: C4::Auth short-circuits and redirects to the login page, without setting the KOHA_VERSION param. This patch solves it for good. To test: - Enable the SCI module - Open the browser at http://localhost:8080/cgi-bin/koha/sci/sci-main.pl - Login with the db user (koha_kohadev / password) => FAIL: Login failure, but styling is broken - Apply this patch - Retry => SUCCESS: Everything looks as it should! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20480 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 73334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73334&action=edit Bug 20480: send KOHA_VERSION even if only one language is enabled Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20480 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20480 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20480 Bug 20480 depends on bug 15492, which changed state. Bug 15492 Summary: Stand alone self check-in tool https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org