[Bug 21683] New: Remove accountlines.accountno
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Bug ID: 21683 Summary: Remove accountlines.accountno Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org This database column is obsolete. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Assignee|koha-bugs@lists.koha-commun |josef.moravec@gmail.com |ity.org | Depends on| |21678, 21680, 21681 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21678 [Bug 21678] Adding debit "Renewal of Rental Item" and "Reserve Charge" does not create account offset https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21680 [Bug 21680] Remove dead code C4::Accounts::fixaccounts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21681 [Bug 21681] Remove C4::Accounts::getcharges -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 81281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81281&action=edit Bug 21683: Database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 81282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81282&action=edit Bug 21683: Remove accountlines.accountno Test plan: 1) Play with fines, should work OK 2) Try to print receipts on fines - prinfeercpt.pl, printinvoice.pl 3) git grep getnextacctno -> no occurences 4) git grep accountno should return only: installer/data/mysql/atomicupdate/bug_21683_remove_column_accountno.perl installer/data/mysql/update22to30.pl misc/release_notes/release_notes_3_10_0.txt misc/release_notes/release_notes_3_22_0.txt 5) prove t/db_dependent/Accounts.t t/db_dependent/ILSDI_Services.t t/db_dependent/Stats.t t/db_dependent/Koha/Account.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 81283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81283&action=edit Bug 21683: Update schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21679 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21641 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21658 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 81282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81282 Bug 21683: Remove accountlines.accountno Review of attachment 81282: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21683&attachment=81282) ----------------------------------------------------------------- Some of these are issues. Some of them are reminders, at least for me, to look more closely in places that might have side-effects. ::: C4/Circulation.pm @@ +2400,4 @@
accounttype => { -in => [ 'L', 'Rep', 'W' ] }, }, { + order_by => { -desc => [ 'date' ] }
accountno was being used to keep them in the same order they were added. I would have substituted accountlines_id for the same effect. I noticed the other patched files were. ::: C4/Stats.pm @@ +130,5 @@
(datetime, branch, type, value, other, itemnumber, itemtype, location, + borrowernumber, ccode) + VALUES (now(),?,?,?,?,?,?,?,?,?)"
Strangely enough, I think the defaulting to null is better for the statistics for fine/charges. accountno was NOT really a "type of procedure used when making payments". But I'm going to have to read the code as a whole after application to make sure this didn't mess things up for other statistics. ::: Koha/Account.pm @@ -93,5 @@
- { - order_by => 'accountno' - } - )->next(); - my $accountno = $last ? $last->accountno + 1 : 1;
This was what I was thinking should be it's only function in the Koha namespace, before notions of removing it came out. @@ -351,5 @@
sub { - # We should remove accountno, it is no longer needed - my $last = Koha::Account::Lines->search( { borrowernumber => $self->{patron_id} }, - { order_by => 'accountno' } )->next(); - my $accountno = $last ? $last->accountno + 1 : 1;
See how it was put in multiple places? That's why. ::: members/printfeercpt.pl @@ -56,5 @@
-if ( $action eq 'print' ) { -# ReversePayment( $borrowernumber, $input->param('accountno') ); -} -
Scope creep! ;) -- but totally fine. ::: misc/maintenance/fix_accountlines_date.pl @@ -127,4 @@
our $dbh = C4::Context->dbh; $dbh->{AutoCommit} = 0; my $sth = $dbh->prepare(" -SELECT borrowernumber, itemnumber, accountno, description
Will need to read applied patch to see if removing itemnumber from query has impact. ::: misc/maintenance/fix_accountlines_rmdupfines_bug8253.pl @@ +98,4 @@
}
my $sql = + "DELETE FROM accountlines WHERE accountlines_id = ? LIMIT 1";
accountlines_id is auto increment and thus unique. There is no need for LIMIT 1. @@ +103,5 @@
}
if ($has_changed) { my $sql = + "UPDATE accountlines SET amountoutstanding = ? WHERE accountlines_id = ? LIMIT 1";
accountlines_id is auto increment and thus unique. There is no need for LIMIT 1. ::: t/db_dependent/Stats.t @@ -120,4 @@
is ($params->{other}, $line->{other}, "UpdateStats save other param in other field of statistics table"); is ($params->{itemtype}, $line->{itemtype}, "UpdateStats save itemtype param in itemtype field of statistics table"); is ($params->{location}, $line->{location}, "UpdateStats save location param in location field of statistics table"); -is ($params->{accountno}, $line->{proccode}, "UpdateStats save accountno param in proccode field of statistics table");
Removed test, could have changed test to confirm it is null/undef. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Bug 21683 depends on bug 21678, which changed state. Bug 21678 Summary: Adding debit "Renewal of Rental Item" and "Reserve Charge" does not create account offset https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21678 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- I will wait to the patches on ->add_debit related bug reports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Bug 21683 depends on bug 21681, which changed state. Bug 21681 Summary: Remove C4::Accounts::getcharges https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21681 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21804 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21804 [Bug 21804] Bad rebase reintroduced C4::Accounts::getcharges -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81281|0 |1 is obsolete| | Attachment #81282|0 |1 is obsolete| | Attachment #81283|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 82183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82183&action=edit Bug 21683: Database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 82184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82184&action=edit Bug 21683: Remove accountlines.accountno Test plan: 1) Play with fines, should work OK 2) Try to print receipts on fines - prinfeercpt.pl, printinvoice.pl 3) git grep getnextacctno -> no occurences 4) git grep accountno should return only: installer/data/mysql/atomicupdate/bug_21683_remove_column_accountno.perl installer/data/mysql/update22to30.pl misc/release_notes/release_notes_3_10_0.txt misc/release_notes/release_notes_3_22_0.txt 5) prove t/db_dependent/Accounts.t t/db_dependent/ILSDI_Services.t t/db_dependent/Stats.t t/db_dependent/Koha/Account.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 82185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82185&action=edit Bug 21683: Update schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 82188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82188&action=edit Bug 21683: (follow-up) Polish the change - based on feedback -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #10 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to M. Tompsett from comment #4)
Comment on attachment 81282 [details] [review] Bug 21683: Remove accountlines.accountno
Review of attachment 81282 [details] [review]: -----------------------------------------------------------------
Thanks, I added a follow-up based on your comments -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Bug 21683 depends on bug 21804, which changed state. Bug 21804 Summary: Bad rebase reintroduced C4::Accounts::getcharges https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21804 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Bug 21683 depends on bug 21680, which changed state. Bug 21680 Summary: Remove dead code C4::Accounts::fixaccounts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21680 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21721 CC| |martin.renvoize@ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 [Bug 21721] Update C4::Circulation::AddRenewal to use Koha::Account->add_debit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21680 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21680 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21680 [Bug 21680] Remove dead code C4::Accounts::fixaccounts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21678 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21678 [Bug 21678] Adding debit "Renewal of Rental Item" and "Reserve Charge" does not create account offset -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21678 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21680 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21680 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21680 [Bug 21680] Remove dead code C4::Accounts::fixaccounts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21722 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 [Bug 21722] Update C4::Accounts::chargelostitem to use Koha::Account->add_debit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21728, 21756, 21747 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728 [Bug 21728] Update C4::Reserves::ChargeReserveFee to use Koha::Account->add_debit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #11 from Josef Moravec <josef.moravec@gmail.com> --- Marking as BLOCKED, I'll wait for dependency patches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22331 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17702 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21747 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21722 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 [Bug 21722] Update C4::Accounts::chargelostitem to use Koha::Account->add_debit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21728 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728 [Bug 21728] Update C4::Reserves::ChargeReserveFee to use Koha::Account->add_debit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21721 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 [Bug 21721] Update C4::Circulation::AddRenewal to use Koha::Account->add_debit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82185|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82183|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85531&action=edit Bug 21683: Database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82184|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85532&action=edit Bug 21683: Remove accountlines.accountno Test plan: 1) Play with fines, should work OK 2) Try to print receipts on fines - prinfeercpt.pl, printinvoice.pl 3) git grep getnextacctno -> no occurences 4) git grep accountno should return only: installer/data/mysql/atomicupdate/bug_21683_remove_column_accountno.perl installer/data/mysql/update22to30.pl misc/release_notes/release_notes_3_10_0.txt misc/release_notes/release_notes_3_22_0.txt 5) prove t/db_dependent/Accounts.t t/db_dependent/ILSDI_Services.t t/db_dependent/Stats.t t/db_dependent/Koha/Account.t Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82188|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85533&action=edit Bug 21683: (follow-up) Polish the change - based on feedback Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85534&action=edit Bug 21683: (QA follow-up) Koha::Account::Line rebase fix -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85531|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85535&action=edit Bug 21683: Database update Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85532|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85536&action=edit Bug 21683: Remove accountlines.accountno Test plan: 1) Play with fines, should work OK 2) Try to print receipts on fines - prinfeercpt.pl, printinvoice.pl 3) git grep getnextacctno -> no occurences 4) git grep accountno should return only: installer/data/mysql/atomicupdate/bug_21683_remove_column_accountno.perl installer/data/mysql/update22to30.pl misc/release_notes/release_notes_3_10_0.txt misc/release_notes/release_notes_3_22_0.txt 5) prove t/db_dependent/Accounts.t t/db_dependent/ILSDI_Services.t t/db_dependent/Stats.t t/db_dependent/Koha/Account.t Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85533|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85537&action=edit Bug 21683: (follow-up) Polish the change - based on feedback Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85534|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85538&action=edit Bug 21683: (QA follow-up) Koha::Account::Line rebase fix Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Brought back up to date and signed off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21680 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21680 [Bug 21680] Remove dead code C4::Accounts::fixaccounts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |kyle@bywatersolutions.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Shouldn't we use accountline_id for the proccode parameter in UpdateStats? I'm getting failures in all tests that set statistics. To reproduce: $ dbic $ updatedatabase $ kshell k$ prove t/db_dependent/Accounts.t \ t/db_dependent/Circ* \ t/db_dependent/Koha/Account* => FAIL: Lots of errors like this: DBD::mysql::st execute failed: Column count doesn't match value count at row 1 [for Statement "INSERT INTO statistics (datetime, branch, type, value, other, itemnumber, itemtype, location, borrowernumber, proccode, ccode) VALUES (now(),?,?,?,?,?,?,?,?,?)" with ParamValues: 0='VBVsbXZxI', 1='payment', 2=150, 3='', 4=undef, 5='', 6=undef, 7='205', 8=''] at /home/vagrant/kohaclone/C4/Stats.pm line 136. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #21)
Shouldn't we use accountline_id for the proccode parameter in UpdateStats? I'm getting failures in all tests that set statistics.
To reproduce: $ dbic $ updatedatabase $ kshell k$ prove t/db_dependent/Accounts.t \ t/db_dependent/Circ* \ t/db_dependent/Koha/Account* => FAIL: Lots of errors like this: DBD::mysql::st execute failed: Column count doesn't match value count at row 1 [for Statement "INSERT INTO statistics (datetime, branch, type, value, other, itemnumber, itemtype, location, borrowernumber, proccode, ccode) VALUES (now(),?,?,?,?,?,?,?,?,?)" with ParamValues: 0='VBVsbXZxI', 1='payment', 2=150, 3='', 4=undef, 5='', 6=undef, 7='205', 8=''] at /home/vagrant/kohaclone/C4/Stats.pm line 136.
Reverting the changes in t/db_dependent/Stats.t and C4/Stats.pm fixes the failures. Still not sure what's the best solution. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think the failures must have been introduced by my rebase.. simple mistake on number of `?` chars.. but.. I agree with you.. I 'think' rather that outright removing the link to the accountline here we should probably be recording accountline_id as an alternative... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85535|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86221&action=edit Bug 21683: Database update Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85536|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86222&action=edit Bug 21683: Remove accountlines.accountno Test plan: 1) Play with fines, should work OK 2) Try to print receipts on fines - prinfeercpt.pl, printinvoice.pl 3) git grep getnextacctno -> no occurences 4) git grep accountno should return only: installer/data/mysql/atomicupdate/bug_21683_remove_column_accountno.perl installer/data/mysql/update22to30.pl misc/release_notes/release_notes_3_10_0.txt misc/release_notes/release_notes_3_22_0.txt 5) prove t/db_dependent/Accounts.t t/db_dependent/ILSDI_Services.t t/db_dependent/Stats.t t/db_dependent/Koha/Account.t Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85537|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86223&action=edit Bug 21683: (follow-up) Polish the change - based on feedback Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85538|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86224&action=edit Bug 21683: (QA follow-up) Koha::Account::Line rebase fix Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've now uploaded a correctly rebased patchset so the tests should all now be passing. Having discussed this with Josef in IRC we are both in agreement that statistucs.proccode should be removed as is. I've looked through the SQL Reports library on the wiki and can't find a single mention of it's use and neither of us could work out a consistent and correct way to report against it which remained accurate. We also couldn't work out any form of migration path from accountno to accountline_id. So.. I believe this patchset is now sound, although I would like one minor followup which actually removed the field from the statistics table too. I believe if we do decide we want a link to accountlines in this table we should treat that as a separate issue. I'll add the followup to remove the field from the database. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86221|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86225&action=edit Bug 21683: Database update Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86222|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86226&action=edit Bug 21683: Remove accountlines.accountno Test plan: 1) Play with fines, should work OK 2) Try to print receipts on fines - prinfeercpt.pl, printinvoice.pl 3) git grep getnextacctno -> no occurences 4) git grep accountno should return only: installer/data/mysql/atomicupdate/bug_21683_remove_column_accountno.perl installer/data/mysql/update22to30.pl misc/release_notes/release_notes_3_10_0.txt misc/release_notes/release_notes_3_22_0.txt 5) prove t/db_dependent/Accounts.t t/db_dependent/ILSDI_Services.t t/db_dependent/Stats.t t/db_dependent/Koha/Account.t Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86223|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86227&action=edit Bug 21683: (follow-up) Polish the change - based on feedback Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86224|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86228&action=edit Bug 21683: (QA follow-up) Koha::Account::Line rebase fix Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86229&action=edit Bug 21683: (QA follow-up) Drop statistics.proccode Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86225|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86230&action=edit Bug 21683: Database update Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86226|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86231&action=edit Bug 21683: Remove accountlines.accountno Test plan: 1) Play with fines, should work OK 2) Try to print receipts on fines - prinfeercpt.pl, printinvoice.pl 3) git grep getnextacctno -> no occurences 4) git grep accountno should return only: installer/data/mysql/atomicupdate/bug_21683_remove_column_accountno.perl installer/data/mysql/update22to30.pl misc/release_notes/release_notes_3_10_0.txt misc/release_notes/release_notes_3_22_0.txt 5) prove t/db_dependent/Accounts.t t/db_dependent/ILSDI_Services.t t/db_dependent/Stats.t t/db_dependent/Koha/Account.t Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86227|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86232&action=edit Bug 21683: (follow-up) Polish the change - based on feedback Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86228|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86233&action=edit Bug 21683: (QA follow-up) Koha::Account::Line rebase fix Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86229|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86234&action=edit Bug 21683: (QA follow-up) Drop statistics.proccode Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Martin Renvoize from comment #28)
I've now uploaded a correctly rebased patchset so the tests should all now be passing.
Having discussed this with Josef in IRC we are both in agreement that statistucs.proccode should be removed as is. I've looked through the SQL Reports library on the wiki and can't find a single mention of it's use and neither of us could work out a consistent and correct way to report against it which remained accurate. We also couldn't work out any form of migration path from accountno to accountline_id.
So.. I believe this patchset is now sound, although I would like one minor followup which actually removed the field from the statistics table too.
I believe if we do decide we want a link to accountlines in this table we should treat that as a separate issue.
I'll add the followup to remove the field from the database.
Back to you Tomas :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #40 from Josef Moravec <josef.moravec@gmail.com> --- It is not finished yet, the last follow-up is not enough, there is occurence of proccode in: koha-tmpl/intranet-tmpl/prog/en/columns.def t/db_dependent/Stats.t - test if proccode is undef could be removed i think -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #41 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86336&action=edit Bug 21683: (follow-up) Remove last occurences of statistics.proccode columns.def is used to define descriptions of db columns in guided reports test is not useful anymore IMO -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Agreed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86336|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86230|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86231|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86232|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86233|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86234|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #43 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 86470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86470&action=edit Bug 21683: Database update Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #44 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 86471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86471&action=edit Bug 21683: Remove accountlines.accountno Test plan: 1) Play with fines, should work OK 2) Try to print receipts on fines - prinfeercpt.pl, printinvoice.pl 3) git grep getnextacctno -> no occurences 4) git grep accountno should return only: installer/data/mysql/atomicupdate/bug_21683_remove_column_accountno.perl installer/data/mysql/update22to30.pl misc/release_notes/release_notes_3_10_0.txt misc/release_notes/release_notes_3_22_0.txt 5) prove t/db_dependent/Accounts.t t/db_dependent/ILSDI_Services.t t/db_dependent/Stats.t t/db_dependent/Koha/Account.t Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #45 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 86472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86472&action=edit Bug 21683: (follow-up) Polish the change - based on feedback Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #46 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 86473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86473&action=edit Bug 21683: (QA follow-up) Koha::Account::Line rebase fix Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #47 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 86474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86474&action=edit Bug 21683: (QA follow-up) Drop statistics.proccode Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #48 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 86475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86475&action=edit Bug 21683: (follow-up) Remove last occurences of statistics.proccode columns.def is used to define descriptions of db columns in guided reports test is not useful anymore IMO Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22516 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 [Bug 22516] accountlines.lastincrement can be removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Bug 21683 depends on bug 21756, which changed state. Bug 21756 Summary: Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13795 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 [Bug 13795] Delete unused columns from statistics table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #49 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17702 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #51 from Rocio Dressler <rocio@bywatersolutions.com> --- *** Bug 15732 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org