http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4838 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4838 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|--- |Needs Signoff --- Comment #2 from Frédéric Demians <frederic@tamil.fr> 2010-12-09 20:47:38 UTC --- I rebased this patch on HEAD: http://lists.koha-community.org/pipermail/koha-patches/2010-December/013223.... I need it. It doesn't hurt anything. It's not easy to test because multilingual authorities are required. So I will post a screencast to show how it works. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4838 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Needs Signoff |Patch Pushed --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2010-12-21 03:52:11 UTC --- Pushed to new/bug_4838, please test with both MARC21 and UNIMARC then let me know and I will merge it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4838 --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-01-09 20:13:10 UTC --- Have tested with MARC21 seems ok, merging please test and mark resolved -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4838 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |januszop@gmail.com Resolution|FIXED | --- Comment #7 from Janusz Kaczmarek <januszop@gmail.com> 2011-06-05 17:59:01 UTC --- This patch, beside that it adds some enhancements, introduces also problems with UNIMARC authorities, if summary is defined for UNIMARC authorities according to the standard settings from installation files (e.g. autorites_norme_unimarc.sql) Try this (having authorities summaries defined in the standard form, cf. autorites_norme_unimarc.sql or screenshot and subsequent subfields in authority records defined as well): 1. Go: Cataloguing --> New Record 2. Go to a field controlled by authority, of which you know that has has "--" in summary and subfields preceded by "--" defined, e.g. SNC in standard UNICODE situation with x, y or z subfields 3. Click on ... 4. Search for such a term which has x, y or z defined (and a of course) 5. Try to click on 2 next to search result You should get en error (cf. screenshot). This is because of the following: In the patch 4838 a notion of "repet" is introduced. In line 77 of auth_finder.pl "--" is used to extract (in fact: guess) the subsequent repets from summary (produced by C4::BuildSummary). BUT if there is only one heading field in the authority record and by chance this field contains subfields, which--according to the summary template--will be separated by two dashes, then "repets" will be created (whereas should not) and by clicking on 2 you get in troubles in blinddetail-biblio-search.pl, when executing: my $field = $fields[$repet]; for ( $field->subfields ) { In described scenario, $field is not defined (@fields has only one element), hence you get error. What can be done? My ideas about it: Either one should modify the patch in a way that it will guess "repets" correctly OR change the default summary templates in autorites_norme_unimarc.sql AND (warn people using UNIMARC to modify their existing summaries templates OR make the modification for them in updatedatabase.pl). BTW changing the template to something like "[250a][ - 250x][ - 250y][ - 250z] [(250b)]" (one dash instead of two) helps, of course. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4838 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Patch Pushed |Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4838 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 --- Comment #10 from Frédéric Demians <frederic@tamil.fr> --- In 3.8, this functionality doesn't work anymore. Recent work on authorities broke the template which was distinguishing authorities repetitions. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4838 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4838 --- Comment #13 from Francois Charbonnier <francois.charbonnier@biblibre.com> --- Created attachment 10066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10066&action=edit [SIGNED-OFF] Bug 4838 Fix repeated authorities selection How to test: Create an authority, with more than one heading, for example a UNIMARC multilingual author: 200 $7 da $a 原 $b 純輔 200 $7 ba $a Hara $b Junsuke In data entry form, on 700 field, you click on ... Search for the above author. In auhtority search result page, you just have a 'Choose' link, and so you just can select the first heading (in Chinesse writing). Apply the patch. Repeat. Now you have, on result page, you have two links, and can select one heading or the other. Signed-off-by: François Charbonnier <francois.charbonnier@biblibre.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4838 Francois Charbonnier <francois.charbonnier@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9919|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4838 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|rel_3_2 |rel_3_8 Severity|major |normal --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> --- Lowering severity as the case is quite rare, but it's a bugfix, so valuable in 3.8 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4838 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7442 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.