[Bug 18112] New: opac-memberentry.pl doesn't contain streettype field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Bug ID: 18112 Summary: opac-memberentry.pl doesn't contain streettype field Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: corinne.hayet@progilone.fr QA Contact: testopia@bugs.koha-community.org streettype is missing in opac-memberentry.pl, we cannot have a complete address -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.05 |unspecified CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Serhij Dubyk <dubyk@ukr.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dubyk@ukr.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I confirm that this is still the case in master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- streettype is also missing on memberentrygen.tt yet it exists as an option on BorrowerMandatoryField and PatronSelfRegistrationBorrowerMandatoryField. If you add street type to either of these system preference you can never complete the form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Lucas Gass from comment #2)
streettype is also missing on memberentrygen.tt yet it exists as an option on BorrowerMandatoryField and PatronSelfRegistrationBorrowerMandatoryField.
If you add street type to either of these system preference you can never complete the form.
I am mistaken. Streettype will appear on memberentrygen.tt IF the AV ROADTYPE contains values. It is missing from the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 120476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120476&action=edit Bug 18112: Add street type to self reg/self mod form 1. Add some values to the ROADTYPE authorized value 2. Go to PatronSelfRegistrationBorrowerUnwantedField and make sure streettype is NOT checked 3. Go the self reg form, no street type field 4. Apply patch 5. Check the self reg form, streettype should be there with all the options defined in ROADTYPE a.v. 6. Check the self modification form, street type should be there. 7. Make sure PatronSelfRegistrationBorrowerUnwantedField and PatronSelfModificationBorrowerUnwantedField hide the field correctly. 8. Make sure PatronSelfRegistrationBorrowerMandatoryField properly makes the field required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- This works as expected except for one thing: A required street type <select> is not caught by the client-side validation. In the template the tag is missing "class="[% required.streettype | html %]" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 120720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120720&action=edit Bug 18112: (follow-up) add required class to select -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120476|0 |1 is obsolete| | Attachment #120720|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 120770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120770&action=edit Bug 18112: Add street type to self reg/self mod form 1. Add some values to the ROADTYPE authorized value 2. Go to PatronSelfRegistrationBorrowerUnwantedField and make sure streettype is NOT checked 3. Go the self reg form, no street type field 4. Apply patch 5. Check the self reg form, streettype should be there with all the options defined in ROADTYPE a.v. 6. Check the self modification form, street type should be there. 7. Make sure PatronSelfRegistrationBorrowerUnwantedField and PatronSelfModificationBorrowerUnwantedField hide the field correctly. 8. Make sure PatronSelfRegistrationBorrowerMandatoryField properly makes the field required. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 120771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120771&action=edit Bug 18112: (follow-up) add required class to select Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this is a needed change and I don't want to block it. But should we not open a new bug for adding the street type to alternate address as well to match the staff side? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120770|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 120809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120809&action=edit Bug 18112: Add street type to self reg/self mod form 1. Add some values to the ROADTYPE authorized value 2. Go to PatronSelfRegistrationBorrowerUnwantedField and make sure streettype is NOT checked 3. Go the self reg form, no street type field 4. Apply patch 5. Check the self reg form, streettype should be there with all the options defined in ROADTYPE a.v. 6. Check the self modification form, street type should be there. 7. Make sure PatronSelfRegistrationBorrowerUnwantedField and PatronSelfModificationBorrowerUnwantedField hide the field correctly. 8. Make sure PatronSelfRegistrationBorrowerMandatoryField properly makes the field required. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120771|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 120810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120810&action=edit Bug 18112: (follow-up) add required class to select Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|opac-memberentry.pl doesn't |Add street type to main |contain streettype field |address in OPAC Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28313 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28313 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28313 [Bug 28313] Add street type to alternate address in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120841&action=edit Bug 18112: Use GetAuthValueDropbox from the template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Does not apply on 20.11.x. Please provide patches if needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28511 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28511 [Bug 28511] Road types in OPAC should prefer OPAC description if one exists -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org