[Bug 35638] New: Upgrade Enquire JS library from v2.0.1 to v2.1.6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35638 Bug ID: 35638 Summary: Upgrade Enquire JS library from v2.0.1 to v2.1.6 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 35584 The Enquire JS library hasn't been updated for a while, but we're still using an older version. Upgrading to 2.1.6 will bring us to the latest version. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 [Bug 35584] Missing licenses in about page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35638 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29960 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 [Bug 29960] Remove Modernizr dependency in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35638 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35638 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160236&action=edit Bug 35638: Upgrade Enquire JS library from v2.0.1 to v2.1.6 This patch upgrades enquire.js in the OPAC to the latest version, v.2.1.6. The patch also moves the file (enquire.min.js) into its own directory for consistency's sake. Enquire.js lets us use CSS-like "breakpoints" to trigger JS actions. We use it to in "mobile" views (narrower browser widths): Collapsing the facets menu and triggering automatic scroll to "main content." The patch also removes media.match.js which should have been removed in Bug 29960. At that time Enquire.js required that we used Modernizr to load media.match.js as a polyfill for older browsers. To test, apply the patch and clear your browser cache if necessary. - In the OPAC, perform a catalog search which will return results. - At wider browser widths the facets menu will appear in the left-hand sidebar. - When you narrow your browser until the viewport is less than 992 pixels wide* the facets menu should collapse into a "Refine your search" button above the search results. - If you narrow your browser width to below 600 pixels wide and reload the search results page, the browser should automatically scroll down so that the "Your search..." heading is at the top of the viewport. * Use Firefox's Responsive Design Mode to get pixel-level control over viewport width: https://firefox-source-docs.mozilla.org/devtools-user/responsive_design_mode... In Chrome it's called "Device Mode." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35638 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35638 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160236|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 160380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160380&action=edit Bug 35638: Upgrade Enquire JS library from v2.0.1 to v2.1.6 This patch upgrades enquire.js in the OPAC to the latest version, v.2.1.6. The patch also moves the file (enquire.min.js) into its own directory for consistency's sake. Enquire.js lets us use CSS-like "breakpoints" to trigger JS actions. We use it to in "mobile" views (narrower browser widths): Collapsing the facets menu and triggering automatic scroll to "main content." The patch also removes media.match.js which should have been removed in Bug 29960. At that time Enquire.js required that we used Modernizr to load media.match.js as a polyfill for older browsers. To test, apply the patch and clear your browser cache if necessary. - In the OPAC, perform a catalog search which will return results. - At wider browser widths the facets menu will appear in the left-hand sidebar. - When you narrow your browser until the viewport is less than 992 pixels wide* the facets menu should collapse into a "Refine your search" button above the search results. - If you narrow your browser width to below 600 pixels wide and reload the search results page, the browser should automatically scroll down so that the "Your search..." heading is at the top of the viewport. * Use Firefox's Responsive Design Mode to get pixel-level control over viewport width: https://firefox-source-docs.mozilla.org/devtools-user/responsive_design_mode... In Chrome it's called "Device Mode." Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35638 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Things I noted from testing (using KTD): 1. After the search results, the block for making a purchase suggestion only appears if you are logged in to the OPAC (Block text: Not finding what you're looking for? Make a purchase suggestion). 2. The link in the text under the number of search results, but before the results pagination section, gives you a blank page: - Text is "Not what you expected? Check for suggestions" - 'suggestions' is linked to /cgi-bin/koha/svc/suggestion?render=standalone&q=cat - I have created bug 35676 for this -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35638 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35638 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160380|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160935&action=edit Bug 35638: Upgrade Enquire JS library from v2.0.1 to v2.1.6 This patch upgrades enquire.js in the OPAC to the latest version, v.2.1.6. The patch also moves the file (enquire.min.js) into its own directory for consistency's sake. Enquire.js lets us use CSS-like "breakpoints" to trigger JS actions. We use it to in "mobile" views (narrower browser widths): Collapsing the facets menu and triggering automatic scroll to "main content." The patch also removes media.match.js which should have been removed in Bug 29960. At that time Enquire.js required that we used Modernizr to load media.match.js as a polyfill for older browsers. To test, apply the patch and clear your browser cache if necessary. - In the OPAC, perform a catalog search which will return results. - At wider browser widths the facets menu will appear in the left-hand sidebar. - When you narrow your browser until the viewport is less than 992 pixels wide* the facets menu should collapse into a "Refine your search" button above the search results. - If you narrow your browser width to below 600 pixels wide and reload the search results page, the browser should automatically scroll down so that the "Your search..." heading is at the top of the viewport. * Use Firefox's Responsive Design Mode to get pixel-level control over viewport width: https://firefox-source-docs.mozilla.org/devtools-user/responsive_design_mode... In Chrome it's called "Device Mode." Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35638 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35638 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35638 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35638 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Module(?) change, nothing to add/edit in the Koha manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35638 Bug 35638 depends on bug 35584, which changed state. Bug 35584 Summary: Missing licenses in about page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org