[Bug 28187] New: rowGroup headings are getting their styles overriden
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Bug ID: 28187 Summary: rowGroup headings are getting their styles overriden Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The rowGroup datatables plugin used in the register details page for transaction groups is having it's header row background styling overridden by local css for the case where the row is 'odd'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119936&action=edit Screenshot highlighting problem -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- How is it supposed to look? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Ooops.. I cut of the text in my screenshot.. the first and second arrow rows are incorrect.. the third arrow points out the correct darker background colour. i.e. we should continue to do our even/odd row highlighting.. but on top of that if it's a 'header row for a group' we should allow that to take precedence and take the darker third shade. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 119951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119951&action=edit Bug 28187: Make debit/credit row headers correct color To test: -Enable POS -Create a register and make some transactions. -Have both debits and credits -Have some older tranactions so you can look at the past_sales table. -Apply patch and regenerate the staff CSS: (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) -Look at the sales and past_sales table. -Make sure each row header is the darker shade of gray (#e0e0e0) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119951|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119998&action=edit Bug 28187: Make debit/credit row headers correct color To test: -Enable POS -Create a register and make some transactions. -Have both debits and credits -Have some older tranactions so you can look at the past_sales table. -Apply patch and regenerate the staff CSS: (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) -Look at the sales and past_sales table. -Make sure each row header is the darker shade of gray (#e0e0e0) Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Whilst this does fix the immediate issue, I was hoping to fix it at a higher level so subsequent uses of the rowGrouping plugin don't suffer the same problem. The problem I was having is that I couldn't find where in our css source files the background color was coming from. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Indeed.. still stuck How does the following rule get generated: tbody tr:nth-child(odd) td:not(.bg-danger):not(.bg-warning):not(.bg-info):not(.bg-success):not(.bg-primary) { background-color: #f9f9f9; } and why does it take precedence over table.dataTable tr.dtrg-group td { background-color: #e0e0e0; } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The rowGroup plugin is also used for checkouts I believe.. which is a shared include in a number of templates.. so yeah.. I do still feel we need a higher level fix. Sorry Lucas, thanks for working on it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lucas@bywatersolutions.com |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 120956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120956&action=edit Bug 28187: Exclude dtrg-group from row striping. The odd row lowlighting stripe effect added to datatales wasn't accounting for classes introduced by the rowGroup plugin to denote grouping header rows. This patch adds the required exclusion rule to properly highlight rowGroup grouping rows. Test plan 1/ Enable POS 2/ Create a register and make some transactions. 3/ Have both debits and credits 4/ Have some older tranactions so you can look at the past_sales table. 5/ Apply patch and regenerate the staff CSS: (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) 6/ Look at the sales and past_sales table. 7/ Make sure each row header is the darker shade of gray (#e0e0e0) 7a/ You will need to have made some transactions with even and odd numbers of items in the sale highlight the problem before applying the patch 7b/ The rowGroup plugin is also used for the checkouts table and this patch should also fix that case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119998|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've come up with an alternate solution now that catches the cases more widely.. back to NSO.. not sure why it took me so long to wrap my brain around that! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120956|0 |1 is obsolete| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 120962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120962&action=edit Bug 28187: Exclude dtrg-group from row striping. The odd row lowlighting stripe effect added to datatales wasn't accounting for classes introduced by the rowGroup plugin to denote grouping header rows. This patch adds the required exclusion rule to properly highlight rowGroup grouping rows. Test plan 1/ Enable POS 2/ Create a register and make some transactions. 3/ Have both debits and credits 4/ Have some older tranactions so you can look at the past_sales table. 5/ Apply patch and regenerate the staff CSS: (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) 6/ Look at the sales and past_sales table. 7/ Make sure each row header is the darker shade of gray (#e0e0e0) 7a/ You will need to have made some transactions with even and odd numbers of items in the sale highlight the problem before applying the patch 7b/ The rowGroup plugin is also used for the checkouts table and this patch should also fix that case. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
7b/ The rowGroup plugin is also used for the checkouts table and this patch should also fix that case.
Where is that? http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=XXX http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=XXXX ? Is there anything wrong? https://wtf.roflcopter.fr/pics/gallery#vzlK8k2u/lgCojF0C.png,pjbLuxYq/d6NnmV... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Meanwhile, the main stuff works :D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120962|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 121104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121104&action=edit Bug 28187: Exclude dtrg-group from row striping. The odd row lowlighting stripe effect added to datatales wasn't accounting for classes introduced by the rowGroup plugin to denote grouping header rows. This patch adds the required exclusion rule to properly highlight rowGroup grouping rows. Test plan 1/ Enable POS 2/ Create a register and make some transactions. 3/ Have both debits and credits 4/ Have some older tranactions so you can look at the past_sales table. 5/ Apply patch and regenerate the staff CSS: (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) 6/ Look at the sales and past_sales table. 7/ Make sure each row header is the darker shade of gray (#e0e0e0) 7a/ You will need to have made some transactions with even and odd numbers of items in the sale highlight the problem before applying the patch 7b/ The rowGroup plugin is also used for the checkouts table and this patch should also fix that case. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- note: was backported to oldstable (20.11.x) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #17 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] [Omnibus] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] [Omnibus] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org