[Bug 22833] New: Don't let users cancel holds connected with ILLs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Bug ID: 22833 Summary: Don't let users cancel holds connected with ILLs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: magnus@libriotech.no Target Milestone: --- In the Swedish (Libris) ILL module, when a new ILL request is created, a record and an item (with a specific ILL itemtype) are also created. And a hold is created between the local patron that is waiting for the ILL and the local ILL item. This means that the ILL shows up as a regular hold when the patron logs into the OPAC. That in it self is OK, but the problematic thing is that patrons can cancel the holds connected with the ILL (maybe thinking that they are then also canceling the ILL request). Libraries would like to stop patrons from doing this. A couple of options come to mind: 1. Add a syspref that can take a list of itemtypes that should not be cancel'able by the patron in the OPAC 2. Add a boolean field like itetypes.let_patrons_cancel_holds_in_opac which defaults to 1 for existing itemtypes, but can be set to 0 to achieve the desired effect. 1 is more unobtrusive, 2 is probably cleaner in the long run? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |magnus@libriotech.no |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- Third option: 3. Detect when a hold is related to an ILL request and don't display Suspend/Cancel for these holds. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Don't let users cancel |Block suspend and cancel on |holds connected with ILLs |holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- Created attachment 96196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96196&action=edit Bug 22833 - Schema update, DO NOT PUSH -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- Created attachment 96197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96197&action=edit Bug 22833 - Flag booleans in Itemtype.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #4 from Magnus Enger <magnus@libriotech.no> --- Created attachment 96198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96198&action=edit Bug 22833 - Block suspend and cancel on holds Swedish ILL uses a hold as part of the ILL workflow. It is problematic if patrons suspend or cancel those holds before the ILL request is received. This patch makes it possible to configure, on the itemtype level, if it should be possible to suspend or cancel holds. Since a record can have items with different itemtypes, the record level itemtype is used to determine if holds connected to a record can be suspended and/or cancelled. If suspension is blocked for an itemtype, holds connected to records with that itemtype can not be - individually suspended by patrons in the OPAC (The "Suspend" button is not shown in the table of active holds in the "Holds" tab in "My summary".) - suspended as part of a "suspend all" operation in the OPAC - suspended as part of a "suspend all" operation in the staff client (but individual holds can still be suspended by staff) If cancellation is blocked for an itemtype, holds connected to records with that itemtype can not be - individually cancelled by patrons in the OPAC (The "Cancel" button is not shown in the table of active holds in the "Holds" tab in "My summary".) To test: - Apply the patch and make sure the atomic database update is run - Make sure you have two different itemtypes and records with those itemtypes at the record level (field 942$c in MARC 21). - Toggle the two new settings on the itemtypes, and make sure the behaviour is in line with the behaviour described above. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96198|0 |1 is obsolete| | --- Comment #5 from Magnus Enger <magnus@libriotech.no> --- Created attachment 96207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96207&action=edit Bug 22833 - Block suspend and cancel on holds Swedish ILL uses a hold as part of the ILL workflow. It is problematic if patrons suspend or cancel those holds before the ILL request is received. This patch makes it possible to configure, on the itemtype level, if it should be possible to suspend or cancel holds. Since a record can have items with different itemtypes, the record level itemtype is used to determine if holds connected to a record can be suspended and/or cancelled. If suspension is blocked for an itemtype, holds connected to records with that itemtype can not be - individually suspended by patrons in the OPAC (The "Suspend" button is not shown in the table of active holds in the "Holds" tab in "My summary".) - suspended as part of a "suspend all" operation in the OPAC - suspended as part of a "suspend all" operation in the staff client (but individual holds can still be suspended by staff) If cancellation is blocked for an itemtype, holds connected to records with that itemtype can not be - individually cancelled by patrons in the OPAC (The "Cancel" button is not shown in the table of active holds in the "Holds" tab in "My summary".) To test: - Apply the patch and make sure the atomic database update is run - Make sure you have two different itemtypes and records with those itemtypes at the record level (field 942$c in MARC 21). - Toggle the two new settings on the itemtypes, and make sure the behaviour is in line with the behaviour described above. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Stina Hallin <stina.hallin@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stina.hallin@ub.lu.se --- Comment #6 from Stina Hallin <stina.hallin@ub.lu.se> --- Hello Magnus, I tried the patch, but when testing, Koha gave an error message when I unchecked the Cancel and Suspend hold check boxes on the Item types administration side (the error message came after saving). It said "Error when saving..." The new settings where not saved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96207|0 |1 is obsolete| | --- Comment #7 from Magnus Enger <magnus@libriotech.no> --- Created attachment 98649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98649&action=edit Bug 22833 - Block suspend and cancel on holds Swedish ILL uses a hold as part of the ILL workflow. It is problematic if patrons suspend or cancel those holds before the ILL request is received. This patch makes it possible to configure, on the itemtype level, if it should be possible to suspend or cancel holds. Since a record can have items with different itemtypes, the record level itemtype is used to determine if holds connected to a record can be suspended and/or cancelled. If suspension is blocked for an itemtype, holds connected to records with that itemtype can not be - individually suspended by patrons in the OPAC (The "Suspend" button is not shown in the table of active holds in the "Holds" tab in "My summary".) - suspended as part of a "suspend all" operation in the OPAC - suspended as part of a "suspend all" operation in the staff client (but individual holds can still be suspended by staff) If cancellation is blocked for an itemtype, holds connected to records with that itemtype can not be - individually cancelled by patrons in the OPAC (The "Cancel" button is not shown in the table of active holds in the "Holds" tab in "My summary".) To test: - Apply the patch and make sure the atomic database update is run - Make sure you have two different itemtypes and records with those itemtypes at the record level (field 942$c in MARC 21). - Toggle the two new settings on the itemtypes, and make sure the behaviour is in line with the behaviour described above. Update 2020-02-10: Minor rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98649|0 |1 is obsolete| | --- Comment #8 from Magnus Enger <magnus@libriotech.no> --- Created attachment 98650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98650&action=edit Bug 22833 - Block suspend and cancel on holds Swedish ILL uses a hold as part of the ILL workflow. It is problematic if patrons suspend or cancel those holds before the ILL request is received. This patch makes it possible to configure, on the itemtype level, if it should be possible to suspend or cancel holds. Since a record can have items with different itemtypes, the record level itemtype is used to determine if holds connected to a record can be suspended and/or cancelled. If suspension is blocked for an itemtype, holds connected to records with that itemtype can not be - individually suspended by patrons in the OPAC (The "Suspend" button is not shown in the table of active holds in the "Holds" tab in "My summary".) - suspended as part of a "suspend all" operation in the OPAC - suspended as part of a "suspend all" operation in the staff client (but individual holds can still be suspended by staff) If cancellation is blocked for an itemtype, holds connected to records with that itemtype can not be - individually cancelled by patrons in the OPAC (The "Cancel" button is not shown in the table of active holds in the "Holds" tab in "My summary".) To test: - Apply the patch and make sure the atomic database update is run - Make sure you have two different itemtypes and records with those itemtypes at the record level (field 942$c in MARC 21). - Toggle the two new settings on the itemtypes, and make sure the behaviour is in line with the behaviour described above. Update 2020-02-10: Minor rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #9 from Magnus Enger <magnus@libriotech.no> --- (In reply to Stina Hallin from comment #6)
Hello Magnus, I tried the patch, but when testing, Koha gave an error message when I unchecked the Cancel and Suspend hold check boxes on the Item types administration side (the error message came after saving). It said "Error when saving..." The new settings where not saved.
Hm, I can't reproduce that problem. But I did have to rebase/update the patch a bit to work with current master. Would you mind trying again now? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|ILL |Hold requests CC| |gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is more of a general enhancement than purely an ILL feature.. as such I've set the status's accordingly to try and expose it to a few more interested parties and get it moving. Looks like a reasonable implementation to me so far :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98669&action=edit Bug 22833: Schema update, DO NOT PUSH Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98670&action=edit Bug 22833: Flag booleans in Itemtype.pm Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98671&action=edit Bug 22833: Block suspend and cancel on holds Swedish ILL uses a hold as part of the ILL workflow. It is problematic if patrons suspend or cancel those holds before the ILL request is received. This patch makes it possible to configure, on the itemtype level, if it should be possible to suspend or cancel holds. Since a record can have items with different itemtypes, the record level itemtype is used to determine if holds connected to a record can be suspended and/or cancelled. If suspension is blocked for an itemtype, holds connected to records with that itemtype can not be - individually suspended by patrons in the OPAC (The "Suspend" button is not shown in the table of active holds in the "Holds" tab in "My summary".) - suspended as part of a "suspend all" operation in the OPAC - suspended as part of a "suspend all" operation in the staff client (but individual holds can still be suspended by staff) If cancellation is blocked for an itemtype, holds connected to records with that itemtype can not be - individually cancelled by patrons in the OPAC (The "Cancel" button is not shown in the table of active holds in the "Holds" tab in "My summary".) To test: - Apply the patch and make sure the atomic database update is run - Make sure you have two different itemtypes and records with those itemtypes at the record level (field 942$c in MARC 21). - Toggle the two new settings on the itemtypes, and make sure the behaviour is in line with the behaviour described above. Update 2020-02-10: Minor rebase Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98650|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96197|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96196|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works well for me, Signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Stina Hallin <stina.hallin@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #15 from Stina Hallin <stina.hallin@ub.lu.se> --- Tried the patsch again and got this plack error message when I unchecked the box: DBD::mysql::st execute failed: Column 'can_cancel_hold' cannot be null [for Statement "UPDATE `itemtypes` SET `can_cancel_hold` = ?, `can_suspend_hold` = ?, `defaultreplacecost` = ?, `processfee` = ? WHERE ( `itemtype` = ? )" with ParamValues: 0=undef, 1=undef, 2=undef, 3=undef, 4='BK'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. When I tried to uncheck the boxes Koha gave me this message: An error occurred when updating this item type. Perhaps the value already exists. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #16 from Magnus Enger <magnus@libriotech.no> --- (In reply to Stina Hallin from comment #15)
Tried the patsch again and got this plack error message when I unchecked the box:
DBD::mysql::st execute failed: Column 'can_cancel_hold' cannot be null [for Statement "UPDATE `itemtypes` SET `can_cancel_hold` = ?, `can_suspend_hold` = ?, `defaultreplacecost` = ?, `processfee` = ? WHERE ( `itemtype` = ? )" with ParamValues: 0=undef, 1=undef, 2=undef, 3=undef, 4='BK'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.
When I tried to uncheck the boxes Koha gave me this message:
An error occurred when updating this item type. Perhaps the value already exists.
Weird. It still works for me. And I double checked that the database is getting updated as it should. Some sources of error I can think of: - Testing with Swedish as the active language in the staff client, without updating the templates (but then you should not see the checkboxes for "Hold can be suspended/cancelled in OPAC", I guess - The db update did not succeed completely. Could you paste the output of "describe itemtypes;" here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #17 from Stina Hallin <stina.hallin@ub.lu.se> --- Here's the description of itemtypes: +---------------------+---------------+------+-----+---------+-------+ | Field | Type | Null | Key | Default | Extra | +---------------------+---------------+------+-----+---------+-------+ | itemtype | varchar(10) | NO | PRI | | | | description | longtext | YES | | NULL | | | rentalcharge | decimal(28,6) | YES | | NULL | | | rentalcharge_daily | decimal(28,6) | YES | | NULL | | | rentalcharge_hourly | decimal(28,6) | YES | | NULL | | | defaultreplacecost | decimal(28,6) | YES | | NULL | | | processfee | decimal(28,6) | YES | | NULL | | | notforloan | smallint(6) | YES | | NULL | | | imageurl | varchar(200) | YES | | NULL | | | summary | mediumtext | YES | | NULL | | | checkinmsg | varchar(255) | YES | | NULL | | | checkinmsgtype | char(16) | NO | | message | | | sip_media_type | varchar(3) | YES | | NULL | | | hideinopac | tinyint(1) | NO | | 0 | | | searchcategory | varchar(80) | YES | | NULL | | | can_suspend_hold | tinyint(1) | NO | | 1 | | | can_cancel_hold | tinyint(1) | NO | | 1 | | +---------------------+---------------+------+-----+---------+-------+ We discussed it here, and have a suggestion for solution. Replace: my $can_suspend_hold = $input->param('can_suspend_hold'); my $can_cancel_hold = $input->param('can_cancel_hold'); with: my $can_suspend_hold = $input->param('can_suspend_hold') // 0; my $can_cancel_hold = $input->param('can_cancel_hold') // 0; And replace: [% IF ( HOLD.is_cancelable_from_opac ) %] with: [% IF ( HOLD.is_cancelable_from_opac && ItemTypes.CanCancelHold( HOLD.biblio.biblioitem.itemtype )) %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #18 from Magnus Enger <magnus@libriotech.no> --- (In reply to Stina Hallin from comment #17)
And replace: [% IF ( HOLD.is_cancelable_from_opac ) %]
with: [% IF ( HOLD.is_cancelable_from_opac && ItemTypes.CanCancelHold( HOLD.biblio.biblioitem.itemtype )) %]
Hm, I think I'm already doing that in the last part of the diff here? https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98671&action=diff Did I miss some occurrence of this, or did your template not get updated? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #19 from Stina Hallin <stina.hallin@ub.lu.se> --- (In reply to Magnus Enger from comment #18)
(In reply to Stina Hallin from comment #17)
And replace: [% IF ( HOLD.is_cancelable_from_opac ) %]
with: [% IF ( HOLD.is_cancelable_from_opac && ItemTypes.CanCancelHold( HOLD.biblio.biblioitem.itemtype )) %]
Hm, I think I'm already doing that in the last part of the diff here? https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98671&action=diff
Did I miss some occurrence of this, or did your template not get updated?
That was line 140. We think that you also need to add it to line 186. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #20 from Magnus Enger <magnus@libriotech.no> --- Created attachment 98947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98947&action=edit Bug 22833 - QA followup This patch incorporates the suggestions made by Stina Hallin. To test: - Apply with the other patches and make sure there are no errors when following the previous test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #21 from Magnus Enger <magnus@libriotech.no> --- (In reply to Stina Hallin from comment #19)
That was line 140. We think that you also need to add it to line 186.
Ah, gotach! Could you please test again now, with all the patches? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98669|0 |1 is obsolete| | --- Comment #22 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 98951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98951&action=edit Bug 22833: Schema update, DO NOT PUSH Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98670|0 |1 is obsolete| | --- Comment #23 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 98952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98952&action=edit Bug 22833: Flag booleans in Itemtype.pm Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98671|0 |1 is obsolete| | --- Comment #24 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 98953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98953&action=edit Bug 22833: Block suspend and cancel on holds Swedish ILL uses a hold as part of the ILL workflow. It is problematic if patrons suspend or cancel those holds before the ILL request is received. This patch makes it possible to configure, on the itemtype level, if it should be possible to suspend or cancel holds. Since a record can have items with different itemtypes, the record level itemtype is used to determine if holds connected to a record can be suspended and/or cancelled. If suspension is blocked for an itemtype, holds connected to records with that itemtype can not be - individually suspended by patrons in the OPAC (The "Suspend" button is not shown in the table of active holds in the "Holds" tab in "My summary".) - suspended as part of a "suspend all" operation in the OPAC - suspended as part of a "suspend all" operation in the staff client (but individual holds can still be suspended by staff) If cancellation is blocked for an itemtype, holds connected to records with that itemtype can not be - individually cancelled by patrons in the OPAC (The "Cancel" button is not shown in the table of active holds in the "Holds" tab in "My summary".) To test: - Apply the patch and make sure the atomic database update is run - Make sure you have two different itemtypes and records with those itemtypes at the record level (field 942$c in MARC 21). - Toggle the two new settings on the itemtypes, and make sure the behaviour is in line with the behaviour described above. Update 2020-02-10: Minor rebase Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98947|0 |1 is obsolete| | --- Comment #25 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 98954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98954&action=edit Bug 22833 - QA followup This patch incorporates the suggestions made by Stina Hallin. To test: - Apply with the other patches and make sure there are no errors when following the previous test plan. Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Stina Hallin <stina.hallin@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #26 from Magnus Enger <magnus@libriotech.no> --- Thanks, Stina! :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Magnus, * I am not sure I understand why you did not use these new flags/conditions for item-level hold? * I do not understand why you need the 2 subroutines in the TT plugin (CanCancelHold and CanSuspendHold), you should not need that, but call the Koha::ItemType method instead). It seems that you will need a new method in Koha::Biblio to retrieve the Koha::ItemType object. * Tests no provided for new subroutines anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- * Does that need to block staff users as well? At first I understood that is was for OPAC only, but C4::Reserves::SuspendAll is blocking it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 29851 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org