[Bug 20249] New: "Patron has no outstanding fines" now appears alongside fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20249 Bug ID: 20249 Summary: "Patron has no outstanding fines" now appears alongside fines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: charles.farmer@inlibro.com QA Contact: testopia@bugs.koha-community.org I was working on BZ11373 when I fell on this behavior. It seems like commit 0ab22e1c (BZ18789) introduced a small regression: the [% ELSE %] tag at line 125 of pay.tt disappeared when work was done to replace the 'borrower' object with 'patron'. I'll provide a patch in a jiffy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20249 --- Comment #1 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 71972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71972&action=edit Bug 20249: "Patron has no outstanding fines" now appears alongside fines Test plan: 1) Choose two patrons from your database, one who has fines, and the other who does not 2) Visit their 'Fines' page, and click on the 'Pay fines' tab 2.1) If they don't have any fines, you'll only see a blank row 2.2) If they do have fines, the payment form will appear, but the text "... no outstanding fines" will also appear 3) Apply patch 4) Visit once again the 'Pay fines' tab of your patrons 4.1) Now, "... no outstanding fines" will appear for the right situation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20249 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|oleonard@myacpl.org |charles.farmer@inlibro.com Status|NEW |Needs Signoff QA Contact|testopia@bugs.koha-communit |charles.farmer@inlibro.com |y.org | CC| |charles.farmer@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20249 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20249 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71972|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71973&action=edit Bug 20249: (bug 18789 follow-up) "Patron has no outstanding fines" now appears alongside fines Test plan: 1) Choose two patrons from your database, one who has fines, and the other who does not 2) Visit their 'Fines' page, and click on the 'Pay fines' tab 2.1) If they don't have any fines, you'll only see a blank row 2.2) If they do have fines, the payment form will appear, but the text "... no outstanding fines" will also appear 3) Apply patch 4) Visit once again the 'Pay fines' tab of your patrons 4.1) Now, "... no outstanding fines" will appear for the right situation Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20249 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off QA Contact|charles.farmer@inlibro.com | Depends on| |18789 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 [Bug 18789] Send a Koha::Patron object to the templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20249 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20249 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patch pushed to master for 18.05 Thanks for catching that Charles! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20249 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 20233 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20249 Bug 20249 depends on bug 18789, which changed state. Bug 18789 Summary: Send a Koha::Patron object to the templates https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20249 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |nick@bywatersolutions.com Status|Pushed to Master |RESOLVED --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Depends on 18789 which is not in stable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org